136569 2014-09-05 03:16:13 -0700 offlineasm generates suboptimal code for load/store on ARM64 2014-09-10 16:57:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 akiss webkit-unassigned commit-queue dbates fpizlo msaboff oldest_to_newest 1033429 0 akiss 2014-09-05 03:16:13 -0700 For every load/store instruction, where the address is in the form of base + offset, and the offset is out of range -255..4095, the ARM64 backend applies the standard risc lowering. That is, as the documentation of riscLowerMalformedAddresses describes: loadp 10000[foo], bar will become move 10000, tmp addp foo, tmp loadp 0[tmp], bar Which, in ARM64, means that, e.g., storep cfr, VM::topVMEntryFrame[vm] becomes movz x17, #45424, lsl #0 add x17, x17, x1 str x29, [x17, #0] However, ARM64 can do better: movz x17, #45424, lsl #0 str x29, [x1, x17, lsl #0] This would achieve the same result with less instructions. 1033434 1 237682 akiss 2014-09-05 04:33:42 -0700 Created attachment 237682 Proposed patch. 1034401 2 237682 msaboff 2014-09-10 14:06:14 -0700 Comment on attachment 237682 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=237682&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + base to the temporary, and the change the load/store to use the "the change" -> "then change" > Source/JavaScriptCore/ChangeLog:13 > + perform explicit register additons but it is enough to change load/store Typo: "additions" 1034404 3 237682 msaboff 2014-09-10 14:07:48 -0700 Comment on attachment 237682 Proposed patch. r=me 1034440 4 237911 akiss 2014-09-10 15:37:27 -0700 Created attachment 237911 Updated patch Typos fixed. 1034449 5 237911 msaboff 2014-09-10 16:00:25 -0700 Comment on attachment 237911 Updated patch r=me. 1034466 6 237911 commit-queue 2014-09-10 16:57:48 -0700 Comment on attachment 237911 Updated patch Clearing flags on attachment: 237911 Committed r173497: <http://trac.webkit.org/changeset/173497> 1034467 7 commit-queue 2014-09-10 16:57:51 -0700 All reviewed patches have been landed. Closing bug. 237682 2014-09-05 04:33:42 -0700 2014-09-10 15:37:27 -0700 Proposed patch. offlineasm-ldr-str-opt-v2.patch text/plain 3495 akiss ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQxNTJjOTkuLjdhODRkN2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA5LTA1ICBBa29zIEtpc3MgIDxh a2lzc0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgQXBwbHkgQVJNNjQtc3BlY2lmaWMgbG93 ZXJpbmcgdG8gbG9hZC9zdG9yZSBpbnN0cnVjdGlvbnMgaW4gb2ZmbGluZWFzbQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NTY5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHN0YW5kYXJkIHJpc2Mg bG93ZXJpbmcgb2YgbG9hZC9zdG9yZSBpbnN0cnVjdGlvbnMgd2l0aCBiYXNlICsKKyAgICAgICAg aW1tZWRpYXRlIG9mZnNldCBhZGRyZXNzZXMgaXMgdG8gbW92ZSB0aGUgb2Zmc2V0IHRvIGEgdGVt cG9yYXJ5LCBhZGQgdGhlCisgICAgICAgIGJhc2UgdG8gdGhlIHRlbXBvcmFyeSwgYW5kIHRoZSBj aGFuZ2UgdGhlIGxvYWQvc3RvcmUgdG8gdXNlIHRoZQorICAgICAgICB0ZW1wb3JhcnkgKyAwIGlt bWVkaWF0ZSBvZmZzZXQgYWRkcmVzcy4gSG93ZXZlciwgb24gQVJNNjQsIGJhc2UgKworICAgICAg ICByZWdpc3RlciBvZmZzZXQgYWRkcmVzc2luZyBtb2RlIGlzIGF2YWlsYWJsZSwgc28gaXQgaXMg dW5uZWNlc3NhcnkgdG8KKyAgICAgICAgcGVyZm9ybSBleHBsaWNpdCByZWdpc3RlciBhZGRpdG9u cyBidXQgaXQgaXMgZW5vdWdoIHRvIGNoYW5nZSBsb2FkL3N0b3JlCisgICAgICAgIHRvIHVzZSBi YXNlICsgdGVtcG9yYXJ5IGFzIHRoZSBhZGRyZXNzLgorCisgICAgICAgICogb2ZmbGluZWFzbS9h cm02NC5yYjogQWRkZWQgYXJtNjRMb3dlck1hbGZvcm1lZExvYWRTdG9yZUFkZHJlc3NlcworCiAy MDE0LTA5LTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3Zl IFByb3BlcnR5U2xvdCdzIGlubGluZSBmdW5jdGlvbnMgYmFjayB0byBQcm9wZXJ0eVNsb3QuaC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FybTY0LnJiIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJtNjQucmIKaW5kZXggOWU4NTAyOC4u MTk0MGQ3ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Fy bTY0LnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FybTY0LnJiCkBA IC0xLDQgKzEsNSBAQAogIyBDb3B5cmlnaHQgKEMpIDIwMTEsIDIwMTIsIDIwMTQgQXBwbGUgSW5j LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMTQgVW5pdmVyc2l0eSBv ZiBTemVnZWQuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKQEAgLTE5Nyw2ICsxOTgsMzYgQEAgZW5kCiAjIEFjdHVhbCBsb3dlcmluZyBjb2RlIGZvbGxv d3MuCiAjCiAKK2RlZiBhcm02NExvd2VyTWFsZm9ybWVkTG9hZFN0b3JlQWRkcmVzc2VzKGxpc3Qp CisgICAgbmV3TGlzdCA9IFtdCisKKyAgICBkZWYgaXNBZGRyZXNzTWFsZm9ybWVkKG9wZXJhbmQp CisgICAgICAgIG9wZXJhbmQuaXNfYT8gQWRkcmVzcyBhbmQgbm90ICgtMjU1Li40MDk1KS5pbmNs dWRlPyBvcGVyYW5kLm9mZnNldC52YWx1ZQorICAgIGVuZAorCisgICAgbGlzdC5lYWNoIHsKKyAg ICAgICAgfCBub2RlIHwKKyAgICAgICAgaWYgbm9kZS5pc19hPyBJbnN0cnVjdGlvbgorICAgICAg ICAgICAgaWYgbm9kZS5vcGNvZGUgPX4gL15zdG9yZS8gYW5kIGlzQWRkcmVzc01hbGZvcm1lZChu b2RlLm9wZXJhbmRzWzFdKQorICAgICAgICAgICAgICAgIGFkZHJlc3MgPSBub2RlLm9wZXJhbmRz WzFdCisgICAgICAgICAgICAgICAgdG1wID0gVG1wLm5ldyhjb2RlT3JpZ2luLCA6Z3ByKQorICAg ICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9yaWdpbiwg Im1vdmUiLCBbYWRkcmVzcy5vZmZzZXQsIHRtcF0pCisgICAgICAgICAgICAgICAgbmV3TGlzdCA8 PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLCBub2RlLm9wY29kZSwgW25vZGUub3Bl cmFuZHNbMF0sIEJhc2VJbmRleC5uZXcobm9kZS5jb2RlT3JpZ2luLCBhZGRyZXNzLmJhc2UsIHRt cCwgMSwgSW1tZWRpYXRlLm5ldyhjb2RlT3JpZ2luLCAwKSldLCBub2RlLmFubm90YXRpb24pCisg ICAgICAgICAgICBlbHNpZiBub2RlLm9wY29kZSA9fiAvXmxvYWQvIGFuZCBpc0FkZHJlc3NNYWxm b3JtZWQobm9kZS5vcGVyYW5kc1swXSkKKyAgICAgICAgICAgICAgICBhZGRyZXNzID0gbm9kZS5v cGVyYW5kc1swXQorICAgICAgICAgICAgICAgIHRtcCA9IFRtcC5uZXcoY29kZU9yaWdpbiwgOmdw cikKKyAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLmNvZGVP cmlnaW4sICJtb3ZlIiwgW2FkZHJlc3Mub2Zmc2V0LCB0bXBdKQorICAgICAgICAgICAgICAgIG5l d0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9yaWdpbiwgbm9kZS5vcGNvZGUsIFtC YXNlSW5kZXgubmV3KG5vZGUuY29kZU9yaWdpbiwgYWRkcmVzcy5iYXNlLCB0bXAsIDEsIEltbWVk aWF0ZS5uZXcoY29kZU9yaWdpbiwgMCkpLCBub2RlLm9wZXJhbmRzWzFdXSwgbm9kZS5hbm5vdGF0 aW9uKQorICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgbm9kZQor ICAgICAgICAgICAgZW5kCisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIG5ld0xpc3QgPDwgbm9k ZQorICAgICAgICBlbmQKKyAgICB9CisgICAgbmV3TGlzdAorZW5kCisKIGNsYXNzIFNlcXVlbmNl CiAgICAgZGVmIGdldE1vZGlmaWVkTGlzdEFSTTY0CiAgICAgICAgIHJlc3VsdCA9IEBsaXN0CkBA IC0yMDQsNiArMjM1LDcgQEAgY2xhc3MgU2VxdWVuY2UKICAgICAgICAgcmVzdWx0ID0gcmlzY0xv d2VyU2ltcGxlQnJhbmNoT3BzKHJlc3VsdCkKICAgICAgICAgcmVzdWx0ID0gcmlzY0xvd2VySGFy ZEJyYW5jaE9wczY0KHJlc3VsdCkKICAgICAgICAgcmVzdWx0ID0gcmlzY0xvd2VyU2hpZnRPcHMo cmVzdWx0KQorICAgICAgICByZXN1bHQgPSBhcm02NExvd2VyTWFsZm9ybWVkTG9hZFN0b3JlQWRk cmVzc2VzKHJlc3VsdCkKICAgICAgICAgcmVzdWx0ID0gcmlzY0xvd2VyTWFsZm9ybWVkQWRkcmVz c2VzKHJlc3VsdCkgewogICAgICAgICAgICAgfCBub2RlLCBhZGRyZXNzIHwKICAgICAgICAgICAg IGNhc2Ugbm9kZS5vcGNvZGUK 237911 2014-09-10 15:37:27 -0700 2014-09-10 16:57:48 -0700 Updated patch offlineasm-ldr-str-opt-v3.patch text/plain 3497 akiss ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQxNTJjOTkuLjdhODRkN2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA5LTA1ICBBa29zIEtpc3MgIDxh a2lzc0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgQXBwbHkgQVJNNjQtc3BlY2lmaWMgbG93 ZXJpbmcgdG8gbG9hZC9zdG9yZSBpbnN0cnVjdGlvbnMgaW4gb2ZmbGluZWFzbQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NTY5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHN0YW5kYXJkIHJpc2Mg bG93ZXJpbmcgb2YgbG9hZC9zdG9yZSBpbnN0cnVjdGlvbnMgd2l0aCBiYXNlICsKKyAgICAgICAg aW1tZWRpYXRlIG9mZnNldCBhZGRyZXNzZXMgaXMgdG8gbW92ZSB0aGUgb2Zmc2V0IHRvIGEgdGVt cG9yYXJ5LCBhZGQgdGhlCisgICAgICAgIGJhc2UgdG8gdGhlIHRlbXBvcmFyeSwgYW5kIHRoZW4g Y2hhbmdlIHRoZSBsb2FkL3N0b3JlIHRvIHVzZSB0aGUKKyAgICAgICAgdGVtcG9yYXJ5ICsgMCBp bW1lZGlhdGUgb2Zmc2V0IGFkZHJlc3MuIEhvd2V2ZXIsIG9uIEFSTTY0LCBiYXNlICsKKyAgICAg ICAgcmVnaXN0ZXIgb2Zmc2V0IGFkZHJlc3NpbmcgbW9kZSBpcyBhdmFpbGFibGUsIHNvIGl0IGlz IHVubmVjZXNzYXJ5IHRvCisgICAgICAgIHBlcmZvcm0gZXhwbGljaXQgcmVnaXN0ZXIgYWRkaXRp b25zIGJ1dCBpdCBpcyBlbm91Z2ggdG8gY2hhbmdlIGxvYWQvc3RvcmUKKyAgICAgICAgdG8gdXNl IGJhc2UgKyB0ZW1wb3JhcnkgYXMgdGhlIGFkZHJlc3MuCisKKyAgICAgICAgKiBvZmZsaW5lYXNt L2FybTY0LnJiOiBBZGRlZCBhcm02NExvd2VyTWFsZm9ybWVkTG9hZFN0b3JlQWRkcmVzc2VzCisK IDIwMTQtMDktMDQgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIE1v dmUgUHJvcGVydHlTbG90J3MgaW5saW5lIGZ1bmN0aW9ucyBiYWNrIHRvIFByb3BlcnR5U2xvdC5o LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJtNjQucmIg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hcm02NC5yYgppbmRleCA5ZTg1MDI4 Li4xOTQwZDdkZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v YXJtNjQucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXJtNjQucmIK QEAgLTEsNCArMSw1IEBACiAjIENvcHlyaWdodCAoQykgMjAxMSwgMjAxMiwgMjAxNCBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAxNCBVbml2ZXJzaXR5 IG9mIFN6ZWdlZC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAjIG1vZGlm aWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0 aW9ucwpAQCAtMTk3LDYgKzE5OCwzNiBAQCBlbmQKICMgQWN0dWFsIGxvd2VyaW5nIGNvZGUgZm9s bG93cy4KICMKIAorZGVmIGFybTY0TG93ZXJNYWxmb3JtZWRMb2FkU3RvcmVBZGRyZXNzZXMobGlz dCkKKyAgICBuZXdMaXN0ID0gW10KKworICAgIGRlZiBpc0FkZHJlc3NNYWxmb3JtZWQob3BlcmFu ZCkKKyAgICAgICAgb3BlcmFuZC5pc19hPyBBZGRyZXNzIGFuZCBub3QgKC0yNTUuLjQwOTUpLmlu Y2x1ZGU/IG9wZXJhbmQub2Zmc2V0LnZhbHVlCisgICAgZW5kCisKKyAgICBsaXN0LmVhY2ggewor ICAgICAgICB8IG5vZGUgfAorICAgICAgICBpZiBub2RlLmlzX2E/IEluc3RydWN0aW9uCisgICAg ICAgICAgICBpZiBub2RlLm9wY29kZSA9fiAvXnN0b3JlLyBhbmQgaXNBZGRyZXNzTWFsZm9ybWVk KG5vZGUub3BlcmFuZHNbMV0pCisgICAgICAgICAgICAgICAgYWRkcmVzcyA9IG5vZGUub3BlcmFu ZHNbMV0KKyAgICAgICAgICAgICAgICB0bXAgPSBUbXAubmV3KGNvZGVPcmlnaW4sIDpncHIpCisg ICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2lu LCAibW92ZSIsIFthZGRyZXNzLm9mZnNldCwgdG1wXSkKKyAgICAgICAgICAgICAgICBuZXdMaXN0 IDw8IEluc3RydWN0aW9uLm5ldyhub2RlLmNvZGVPcmlnaW4sIG5vZGUub3Bjb2RlLCBbbm9kZS5v cGVyYW5kc1swXSwgQmFzZUluZGV4Lm5ldyhub2RlLmNvZGVPcmlnaW4sIGFkZHJlc3MuYmFzZSwg dG1wLCAxLCBJbW1lZGlhdGUubmV3KGNvZGVPcmlnaW4sIDApKV0sIG5vZGUuYW5ub3RhdGlvbikK KyAgICAgICAgICAgIGVsc2lmIG5vZGUub3Bjb2RlID1+IC9ebG9hZC8gYW5kIGlzQWRkcmVzc01h bGZvcm1lZChub2RlLm9wZXJhbmRzWzBdKQorICAgICAgICAgICAgICAgIGFkZHJlc3MgPSBub2Rl Lm9wZXJhbmRzWzBdCisgICAgICAgICAgICAgICAgdG1wID0gVG1wLm5ldyhjb2RlT3JpZ2luLCA6 Z3ByKQorICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29k ZU9yaWdpbiwgIm1vdmUiLCBbYWRkcmVzcy5vZmZzZXQsIHRtcF0pCisgICAgICAgICAgICAgICAg bmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcobm9kZS5jb2RlT3JpZ2luLCBub2RlLm9wY29kZSwg W0Jhc2VJbmRleC5uZXcobm9kZS5jb2RlT3JpZ2luLCBhZGRyZXNzLmJhc2UsIHRtcCwgMSwgSW1t ZWRpYXRlLm5ldyhjb2RlT3JpZ2luLCAwKSksIG5vZGUub3BlcmFuZHNbMV1dLCBub2RlLmFubm90 YXRpb24pCisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBub2Rl CisgICAgICAgICAgICBlbmQKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbmV3TGlzdCA8PCBu b2RlCisgICAgICAgIGVuZAorICAgIH0KKyAgICBuZXdMaXN0CitlbmQKKwogY2xhc3MgU2VxdWVu Y2UKICAgICBkZWYgZ2V0TW9kaWZpZWRMaXN0QVJNNjQKICAgICAgICAgcmVzdWx0ID0gQGxpc3QK QEAgLTIwNCw2ICsyMzUsNyBAQCBjbGFzcyBTZXF1ZW5jZQogICAgICAgICByZXN1bHQgPSByaXNj TG93ZXJTaW1wbGVCcmFuY2hPcHMocmVzdWx0KQogICAgICAgICByZXN1bHQgPSByaXNjTG93ZXJI YXJkQnJhbmNoT3BzNjQocmVzdWx0KQogICAgICAgICByZXN1bHQgPSByaXNjTG93ZXJTaGlmdE9w cyhyZXN1bHQpCisgICAgICAgIHJlc3VsdCA9IGFybTY0TG93ZXJNYWxmb3JtZWRMb2FkU3RvcmVB ZGRyZXNzZXMocmVzdWx0KQogICAgICAgICByZXN1bHQgPSByaXNjTG93ZXJNYWxmb3JtZWRBZGRy ZXNzZXMocmVzdWx0KSB7CiAgICAgICAgICAgICB8IG5vZGUsIGFkZHJlc3MgfAogICAgICAgICAg ICAgY2FzZSBub2RlLm9wY29kZQo=