136562 2014-09-04 18:32:59 -0700 [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled 2014-09-05 13:25:17 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki clopez benjamin berto cdumez cgarcia clopez commit-queue danw gustavo gyuyoung.kim mrobinson pnormand psolanki svillar oldest_to_newest 1033381 0 psolanki 2014-09-04 18:32:59 -0700 Build is broken after bug 136534 (r173272) because that change relies on a platform specific platformSuggestedFilename() method. I will be adding a stub one to fix the build but this needs to be implemented correctly. 1033382 1 psolanki 2014-09-04 18:36:42 -0700 Stub implementation landed in https://trac.webkit.org/r173301 1033478 2 clopez 2014-09-05 10:19:09 -0700 r173272 introduced two new layout test failures on the GTK port: http/tests/download/basic-ascii.html [ Failure ] http/tests/download/literal-utf-8.html [ Failure ] Diffs here: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r173306%20%282554%29/http/tests/download/ I'm updating the GTK TestExpectations and assigning this bug to such failures since I think that fixing this bug will fix also both tests. 1033495 3 clopez 2014-09-05 11:26:21 -0700 r173272 has also caused failures on the GTK API tests: TestWebKitAPI/WebKit2Gtk/TestDownloads TestWebKitAPI/WebKit2Gtk/TestResources $ Tools/Scripts/run-gtk-tests --verbose --release WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources TEST: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads... (pid=2457) /webkit2/Downloads/local-file: OK /webkit2/Downloads/local-file-error: OK /webkit2/Downloads/remote-file: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:172:void DownloadTest::checkDestinationAndDeleteFile(WebKitDownload*, const char*): assertion failed (destBasename.get() == expectedName): ("test.pdf" == "webkit-downloaded-file") FAIL GTester: last random seed: R02S411e3b1c5da1feafced3b6bd5721a40f (pid=2521) /webkit2/Downloads/remote-file-error: OK /webkit2/Downloads/policy-decision-download: OK /webkit2/WebKitWebView/download-uri: OK FAIL: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads TEST: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources... (pid=2548) /webkit2/WebKitWebView/resources: OK /webkit2/WebKitWebView/history-cache: OK /webkit2/WebKitWebResource/loading: OK /webkit2/WebKitWebResource/response: OK /webkit2/WebKitWebResource/mime-type: OK /webkit2/WebKitWebResource/suggested-filename: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:431:void testWebResourceSuggestedFilename(SingleResourceLoadTest*, gconstpointer): assertion failed (webkit_uri_response_get_suggested_filename(response) == "JavaScript.js"): (NULL == "JavaScript.js") FAIL GTester: last random seed: R02Sa97354273c64dd60f7d30bb2ec4a95b7 (pid=2574) /webkit2/WebKitWebResource/active-uri: OK /webkit2/WebKitWebResource/get-data: OK /webkit2/WebKitWebPage/send-request: OK FAIL: WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources Tests failed (2): WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestDownloads, WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestResources I'm assigning this bug also to such failures. 1033502 4 clopez 2014-09-05 11:44:28 -0700 Updated GTK TestExpectations and list of API Skipped tests on http://trac.webkit.org/changeset/173319 1033524 5 237706 clopez 2014-09-05 12:41:00 -0700 Created attachment 237706 Patch 1033537 6 237706 commit-queue 2014-09-05 13:25:12 -0700 Comment on attachment 237706 Patch Clearing flags on attachment: 237706 Committed r173331: <http://trac.webkit.org/changeset/173331> 1033538 7 commit-queue 2014-09-05 13:25:17 -0700 All reviewed patches have been landed. Closing bug. 237706 2014-09-05 12:41:00 -0700 2014-09-05 13:25:12 -0700 Patch bug-136562-20140905214053.patch text/plain 5215 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGEyMGI1MjRkMTU0NzYy NWMyMGJhOGUyMWZjZjdhMTYxYzAzMDQ2Yi4uZTczZmFkZTZmMDFkMWVkNWZjM2NlZWU2MzQ3MmM3 M2RjMGRhMjgxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA5LTA1ICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtT T1VQXSBJbXBsZW1lbnQgUmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1TdWdnZXN0ZWRGaWxlbmFt ZSgpIHdoZW4gVVNFKFNPVVApIGlzIGVuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY1NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHRoaXMgbWFrZXMgZXhpc3Rpbmcg dGVzdHMgcGFzcy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJl c3BvbnNlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpwbGF0 Zm9ybVN1Z2dlc3RlZEZpbGVuYW1lKToKKyAgICAgICAgSW1wbGVtZW50IFJlc291cmNlUmVzcG9u c2U6OnBsYXRmb3JtU3VnZ2VzdGVkRmlsZW5hbWUoKSBmb3IgU09VUCBhZnRlciByMTczMjcyLCBy MTczMzAxIGFuZCByMTczMzA1LgorCiAyMDE0LTA5LTA1ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5n QGFwcGxlLmNvbT4KIAogICAgICAgICBDVFRFOiBTVkdSZXNvdXJjZXNDYWNoZSBzaG91bGQgb25s eSBhbGxvdyBSZW5kZXJFbGVtZW50cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3BvbnNlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXNwb25zZVNvdXAuY3BwCmluZGV4IDBm ZDc5MWU0YjczMzkyOGJlZjQ2ZTg1M2I3ODY0N2E5YmQ3ZGI3ZjQuLmVlNDg1YjZlZWU1ODhjYWYz YTJkYmIzNjAwOTQ0MDBmMDZiN2QwYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3BvbnNlU291cC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcApAQCAt MTAzLDcgKzEwMyw3IEBAIHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6dXBkYXRlRnJvbVNvdXBNZXNz YWdlSGVhZGVycyhjb25zdCBTb3VwTWVzc2FnZUhlYWRlcnMqIG1lCiAKIFN0cmluZyBSZXNvdXJj ZVJlc3BvbnNlOjpwbGF0Zm9ybVN1Z2dlc3RlZEZpbGVuYW1lKCkgY29uc3QKIHsKLSAgICByZXR1 cm4gU3RyaW5nKCk7CisgICAgcmV0dXJuIGZpbGVuYW1lRnJvbUhUVFBDb250ZW50RGlzcG9zaXRp b24oaHR0cEhlYWRlckZpZWxkKEhUVFBIZWFkZXJOYW1lOjpDb250ZW50RGlzcG9zaXRpb24pKTsK IH0KIAogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDUwNDU2NmMyNmMwYmU1NTRiZGZjYWU1OTljZWI4NjJhNzMzZDdlYWEuLjZmODQ2NjNkMjJh N2M1NzRjZmNmMDMyMjg4NGIwYjdlZjcyZWFlMWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wOS0wNSAgQ2Fy bG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBb U09VUF0gSW1wbGVtZW50IFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtU3VnZ2VzdGVkRmlsZW5h bWUoKSB3aGVuIFVTRShTT1VQKSBpcyBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NTYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6CisgICAgICAg IChUZXN0UnVubmVyKTogUmVtb3ZlIGZhaWx1cmUgZXhwZWN0YXRpb25zIGZvciB0ZXN0cyB0aGF0 IG5vdyBwYXNzLgorCiAyMDE0LTA5LTA0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIERhc2hib2FyZCBtZXRyaWNzIHBhZ2Ugd2FzdGVzIGEgbG90IG9mIHRp bWUgc29ydGluZyBpdGVyYXRpb25zCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1ndGst dGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMKaW5kZXggZDBhZWE2OTkwNjY0MGI0 MzZlNzlkODJiMDU0MTgyMDg2NWZhMzYxYy4uZDUzMGY5ZDQ1MzU4YTAyYWYzYjc1MGQwNmQ1Zjlm ZGRjOGUwNmQ2MSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzCisrKyBi L1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwpAQCAtNjcsOCArNjcsNiBAQCBjbGFzcyBUZXN0 UnVubmVyOgogICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0Mkd0ay9UZXN0V2ViS2l0V2ViVmll dyIsICIvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L3NuYXBzaG90IiwgIlRlc3QgZmFpbHMiLCAxMjA0 MDQpLAogICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0Mkd0ay9UZXN0V2ViS2l0V2ViVmlldyIs ICIvd2Via2l0Mi9XZWJLaXRXZWJWaWV3L3BhZ2UtdmlzaWJpbGl0eSIsICJUZXN0IGZhaWxzIG9y IHRpbWVzIG91dCIsIDEzMTczMSksCiAgICAgICAgIFNraXBwZWRUZXN0KCJXZWJLaXQyR3RrL1Rl c3RDb29raWVNYW5hZ2VyIiwgIi93ZWJraXQyL1dlYktpdENvb2tpZU1hbmFnZXIvcGVyc2lzdGVu dC1zdG9yYWdlIiwgIlRlc3QgaXMgZmxha3kiLCAxMzQ1ODApLAotICAgICAgICBTa2lwcGVkVGVz dCgiV2ViS2l0Mkd0ay9UZXN0RG93bmxvYWRzIiwgIi93ZWJraXQyL0Rvd25sb2Fkcy9yZW1vdGUt ZmlsZSIsICJUZXN0IGZhaWxzIHNpbmNlIHIxNzMyNzIiLCAxMzY1NjIpLAotICAgICAgICBTa2lw cGVkVGVzdCgiV2ViS2l0Mkd0ay9UZXN0UmVzb3VyY2VzIiwgIi93ZWJraXQyL1dlYktpdFdlYlJl c291cmNlL3N1Z2dlc3RlZC1maWxlbmFtZSIsICJUZXN0IGZhaWxzIHNpbmNlIHIxNzMyNzIiLCAx MzY1NjIpLAogICAgICAgICBTa2lwcGVkVGVzdCgiV2ViS2l0Mi9UZXN0V2ViS2l0MiIsICJXZWJL aXQyLk1vdXNlTW92ZUFmdGVyQ3Jhc2giLCAiVGVzdCBpcyBmbGFreSIsIDg1MDY2KSwKICAgICAg ICAgU2tpcHBlZFRlc3QoIldlYktpdDIvVGVzdFdlYktpdDIiLCAiV2ViS2l0Mi5OZXdGaXJzdFZp c3VhbGx5Tm9uRW1wdHlMYXlvdXRGb3JJbWFnZXMiLCAiVGVzdCBpcyBmbGFreSIsIDg1MDY2KSwK ICAgICAgICAgU2tpcHBlZFRlc3QoIldlYktpdDIvVGVzdFdlYktpdDIiLCAiV2ViS2l0Mi5OZXdG aXJzdFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRGcmFtZXMiLCAiVGVzdCBmYWlscyIsIDg1MDM3KSwK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MmE1ODhhMTlhM2ZlOWU1YTdiMmQ2OWRiZTY3ZmJmNmY1OWIzNWRiLi4wNmU2Y2I1 ZDYxMDc2OWE4MDQzMDgxYmQ3NjRmNmQ0ZGQ4ZTNiMmU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTQtMDktMDUgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5j b20+CiAKKyAgICAgICAgW1NPVVBdIEltcGxlbWVudCBSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9y bVN1Z2dlc3RlZEZpbGVuYW1lKCkgd2hlbiBVU0UoU09VUCkgaXMgZW5hYmxlZC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjU2MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnM6IFJlbW92ZSBmYWlsdXJlIGV4cGVjdGF0aW9ucyBmb3IgdGVzdHMgdGhh dCBub3cgcGFzcy4KKworMjAxNC0wOS0wNSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxj bG9wZXpAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RLXSBVbnJldmlld2VkIEdUSyBnYXJkZW5p bmcuCiAKICAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczogUmVwb3J0IGFu ZCBtYXJrIG5ldyBmYWlsdXJlcyBhZnRlciByMTczMDQ5IGFuZCByMTczMjcyLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBlNDQ4MjM4YzZkZTE2ZTE0MjIw NzVjZmQ5YWNkZmNmY2NkOGIyMWI1Li5iMmY3OWM0YmQyZTRjYTNmMDMzMDIxOGJkOWI5NjQ4OTgy MDJiOGI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0 aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAt MjExNSw5ICsyMTE1LDYgQEAgd2Via2l0Lm9yZy9iLzEzNjE1OSBmYXN0L2JvcmRlcnMvaGlkcGkt Ym9yZGVyLXBhaW50aW5nLXJpZGdlLmh0bWwgWyBJbWFnZU9ubHlGYWkKIHdlYmtpdC5vcmcvYi8x MzY1MzcgY3NzMy9mbGV4Ym94L2ZsZXgtcm91bmRpbmcuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0 Lm9yZy9iLzEzNjUzNyBmYXN0L3N1Yi1waXhlbC9jbGllbnQtd2lkdGgtaGVpZ2h0LXNuYXBwaW5n Lmh0bWwgWyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzEzNjU2MiBodHRwL3Rlc3RzL2Rvd25s b2FkL2Jhc2ljLWFzY2lpLmh0bWwgWyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8xMzY1NjIgaHR0 cC90ZXN0cy9kb3dubG9hZC9saXRlcmFsLXV0Zi04Lmh0bWwgWyBGYWlsdXJlIF0KLQogIy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgRW5kIG9mIFRlc3RzIGZhaWxpbmcKICMvLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCg==