136561 2014-09-04 17:49:33 -0700 Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots 2014-09-10 13:29:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser ap simon.fraser oldest_to_newest 1033366 0 simon.fraser 2014-09-04 17:49:33 -0700 Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots 1033367 1 237663 simon.fraser 2014-09-04 17:50:07 -0700 Created attachment 237663 Patch 1033369 2 237663 thorton 2014-09-04 17:51:18 -0700 Comment on attachment 237663 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237663&action=review > Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm:58 > + WTFLogAlways("calloc(%llu, %llu) failed\n", pixelsHigh, rowBytes); Can we throw a note in here about where these are coming from? ("DumpRenderTree: calloc..."). 1033370 3 simon.fraser 2014-09-04 17:55:39 -0700 https://trac.webkit.org/r173297 1034369 4 ap 2014-09-10 12:45:33 -0700 It says: DumpRenderTree: calloc(18446744073709551595, 64) failed http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r173475%20(7561)/fast/regions/auto-size/autosize-region-window-resize-stderr.txt 18446744073709551595 is 0x7FFFFFFFFFFFFFFF 1034387 5 simon.fraser 2014-09-10 13:29:41 -0700 Yeah. I should have logged height and width. 237663 2014-09-04 17:50:07 -0700 2014-09-04 17:51:18 -0700 Patch bug-136561-20140904175001.patch text/plain 3151 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMjk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDU0ODE3ZTM0MDk5OTlkZmVlYjgzY2NhNzBhZTliZjFm NTRhNzA1Ni4uM2YzZmU5YzQ5ZGYwYTRmYjI2YWViMjRlYmU2M2ZlZDFmNGZjMmNiYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA5LTA0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBzb21lIGxvZ2dpbmcgdG8gaGVscCBkaWFnbm9zZSBhc3NlcnRpb25zIGlu IGR1bXBXZWJWaWV3QXNQaXhlbHNBbmRDb21wYXJlV2l0aEV4cGVjdGVkKCkgb24gYm90cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NTYxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBMb2cg Zm9yIGNhbGxvYygpIGFuZCBDR0JpdG1hcENvbnRleHRDcmVhdGUoKSBmYWlsdXJlcy4KKworICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9QaXhlbER1bXBTdXBwb3J0TWFjLm1tOgorICAgICAg ICAoY3JlYXRlQml0bWFwQ29udGV4dCk6CisgICAgICAgIChjcmVhdGVCaXRtYXBDb250ZXh0RnJv bVdlYlZpZXcpOgorCiAyMDE0LTA5LTA0ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIFtXaW5dIHdlYmtpdHB5IHRlc3Qgc3VpdGUgZnJlcXVlbnRseSBmYWls cyB0byBjb21wbGV0ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL1BpeGVs RHVtcFN1cHBvcnRNYWMubW0gYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMvUGl4ZWxEdW1wU3Vw cG9ydE1hYy5tbQppbmRleCA4YzZmMjU2YTg3YWVjMzhhMjUwMWNhYTA2ODUxODhlZjgwNWZlODhi Li44OWUzMWU0MTQyNzA4YmZhZWE0ZjYyZDU4ZjM3YmQwMWU4MjMzNTBjIDEwMDY0NAotLS0gYS9U b29scy9EdW1wUmVuZGVyVHJlZS9tYWMvUGl4ZWxEdW1wU3VwcG9ydE1hYy5tbQorKysgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9tYWMvUGl4ZWxEdW1wU3VwcG9ydE1hYy5tbQpAQCAtNTQsMTUgKzU0 LDE4IEBAIHN0YXRpYyBQYXNzUmVmUHRyPEJpdG1hcENvbnRleHQ+IGNyZWF0ZUJpdG1hcENvbnRl eHQoc2l6ZV90IHBpeGVsc1dpZGUsIHNpemVfdCBwCiAgICAgcm93Qnl0ZXMgPSAoNCAqIHBpeGVs c1dpZGUgKyA2MykgJiB+NjM7IC8vIFVzZSBhIG11bHRpcGxlIG9mIDY0IGJ5dGVzIHRvIGltcHJv dmUgQ0cgcGVyZm9ybWFuY2UKIAogICAgIGJ1ZmZlciA9IGNhbGxvYyhwaXhlbHNIaWdoLCByb3dC eXRlcyk7Ci0gICAgaWYgKCFidWZmZXIpCi0gICAgICAgIHJldHVybiAwOworICAgIGlmICghYnVm ZmVyKSB7CisgICAgICAgIFdURkxvZ0Fsd2F5cygiY2FsbG9jKCVsbHUsICVsbHUpIGZhaWxlZFxu IiwgcGl4ZWxzSGlnaCwgcm93Qnl0ZXMpOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICB9 CiAgICAgCiAgICAgLy8gQ3JlYXRpbmcgdGhpcyBiaXRtYXAgaW4gdGhlIGRldmljZSBjb2xvciBz cGFjZSBwcmV2ZW50cyBhbnkgY29sb3IgY29udmVyc2lvbiB3aGVuIHRoZSBpbWFnZSBvZiB0aGUg d2ViIHZpZXcgaXMgZHJhd24gaW50byBpdC4KICAgICBSZXRhaW5QdHI8Q0dDb2xvclNwYWNlUmVm PiBjb2xvclNwYWNlID0gYWRvcHRDRihDR0NvbG9yU3BhY2VDcmVhdGVEZXZpY2VSR0IoKSk7CiAg ICAgQ0dDb250ZXh0UmVmIGNvbnRleHQgPSBDR0JpdG1hcENvbnRleHRDcmVhdGUoYnVmZmVyLCBw aXhlbHNXaWRlLCBwaXhlbHNIaWdoLCA4LCByb3dCeXRlcywgY29sb3JTcGFjZS5nZXQoKSwga0NH SW1hZ2VBbHBoYVByZW11bHRpcGxpZWRGaXJzdCB8IGtDR0JpdG1hcEJ5dGVPcmRlcjMySG9zdCk7 IC8vIFVzZSBBUkdCOCBvbiBQUEMgb3IgQkdSQTggb24gWDg2IHRvIGltcHJvdmUgQ0cgcGVyZm9y bWFuY2UKICAgICBpZiAoIWNvbnRleHQpIHsKICAgICAgICAgZnJlZShidWZmZXIpOwotICAgICAg ICByZXR1cm4gMDsKKyAgICAgICAgV1RGTG9nQWx3YXlzKCJDR0JpdG1hcENvbnRleHRDcmVhdGUo JXAsICVsbHUsICVsbHUsIDgsICVsbHUsICVwLCAweCV4KSBmYWlsZWRcbiIsIGJ1ZmZlciwgcGl4 ZWxzSGlnaCwgcGl4ZWxzV2lkZSwgcm93Qnl0ZXMsIGNvbG9yU3BhY2UuZ2V0KCksIGtDR0ltYWdl QWxwaGFQcmVtdWx0aXBsaWVkRmlyc3QgfCBrQ0dCaXRtYXBCeXRlT3JkZXIzMkhvc3QpOworICAg ICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CiAKICAgICByZXR1cm4gQml0bWFwQ29udGV4dDo6 Y3JlYXRlQnlBZG9wdGluZ0JpdG1hcEFuZENvbnRleHQoYnVmZmVyLCBjb250ZXh0KTsKQEAgLTEx NSwxMCArMTE4LDEwIEBAIFBhc3NSZWZQdHI8Qml0bWFwQ29udGV4dD4gY3JlYXRlQml0bWFwQ29u dGV4dEZyb21XZWJWaWV3KGJvb2wgb25zY3JlZW4sIGJvb2wgaW5jCiAgICAgc2l6ZV90IHBpeGVs c1dpZGUgPSBzdGF0aWNfY2FzdDxzaXplX3Q+KHdlYlZpZXdTaXplLndpZHRoICogZGV2aWNlU2Nh bGVGYWN0b3IpOwogICAgIHNpemVfdCBwaXhlbHNIaWdoID0gc3RhdGljX2Nhc3Q8c2l6ZV90Pih3 ZWJWaWV3U2l6ZS5oZWlnaHQgKiBkZXZpY2VTY2FsZUZhY3Rvcik7CiAgICAgc2l6ZV90IHJvd0J5 dGVzID0gMDsKLSAgICB2b2lkKiBidWZmZXIgPSAwOworICAgIHZvaWQqIGJ1ZmZlciA9IG51bGxw dHI7CiAgICAgUmVmUHRyPEJpdG1hcENvbnRleHQ+IGJpdG1hcENvbnRleHQgPSBjcmVhdGVCaXRt YXBDb250ZXh0KHBpeGVsc1dpZGUsIHBpeGVsc0hpZ2gsIHJvd0J5dGVzLCBidWZmZXIpOwogICAg IGlmICghYml0bWFwQ29udGV4dCkKLSAgICAgICAgcmV0dXJuIDA7CisgICAgICAgIHJldHVybiBu dWxscHRyOwogICAgIENHQ29udGV4dFJlZiBjb250ZXh0ID0gYml0bWFwQ29udGV4dC0+Y2dDb250 ZXh0KCk7CiAgICAgLy8gVGhlIGZpbmFsIHNjYWxpbmcgZ2V0cyBkb3VibGVkIG9uIHRoZSBzY3Jl ZW4gY2FwdHVyZSBzdXJmYWNlIHdoZW4gd2UgdXNlIHRoZSBoaWRwaSBiYWNraW5nU2NhbGVGYWN0 b3IgdmFsdWUgZm9yIENUTS4KICAgICAvLyBUaGlzIGlzIGEgd29ya2Fyb3VuZCB0byBwdXNoIHRo ZSBzY2FsaW5nIGJhY2suCg==