136560 2014-09-04 17:38:24 -0700 Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility 2014-09-04 18:03:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki joepeck psolanki oldest_to_newest 1033362 0 psolanki 2014-09-04 17:38:24 -0700 Bring back [WebPreferences setDiskImageCacheEnabled:] for backwards compatibility 1033363 1 237661 psolanki 2014-09-04 17:40:32 -0700 Created attachment 237661 Patch 1033364 2 237661 joepeck 2014-09-04 17:46:46 -0700 Comment on attachment 237661 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237661&action=review r=me > Source/WebKit/mac/WebView/WebPreferences.mm:1909 > +- (void)setDiskImageCacheEnabled:(BOOL)enabled > +{ > +} You could throw a comment in here in case anyone sees this. // Staging. Can be removed once there are no more callers. 1033375 3 psolanki 2014-09-04 18:03:05 -0700 Committed r173299: <http://trac.webkit.org/changeset/173299> 237661 2014-09-04 17:40:32 -0700 2014-09-04 17:46:45 -0700 Patch bug-136560-20140904174027.patch text/plain 2319 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggODdhNzU1MjEx YTk4YTU0MTRhZjA5OWJkMGEzMGY3NzZlMmZhNzgyOS4uOGU5N2FlZTY5N2M1YzVmN2UzNjJhMTY5 ZDVjMjNkYTIzM2Y4Y2NkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0 LTA5LTA0ICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KIAorICAgICAgICBC cmluZyBiYWNrIFtXZWJQcmVmZXJlbmNlcyBzZXREaXNrSW1hZ2VDYWNoZUVuYWJsZWQ6XSBmb3Ig YmFja3dhcmRzIGNvbXBhdGliaWxpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNjU2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEkgcmVtb3ZlZCB0aGUgZGlzayBpbWFnZSBjYWNoaW5nIGNvZGUgaW4g cjE3MzI2NS4gSG93ZXZlciwgd2Ugc3RpbGwgaGF2ZSBjbGllbnRzIHRoYXQgY2FsbAorICAgICAg ICBzZXREaXNrSW1hZ2VDYWNoZUVuYWJsZWQuIEFkZCBpbiBhIHN0dWIgbWV0aG9kIHVudGlsIHdl IGNhbiB3ZWFuIHRoZSBjbGllbnRzIG9mZiB0aGlzIGNhbGwuIAorCisgICAgICAgICogV2ViVmll dy9XZWJQcmVmZXJlbmNlcy5tbToKKyAgICAgICAgKC1bV2ViUHJlZmVyZW5jZXMgc2V0RGlza0lt YWdlQ2FjaGVFbmFibGVkOl0pOgorICAgICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2 YXRlLmg6CisKKzIwMTQtMDktMDQgIFByYXRpayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29t PgorCiAgICAgICAgIFJlbW92ZSBpT1Mgc3BlY2lmaWMgZGlzayBpbWFnZSBjYWNoZQogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NTE3CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViUHJlZmVyZW5jZXMubW0gYi9Tb3Vy Y2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzLm1tCmluZGV4IDI2ZGM1M2MzODRk ODdlOTRmZDhhMGE0NWJlZTY2NTU4MmU2NDBiMDMuLjA1N2ExYzNlZjIyMTFjZTgzMTc0ZTdiZTFj NTU0ZGY3OTk0NWIzNWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2Vi UHJlZmVyZW5jZXMubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJl bmNlcy5tbQpAQCAtMTkwNCw2ICsxOTA0LDEwIEBAIHN0YXRpYyBOU1N0cmluZyAqY2xhc3NJQkNy ZWF0b3JJRCA9IG5pbDsKICAgICBbc2VsZiBfc2V0Qm9vbFZhbHVlOmVuYWJsZWQgZm9yS2V5Oldl YktpdEFjY2VsZXJhdGVkMmRDYW52YXNFbmFibGVkUHJlZmVyZW5jZUtleV07CiB9CiAKKy0gKHZv aWQpc2V0RGlza0ltYWdlQ2FjaGVFbmFibGVkOihCT09MKWVuYWJsZWQKK3sKK30KKwogLSAoQk9P TClpc0ZyYW1lRmxhdHRlbmluZ0VuYWJsZWQKIHsKICAgICByZXR1cm4gW3NlbGYgX2Jvb2xWYWx1 ZUZvcktleTpXZWJLaXRGcmFtZUZsYXR0ZW5pbmdFbmFibGVkUHJlZmVyZW5jZUtleV07CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzUHJpdmF0ZS5o IGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJQcmVmZXJlbmNlc1ByaXZhdGUuaAppbmRl eCBlNGRhMWZmMjAwMzY5NmQ1ODdiMzUxNDUzZWQxY2JhZDIwZWVlMmNiLi4xY2JkOWQwMGRjNWIx OWFiZGFiNTg3NzkyZmFjOTMwOTAyOTczMmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21h Yy9XZWJWaWV3L1dlYlByZWZlcmVuY2VzUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFj L1dlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmgKQEAgLTI3MSw2ICsyNzEsOSBAQCBleHRl cm4gTlNTdHJpbmcgKldlYlByZWZlcmVuY2VzQ2FjaGVNb2RlbENoYW5nZWRJbnRlcm5hbE5vdGlm aWNhdGlvbjsKIC0gKHZvaWQpX3NldE1pbmltdW1ab29tRm9udFNpemU6KGZsb2F0KXNpemU7CiAt IChmbG9hdClfbWluaW11bVpvb21Gb250U2l6ZTsKIAorLy8gRGVwcmVjYXRlZC4gSGFzIG5vIGVm ZmVjdC4KKy0gKHZvaWQpc2V0RGlza0ltYWdlQ2FjaGVFbmFibGVkOihCT09MKWVuYWJsZWQ7CisK IC0gKHZvaWQpc2V0TWVkaWFQbGF5YmFja0FsbG93c0FpclBsYXk6KEJPT0wpZmxhZzsKIC0gKEJP T0wpbWVkaWFQbGF5YmFja0FsbG93c0FpclBsYXk7CiAjZW5kaWYK