136559 2014-09-04 17:09:21 -0700 Dashboard metrics page wastes a lot of time sorting iterations 2014-09-05 12:09:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap thorton oldest_to_newest 1033357 0 ap 2014-09-04 17:09:21 -0700 We now re-sort iterations array for every iteration that is parsed, which makes no sense at all. Especially because we don't even end up with a sorted array, as we sort it before adding to it. This only affects the metrics page, not the regular dashboard which updates previously shallowly loaded iterations in place. 1033376 1 237665 ap 2014-09-04 18:10:14 -0700 Created attachment 237665 proposed fix 1033511 2 ap 2014-09-05 12:09:29 -0700 Committed <http://trac.webkit.org/r173322>. 237665 2014-09-04 18:10:14 -0700 2014-09-05 11:52:52 -0700 proposed fix MetricsFixes.txt text/plain 3851 ap SW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90SXRlcmF0aW9uLmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90SXRlcmF0aW9uLmpzCShyZXZpc2lv biAxNzMyNTkpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdEl0ZXJhdGlvbi5qcwko d29ya2luZyBjb3B5KQpAQCAtMzA4LDkgKzMwOCw2IEBAIEJ1aWxkYm90SXRlcmF0aW9uLnByb3Rv dHlwZSA9IHsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIHRoaXMuX3Byb2R1Y3RpdmUgPSBm aW5pc2hlZEFueVByb2R1Y3RpdmVTdGVwOwogICAgICAgICB9Ci0KLSAgICAgICAgLy8gVXBkYXRl IHRoZSBzb3J0aW5nIHNpbmNlIGl0IGlzIGJhc2VkIG9uIHRoZSByZXZpc2lvbnMgd2UganVzdCBs b2FkZWQuCi0gICAgICAgIHRoaXMucXVldWUuc29ydEl0ZXJhdGlvbnMoKTsKICAgICB9LAogCiAg ICAgX3VwZGF0ZVdpdGhEYXRhOiBmdW5jdGlvbihkYXRhKQpAQCAtMzE5LDYgKzMxNiwxMCBAQCBC dWlsZGJvdEl0ZXJhdGlvbi5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm47CiAKICAg ICAgICAgdGhpcy5fcGFyc2VEYXRhKGRhdGEpOworCisgICAgICAgIC8vIFVwZGF0ZSB0aGUgc29y dGluZyBzaW5jZSBpdCBpcyBiYXNlZCBvbiB0aGUgcmV2aXNpb24gbnVtYmVycyB0aGF0IGp1c3Qg YmVjYW1lIGtub3duLgorICAgICAgICB0aGlzLnF1ZXVlLnNvcnRJdGVyYXRpb25zKCk7CisKICAg ICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoQnVpbGRib3RJdGVyYXRpb24uRXZl bnQuVXBkYXRlZCk7CiAgICAgfSwKIApJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRi b3RRdWV1ZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1 ZXVlLmpzCShyZXZpc2lvbiAxNzMyNTkpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJv dFF1ZXVlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0yMjIsMTEgKzIyMiwxMyBAQCBCdWlsZGJvdFF1 ZXVlLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5fbG9hZCh0aGlzLmFsbEl0ZXJhdGlvbnNV UkwsIGZ1bmN0aW9uKGRhdGEpIHsKICAgICAgICAgICAgIGZvciAodmFyIGlkU3RyaW5nIGluIGRh dGEpIHsKICAgICAgICAgICAgICAgICBjb25zb2xlLmFzc2VydCh0eXBlb2YgaWRTdHJpbmcgPT09 ICJzdHJpbmciKTsKLSAgICAgICAgICAgICAgICBpdGVyYXRpb24gPSBuZXcgQnVpbGRib3RJdGVy YXRpb24odGhpcywgZGF0YVtpZFN0cmluZ10pOworICAgICAgICAgICAgICAgIHZhciBpdGVyYXRp b24gPSBuZXcgQnVpbGRib3RJdGVyYXRpb24odGhpcywgZGF0YVtpZFN0cmluZ10pOwogICAgICAg ICAgICAgICAgIHRoaXMuaXRlcmF0aW9ucy5wdXNoKGl0ZXJhdGlvbik7CiAgICAgICAgICAgICAg ICAgdGhpcy5fa25vd25JdGVyYXRpb25zW2l0ZXJhdGlvbi5pZF0gPSBpdGVyYXRpb247CiAgICAg ICAgICAgICB9CiAKKyAgICAgICAgICAgIHRoaXMuc29ydEl0ZXJhdGlvbnMoKTsKKwogICAgICAg ICAgICAgY2FsbGJhY2sodGhpcyk7CiAgICAgICAgIH0uYmluZCh0aGlzKSk7CiAgICAgfSwKSW5k ZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1Ymxp Y19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL01ldHJpY3NBbmFseXplci5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNf aHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9NZXRyaWNzQW5hbHl6ZXIuanMJKHJldmlzaW9uIDE3MzI2 MCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL01ldHJpY3NBbmFseXplci5qcwkod29ya2luZyBj b3B5KQpAQCAtMjMwLDcgKzIzMCw3IEBAIEFuYWx5emVyLnByb3RvdHlwZSA9IHsKICAgICAgICAg aXRlcmF0aW9uc0J5UmV2aXNpb24uc29ydChmdW5jdGlvbihhLCBiKSB7IHJldHVybiBhLmVuZFRp bWUgLSBiLmVuZFRpbWU7IH0pOyAvLyBXaGVuIHRoZXJlIGFyZSBtdWx0aXBsZSBpdGVyYXRpb25z IGJ1aWxkaW5nIHRoZSBzYW1lIHJldmlzaW9uLCB0aGUgZmlyc3Qgb25lIHdpbnMgKGFzIHRoZSBv dGhlciBvbmVzIHdlcmUgcHJvYmFibHkgbWFudWFsIHJldHJpZXMpLgogICAgICAgICBpdGVyYXRp b25zQnlSZXZpc2lvbi5zb3J0KGZ1bmN0aW9uKGEsIGIpIHsgcmV0dXJuIGEub3BlblNvdXJjZVJl dmlzaW9uIC0gYi5vcGVuU291cmNlUmV2aXNpb247IH0pOwogCi0gICAgICAgIC8vIFJldmlzaW9u cyB0aGF0IGxhbmRlZCB3aXRoaW4gdGhlIHBlcmlvZC4KKyAgICAgICAgLy8gUmV2aXNpb25zIHRo YXQgbGFuZGVkIHdpdGhpbiB0aGUgdGltZSByYW5nZS4KICAgICAgICAgdmFyIHJldmlzaW9ucyA9 IHdlYmtpdFRyYWMucmVjb3JkZWRDb21taXRzLnJlZHVjZShmdW5jdGlvbihyZXN1bHQsIHJldmlz aW9uKSB7CiAgICAgICAgICAgICBpZiAocmV2aXNpb24uZGF0ZSA+PSB0aGlzLl9yYW5nZVN0YXJ0 VGltZSAmJiByZXZpc2lvbi5kYXRlIDwgdGhpcy5fcmFuZ2VFbmRUaW1lKQogICAgICAgICAgICAg ICAgIHJlc3VsdFtyZXZpc2lvbi5yZXZpc2lvbk51bWJlcl0gPSByZXZpc2lvbjsKQEAgLTI2OSw4 ICsyNjksMTAgQEAgQW5hbHl6ZXIucHJvdG90eXBlID0gewogICAgICAgICB2YXIgb3duVGltZXMg PSBbXTsKICAgICAgICAgZm9yICh2YXIgcmV2aXNpb25OdW1iZXIgaW4gcmV2aXNpb25zKSB7CiAg ICAgICAgICAgICB2YXIgcmV2aXNpb24gPSByZXZpc2lvbnNbcmV2aXNpb25OdW1iZXJdOwotICAg ICAgICAgICAgaWYgKCEoImVsYXBzZWRUaW1lIiBpbiByZXZpc2lvbikpCisgICAgICAgICAgICBp ZiAoISgiZWxhcHNlZFRpbWUiIGluIHJldmlzaW9uKSkgeworICAgICAgICAgICAgICAgIC8vIEEg cmV2aXNpb24gdGhhdCBsYW5kZWQgd2l0aGluIHRoZSB0aW1lIHJhbmdlIGRpZG4ndCBuZWNlc3Nh cmlseSBnZXQgYWxsIHJlc3VsdHMgYnkgdGhlIHJhbmdlIGVuZC4KICAgICAgICAgICAgICAgICBj b250aW51ZTsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIC8vIENoYW5nZXMgb24gb3RoZXIg YnJhbmNoZXMgYXJlIGlycmVsZXZhbnQsIGFzIHRoZXkgYXJlIG5vdCBidWlsdCBvciB0ZXN0ZWQu CiAgICAgICAgICAgICAvLyBGSVhNRTogU3VwcG9ydCBtZXRyaWNzIGZvciBub24tdHJ1bmsgcXVl dWVzLgogICAgICAgICAgICAgaWYgKCFyZXZpc2lvbi5jb250YWluc0JyYW5jaExvY2F0aW9uIHx8 IHJldmlzaW9uLmJyYW5jaCA9PT0gInRydW5rIikgewo=