136552 2014-09-04 15:45:51 -0700 Fix FIXME's in JSTrackCustom now that AudioTrack and VideoTrack exist. 2014-09-11 08:04:00 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 b.long b.long commit-queue eric.carlson jer.noble pnormand oldest_to_newest 1033328 0 b.long 2014-09-04 15:45:51 -0700 Fix FIXME's in JSTrackCustom not that AudioTrack and VideoTrack exist. 1033329 1 237652 b.long 2014-09-04 15:47:18 -0700 Created attachment 237652 Patch 1033330 2 b.long 2014-09-04 15:48:08 -0700 I saw this FIXME while I was working on another patch. I'm not really sure how this code is used though. Is there some way I could test this? 1033474 3 eric.carlson 2014-09-05 09:52:56 -0700 (In reply to comment #2) > I saw this FIXME while I was working on another patch. I'm not really sure how this code is used though. Is there some way I could test this? I think toTrack() is only used by JSDictionary::convertValue() currently, and I believe that is only used when MediaStream is enabled so you can't test it at the moment. 1033475 4 eric.carlson 2014-09-05 09:58:58 -0700 (In reply to comment #3) > (In reply to comment #2) > > I saw this FIXME while I was working on another patch. I'm not really sure how this code is used though. Is there some way I could test this? > > I think toTrack() is only used by JSDictionary::convertValue() currently, and I believe that is only used when MediaStream is enabled so you can't test it at the moment. Scratch that, it can also be used for a TrackEvent. But I am still not sure how you would test it. 1034437 5 b.long 2014-09-10 15:32:32 -0700 Sorry, got distracted by some other stuff. Do you think we should apply this fix, or should we wait until we have some way to test it? 1034461 6 eric.carlson 2014-09-10 16:40:56 -0700 (In reply to comment #5) > Sorry, got distracted by some other stuff. Do you think we should apply this fix, or should we wait until we have some way to test it? Why don't you land it, the new code is obviously better than what we have now. 1034603 7 237652 commit-queue 2014-09-11 08:03:56 -0700 Comment on attachment 237652 Patch Clearing flags on attachment: 237652 Committed r173513: <http://trac.webkit.org/changeset/173513> 1034604 8 commit-queue 2014-09-11 08:04:00 -0700 All reviewed patches have been landed. Closing bug. 237652 2014-09-04 15:47:18 -0700 2014-09-11 08:03:55 -0700 Patch bug-136552-20140904174712.patch text/plain 1621 b.long U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODYyZTA0ZTRmOWFhOGVl MTlkYTAzNjg4YmRiMzhmNzk2MTdkZDY4MS4uYWE1NWQwODI3MWI4YWY4NTk5YTE4Y2Q3ZDFiNzBj YzQ2Mjc0MGQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA5LTA0ICBCcmVu ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBGaXggRklYTUUncyBp biBKU1RyYWNrQ3VzdG9tIG5vdyB0aGF0IEF1ZGlvVHJhY2sgYW5kIFZpZGVvVHJhY2sgZXhpc3Qu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY1NTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRp bmdzL2pzL0pTVHJhY2tDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6dG9UcmFjayk6IEFk ZCBjYXN0cyBmb3IgQXVkaW9UcmFjayBhbmQgVmlkZW9UcmFjay4KKwogMjAxNC0wOS0wMiAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBOb24tY29tcG9z aXRlZCBjaGlsZCBSZW5kZXJMYXllcnMgY2F1c2UgYWxsb2NhdGlvbiBvZiB1bm5jZXNzYXJ5IGJh Y2tpbmcgc3RvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTVHJh Y2tDdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNUcmFja0N1c3RvbS5j cHAKaW5kZXggMjgzNGI0MDk3ZjgwODZhZjE0YzU2OTZmOTc0NmIwY2M5MDM2NzRiZS4uOTc1MTQ2 NzI0ZGIwMjY5MDU0NDQ1ODlhZGQ5MmY0MWJiNDUzMDhjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNUcmFja0N1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNUcmFja0N1c3RvbS5jcHAKQEAgLTQ1LDkgKzQ1LDEwIEBAIFRyYWNrQmFz ZSogdG9UcmFjayhKU1ZhbHVlIHZhbHVlKQogICAgIEpTT2JqZWN0KiBvYmplY3QgPSBhc09iamVj dCh2YWx1ZSk7CiAgICAgaWYgKG9iamVjdC0+aW5oZXJpdHMoSlNUZXh0VHJhY2s6OmluZm8oKSkp CiAgICAgICAgIHJldHVybiAmanNDYXN0PEpTVGV4dFRyYWNrKj4ob2JqZWN0KS0+aW1wbCgpOwot ICAgIAotICAgIC8vIEZJWE1FOiBGaWxsIGluIGFkZGl0aW9uYWwgdGVzdHMgYW5kIGNhc3RzIGhl cmUgZm9yIFZpZGVvVHJhY2sgYW5kIEF1ZGlvVHJhY2sgd2hlbiAKLSAgICAvLyB0aGV5IGhhdmUg YmVlbiBhZGRlZCB0byBXZWJDb3JlLgorICAgIGlmIChvYmplY3QtPmluaGVyaXRzKEpTQXVkaW9U cmFjazo6aW5mbygpKSkKKyAgICAgICAgcmV0dXJuICZqc0Nhc3Q8SlNBdWRpb1RyYWNrKj4ob2Jq ZWN0KS0+aW1wbCgpOworICAgIGlmIChvYmplY3QtPmluaGVyaXRzKEpTVmlkZW9UcmFjazo6aW5m bygpKSkKKyAgICAgICAgcmV0dXJuICZqc0Nhc3Q8SlNWaWRlb1RyYWNrKj4ob2JqZWN0KS0+aW1w bCgpOwogCiAgICAgcmV0dXJuIDA7CiB9Cg==