136548 2014-09-04 14:38:56 -0700 Clicking on a select element should never hide the popup menu. 2014-09-04 16:40:02 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned bfulgham jonlee roger_fong sam simon.fraser thorton oldest_to_newest 1033311 0 roger_fong 2014-09-04 14:38:56 -0700 You can never click on a select element to close the popup associated popup menu. The popup menu is only closed by either clicking on the popup menu or by clicking elsewhere to no longer focus on the popup menu. This becomes an issue when you double click on a popup menu while you are not focused on the app containing the popup menu. The select element thinks there are two clicks back to back on the select element, which normally should never be able to happen. Details: This back to back click results in the popup menu being visible but also the popup menu proxy being invalidated. Note that the popup menu does not disappear, it remains visible (which is the desired behavior). This happens because at the time of the second click the popup menu has not been actually been created yet, so there's nothing to dismiss. As a result when we actually close the popup we do not set the visible flag to false because the PopupMenuProxy is invalidated. Then when we try to open up the popup again, nothing happens (no popup appears) because we think that the popup is already visible. The fix here is to make sure we do not try to invalidate the popup menu at the wrong time. In this case, the wrong time is when you're clicking on the select element itself. We should never attempt to hide the popup menu as a result of clicking on the select element. 1033315 1 237649 roger_fong 2014-09-04 14:49:48 -0700 Created attachment 237649 patch 1033345 2 237649 simon.fraser 2014-09-04 16:24:24 -0700 Comment on attachment 237649 patch Can we make a test for this? 1033350 3 roger_fong 2014-09-04 16:40:02 -0700 Committed: http://trac.webkit.org/changeset/173289 Discussed test with smfr in person and determined that it wasn't feasible since the test infrastructure doesn't allow tests that involves switching to and from more than one window. 237649 2014-09-04 14:49:48 -0700 2014-09-04 16:24:24 -0700 patch patch.patch text/plain 2298 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzI3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA5LTA0ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQ2xpY2tpbmcgb24gYSBzZWxl Y3QgZWxlbWVudCBzaG91bGQgbmV2ZXIgaGlkZSB0aGUgcG9wdXAgbWVudS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjU0OC4KKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzEwMjE1OTI2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6bWVudUxpc3REZWZhdWx0RXZlbnRIYW5kbGVyKToK KyAgICAgICAgTmV2ZXIgY2FsbCBoaWRlUG9wdXAgYXMgYSByZXN1bHQgb2YgYSBjbGljayBvbiBh IHNlbGVjdCBlbGVtZW50LgorICAgICAgICBUaGUgb25seSB3YXkgeW91IGNhbiBwcm9wZXJseSBo aWRlIGEgcG9wdXAgaXMgdG8gY2xpY2sgYWdhaW4gb3IgbG9zZSBmb2N1cyBvbiB0aGUgcG9wdXAg aXRzZWxmLgorCiAyMDE0LTA5LTA0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4K IAogICAgICAgICBSZW1vdmUgUmVzb3VyY2VSZXNwb25zZTo6bV9zdWdnZXN0ZWRGaWxlbmFtZQpJ bmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHAJKHJldmlzaW9u IDE3MzAwOCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMjYwLDE3ICsxMjYwLDE0IEBAIHZvaWQgSFRNTFNlbGVjdEVsZW1l bnQ6Om1lbnVMaXN0RGVmYXVsdEUKICNpZiAhUExBVEZPUk0oSU9TKQogICAgICAgICBpZiAocmVu ZGVyZXIoKSAmJiByZW5kZXJlcigpLT5pc01lbnVMaXN0KCkpIHsKICAgICAgICAgICAgIGF1dG8m IG1lbnVMaXN0ID0gdG9SZW5kZXJNZW51TGlzdCgqcmVuZGVyZXIoKSk7Ci0gICAgICAgICAgICBp ZiAobWVudUxpc3QucG9wdXBJc1Zpc2libGUoKSkKLSAgICAgICAgICAgICAgICBtZW51TGlzdC5o aWRlUG9wdXAoKTsKLSAgICAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgICAgIC8vIFNhdmUg dGhlIHNlbGVjdGlvbiBzbyBpdCBjYW4gYmUgY29tcGFyZWQgdG8gdGhlIG5ldwotICAgICAgICAg ICAgICAgIC8vIHNlbGVjdGlvbiB3aGVuIHdlIGNhbGwgb25DaGFuZ2UgZHVyaW5nIHNlbGVjdE9w dGlvbiwKLSAgICAgICAgICAgICAgICAvLyB3aGljaCBnZXRzIGNhbGxlZCBmcm9tIFJlbmRlck1l bnVMaXN0Ojp2YWx1ZUNoYW5nZWQsCi0gICAgICAgICAgICAgICAgLy8gd2hpY2ggZ2V0cyBjYWxs ZWQgYWZ0ZXIgdGhlIHVzZXIgbWFrZXMgYSBzZWxlY3Rpb24gZnJvbQotICAgICAgICAgICAgICAg IC8vIHRoZSBtZW51LgotICAgICAgICAgICAgICAgIHNhdmVMYXN0U2VsZWN0aW9uKCk7Ci0gICAg ICAgICAgICAgICAgICAgIG1lbnVMaXN0LnNob3dQb3B1cCgpOwotICAgICAgICAgICAgfQorICAg ICAgICAgICAgQVNTRVJUKCFtZW51TGlzdC5wb3B1cElzVmlzaWJsZSgpKTsKKyAgICAgICAgICAg IC8vIFNhdmUgdGhlIHNlbGVjdGlvbiBzbyBpdCBjYW4gYmUgY29tcGFyZWQgdG8gdGhlIG5ldwor ICAgICAgICAgICAgLy8gc2VsZWN0aW9uIHdoZW4gd2UgY2FsbCBvbkNoYW5nZSBkdXJpbmcgc2Vs ZWN0T3B0aW9uLAorICAgICAgICAgICAgLy8gd2hpY2ggZ2V0cyBjYWxsZWQgZnJvbSBSZW5kZXJN ZW51TGlzdDo6dmFsdWVDaGFuZ2VkLAorICAgICAgICAgICAgLy8gd2hpY2ggZ2V0cyBjYWxsZWQg YWZ0ZXIgdGhlIHVzZXIgbWFrZXMgYSBzZWxlY3Rpb24gZnJvbQorICAgICAgICAgICAgLy8gdGhl IG1lbnUuCisgICAgICAgICAgICBzYXZlTGFzdFNlbGVjdGlvbigpOworICAgICAgICAgICAgbWVu dUxpc3Quc2hvd1BvcHVwKCk7CiAgICAgICAgIH0KICNlbmRpZgogICAgICAgICBldmVudC0+c2V0 RGVmYXVsdEhhbmRsZWQoKTsK