136547 2014-09-04 14:38:05 -0700 Move PropertySlot's inline functions back to PropertySlot.h 2014-09-04 20:37:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1033309 0 mark.lam 2014-09-04 14:38:05 -0700 The inline implementations of PropertySlot::getValue() belongs in PropertySlot.h, not JSObject.h. 1033389 1 237669 mark.lam 2014-09-04 19:01:51 -0700 Created attachment 237669 the patch 1033404 2 237669 commit-queue 2014-09-04 20:37:05 -0700 Comment on attachment 237669 the patch Clearing flags on attachment: 237669 Committed r173307: <http://trac.webkit.org/changeset/173307> 1033405 3 commit-queue 2014-09-04 20:37:06 -0700 All reviewed patches have been landed. Closing bug. 237669 2014-09-04 19:01:51 -0700 2014-09-04 20:37:04 -0700 the patch bug-136547.patch text/plain 3185 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTczMjgxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA5LTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBN b3ZlIFByb3BlcnR5U2xvdCdzIGlubGluZSBmdW5jdGlvbnMgYmFjayB0byBQcm9wZXJ0eVNsb3Qu aC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzNjU0Nz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuaDoK KyAgICAgICAgKEpTQzo6UHJvcGVydHlTbG90OjpnZXRWYWx1ZSk6IERlbGV0ZWQuCisgICAgICAg ICogcnVudGltZS9Qcm9wZXJ0eVNsb3QuaDoKKyAgICAgICAgKEpTQzo6UHJvcGVydHlTbG90Ojpn ZXRWYWx1ZSk6CisKIDIwMTQtMDktMDMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4K IAogICAgICAgICBCZWVmIHVwIHRoZSBERkcncyBDRkcgYW5hbHlzZXMgdG8gaW5jbHVkZSBpdGVy YXRlZCBkb21pbmFuY2UgZnJvbnRpZXJzIGFuZCBtb3JlIHVzZXItZnJpZW5kbHkgQmxvY2tTZXRz CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgJKHJldmlzaW9u IDE3MzI2OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmgJKHdv cmtpbmcgY29weSkKQEAgLTE1NzksMjQgKzE1NzksNiBAQCBBTFdBWVNfSU5MSU5FIElkZW50aWZp ZXIgbWFrZUlkZW50aWZpZXIoCiAjZGVmaW5lIEpTQ19OQVRJVkVfRlVOQ1RJT04oanNOYW1lLCBj cHBOYW1lLCBhdHRyaWJ1dGVzLCBsZW5ndGgpIFwKICAgICBKU0NfTkFUSVZFX0lOVFJJTlNJQ19G VU5DVElPTihqc05hbWUsIGNwcE5hbWUsIChhdHRyaWJ1dGVzKSwgKGxlbmd0aCksIE5vSW50cmlu c2ljKQogCi1BTFdBWVNfSU5MSU5FIEpTVmFsdWUgUHJvcGVydHlTbG90OjpnZXRWYWx1ZShFeGVj U3RhdGUqIGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hbWUpIGNvbnN0Ci17Ci0gICAgaWYg KG1fcHJvcGVydHlUeXBlID09IFR5cGVWYWx1ZSkKLSAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmRl Y29kZShtX2RhdGEudmFsdWUpOwotICAgIGlmIChtX3Byb3BlcnR5VHlwZSA9PSBUeXBlR2V0dGVy KQotICAgICAgICByZXR1cm4gZnVuY3Rpb25HZXR0ZXIoZXhlYyk7Ci0gICAgcmV0dXJuIEpTVmFs dWU6OmRlY29kZShtX2RhdGEuY3VzdG9tLmdldFZhbHVlKGV4ZWMsIHNsb3RCYXNlKCksIEpTVmFs dWU6OmVuY29kZShtX3RoaXNWYWx1ZSksIHByb3BlcnR5TmFtZSkpOwotfQotCi1BTFdBWVNfSU5M SU5FIEpTVmFsdWUgUHJvcGVydHlTbG90OjpnZXRWYWx1ZShFeGVjU3RhdGUqIGV4ZWMsIHVuc2ln bmVkIHByb3BlcnR5TmFtZSkgY29uc3QKLXsKLSAgICBpZiAobV9wcm9wZXJ0eVR5cGUgPT0gVHlw ZVZhbHVlKQotICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZGVjb2RlKG1fZGF0YS52YWx1ZSk7Ci0g ICAgaWYgKG1fcHJvcGVydHlUeXBlID09IFR5cGVHZXR0ZXIpCi0gICAgICAgIHJldHVybiBmdW5j dGlvbkdldHRlcihleGVjKTsKLSAgICByZXR1cm4gSlNWYWx1ZTo6ZGVjb2RlKG1fZGF0YS5jdXN0 b20uZ2V0VmFsdWUoZXhlYywgc2xvdEJhc2UoKSwgSlNWYWx1ZTo6ZW5jb2RlKG1fdGhpc1ZhbHVl KSwgSWRlbnRpZmllcjo6ZnJvbShleGVjLCBwcm9wZXJ0eU5hbWUpKSk7Ci19Ci0KIH0gLy8gbmFt ZXNwYWNlIEpTQwogCiAjZW5kaWYgLy8gSlNPYmplY3RfaApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvUHJvcGVydHlTbG90LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvUHJvcGVydHlTbG90LmgJKHJldmlzaW9uIDE3MzI2OSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Byb3BlcnR5U2xvdC5oCSh3b3JraW5nIGNvcHkp CkBAIC0yNDYsNiArMjQ2LDI0IEBAIHByaXZhdGU6CiAgICAgQ2FjaGVhYmlsaXR5VHlwZSBtX2Nh Y2hlYWJpbGl0eTsKIH07CiAKK0FMV0FZU19JTkxJTkUgSlNWYWx1ZSBQcm9wZXJ0eVNsb3Q6Omdl dFZhbHVlKEV4ZWNTdGF0ZSogZXhlYywgUHJvcGVydHlOYW1lIHByb3BlcnR5TmFtZSkgY29uc3QK K3sKKyAgICBpZiAobV9wcm9wZXJ0eVR5cGUgPT0gVHlwZVZhbHVlKQorICAgICAgICByZXR1cm4g SlNWYWx1ZTo6ZGVjb2RlKG1fZGF0YS52YWx1ZSk7CisgICAgaWYgKG1fcHJvcGVydHlUeXBlID09 IFR5cGVHZXR0ZXIpCisgICAgICAgIHJldHVybiBmdW5jdGlvbkdldHRlcihleGVjKTsKKyAgICBy ZXR1cm4gSlNWYWx1ZTo6ZGVjb2RlKG1fZGF0YS5jdXN0b20uZ2V0VmFsdWUoZXhlYywgc2xvdEJh c2UoKSwgSlNWYWx1ZTo6ZW5jb2RlKG1fdGhpc1ZhbHVlKSwgcHJvcGVydHlOYW1lKSk7Cit9CisK K0FMV0FZU19JTkxJTkUgSlNWYWx1ZSBQcm9wZXJ0eVNsb3Q6OmdldFZhbHVlKEV4ZWNTdGF0ZSog ZXhlYywgdW5zaWduZWQgcHJvcGVydHlOYW1lKSBjb25zdAoreworICAgIGlmIChtX3Byb3BlcnR5 VHlwZSA9PSBUeXBlVmFsdWUpCisgICAgICAgIHJldHVybiBKU1ZhbHVlOjpkZWNvZGUobV9kYXRh LnZhbHVlKTsKKyAgICBpZiAobV9wcm9wZXJ0eVR5cGUgPT0gVHlwZUdldHRlcikKKyAgICAgICAg cmV0dXJuIGZ1bmN0aW9uR2V0dGVyKGV4ZWMpOworICAgIHJldHVybiBKU1ZhbHVlOjpkZWNvZGUo bV9kYXRhLmN1c3RvbS5nZXRWYWx1ZShleGVjLCBzbG90QmFzZSgpLCBKU1ZhbHVlOjplbmNvZGUo bV90aGlzVmFsdWUpLCBJZGVudGlmaWVyOjpmcm9tKGV4ZWMsIHByb3BlcnR5TmFtZSkpKTsKK30K KwogfSAvLyBuYW1lc3BhY2UgSlNDCiAKICNlbmRpZiAvLyBQcm9wZXJ0eVNsb3RfaAo=