13654 2007-05-10 04:37:03 -0700 REGRESSION: Fieldset stretches too much because minwidth is wrong. 2007-05-10 05:30:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar P1 Normal --- 1 hyatt hyatt oldest_to_newest 10564 0 hyatt 2007-05-10 04:37:03 -0700 In the attached test case, the fieldset has a minwidth that is bigger than other browsers. Clear whitespace breaking opportunities exist, and yet they are somehow not being factored into the minwidth. This is a regression caused by http://bugs.webkit.org/show_bug.cgi?id=8438 although I think it just exposed a min width bug. 10565 1 14457 hyatt 2007-05-10 04:37:52 -0700 Created attachment 14457 Reduction Reduction. 10566 2 hyatt 2007-05-10 04:38:30 -0700 <rdar://problem/5146757> 10575 3 14459 hyatt 2007-05-10 05:08:28 -0700 Created attachment 14459 This fixes it. Any text run that gets thoroughly ignored but that contains only stripped out whitespace will have beginWS and endWS set to true. Combine that with autoWrap and you know when a break opportunity exists. 10577 4 14460 hyatt 2007-05-10 05:20:43 -0700 Created attachment 14460 Better patch. After conversation with mitz on IRC, new patch. 10578 5 14460 mitz 2007-05-10 05:22:01 -0700 Comment on attachment 14460 Better patch. r=me. fix indentation of the first 'if'! 10581 6 hyatt 2007-05-10 05:30:19 -0700 Fixed in r21365. 14457 2007-05-10 04:37:52 -0700 2007-05-10 04:37:52 -0700 Reduction fieldset-width.html text/html 1509 hyatt PGhlYWQ+CjxzdHlsZT4KI21hcHMgZGl2IHsgZGlzcGxheTogaW5saW5lOyB3aGl0ZS1zcGFjZTog bm9ybWFsIH0KI21hcHMgZGl2IGRpdiB7IHdoaXRlLXNwYWNlOiBub3dyYXAgfQo8L3N0eWxlPgo8 L2hlYWQ+Cjxib2R5Pgo8ZmllbGRzZXQgaWQ9ImFsZXJ0bWUiPgo8ZGl2IGlkPSJtYXBzIj4KPGRp dj48ZGl2Pgo8YSBocmVmPSJtYXBzL0NsYXNzaWMuUy5qcGciIHJlbD0ibGlnaHRib3giIHRpdGxl PSJDbGFzc2ljIE1hcCI+PGltZyBzcmM9Im1hcHMvQ2xhc3NpYy50aHVtYi5wbmciIHdpZHRoPSI1 MCIgaGVpZ2h0PSIzNCIgYWx0PSJDbGFzc2ljIiB0aXRsZT0iQ2xhc3NpYyIgLz48L2E+CjxpbnB1 dCB0eXBlPSJjaGVja2JveCIgbmFtZT0ibWFwW10iIGlkPSJtYXBfQ2xhc3NpYyIgdmFsdWU9IkNs YXNzaWMiICAvPjxsYWJlbCBmb3I9Im1hcF9DbGFzc2ljIj5DbGFzc2ljPC9sYWJlbD4KPC9kaXY+ PC9kaXY+CjxkaXY+PGRpdj4KPGEgaHJlZj0ibWFwcy9BZnJpY2EuUy5qcGciIHJlbD0ibGlnaHRi b3giIHRpdGxlPSJBZnJpY2EgTWFwIj48aW1nIHNyYz0ibWFwcy9BZnJpY2EudGh1bWIucG5nIiB3 aWR0aD0iNTAiIGhlaWdodD0iMzQiIGFsdD0iQWZyaWNhIiB0aXRsZT0iQWZyaWNhIiAvPjwvYT4K PGlucHV0IHR5cGU9ImNoZWNrYm94IiBuYW1lPSJtYXBbXSIgaWQ9Im1hcF9BZnJpY2EiIHZhbHVl PSJBZnJpY2EiICAvPjxsYWJlbCBmb3I9Im1hcF9BZnJpY2EiPkFmcmljYTwvbGFiZWw+CjwvZGl2 PjwvZGl2Pgo8ZGl2PjxkaXY+CjxhIGhyZWY9Im1hcHMvQWxleGFuZGVyc19FbXBpcmUuUy5qcGci IHJlbD0ibGlnaHRib3giIHRpdGxlPSJBbGV4YW5kZXIncyBFbXBpcmUgTWFwIj48aW1nIHNyYz0i bWFwcy9BbGV4YW5kZXJzX0VtcGlyZS50aHVtYi5wbmciIHdpZHRoPSI1MCIgaGVpZ2h0PSIzNCIg YWx0PSJBbGV4YW5kZXIncyBFbXBpcmUiIHRpdGxlPSJBbGV4YW5kZXIncyBFbXBpcmUiIC8+PC9h Pgo8aW5wdXQgdHlwZT0iY2hlY2tib3giIG5hbWU9Im1hcFtdIiBpZD0ibWFwX0FsZXhhbmRlcnNf RW1waXJlIiB2YWx1ZT0iQWxleGFuZGVyJ3MgRW1waXJlIiAgLz48bGFiZWwgZm9yPSJtYXBfQWxl eGFuZGVyc19FbXBpcmUiPkFsZXhhbmRlcidzIEVtcGlyZTwvbGFiZWw+CjwvZGl2PjwvZGl2Pgo8 ZGl2PjxkaXY+CjxhIGhyZWY9Im1hcHMvQW5jaWVudF9HcmVlY2UuUy5qcGciIHJlbD0ibGlnaHRi b3giIHRpdGxlPSJBbmNpZW50IEdyZWVjZSBNYXAiPjxpbWcgc3JjPSJtYXBzL0FuY2llbnRfR3Jl ZWNlLnRodW1iLnBuZyIgd2lkdGg9IjUwIiBoZWlnaHQ9IjM0IiBhbHQ9IkFuY2llbnQgR3JlZWNl IiB0aXRsZT0iQW5jaWVudCBHcmVlY2UiIC8+PC9hPgo8aW5wdXQgdHlwZT0iY2hlY2tib3giIG5h bWU9Im1hcFtdIiBpZD0ibWFwX0FuY2llbnRfR3JlZWNlIiB2YWx1ZT0iQW5jaWVudCBHcmVlY2Ui ICAvPjxsYWJlbCBmb3I9Im1hcF9BbmNpZW50X0dyZWVjZSI+QW5jaWVudCBHcmVlY2U8L2xhYmVs Pgo8L2Rpdj48L2Rpdj4KPC9maWVsZHNldD4K 14459 2007-05-10 05:08:28 -0700 2007-05-10 05:20:43 -0700 This fixes it. patch.txt text/plain 1068 hyatt SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5n L1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gMjEzNjMpCisrKyByZW5kZXJpbmcvUmVuZGVyQmxv Y2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjMyLDkgKzM2MzIsMTQgQEAKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBoYXNCcmVha2FibGVDaGFyLCBoYXNCcmVhaywgYmVn aW5NYXgsIGVuZE1heCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGls ZE1pbiwgY2hpbGRNYXgsIHN0cmlwRnJvbnRTcGFjZXMpOwogCi0gICAgICAgICAgICAgICAgLy8g VGhpcyB0ZXh0IG9iamVjdCBpcyBpbnNpZ25pZmljYW50IGFuZCB3aWxsIG5vdCBiZSByZW5kZXJl ZC4gIEp1c3QKLSAgICAgICAgICAgICAgICAvLyBjb250aW51ZS4KLSAgICAgICAgICAgICAgICBp ZiAoIWhhc0JyZWFrICYmIGNoaWxkTWF4ID09IDApIGNvbnRpbnVlOworICAgICAgICAgICAgICAg IC8vIFRoaXMgdGV4dCBvYmplY3Qgd2lsbCBub3QgYmUgcmVuZGVyZWQsIGJ1dCBpdCBtYXkgc3Rp bGwgcHJvdmlkZSBhIGJyZWFraW5nIG9wcG9ydHVuaXR5LgorICAgICAgICAgICAgICAgICBpZiAo IWhhc0JyZWFrICYmIGNoaWxkTWF4ID09IDApIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGF1 dG9XcmFwICYmIGJlZ2luV1MgJiYgZW5kV1MpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIG1f bWluUHJlZldpZHRoID0gbWF4KGlubGluZU1pbiwgbV9taW5QcmVmV2lkdGgpOworICAgICAgICAg ICAgICAgICAgICAgICAgaW5saW5lTWluID0gMDsKKyAgICAgICAgICAgICAgICAgICAgICAgIGNv bnRpbnVlOworICAgICAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgfQogICAgICAg ICAgICAgICAgIAogICAgICAgICAgICAgICAgIGlmIChzdHJpcEZyb250U3BhY2VzKQogICAgICAg ICAgICAgICAgICAgICB0cmFpbGluZ1NwYWNlQ2hpbGQgPSBjaGlsZDsK 14460 2007-05-10 05:20:43 -0700 2007-05-10 05:22:01 -0700 Better patch. patch.txt text/plain 1066 hyatt SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5n L1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gMjEzNjMpCisrKyByZW5kZXJpbmcvUmVuZGVyQmxv Y2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjMyLDkgKzM2MzIsMTQgQEAKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBoYXNCcmVha2FibGVDaGFyLCBoYXNCcmVhaywgYmVn aW5NYXgsIGVuZE1heCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjaGls ZE1pbiwgY2hpbGRNYXgsIHN0cmlwRnJvbnRTcGFjZXMpOwogCi0gICAgICAgICAgICAgICAgLy8g VGhpcyB0ZXh0IG9iamVjdCBpcyBpbnNpZ25pZmljYW50IGFuZCB3aWxsIG5vdCBiZSByZW5kZXJl ZC4gIEp1c3QKLSAgICAgICAgICAgICAgICAvLyBjb250aW51ZS4KLSAgICAgICAgICAgICAgICBp ZiAoIWhhc0JyZWFrICYmIGNoaWxkTWF4ID09IDApIGNvbnRpbnVlOworICAgICAgICAgICAgICAg IC8vIFRoaXMgdGV4dCBvYmplY3Qgd2lsbCBub3QgYmUgcmVuZGVyZWQsIGJ1dCBpdCBtYXkgc3Rp bGwgcHJvdmlkZSBhIGJyZWFraW5nIG9wcG9ydHVuaXR5LgorICAgICAgICAgICAgICAgICBpZiAo IWhhc0JyZWFrICYmIGNoaWxkTWF4ID09IDApIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGF1 dG9XcmFwICYmIChiZWdpbldTIHx8IGVuZFdTKSkgeworICAgICAgICAgICAgICAgICAgICAgICAg bV9taW5QcmVmV2lkdGggPSBtYXgoaW5saW5lTWluLCBtX21pblByZWZXaWR0aCk7CisgICAgICAg ICAgICAgICAgICAgICAgICBpbmxpbmVNaW4gPSAwOworICAgICAgICAgICAgICAgICAgICB9Cisg ICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgICAgICAKICAgICAgICAgICAgICAgICBpZiAoc3RyaXBGcm9udFNwYWNlcykKICAgICAgICAg ICAgICAgICAgICAgdHJhaWxpbmdTcGFjZUNoaWxkID0gY2hpbGQ7Cg==