136539 2014-09-04 11:54:12 -0700 REGRESSION: Dashboard metrics page aggregation counts performance bots 2014-09-04 13:01:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue dburkart thorton oldest_to_newest 1033264 0 ap 2014-09-04 11:54:12 -0700 The dashboard metrics page doesn't show performance bots on the grid, so it's unexpected that their results are taken into account at all. Furthermore, waiting for performance bots to cycle is not generally considered as part of due diligence after landing a patch, so performance bots should not be included in the elapsed time anyway. It's arguable whether they should be included in red/green time. 1033266 1 237637 ap 2014-09-04 11:56:47 -0700 Created attachment 237637 proposed fix 1033285 2 237637 commit-queue 2014-09-04 13:01:49 -0700 Comment on attachment 237637 proposed fix Clearing flags on attachment: 237637 Committed r173273: <http://trac.webkit.org/changeset/173273> 1033286 3 commit-queue 2014-09-04 13:01:51 -0700 All reviewed patches have been landed. Closing bug. 237637 2014-09-04 11:56:47 -0700 2014-09-04 13:01:48 -0700 proposed fix PerfVsMetrics.txt text/plain 1505 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzI2OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE0LTA5LTA0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT046IERhc2hib2FyZCBtZXRyaWNzIHBhZ2UgYWdncmVnYXRp b24gY291bnRzIHBlcmZvcm1hbmNlIGJvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzNjUzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvTWV0cmljc01haW4uanM6CisKIDIw MTQtMDktMDQgIEV2YSBCYWxhenNmYWx2aSAgPGV2YWIudS1zemVnZWRAcGFydG5lci5zYW1zdW5n LmNvbT4KIAogICAgICAgICBSZW1vdmUgQ1NTX0ZJTFRFUlMgZmxhZwpJbmRleDogVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJv YXJkL1NjcmlwdHMvTWV0cmljc01haW4uanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Nj cmlwdHMvTWV0cmljc01haW4uanMJKHJldmlzaW9uIDE3MzI1OSkKKysrIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9T Y3JpcHRzL01ldHJpY3NNYWluLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0zMjcsNyArMzI3LDEwIEBA IGZ1bmN0aW9uIGRvY3VtZW50UmVhZHkoKQogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAg IHZhciBlbmREYXRlID0gbmV3IERhdGUobmV3IERhdGUob2JqLmRhdGUyKS5zZXREYXRlKG9iai5k YXRlMi5nZXREYXRlKCkgKyAxKSk7Ci0gICAgICAgIGFuYWx5emVyLmFuYWx5emUodW5oaWRkZW5R dWV1ZXMoKSwgb2JqLmRhdGUxLCBlbmREYXRlKTsKKworICAgICAgICAvLyBGSVhNRTogU3VwcG9y dCBwZXJmb3JtYW5jZSBib3RzLgorICAgICAgICB2YXIgcXVldWVzID0gdW5oaWRkZW5RdWV1ZXMo KS5maWx0ZXIoZnVuY3Rpb24ocXVldWUpIHsgcmV0dXJuIHF1ZXVlLmJ1aWxkZXIgfHwgcXVldWUu dGVzdGVyOyB9KTsKKyAgICAgICAgYW5hbHl6ZXIuYW5hbHl6ZShxdWV1ZXMsIG9iai5kYXRlMSwg ZW5kRGF0ZSk7CiAgICAgfSk7CiAKICAgICB2YXIgbG9hZGluZ0luZGljYXRvciA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwo=