136535 2014-09-04 10:44:16 -0700 Allow pages with unload handlers in the page cache 2014-09-05 15:11:29 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson commit-queue oldest_to_newest 1033235 0 beidson 2014-09-04 10:44:16 -0700 Allow pages with unload handlers in the page cache. It's 2014. unload events served their purpose a decade ago, but we've had pagehide for years to overcome unload's shortcomings. Let's stop letting the mere existence of an unload handler kill an import performance enhancement, and willfully break unload semantics instead. <rdar://problem/11084669> 1033306 1 237647 beidson 2014-09-04 14:24:12 -0700 Created attachment 237647 Patch v1 Ran tests locally, but not confident in my findings - This is for EWS 1033548 2 beidson 2014-09-05 14:30:22 -0700 This should be fine, let's review it and land it. 1033561 3 237647 commit-queue 2014-09-05 15:11:27 -0700 Comment on attachment 237647 Patch v1 Clearing flags on attachment: 237647 Committed r173336: <http://trac.webkit.org/changeset/173336> 1033562 4 commit-queue 2014-09-05 15:11:29 -0700 All reviewed patches have been landed. Closing bug. 237647 2014-09-04 14:24:12 -0700 2014-09-05 15:11:26 -0700 Patch v1 patch text/plain 4707 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3NjQwMWMyLi5lZWI1MWZlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDkt MDQgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IHBh Z2VzIHdpdGggdW5sb2FkIGhhbmRsZXJzIGluIHRoZSBwYWdlIGNhY2hlCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8xMTA4NDY2OT4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzY1MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGZhc3QvZnJhbWVzL2ZyYW1lLWNyYXNoLXdpdGgtcGFnZS1jYWNoZS1leHBlY3Rl ZC50eHQ6CisgICAgICAgICogZmFzdC9mcmFtZXMvcmVzb3VyY2VzL2NhY2hlZC1wYWdlLTEuaHRt bDoKKwogMjAxNC0wOS0wNCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTiAocjE3MjgzMik6IFBvb3IgMi1maW5nZXIgc2Nyb2xsaW5nIHBlcmZvcm1h bmNlIGF0IHRoZXZlcmdlLmNvbSBhcnRpY2xlcyAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZnJhbWVzL2ZyYW1lLWNyYXNoLXdpdGgtcGFnZS1jYWNoZS1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L2ZyYW1lcy9mcmFtZS1jcmFzaC13aXRoLXBhZ2UtY2FjaGUtZXhwZWN0ZWQu dHh0CmluZGV4IDZkY2RkMjIuLmIyMTBhNTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv ZnJhbWVzL2ZyYW1lLWNyYXNoLXdpdGgtcGFnZS1jYWNoZS1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9mcmFtZXMvZnJhbWUtY3Jhc2gtd2l0aC1wYWdlLWNhY2hlLWV4cGVjdGVk LnR4dApAQCAtMSw5ICsxLDYgQEAKLW1haW4gZnJhbWUgLSBoYXMgMSBvbnVubG9hZCBoYW5kbGVy KHMpCi1tYWluIGZyYW1lIC0gaGFzIDEgb251bmxvYWQgaGFuZGxlcihzKQogSWYgV2ViS2l0IGRv ZXMgbm90IGFzc2VydCBvciBjcmFzaCwgeW91IHBhc3NlZC4KIG9wZW4gcGFnZS0xCiBwYWdlLTEs IGFib3V0IHRvIG5hdmlnYXRlIHRvIHBhZ2UtMi4KLXBhZ2UtMSBydW5uaW5nIHVubG9hZCBoYW5k bGVyCiBwYWdlLTIsIGFib3V0IHRvIG5hdmlnYXRlIHRvIHBhZ2UtMy4KIE9uIHBhZ2UtMywgZ29p bmcgYmFjaywgbm93LgogQmFjayBvbiBwYWdlLTIsIHRpbWVyIGlzIHN0aWxsIGZpcmluZy4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL3Jlc291cmNlcy9jYWNoZWQtcGFnZS0x Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9yZXNvdXJjZXMvY2FjaGVkLXBhZ2UtMS5o dG1sCmluZGV4IGZmYjBjZDMuLjkyZTlkMDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv ZnJhbWVzL3Jlc291cmNlcy9jYWNoZWQtcGFnZS0xLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9mcmFtZXMvcmVzb3VyY2VzL2NhY2hlZC1wYWdlLTEuaHRtbApAQCAtMTcsMTMgKzE3LDggQEAg ZnVuY3Rpb24gbG9hZE5leHQoKSB7CiAgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHtsb2NhdGlv bi5ocmVmID0gImNhY2hlZC1wYWdlLTIuaHRtbCI7fSwgMCk7CiB9CiAKLS8vIFRoaXMgdW5sb2Fk IGhhbmRsZXIgZXhpc3RzIGp1c3QgdG8gbWFrZSBzdXJlIHRoaXMgcGFnZSBpcyBub3QgYWRkZWQK LS8vIHRvIHRoZSBwYWdlIGNhY2hlIQotZnVuY3Rpb24gbXlVbmxvYWQoKSB7Ci0gICAgd2luZG93 Lm9wZW5lci5sb2coInBhZ2UtMSBydW5uaW5nIHVubG9hZCBoYW5kbGVyIik7Ci19CiA8L3Njcmlw dD4KIDwvaGVhZD4KLTxib2R5IG9ubG9hZD0ibG9hZE5leHQoKSIgb251bmxvYWQ9Im15VW5sb2Fk KCkiPgorPGJvZHkgb25wYWdlc2hvdz0ibG9hZE5leHQoKSI+CiA8L2JvZHk+CiA8L2h0bWw+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggZjg3ZTA4NS4uYzZmNGExNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTA5LTA0ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAg ICBBbGxvdyBwYWdlcyB3aXRoIHVubG9hZCBoYW5kbGVycyBpbiB0aGUgcGFnZSBjYWNoZQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTEwODQ2Njk+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyB3aWxsIG1hdGNoIHdoYXQgaU9TIGhhcyBiZWVuIGRvaW5n IGZvciBzb21lIHRpbWUuCisKKyAgICAgICAgVXBkYXRlZCB0ZXN0cyBmb3IgbmV3IGJlaGF2aW9y LgorCisgICAgICAgICogaGlzdG9yeS9QYWdlQ2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 bG9nQ2FuQ2FjaGVGcmFtZURlY2lzaW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VDYWNoZTo6 Y2FuQ2FjaGVQYWdlQ29udGFpbmluZ1RoaXNGcmFtZSk6CisKIDIwMTQtMDktMDQgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFRyeSB0byBmaXggaU9TIGJ1aWxk LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCmluZGV4IDA4MzVmYTguLjRkZjNiODIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2hpc3RvcnkvUGFnZUNhY2hlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAKQEAgLTc1LDcgKzc1LDYgQEAgZW51 bSBSZWFzb25GcmFtZUNhbm5vdEJlSW5QYWdlQ2FjaGUgewogICAgIElzRXJyb3JQYWdlLAogICAg IEhhc1BsdWdpbnMsCiAgICAgSXNIdHRwc0FuZENhY2hlQ29udHJvbGxlZCwKLSAgICBIYXNVbmxv YWRMaXN0ZW5lciwKICAgICBIYXNEYXRhYmFzZUhhbmRsZXMsCiAgICAgSGFzU2hhcmVkV29ya2Vy cywKICAgICBOb0hpc3RvcnlJdGVtLApAQCAtMTMwLDE1ICsxMjksNiBAQCBzdGF0aWMgdW5zaWdu ZWQgbG9nQ2FuQ2FjaGVGcmFtZURlY2lzaW9uKEZyYW1lKiBmcmFtZSwgaW50IGluZGVudExldmVs KQogICAgICAgICBQQ0xPRygiICAgLUZyYW1lIGlzIEhUVFBTLCBhbmQgY2FjaGUgY29udHJvbCBw cm9oaWJpdHMgY2FjaGluZyBvciBzdG9yaW5nIik7CiAgICAgICAgIHJlamVjdFJlYXNvbnMgfD0g MSA8PCBJc0h0dHBzQW5kQ2FjaGVDb250cm9sbGVkOwogICAgIH0KLSAgICBpZiAoZnJhbWUtPmRv Y3VtZW50KCktPmRvbVdpbmRvdygpICYmIGZyYW1lLT5kb2N1bWVudCgpLT5kb21XaW5kb3coKS0+ aGFzRXZlbnRMaXN0ZW5lcnMoZXZlbnROYW1lcygpLnVubG9hZEV2ZW50KSkgewotICAgICAgICBQ Q0xPRygiICAgLUZyYW1lIGhhcyBhbiB1bmxvYWQgZXZlbnQgbGlzdGVuZXIiKTsKLSNpZiAhUExB VEZPUk0oSU9TKQotICAgICAgICByZWplY3RSZWFzb25zIHw9IDEgPDwgSGFzVW5sb2FkTGlzdGVu ZXI7Ci0jZWxzZQotICAgICAgICAvLyBpT1MgYWxsb3dzIHBhZ2VzIHdpdGggdW5sb2FkIGV2ZW50 IGxpc3RlbmVycyB0byBlbnRlciB0aGUgcGFnZSBjYWNoZS4KLSAgICAgICAgUENMT0coIiAgICAt QlVUIGlPUyBhbGxvd3MgdGhlc2UgcGFnZXMgdG8gYmUgY2FjaGVkLiIpOwotI2VuZGlmCi0gICAg fQogI2lmIEVOQUJMRShTUUxfREFUQUJBU0UpCiAgICAgaWYgKERhdGFiYXNlTWFuYWdlcjo6bWFu YWdlcigpLmhhc09wZW5EYXRhYmFzZXMoZnJhbWUtPmRvY3VtZW50KCkpKSB7CiAgICAgICAgIFBD TE9HKCIgICAtRnJhbWUgaGFzIG9wZW4gZGF0YWJhc2UgaGFuZGxlcyIpOwpAQCAtMjk2LDkgKzI4 Niw2IEBAIGJvb2wgUGFnZUNhY2hlOjpjYW5DYWNoZVBhZ2VDb250YWluaW5nVGhpc0ZyYW1lKEZy YW1lKiBmcmFtZSkKICAgICAgICAgJiYgIShkb2N1bWVudExvYWRlci0+c3Vic3RpdHV0ZURhdGEo KS5pc1ZhbGlkKCkgJiYgIWRvY3VtZW50TG9hZGVyLT5zdWJzdGl0dXRlRGF0YSgpLmZhaWxpbmdV UkwoKS5pc0VtcHR5KCkpCiAgICAgICAgICYmICghZnJhbWVMb2FkZXIuc3ViZnJhbWVMb2FkZXIo KS5jb250YWluc1BsdWdpbnMoKSB8fCBmcmFtZS0+cGFnZSgpLT5zZXR0aW5ncygpLnBhZ2VDYWNo ZVN1cHBvcnRzUGx1Z2lucygpKQogICAgICAgICAmJiAoIWRvY3VtZW50LT51cmwoKS5wcm90b2Nv bElzKCJodHRwcyIpIHx8ICghZG9jdW1lbnRMb2FkZXItPnJlc3BvbnNlKCkuY2FjaGVDb250cm9s Q29udGFpbnNOb0NhY2hlKCkgJiYgIWRvY3VtZW50TG9hZGVyLT5yZXNwb25zZSgpLmNhY2hlQ29u dHJvbENvbnRhaW5zTm9TdG9yZSgpKSkKLSNpZiAhUExBVEZPUk0oSU9TKQotICAgICAgICAmJiAo IWRvY3VtZW50LT5kb21XaW5kb3coKSB8fCAhZG9jdW1lbnQtPmRvbVdpbmRvdygpLT5oYXNFdmVu dExpc3RlbmVycyhldmVudE5hbWVzKCkudW5sb2FkRXZlbnQpKQotI2VuZGlmCiAjaWYgRU5BQkxF KFNRTF9EQVRBQkFTRSkKICAgICAgICAgJiYgIURhdGFiYXNlTWFuYWdlcjo6bWFuYWdlcigpLmhh c09wZW5EYXRhYmFzZXMoZG9jdW1lbnQpCiAjZW5kaWYK