136522 2014-09-03 21:11:51 -0700 [iOS WK2] Skip the animated resize if the view was empty 2014-10-24 12:19:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 137988 P2 Normal --- 1 benjamin benjamin ddkilzer oldest_to_newest 1033128 0 benjamin 2014-09-03 21:11:51 -0700 [iOS WK2] Skip the animated resize if the view was empty 1033130 1 237610 benjamin 2014-09-03 21:18:53 -0700 Created attachment 237610 Patch 1033700 2 237610 darin 2014-09-06 17:05:20 -0700 Comment on attachment 237610 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237610&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2203 > + ASSERT_WITH_MESSAGE(!newMinimumLayoutSize.isEmpty(), "Defining an empty minimum layout size would be a misuse of the API. Safari should set up a reasonable size in all cases."); I’m not sure this is a sensible comment. Safari isn’t the only WebKit client app. 1044021 3 ddkilzer 2014-10-24 12:19:12 -0700 *** This bug has been marked as a duplicate of bug 137988 *** 237610 2014-09-03 21:18:53 -0700 2014-09-06 17:05:20 -0700 Patch bug-136522-20140903211740.patch text/plain 3674 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTUxYTM2OWYyNTdkY2Uw NmFjOTE5ZTk2OWQ0OWZiNGFhM2I1MWYxZi4uYTYxMzMwNWQzOTVjYTg3NzhiOWNjZDI0ODliNDZj OWYxMDQ0NGE1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA5LTAzICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBT a2lwIHRoZSBhbmltYXRlZCByZXNpemUgaWYgdGhlIHZpZXcgd2FzIGVtcHR5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY1MjIKKyAgICAgICAgcmRh cjovL3Byb2JsZW0vMTc3ODUxNjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGlzIGlzIGEgcG90ZW50aWFsIGZpeCBmb3IgcmRhcjovL3Byb2JsZW0v MTc3ODUxNjIuIEl0IGlzIG5vdCBjbGVhciB3aHkgdGhlIGJ1ZyBoYXBwZW4sCisgICAgICAgIHRo ZSBoeXBvdGhlc2lzIGhlcmUgaXMgdGhhdCB0aGUgV0tXZWJWaWV3IGlzIG9mIG51bGwgc2l6ZSB3 aGVuIHN0YXJ0aW5nIHRoZSBhbmltYXRlZCByZXNpemUuCisKKyAgICAgICAgSWYgdGhlIFdLV2Vi VmlldyBvciBpdHMgV0tDb250ZW50VmlldyBpcyBlbXB0eSB3aGVuIHN0YXJ0aW5nIHRoZSBhbmlt YXRlZCByZXNpemUsIHRyeWluZyB0byBrZWVwCisgICAgICAgIHRoZSB2aXNpYmxlIGFyZWEgb24g c2NyZWVuIGRvZXMgbm90IG1ha2Ugc2Vuc2UuCisgICAgICAgIFRoaXMgcGF0Y2ggc2hvcnRjdXQg dGhhdCBjYXNlIGFuZCBydW4gdGhlIGJsb2NrIHdpdGhvdXQgYW5pbWF0aW9uIGlmIHRoYXQgd2Vy ZSB0byBoYXBwZW4uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5t bToKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9iZWdpbkFuaW1hdGVkUmVzaXplV2l0aFVwZGF0ZXM6 XSk6CisKIDIwMTQtMDktMDMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAg ICAgICBHZXQgcmlkIG9mIEhJR0hfRFBJX0NBTlZBUyBsZWZ0b3ZlcnMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggZDY0OTJkZjBiYTc0 ZDk3YzYyNmQ2MTg4YTBjM2Y5Y2YxZWJlNWE3Ni4uYjU2NjhmYmEzODFlYjA1OTk1MTAzMjY0NzM1 ZjcwYjVlNjBkMzY2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXcubW0KQEAgLTIxNjIsMTQgKzIxNjIsMTcgQEAgc3RhdGljIGlubGluZSBXZWJL aXQ6OkZpbmRPcHRpb25zIHRvRmluZE9wdGlvbnMoX1dLRmluZE9wdGlvbnMgd2tGaW5kT3B0aW9u cykKIAogLSAodm9pZClfYmVnaW5BbmltYXRlZFJlc2l6ZVdpdGhVcGRhdGVzOih2b2lkICheKSh2 b2lkKSl1cGRhdGVCbG9jawogewotICAgIGlmIChfY3VzdG9tQ29udGVudFZpZXcgfHwgIV9oYXND b21taXR0ZWRMb2FkRm9yTWFpbkZyYW1lKSB7CisgICAgQ0dSZWN0IG9sZEJvdW5kcyA9IHNlbGYu Ym91bmRzOworICAgIENHU2l6ZSBjb250ZW50U2l6ZUluQ29udGVudFZpZXdDb29yZGluYXRlcyA9 IFtfY29udGVudFZpZXcgYm91bmRzXS5zaXplOworICAgIGlmIChfY3VzdG9tQ29udGVudFZpZXcg fHwgIV9oYXNDb21taXR0ZWRMb2FkRm9yTWFpbkZyYW1lCisgICAgICAgIHx8IG9sZEJvdW5kcy5z aXplLndpZHRoIDw9IDAgfHwgb2xkQm91bmRzLnNpemUuaGVpZ2h0IDw9IDAKKyAgICAgICAgfHwg Y29udGVudFNpemVJbkNvbnRlbnRWaWV3Q29vcmRpbmF0ZXMud2lkdGggPD0gMCB8fCBjb250ZW50 U2l6ZUluQ29udGVudFZpZXdDb29yZGluYXRlcy5oZWlnaHQgPD0gMCkgewogICAgICAgICB1cGRh dGVCbG9jaygpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgX2R5bmFtaWNWaWV3cG9y dFVwZGF0ZU1vZGUgPSBEeW5hbWljVmlld3BvcnRVcGRhdGVNb2RlOjpSZXNpemluZ1dpdGhBbmlt YXRpb247CiAKLSAgICBDR1JlY3Qgb2xkQm91bmRzID0gc2VsZi5ib3VuZHM7CiAgICAgV2ViQ29y ZTo6RmxvYXRTaXplIG9sZE1pbmltdW1MYXlvdXRTaXplID0gYWN0aXZlTWluaW11bUxheW91dFNp emUoc2VsZiwgb2xkQm91bmRzKTsKICAgICBXZWJDb3JlOjpGbG9hdFNpemUgb2xkTWluaW11bUxh eW91dFNpemVGb3JNaW5pbWFsVUkgPSBhY3RpdmVNaW5pbXVtTGF5b3V0U2l6ZUZvck1pbmltYWxV SShzZWxmLCBvbGRNaW5pbXVtTGF5b3V0U2l6ZSk7CiAgICAgV2ViQ29yZTo6RmxvYXRTaXplIG9s ZE1heGltdW1Vbm9ic2N1cmVkU2l6ZSA9IGFjdGl2ZU1heGltdW1Vbm9ic2N1cmVkU2l6ZShzZWxm LCBvbGRCb3VuZHMpOwpAQCAtMjE5Nyw2ICsyMjAwLDggQEAgc3RhdGljIGlubGluZSBXZWJLaXQ6 OkZpbmRPcHRpb25zIHRvRmluZE9wdGlvbnMoX1dLRmluZE9wdGlvbnMgd2tGaW5kT3B0aW9ucykK ICAgICAgICAgcmV0dXJuOwogICAgIH0KIAorICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoIW5ld01p bmltdW1MYXlvdXRTaXplLmlzRW1wdHkoKSwgIkRlZmluaW5nIGFuIGVtcHR5IG1pbmltdW0gbGF5 b3V0IHNpemUgd291bGQgYmUgYSBtaXN1c2Ugb2YgdGhlIEFQSS4gU2FmYXJpIHNob3VsZCBzZXQg dXAgYSByZWFzb25hYmxlIHNpemUgaW4gYWxsIGNhc2VzLiIpOworCiAgICAgX3Jlc2l6ZUFuaW1h dGlvblRyYW5zZm9ybUFkanVzdG1lbnRzID0gQ0FUcmFuc2Zvcm0zRElkZW50aXR5OwogCiAgICAg TlNVSW50ZWdlciBpbmRleE9mQ29udGVudFZpZXcgPSBbW19zY3JvbGxWaWV3IHN1YnZpZXdzXSBp bmRleE9mT2JqZWN0Ol9jb250ZW50Vmlldy5nZXQoKV07CkBAIC0yMjA1LDcgKzIyMTAsNiBAQCBz dGF0aWMgaW5saW5lIFdlYktpdDo6RmluZE9wdGlvbnMgdG9GaW5kT3B0aW9ucyhfV0tGaW5kT3B0 aW9ucyB3a0ZpbmRPcHRpb25zKQogICAgIFtfcmVzaXplQW5pbWF0aW9uVmlldyBhZGRTdWJ2aWV3 Ol9jb250ZW50Vmlldy5nZXQoKV07CiAgICAgW19yZXNpemVBbmltYXRpb25WaWV3IGFkZFN1YnZp ZXc6W19jb250ZW50VmlldyB1bnNjYWxlZFZpZXddXTsKIAotICAgIENHU2l6ZSBjb250ZW50U2l6 ZUluQ29udGVudFZpZXdDb29yZGluYXRlcyA9IFtfY29udGVudFZpZXcgYm91bmRzXS5zaXplOwog ICAgIFtfc2Nyb2xsVmlldyBzZXRNaW5pbXVtWm9vbVNjYWxlOnN0ZDo6bWluKG5ld01pbmltdW1M YXlvdXRTaXplLndpZHRoKCkgLyBjb250ZW50U2l6ZUluQ29udGVudFZpZXdDb29yZGluYXRlcy53 aWR0aCwgW19zY3JvbGxWaWV3IG1pbmltdW1ab29tU2NhbGVdKV07CiAgICAgW19zY3JvbGxWaWV3 IHNldE1heGltdW1ab29tU2NhbGU6c3RkOjptYXgobmV3TWluaW11bUxheW91dFNpemUud2lkdGgo KSAvIGNvbnRlbnRTaXplSW5Db250ZW50Vmlld0Nvb3JkaW5hdGVzLndpZHRoLCBbX3Njcm9sbFZp ZXcgbWF4aW11bVpvb21TY2FsZV0pXTsKIAo=