136493 2014-09-03 12:42:22 -0700 [Win] Improper release of unretained AVCFAssetResourceLoaderRef 2014-09-19 17:07:32 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Blocker --- 1 bfulgham bfulgham bfulgham commit-queue eric.carlson glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1032976 0 bfulgham 2014-09-03 12:42:22 -0700 The return value of AVCFURLAssetGetResourceLoader is being adopted by a RetainPtr. This is wrong for a couple of reasons: 1. We use the return value as an argument to another API call, and are not seeking to hold ownership. So the RetainPtr is not necessary and just adds overhead. 2. Since we adopt the argument, we don't increment the reference count. Per Get/Copy/Create semantics, the return value of AVCFURLAssetGetResourceLoader does not have its retain count incremented, so it is inappropriate to release this value. 1032977 1 bfulgham 2014-09-03 12:42:52 -0700 <rdar://problem/18112559> 1032979 2 237571 bfulgham 2014-09-03 12:46:50 -0700 Created attachment 237571 Patch 1032981 3 bfulgham 2014-09-03 12:59:05 -0700 Committed in r173218. <http://trac.webkit.org/changeset/173218> 237571 2014-09-03 12:46:50 -0700 2014-09-03 12:49:43 -0700 Patch bug-136493-20140903124753.patch text/plain 2121 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzIxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE0LTA5LTAzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIEltcHJvcGVyIHJl bGVhc2Ugb2YgdW5yZXRhaW5lZCBBVkNGQXNzZXRSZXNvdXJjZUxvYWRlclJlZgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NDkzCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xODExMjU1OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBEb24ndCBib3RoZXIgd3JhcHBpbmcgdGhlIHJldHVybiB2YWx1ZSBv ZiBBVkNGVVJMQXNzZXRHZXRSZXNvdXJjZUxvYWRlciBpbiBhCisgICAgICAgIFJldGFpblB0ci4g V2UgZG9uJ3QgaG9sZCBvbnRvIHRoaXMgdmFsdWUgb3Igd2FudCB0byBjb250cm9sIGl0cyBsaWZl dGltZTsgd2UganVzdAorICAgICAgICB3YW50IHRvIHBhc3MgaXQgdG8gdGhlIEFWQ0ZBc3NldFJl c291cmNlTG9hZGVyU2V0Q2FsbGJhY2tzIGZ1bmN0aW9uLgorCisgICAgICAgIFVzZSBvZiB0aGUg UmV0YWluUHRyIGNyZWF0ZWQgYSBkb3VibGUtcmVsZWFzZSBhbmQgY3Jhc2guCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vY2YvTWVkaWFQbGF5ZXJQcml2YXRlQVZG b3VuZGF0aW9uQ0YuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QVZGV3JhcHBlcjo6Y3JlYXRlQXNz ZXRGb3JVUkwpOiAKKwogMjAxNC0wOS0wMyAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+ CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHRoZSBpbml0aWFsLWxldHRlciBDU1MgcHJvcGVy dHkgdG8gZmlyc3QtbGV0dGVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9hdmZvdW5kYXRpb24vY2YvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0YuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlv bi9jZi9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRi5jcHAJKHJldmlzaW9uIDE3MzIx NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9jZi9N ZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0 MzUsOCArMTQzNSw4IEBAIHZvaWQgQVZGV3JhcHBlcjo6Y3JlYXRlQXNzZXRGb3JVUkwoY29uc3QK ICAgICBsb2FkZXJDYWxsYmFja3MuY29udGV4dCA9IGNhbGxiYWNrQ29udGV4dCgpOwogICAgIGxv YWRlckNhbGxiYWNrcy5yZXNvdXJjZUxvYWRlclNob3VsZFdhaXRGb3JMb2FkaW5nT2ZSZXF1ZXN0 ZWRSZXNvdXJjZSA9IEFWRldyYXBwZXI6OnJlc291cmNlTG9hZGVyU2hvdWxkV2FpdEZvckxvYWRp bmdPZlJlcXVlc3RlZFJlc291cmNlOwogCi0gICAgUmV0YWluUHRyPEFWQ0ZBc3NldFJlc291cmNl TG9hZGVyUmVmPiByZXNvdXJjZUxvYWRlciA9IGFkb3B0Q0YoQVZDRlVSTEFzc2V0R2V0UmVzb3Vy Y2VMb2FkZXIobV9hdkFzc2V0LmdldCgpKSk7Ci0gICAgQVZDRkFzc2V0UmVzb3VyY2VMb2FkZXJT ZXRDYWxsYmFja3MocmVzb3VyY2VMb2FkZXIuZ2V0KCksICZsb2FkZXJDYWxsYmFja3MsIGdsb2Jh bExvYWRlckRlbGVnYXRlUXVldWUoKSk7CisgICAgQVZDRkFzc2V0UmVzb3VyY2VMb2FkZXJSZWYg cmVzb3VyY2VMb2FkZXIgPSBBVkNGVVJMQXNzZXRHZXRSZXNvdXJjZUxvYWRlcihtX2F2QXNzZXQu Z2V0KCkpOworICAgIEFWQ0ZBc3NldFJlc291cmNlTG9hZGVyU2V0Q2FsbGJhY2tzKHJlc291cmNl TG9hZGVyLCAmbG9hZGVyQ2FsbGJhY2tzLCBnbG9iYWxMb2FkZXJEZWxlZ2F0ZVF1ZXVlKCkpOwog I2VuZGlmCiB9CiAK