136490 2014-09-03 11:48:38 -0700 CallEdgeProfile::visitWeak() should gracefully handle the case where primaryCallee duplicates an entry in otherCallees 2014-09-03 11:58:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenb msaboff nrotem oliver sam oldest_to_newest 1032955 0 fpizlo 2014-09-03 11:48:38 -0700 Patch forthcoming. 1032956 1 237566 fpizlo 2014-09-03 11:49:26 -0700 Created attachment 237566 the patch 1032959 2 237566 ggaren 2014-09-03 11:52:02 -0700 Comment on attachment 237566 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=237566&action=review r=me > Source/JavaScriptCore/bytecode/CallEdgeProfile.cpp:143 > + // the primary culd duplicate an entry in otherCallees, which means that even though we "could" 1032962 3 fpizlo 2014-09-03 11:58:44 -0700 Landed in http://trac.webkit.org/changeset/173214 237566 2014-09-03 11:49:26 -0700 2014-09-03 11:52:01 -0700 the patch blah.patch text/plain 2071 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTczMjEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTA5LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Q2FsbEVkZ2VQcm9maWxlOjp2aXNpdFdlYWsoKSBzaG91bGQgZ3JhY2VmdWxseSBoYW5kbGUgdGhl IGNhc2Ugd2hlcmUgcHJpbWFyeUNhbGxlZSBkdXBsaWNhdGVzIGFuIGVudHJ5IGluIG90aGVyQ2Fs bGVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2 NDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBi eXRlY29kZS9DYWxsRWRnZVByb2ZpbGUuY3BwOgorICAgICAgICAoSlNDOjpDYWxsRWRnZVByb2Zp bGU6OnZpc2l0V2Vhayk6CisKIDIwMTQtMDktMDMgIEFrb3MgS2lzcyAgPGFraXNzQGluZi51LXN6 ZWdlZC5odT4KIAogICAgICAgICBEb24ndCBnZW5lcmF0ZSBzdXBlcmZsdW91cyBtb3YgaW5zdHJ1 Y3Rpb25zIGZvciBtb3ZlIGltbWVkaWF0ZSBvbiBBUk02NC4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9DYWxsRWRnZVByb2ZpbGUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9DYWxsRWRnZVByb2ZpbGUuY3BwCShyZXZpc2lvbiAx NzI5NDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ2FsbEVkZ2VQcm9maWxl LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM1LDExICsxMzUsMTcgQEAgdm9pZCBDYWxsRWRnZVBy b2ZpbGU6OnZpc2l0V2VhaygpCiAgICAgICAgIG1fcHJpbWFyeUNhbGxlZSA9IGxpc3QubGFzdCgp LmtleTsKICAgICAgICAgbV9udW1DYWxsc1RvUHJpbWFyeSA9IGxpc3QubGFzdCgpLmNvdW50Owog ICAgICAgICAKLSAgICAgICAgQVNTRVJUKCEhbV9vdGhlckNhbGxlZXMgPT0gKGxpc3Quc2l6ZSgp ID49IDIpKTsKICAgICAgICAgaWYgKG1fb3RoZXJDYWxsZWVzKSB7CiAgICAgICAgICAgICBtX290 aGVyQ2FsbGVlcy0+bV9wcm9jZXNzZWQuY2xlYXIoKTsKLSAgICAgICAgICAgIGZvciAodW5zaWdu ZWQgaSA9IGxpc3Quc2l6ZSgpIC0gMTsgaS0tOykKLSAgICAgICAgICAgICAgICBtX290aGVyQ2Fs bGVlcy0+bV9wcm9jZXNzZWQuYXBwZW5kKENhbGxFZGdlKGxpc3RbaV0ua2V5LCBsaXN0W2ldLmNv dW50KSk7CisKKyAgICAgICAgICAgIC8vIFdlIGNvdWxkIGhhdmUgYSBzaXR1YXRpb24gd2hlcmUg dGhlIEdDIGNsZWFycyB0aGUgcHJpbWFyeSBhbmQgdGhlbiBsb2cgcHJvY2Vzc2luZworICAgICAg ICAgICAgLy8gcmVpbnN0YXRlcyBpdCB3aXRob3V0IGV2ZXIgZG9pbmcgYW4gYWRkU2xvdyBhbmQg c3Vic2VxdWVudCBtZXJnZUJhY2suIEluIHN1Y2ggYSBjYXNlCisgICAgICAgICAgICAvLyB0aGUg cHJpbWFyeSBjdWxkIGR1cGxpY2F0ZSBhbiBlbnRyeSBpbiBvdGhlckNhbGxlZXMsIHdoaWNoIG1l YW5zIHRoYXQgZXZlbiB0aG91Z2ggd2UKKyAgICAgICAgICAgIC8vIGhhZCBhbiBvdGhlckNhbGxl ZXMgb2JqZWN0LCB0aGUgbGlzdCBzaXplIGlzIGp1c3QgMS4KKyAgICAgICAgICAgIGlmIChsaXN0 LnNpemUoKSA+PSAyKSB7CisgICAgICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gbGlzdC5z aXplKCkgLSAxOyBpLS07KQorICAgICAgICAgICAgICAgICAgICBtX290aGVyQ2FsbGVlcy0+bV9w cm9jZXNzZWQuYXBwZW5kKENhbGxFZGdlKGxpc3RbaV0ua2V5LCBsaXN0W2ldLmNvdW50KSk7Cisg ICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgCiAgICAgICAgIG1fY2xvc3VyZXNBcmVE ZXNwZWNpZmllZCA9IHRydWU7Cg==