136489 2014-09-03 11:43:41 -0700 Dump SimpleLineLayout info in showRenderTree() output 2014-09-03 14:18:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn hyatt koivisto kondapallykalyan simon.fraser zalan oldest_to_newest 1032949 0 simon.fraser 2014-09-03 11:43:41 -0700 Dump SimpleLineLayout info in showRenderTree() output 1032951 1 237565 simon.fraser 2014-09-03 11:45:04 -0700 Created attachment 237565 Patch 1032952 2 simon.fraser 2014-09-03 11:46:37 -0700 Sample output: ------- -- DIV RenderBlock (0.00, 840.00) (741.00, 72.00) renderer->(0x600000161d40) node->(0x6580000c2a70) ------- -- RootInlineBox (0.00, 0.00) (703.84, 18.00) (0x6580001201e0) ------- -- InlineTextBox (0.00, 0.00) (703.84, 18.00) (0x6580000a3240) run(9, 119) "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore" ------- -- RootInlineBox (0.00, 18.00) (729.18, 18.00) (0x658000120280) ------- -- InlineTextBox (0.00, 18.00) (534.98, 18.00) (0x6580000a32a0) run(120, 201) "magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris " ------- -- InlineTextBox (534.98, 18.00) (24.02, 18.00) (0x6580000a3300) run(0, 4) "nisi" ------- -- InlineTextBox (559.00, 18.00) (170.18, 18.00) (0x6580000a3360) run(0, 25) " ut aliquip ex ea commodo" ------- -- RootInlineBox (0.00, 36.00) (696.68, 18.00) (0x658000120820) ------- -- InlineTextBox (0.00, 36.00) (696.68, 18.00) (0x6580000a33c0) run(26, 139) "consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur." ------- -- RootInlineBox (0.00, 54.00) (694.03, 18.00) (0x658000120a00) ------- -- InlineTextBox (0.00, 54.00) (694.03, 18.00) (0x6580000a3420) run(140, 250) "Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum." ------- -- #text RenderText renderer->(0x6000000aa680) node->(0x6580000828a0) length->(201) "\n Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusm"... ------- -- B RenderInline renderer->(0x6000000c4130) node->(0x6580000c2ae0) ------- -- #text RenderText renderer->(0x6000000aac80) node->(0x658000082850) length->(4) "nisi" ------- -- #text RenderText renderer->(0x6000000aab00) node->(0x658000082800) length->(255) " ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in v"... ------- -- DIV RenderBlock (0.00, 912.00) (741.00, 72.00) renderer->(0x600000161e00) node->(0x6580000c2b50) ------- -- SimpleLineLayout (4 lines, 4 runs) (0x658000082030) ------- -- run(9, 119) line 0 "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore" ------- -- run(120, 230) line 1 "magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo" ------- -- run(231, 344) line 2 "consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur." ------- -- run(345, 455) line 3 "Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum." ------- -- #text RenderText renderer->(0x6000000aace0) node->(0x658000082760) length->(460) "\n Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusm"... 1032957 3 237565 zalan 2014-09-03 11:50:28 -0700 Comment on attachment 237565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237565&action=review > Source/WebCore/rendering/SimpleLineLayoutFunctions.h:67 > +void showLineTreeForFlow(const RenderBlockFlow&, const Layout&, int depth); showTextRunsForFlow()? 1033019 4 simon.fraser 2014-09-03 14:18:34 -0700 https://trac.webkit.org/r173226 237565 2014-09-03 11:45:04 -0700 2014-09-03 11:50:28 -0700 Patch bug-136489-20140903114458.patch text/plain 5152 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWViZGJiOTI2MmEzY2Ri OTVmMzg3NjNhNDdlYTUxNWFjNGM2NTU3OS4uNDUzZDJhOGMzODc3ZjY0NzgwYWNjYTU2ZGU0MWE1 ODJjZTM5YWMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA5LTAzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIER1bXAgU2ltcGxl TGluZUxheW91dCBpbmZvIGluIHNob3dSZW5kZXJUcmVlKCkgb3V0cHV0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY0ODkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEluY2x1ZGUgaW5mbyBh Ym91dCBTaW1wbGVMaW5lTGF5b3V0IHRvIHNob3dSZW5kZXJUcmVlKCkgb3V0cHV0LgorICAgICAg ICAKKyAgICAgICAgQWxzbyBzaG93IFJlbmRlclRleHQgbGVuZ3RoLCBhbmQgdHJ1bmNhdGUgdGhl IFJlbmRlclRleHQgY29udGVudHMKKyAgICAgICAgdG8gODAgY2hhcnMgKHNpbmNlIHRoZSBzdHJp bmcgaXMgcmVwbGljYXRlZCBpbiBpbmxpbmUgYm94ZXMgb3Igc2ltcGxlIGxpbmUgbGF5b3V0IG91 dHB1dCkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6c2hvd0xpbmVUcmVlQW5kTWFyayk6CisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJPYmplY3Q6OnNob3dSZW5kZXJPYmplY3QpOgorICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVM aW5lTGF5b3V0RnVuY3Rpb25zLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUxpbmVMYXlv dXQ6OnByaW50UHJlZml4KToKKyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUxpbmVMYXlvdXQ6OnNo b3dMaW5lVHJlZUZvckZsb3cpOgorICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0 RnVuY3Rpb25zLmg6CisKIDIwMTQtMDktMDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgRml4IGFuIGFzc2VydGlvbiBzb21ldGltZXMgc2VlbiB1bmRl ciBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmRldGFjaFJvb3RMYXllcigpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCmluZGV4IDVkOTVmM2UxNmJhM2IxNjQ2 Yzg5YjI0YjVmMDY3NGFhMDE0Yjc3NjguLjhiMmM4NGVkZDMyMDU2MGY0YWQ4NDJkODBhZTk5ZDUz Mjg4MTdiNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j a0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cu Y3BwCkBAIC0zNDc5LDYgKzM0NzksOSBAQCB2b2lkIFJlbmRlckJsb2NrRmxvdzo6c2hvd0xpbmVU cmVlQW5kTWFyayhjb25zdCBJbmxpbmVCb3gqIG1hcmtlZEJveCwgaW50IGRlcHRoKQogewogICAg IGZvciAoY29uc3QgUm9vdElubGluZUJveCogcm9vdCA9IGZpcnN0Um9vdEJveCgpOyByb290OyBy b290ID0gcm9vdC0+bmV4dFJvb3RCb3goKSkKICAgICAgICAgcm9vdC0+c2hvd0xpbmVUcmVlQW5k TWFyayhtYXJrZWRCb3gsIGRlcHRoKTsKKworICAgIGlmIChhdXRvIHNpbXBsZUxpbmVMYXlvdXQg PSB0aGlzLT5zaW1wbGVMaW5lTGF5b3V0KCkpCisgICAgICAgIFNpbXBsZUxpbmVMYXlvdXQ6OnNo b3dMaW5lVHJlZUZvckZsb3coKnRoaXMsICpzaW1wbGVMaW5lTGF5b3V0LCBkZXB0aCk7CiB9CiAj ZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVj dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAppbmRleCBl YTBlZGE2NTUwMDQ1YzhiODdhNzBhYTNiNDk0NTg5MGJkMzYzMmZhLi5jZGE4ODFkMmY3ZTQxMjM0 ZGZmMzQzZDdjNTA0NDIxNjZlZjM4OTBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmNwcApAQCAtMTU0OSw5ICsxNTQ5LDE3IEBAIHZvaWQgUmVuZGVyT2JqZWN0Ojpz aG93UmVuZGVyT2JqZWN0KGJvb2wgbWFyaywgaW50IGRlcHRoKSBjb25zdAogICAgICAgICBmcHJp bnRmKHN0ZGVyciwgIiBub2RlLT4oJXApIiwgbm9kZSgpKTsKICAgICAgICAgaWYgKG5vZGUoKS0+ aXNUZXh0Tm9kZSgpKSB7CiAgICAgICAgICAgICBTdHJpbmcgdmFsdWUgPSBub2RlKCktPm5vZGVW YWx1ZSgpOworICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICIgbGVuZ3RoLT4oJXUpIiwgdmFs dWUubGVuZ3RoKCkpOworCiAgICAgICAgICAgICB2YWx1ZS5yZXBsYWNlV2l0aExpdGVyYWwoJ1xc JywgIlxcXFwiKTsKICAgICAgICAgICAgIHZhbHVlLnJlcGxhY2VXaXRoTGl0ZXJhbCgnXG4nLCAi XFxuIik7Ci0gICAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIiBcIiVzXCIiLCB2YWx1ZS51dGY4 KCkuZGF0YSgpKTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgY29uc3QgaW50IG1heFByaW50 ZWRMZW5ndGggPSA4MDsKKyAgICAgICAgICAgIGlmICh2YWx1ZS5sZW5ndGgoKSA+IG1heFByaW50 ZWRMZW5ndGgpIHsKKyAgICAgICAgICAgICAgICBTdHJpbmcgc3Vic3RyaW5nID0gdmFsdWUuc3Vi c3RyaW5nKDAsIG1heFByaW50ZWRMZW5ndGgpOworICAgICAgICAgICAgICAgIGZwcmludGYoc3Rk ZXJyLCAiIFwiJXNcIi4uLiIsIHN1YnN0cmluZy51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAgICAg IH0gZWxzZQorICAgICAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAiIFwiJXNcIiIsIHZhbHVl LnV0ZjgoKS5kYXRhKCkpOwogICAgICAgICB9CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dEZ1bmN0aW9ucy5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dEZ1bmN0aW9ucy5jcHAKaW5kZXggMWNm ZGYzMTYxMWZhNTgyNjhhZDJjODQ0OThjZGI2NDZjZDUxODk0Zi4uN2U3MzE5YjM4OWI2YjIwMDNk ZTdmMTg1ODg1Mzc0MGRiNzY0NDg5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1NpbXBsZUxpbmVMYXlvdXRGdW5jdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0RnVuY3Rpb25zLmNwcApAQCAtMjAwLDUgKzIwMCwzMSBA QCBWZWN0b3I8RmxvYXRRdWFkPiBjb2xsZWN0VGV4dEFic29sdXRlUXVhZHMoY29uc3QgUmVuZGVy VGV4dCYgdGV4dFJlbmRlcmVyLCBjb25zdAogICAgIHJldHVybiBxdWFkczsKIH0KIAorI2lmbmRl ZiBOREVCVUcKK3N0YXRpYyB2b2lkIHByaW50UHJlZml4KGludCYgcHJpbnRlZENoYXJhY3RlcnMs IGludCBkZXB0aCkKK3sKKyAgICBmcHJpbnRmKHN0ZGVyciwgIi0tLS0tLS0gLS0iKTsKKyAgICBw cmludGVkQ2hhcmFjdGVycyA9IDA7CisgICAgd2hpbGUgKCsrcHJpbnRlZENoYXJhY3RlcnMgPD0g ZGVwdGggKiAyKQorICAgICAgICBmcHV0YygnICcsIHN0ZGVycik7Cit9CisKK3ZvaWQgc2hvd0xp bmVUcmVlRm9yRmxvdyhjb25zdCBSZW5kZXJCbG9ja0Zsb3cmIGZsb3csIGNvbnN0IExheW91dCYg bGF5b3V0LCBpbnQgZGVwdGgpCit7CisgICAgaW50IHByaW50ZWRDaGFyYWN0ZXJzID0gMDsKKyAg ICBwcmludFByZWZpeChwcmludGVkQ2hhcmFjdGVycywgZGVwdGgpOworCisgICAgZnByaW50Zihz dGRlcnIsICJTaW1wbGVMaW5lTGF5b3V0ICgldSBsaW5lcywgJXUgcnVucykgKCVwKVxuIiwgbGF5 b3V0LmxpbmVDb3VudCgpLCBsYXlvdXQucnVuQ291bnQoKSwgJmxheW91dCk7CisgICAgKytkZXB0 aDsKKworICAgIGF1dG8gcmVzb2x2ZXIgPSBydW5SZXNvbHZlcihmbG93LCBsYXlvdXQpOworICAg IGZvciAoYXV0byBpdCA9IHJlc29sdmVyLmJlZ2luKCksIGVuZCA9IHJlc29sdmVyLmVuZCgpOyBp dCAhPSBlbmQ7ICsraXQpIHsKKyAgICAgICAgY29uc3QgYXV0byYgcnVuID0gKml0OworICAgICAg ICBwcmludFByZWZpeChwcmludGVkQ2hhcmFjdGVycywgZGVwdGgpOworICAgICAgICBmcHJpbnRm KHN0ZGVyciwgInJ1bigldSwgJXUpIGxpbmUgJXUgXCIlc1wiXG4iLCBydW4uc3RhcnQoKSwgcnVu LmVuZCgpLCBydW4ubGluZUluZGV4KCksIHJ1bi50ZXh0KCkudXRmOCgpLmRhdGEoKSk7CisgICAg fQorfQorI2VuZGlmCisKIH0KIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9TaW1wbGVMaW5lTGF5b3V0RnVuY3Rpb25zLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv U2ltcGxlTGluZUxheW91dEZ1bmN0aW9ucy5oCmluZGV4IDk5ZDFhYWYxNDgwYWQ1YzEwNTllNWM4 ODFiNmVkMWE1ZGUxNWNkODYuLmZhNmRhZGE1OTBjZjRiMDkyMTVmMzVmOTZhN2FkMzZkNDYwZjhm YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0 RnVuY3Rpb25zLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlv dXRGdW5jdGlvbnMuaApAQCAtNjMsNiArNjMsMTAgQEAgVmVjdG9yPEZsb2F0UXVhZD4gY29sbGVj dFRleHRBYnNvbHV0ZVF1YWRzKGNvbnN0IFJlbmRlclRleHQmLCBjb25zdCBMYXlvdXQmLCBib28K IExheW91dFVuaXQgbGluZUhlaWdodEZyb21GbG93KGNvbnN0IFJlbmRlckJsb2NrRmxvdyYpOwog TGF5b3V0VW5pdCBiYXNlbGluZUZyb21GbG93KGNvbnN0IFJlbmRlckJsb2NrRmxvdyYpOwogCisj aWZuZGVmIE5ERUJVRwordm9pZCBzaG93TGluZVRyZWVGb3JGbG93KGNvbnN0IFJlbmRlckJsb2Nr RmxvdyYsIGNvbnN0IExheW91dCYsIGludCBkZXB0aCk7CisjZW5kaWYKKwogfQogCiBuYW1lc3Bh Y2UgU2ltcGxlTGluZUxheW91dCB7Cg==