<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>136468</bug_id>
          
          <creation_ts>2014-09-02 15:57:55 -0700</creation_ts>
          <short_desc>MallocBench should have a stress test for correctness</short_desc>
          <delta_ts>2014-09-03 14:00:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Geoffrey Garen">ggaren</reporter>
          <assigned_to name="Geoffrey Garen">ggaren</assigned_to>
          <cc>barraclough</cc>
    
    <cc>commit-queue</cc>
    
    <cc>kling</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1032772</commentid>
    <comment_count>0</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2014-09-02 15:57:55 -0700</bug_when>
    <thetext>MallocBench should have a stress test for correctness</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1032773</commentid>
    <comment_count>1</comment_count>
      <attachid>237524</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2014-09-02 16:03:29 -0700</bug_when>
    <thetext>Created attachment 237524
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1032775</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-09-02 16:06:10 -0700</bug_when>
    <thetext>Attachment 237524 did not pass style-queue:


ERROR: PerformanceTests/MallocBench/MallocBench/stress.h:29:  benchmark_stress is incorrectly named. Don&apos;t use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:28:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:36:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:70:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:78:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: PerformanceTests/MallocBench/MallocBench/stress.cpp:103:  benchmark_stress is incorrectly named. Don&apos;t use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 7 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1032920</commentid>
    <comment_count>3</comment_count>
      <attachid>237524</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2014-09-03 10:27:44 -0700</bug_when>
    <thetext>Comment on attachment 237524
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=237524&amp;action=review

r=me

&gt; PerformanceTests/ChangeLog:21
&gt; +        (benchmark_stress): Usually, we random(0). Surprisingly, though, only
&gt; +        random(1) reproduces the bug I was looking for.

This feels a bit sketchy, but it&apos;s better than not having a test at all.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1033004</commentid>
    <comment_count>4</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2014-09-03 14:00:12 -0700</bug_when>
    <thetext>Committed r173223: &lt;http://trac.webkit.org/changeset/173223&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>237524</attachid>
            <date>2014-09-02 16:03:29 -0700</date>
            <delta_ts>2014-09-03 10:27:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-136468-20140902160323.patch</filename>
            <type>text/plain</type>
            <size>12564</size>
            <attacher name="Geoffrey Garen">ggaren</attacher>
            
              <data encoding="base64">SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h
bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzMxOTApCisrKyBQZXJmb3JtYW5jZVRlc3Rz
L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE0LTA5LTAyICBH
ZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFsbG9jQmVuY2gg
c2hvdWxkIGhhdmUgYSBzdHJlc3MgdGVzdCBmb3IgY29ycmVjdG5lc3MKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjQ2OAorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgc3RyZXNzIHRlc3QgdGhh
dCBhbGxvY2F0ZXMgcmFuZG9taXplZCBzaXplcyBvZiByYW5kb21pemVkCisgICAgICAgIGxpZmV0
aW1lcyBpbiByYW5kb21pemVkIG9yZGVyLgorCisgICAgICAgIFRoaXMgdmVyc2lvbiBvZiB0aGUg
dGVzdCByZXByb2R1Y2VzIHRoZSBFV1MgY3Jhc2ggc2VlbiBpbiBibWFsbG9jCisgICAgICAgICg8
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMjYyOT4pLgorCisgICAg
ICAgICogTWFsbG9jQmVuY2gvTWFsbG9jQmVuY2gueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoK
KyAgICAgICAgKiBNYWxsb2NCZW5jaC9NYWxsb2NCZW5jaC9CZW5jaG1hcmsuY3BwOgorICAgICAg
ICAqIE1hbGxvY0JlbmNoL01hbGxvY0JlbmNoL3N0cmVzcy5jcHA6IEFkZGVkLgorICAgICAgICAo
T2JqZWN0OjpPYmplY3QpOgorICAgICAgICAoU2l6ZVN0cmVhbTo6U2l6ZVN0cmVhbSk6CisgICAg
ICAgIChTaXplU3RyZWFtOjpuZXh0KToKKyAgICAgICAgKGJlbmNobWFya19zdHJlc3MpOiBVc3Vh
bGx5LCB3ZSByYW5kb20oMCkuIFN1cnByaXNpbmdseSwgdGhvdWdoLCBvbmx5CisgICAgICAgIHJh
bmRvbSgxKSByZXByb2R1Y2VzIHRoZSBidWcgSSB3YXMgbG9va2luZyBmb3IuCisgICAgICAgICog
TWFsbG9jQmVuY2gvTWFsbG9jQmVuY2gvc3RyZXNzLmg6IEFkZGVkLgorCiAyMDE0LTA2LTAyICBS
eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbmFtZSBEb1lvdUV2
ZW5CZW5jaCAwLjE3IHRvIFNwZWVkb21ldGVyIDEuMCBhbmQgYWRkIGEgbmV3IGxvb2suCkluZGV4
OiBQZXJmb3JtYW5jZVRlc3RzL01hbGxvY0JlbmNoL01hbGxvY0JlbmNoLnhjb2RlcHJvai9wcm9q
ZWN0LnBieHByb2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5jaC9N
YWxsb2NCZW5jaC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCShyZXZpc2lvbiAxNzMxOTApCisr
KyBQZXJmb3JtYW5jZVRlc3RzL01hbGxvY0JlbmNoL01hbGxvY0JlbmNoLnhjb2RlcHJvai9wcm9q
ZWN0LnBieHByb2oJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDcgQEAKIAkJMTRDQzM5M0Yx
OEVBODE4NDAwNEFGRTM0IC8qIG1ibWFsbG9jLmNwcCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBC
WEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDE0Q0MzOTFDMThFQTY3NTkwMDRBRkUzNCAvKiBtYm1hbGxv
Yy5jcHAgKi87IH07CiAJCTE0Q0U0QTYwMTdCRDM1NTgwMDI4OERBQSAvKiBiaWcuY3BwIGluIFNv
dXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMTRDRTRBNUUxN0JEMzU1
ODAwMjg4REFBIC8qIGJpZy5jcHAgKi87IH07CiAJCTE0RTExOTMyMTc3RUNDOEIwMDNBOEQxNSAv
KiBDUFVDb3VudC5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVS
ZWYgPSAxNEUxMTkzMDE3N0VDQzhCMDAzQThEMTUgLyogQ1BVQ291bnQuY3BwICovOyB9OworCQkx
NEZDQTM2MTE5QTdDOTE3MDAxQ0ZEQTkgLyogc3RyZXNzLmNwcCBpbiBTb3VyY2VzICovID0ge2lz
YSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDE0RkNBMzVGMTlBN0M5MTcwMDFDRkRBOSAvKiBz
dHJlc3MuY3BwICovOyB9OwogLyogRW5kIFBCWEJ1aWxkRmlsZSBzZWN0aW9uICovCiAKIC8qIEJl
Z2luIFBCWENvcHlGaWxlc0J1aWxkUGhhc2Ugc2VjdGlvbiAqLwpAQCAtMTA1LDYgKzEwNiw4IEBA
CiAJCTE0RTExOTMwMTc3RUNDOEIwMDNBOEQxNSAvKiBDUFVDb3VudC5jcHAgKi8gPSB7aXNhID0g
UEJYRmlsZVJlZmVyZW5jZTsgZmlsZUVuY29kaW5nID0gNDsgbGFzdEtub3duRmlsZVR5cGUgPSBz
b3VyY2Vjb2RlLmNwcC5jcHA7IHBhdGggPSBDUFVDb3VudC5jcHA7IHNvdXJjZVRyZWUgPSAiPGdy
b3VwPiI7IH07CiAJCTE0RTExOTMxMTc3RUNDOEIwMDNBOEQxNSAvKiBDUFVDb3VudC5oICovID0g
e2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVU
eXBlID0gc291cmNlY29kZS5jLmg7IHBhdGggPSBDUFVDb3VudC5oOyBzb3VyY2VUcmVlID0gIjxn
cm91cD4iOyB9OwogCQkxNEUxMTkzNDE3N0Y1MjE5MDAzQThEMTUgLyogbWJtYWxsb2MuaCAqLyA9
IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0S25vd25GaWxl
VHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBuYW1lID0gbWJtYWxsb2MuaDsgcGF0aCA9IE1hbGxvY0Jl
bmNoL21ibWFsbG9jLmg7IHNvdXJjZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJCTE0RkNBMzVGMTlB
N0M5MTcwMDFDRkRBOSAvKiBzdHJlc3MuY3BwICovID0ge2lzYSA9IFBCWEZpbGVSZWZlcmVuY2U7
IGZpbGVFbmNvZGluZyA9IDQ7IGxhc3RLbm93bkZpbGVUeXBlID0gc291cmNlY29kZS5jcHAuY3Bw
OyBuYW1lID0gc3RyZXNzLmNwcDsgcGF0aCA9IE1hbGxvY0JlbmNoL3N0cmVzcy5jcHA7IHNvdXJj
ZVRyZWUgPSAiPGdyb3VwPiI7IH07CisJCTE0RkNBMzYwMTlBN0M5MTcwMDFDRkRBOSAvKiBzdHJl
c3MuaCAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJlbmNlOyBmaWxlRW5jb2RpbmcgPSA0OyBsYXN0
S25vd25GaWxlVHlwZSA9IHNvdXJjZWNvZGUuYy5oOyBuYW1lID0gc3RyZXNzLmg7IHBhdGggPSBN
YWxsb2NCZW5jaC9zdHJlc3MuaDsgc291cmNlVHJlZSA9ICI8Z3JvdXA+IjsgfTsKIC8qIEVuZCBQ
QlhGaWxlUmVmZXJlbmNlIHNlY3Rpb24gKi8KIAogLyogQmVnaW4gUEJYRnJhbWV3b3Jrc0J1aWxk
UGhhc2Ugc2VjdGlvbiAqLwpAQCAtMjEwLDYgKzIxMyw4IEBACiAJCQkJMTQ0N0FFOEExOEZCNTg0
MjAwQjNEN0ZGIC8qIHJlZGRpdC5jcHAgKi8sCiAJCQkJMTQ0N0FFOEIxOEZCNTg0MjAwQjNEN0ZG
IC8qIHJlZGRpdC5oICovLAogCQkJCTE0NDdBRThDMThGQjU4NDIwMEIzRDdGRiAvKiByZWRkaXQu
b3BzICovLAorCQkJCTE0RkNBMzVGMTlBN0M5MTcwMDFDRkRBOSAvKiBzdHJlc3MuY3BwICovLAor
CQkJCTE0RkNBMzYwMTlBN0M5MTcwMDFDRkRBOSAvKiBzdHJlc3MuaCAqLywKIAkJCQkxNDQ3QUU5
ODE4RkI1OUQ5MDBCM0Q3RkYgLyogdGhldmVyZ2VfbWVtb3J5X3dhcm5pbmcub3BzICovLAogCQkJ
CTE0NDdBRThEMThGQjU4NDIwMEIzRDdGRiAvKiB0aGV2ZXJnZS5jcHAgKi8sCiAJCQkJMTQ0N0FF
OEUxOEZCNTg0MjAwQjNEN0ZGIC8qIHRoZXZlcmdlLmggKi8sCkBAIC0zMDQsNiArMzA5LDcgQEAK
IAkJCQkxNDQ0QUU5NjE3N0U4REYyMDBGODAzMEEgLyogbWVzc2FnZS5jcHAgaW4gU291cmNlcyAq
LywKIAkJCQkxNDQ1MkNFRjE3N0Q0NzExMDA5N0UwNTcgLyogY2h1cm4uY3BwIGluIFNvdXJjZXMg
Ki8sCiAJCQkJMTQ0NTJDQjAxNzdEMjQ0NjAwOTdFMDU3IC8qIG1haW4uY3BwIGluIFNvdXJjZXMg
Ki8sCisJCQkJMTRGQ0EzNjExOUE3QzkxNzAwMUNGREE5IC8qIHN0cmVzcy5jcHAgaW4gU291cmNl
cyAqLywKIAkJCQkxNEM1MDA4RDE4NDAxNkNGMDA3QTUzMUQgLyogZmFjZWJvb2suY3BwIGluIFNv
dXJjZXMgKi8sCiAJCQkJMTQ0N0FFOTAxOEZCNTg0MjAwQjNEN0ZGIC8qIGZsaWNrci5jcHAgaW4g
U291cmNlcyAqLywKIAkJCQkxNDk3NkVDODE3N0UzNjQ5MDA2QjgxOUEgLyogbGlzdC5jcHAgaW4g
U291cmNlcyAqLywKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvTWFsbG9jQmVuY2gvTWFsbG9jQmVu
Y2gvQmVuY2htYXJrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL01hbGxvY0Jl
bmNoL01hbGxvY0JlbmNoL0JlbmNobWFyay5jcHAJKHJldmlzaW9uIDE3MzE5MCkKKysrIFBlcmZv
cm1hbmNlVGVzdHMvTWFsbG9jQmVuY2gvTWFsbG9jQmVuY2gvQmVuY2htYXJrLmNwcAkod29ya2lu
ZyBjb3B5KQpAQCAtMzUsNiArMzUsNyBAQAogI2luY2x1ZGUgIm1lZGl1bS5oIgogI2luY2x1ZGUg
Im1lc3NhZ2UuaCIKICNpbmNsdWRlICJyZWRkaXQuaCIKKyNpbmNsdWRlICJzdHJlc3MuaCIKICNp
bmNsdWRlICJ0aGV2ZXJnZS5oIgogI2luY2x1ZGUgInRyZWUuaCIKICNpbmNsdWRlIDxkaXNwYXRj
aC9kaXNwYXRjaC5oPgpAQCAtNTcsMjYgKzU4LDI3IEBAIHN0cnVjdCBCZW5jaG1hcmtQYWlyIHsK
IH07CiAKIHN0YXRpYyBjb25zdCBCZW5jaG1hcmtQYWlyIGJlbmNobWFya1BhaXJzW10gPSB7Cisg
ICAgeyAiYmFsbG9vbiIsIGJlbmNobWFya19iYWxsb29uIH0sCisgICAgeyAiYmlnIiwgYmVuY2ht
YXJrX2JpZyB9LAogICAgIHsgImNodXJuIiwgYmVuY2htYXJrX2NodXJuIH0sCi0gICAgeyAibGlz
dF9hbGxvY2F0ZSIsIGJlbmNobWFya19saXN0X2FsbG9jYXRlIH0sCi0gICAgeyAibGlzdF90cmF2
ZXJzZSIsIGJlbmNobWFya19saXN0X3RyYXZlcnNlIH0sCi0gICAgeyAidHJlZV9hbGxvY2F0ZSIs
IGJlbmNobWFya190cmVlX2FsbG9jYXRlIH0sCi0gICAgeyAidHJlZV90cmF2ZXJzZSIsIGJlbmNo
bWFya190cmVlX3RyYXZlcnNlIH0sCi0gICAgeyAidHJlZV9jaHVybiIsIGJlbmNobWFya190cmVl
X2NodXJuIH0sCisgICAgeyAiZmFjZWJvb2siLCBiZW5jaG1hcmtfZmFjZWJvb2sgfSwKKyAgICB7
ICJmbGlja3IiLCBiZW5jaG1hcmtfZmxpY2tyIH0sCisgICAgeyAiZmxpY2tyX21lbW9yeV93YXJu
aW5nIiwgYmVuY2htYXJrX2ZsaWNrcl9tZW1vcnlfd2FybmluZyB9LAogICAgIHsgImZyYWdtZW50
IiwgYmVuY2htYXJrX2ZyYWdtZW50IH0sCiAgICAgeyAiZnJhZ21lbnRfaXRlcmF0ZSIsIGJlbmNo
bWFya19mcmFnbWVudF9pdGVyYXRlIH0sCi0gICAgeyAibWVzc2FnZV9vbmUiLCBiZW5jaG1hcmtf
bWVzc2FnZV9vbmUgfSwKLSAgICB7ICJtZXNzYWdlX21hbnkiLCBiZW5jaG1hcmtfbWVzc2FnZV9t
YW55IH0sCisgICAgeyAibGlzdF9hbGxvY2F0ZSIsIGJlbmNobWFya19saXN0X2FsbG9jYXRlIH0s
CisgICAgeyAibGlzdF90cmF2ZXJzZSIsIGJlbmNobWFya19saXN0X3RyYXZlcnNlIH0sCiAgICAg
eyAibWVkaXVtIiwgYmVuY2htYXJrX21lZGl1bSB9LAotICAgIHsgImJpZyIsIGJlbmNobWFya19i
aWcgfSwKLSAgICB7ICJmYWNlYm9vayIsIGJlbmNobWFya19mYWNlYm9vayB9LAotICAgIHsgImJh
bGxvb24iLCBiZW5jaG1hcmtfYmFsbG9vbiB9LAotICAgIHsgImZsaWNrciIsIGJlbmNobWFya19m
bGlja3IgfSwKKyAgICB7ICJtZXNzYWdlX21hbnkiLCBiZW5jaG1hcmtfbWVzc2FnZV9tYW55IH0s
CisgICAgeyAibWVzc2FnZV9vbmUiLCBiZW5jaG1hcmtfbWVzc2FnZV9vbmUgfSwKICAgICB7ICJy
ZWRkaXQiLCBiZW5jaG1hcmtfcmVkZGl0IH0sCi0gICAgeyAidGhldmVyZ2UiLCBiZW5jaG1hcmtf
dGhldmVyZ2UgfSwKLSAgICB7ICJmbGlja3JfbWVtb3J5X3dhcm5pbmciLCBiZW5jaG1hcmtfZmxp
Y2tyX21lbW9yeV93YXJuaW5nIH0sCiAgICAgeyAicmVkZGl0X21lbW9yeV93YXJuaW5nIiwgYmVu
Y2htYXJrX3JlZGRpdF9tZW1vcnlfd2FybmluZyB9LAorICAgIHsgInN0cmVzcyIsIGJlbmNobWFy
a19zdHJlc3MgfSwKKyAgICB7ICJ0aGV2ZXJnZSIsIGJlbmNobWFya190aGV2ZXJnZSB9LAogICAg
IHsgInRoZXZlcmdlX21lbW9yeV93YXJuaW5nIiwgYmVuY2htYXJrX3RoZXZlcmdlX21lbW9yeV93
YXJuaW5nIH0sCisgICAgeyAidHJlZV9hbGxvY2F0ZSIsIGJlbmNobWFya190cmVlX2FsbG9jYXRl
IH0sCisgICAgeyAidHJlZV9jaHVybiIsIGJlbmNobWFya190cmVlX2NodXJuIH0sCisgICAgeyAi
dHJlZV90cmF2ZXJzZSIsIGJlbmNobWFya190cmVlX3RyYXZlcnNlIH0sCiB9OwogCiBzdGF0aWMg
Y29uc3Qgc2l6ZV90IGJlbmNobWFya3NQYWlyc0NvdW50ID0gc2l6ZW9mKGJlbmNobWFya1BhaXJz
KSAvIHNpemVvZihCZW5jaG1hcmtQYWlyKTsKSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvTWFsbG9j
QmVuY2gvTWFsbG9jQmVuY2gvc3RyZXNzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRl
c3RzL01hbGxvY0JlbmNoL01hbGxvY0JlbmNoL3N0cmVzcy5jcHAJKHJldmlzaW9uIDApCisrKyBQ
ZXJmb3JtYW5jZVRlc3RzL01hbGxvY0JlbmNoL01hbGxvY0JlbmNoL3N0cmVzcy5jcHAJKHdvcmtp
bmcgY29weSkKQEAgLTAsMCArMSwxMzkgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTQgQXBw
bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1
c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZp
Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp
b25zCisgKiBhcmUgbWV0OgorICogMS4gUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11
c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9m
IGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqIDIuIFJlZGlzdHJp
YnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0
CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n
IGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRl
cmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdB
UkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBgYEFTIElTJycgQU5EIEFOWQorICogRVhQUkVT
UyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBU
SEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1Mg
Rk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5U
IFNIQUxMIEFQUExFIElOQy4gT1IKKyAqIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBE
SVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLAorICogRVhFTVBMQVJZLCBPUiBD
T05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICog
UFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0Us
IERBVEEsIE9SCisgKiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIg
Q0FVU0VEIEFORCBPTiBBTlkgVEhFT1JZCisgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09O
VFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5D
RSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0Yg
VEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNI
IERBTUFHRS4gCisgKi8KKworI2luY2x1ZGUgIkJlbmNobWFyay5oIgorI2luY2x1ZGUgIkNQVUNv
dW50LmgiCisjaW5jbHVkZSAic3RyZXNzLmgiCisjaW5jbHVkZSA8YXJyYXk+CisjaW5jbHVkZSA8
Y2hyb25vPgorI2luY2x1ZGUgPGNzdGRsaWI+CisjaW5jbHVkZSA8bWVtb3J5PgorI2luY2x1ZGUg
PHN0ZGRlZi5oPgorI2luY2x1ZGUgPHZlY3Rvcj4KKworI2luY2x1ZGUgIm1ibWFsbG9jLmgiCisK
K3N0YXRpYyBjb25zdCBzaXplX3Qga0IgPSAxMDI0Oworc3RhdGljIGNvbnN0IHNpemVfdCBNQiA9
IGtCICoga0I7CisKK3N0cnVjdCBPYmplY3QgeworICAgIE9iamVjdCh2b2lkKiBwb2ludGVyLCBz
aXplX3Qgc2l6ZSkKKyAgICAgICAgOiBwb2ludGVyKHBvaW50ZXIpCisgICAgICAgICwgc2l6ZShz
aXplKQorICAgIHsKKyAgICB9CisKKyAgICB2b2lkKiBwb2ludGVyOworICAgIHNpemVfdCBzaXpl
OworfTsKKworY2xhc3MgU2l6ZVN0cmVhbSB7CitwdWJsaWM6CisgICAgU2l6ZVN0cmVhbSgpCisg
ICAgICAgIDogbV9zdGF0ZShTbWFsbCkKKyAgICAgICAgLCBtX2NvdW50KDApCisgICAgeworICAg
IH0KKworICAgIHNpemVfdCBuZXh0KCkKKyAgICB7CisgICAgICAgIHN3aXRjaCAobV9zdGF0ZSkg
eworICAgICAgICBjYXNlIFNtYWxsOiB7CisgICAgICAgICAgICBpZiAoKyttX2NvdW50ID09IHNt
YWxsQ291bnQpIHsKKyAgICAgICAgICAgICAgICBtX3N0YXRlID0gTWVkaXVtOworICAgICAgICAg
ICAgICAgIG1fY291bnQgPSAwOworICAgICAgICAgICAgfQorICAgICAgICAgICAgcmV0dXJuIHJh
bmRvbSgpICUgc21hbGxNYXg7CisgICAgICAgIH0KKyAgICAgICAgICAgICAgICAKKyAgICAgICAg
Y2FzZSBNZWRpdW06IHsKKyAgICAgICAgICAgIGlmICgrK21fY291bnQgPT0gbWVkaXVtQ291bnQp
IHsKKyAgICAgICAgICAgICAgICBtX3N0YXRlID0gTGFyZ2U7CisgICAgICAgICAgICAgICAgbV9j
b3VudCA9IDA7CisgICAgICAgICAgICB9CisgICAgICAgICAgICByZXR1cm4gcmFuZG9tKCkgJSBt
ZWRpdW1NYXg7CisgICAgICAgIH0KKyAgICAgICAgICAgICAgICAKKyAgICAgICAgY2FzZSBMYXJn
ZTogeworICAgICAgICAgICAgaWYgKCsrbV9jb3VudCA9PSBsYXJnZUNvdW50KSB7CisgICAgICAg
ICAgICAgICAgbV9zdGF0ZSA9IFNtYWxsOworICAgICAgICAgICAgICAgIG1fY291bnQgPSAwOwor
ICAgICAgICAgICAgfQorICAgICAgICAgICAgcmV0dXJuIHJhbmRvbSgpICUgbGFyZ2VNYXg7Cisg
ICAgICAgIH0KKyAgICAgICAgfQorICAgIH0KKworcHJpdmF0ZToKKyAgICBzdGF0aWMgY29uc3Qg
c2l6ZV90IHNtYWxsQ291bnQgPSAxMDAwOworICAgIHN0YXRpYyBjb25zdCBzaXplX3Qgc21hbGxN
YXggPSAxNiAqIGtCOworCisgICAgc3RhdGljIGNvbnN0IHNpemVfdCBtZWRpdW1Db3VudCA9IDEw
MDsKKyAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IG1lZGl1bU1heCA9IDUxMiAqIGtCOworICAgIAor
ICAgIHN0YXRpYyBjb25zdCBzaXplX3QgbGFyZ2VDb3VudCA9IDEwOworICAgIHN0YXRpYyBjb25z
dCBzaXplX3QgbGFyZ2VNYXggPSA0ICogTUI7CisKKyAgICBlbnVtIHsgU21hbGwsIE1lZGl1bSwg
TGFyZ2UgfSBtX3N0YXRlOworICAgIHNpemVfdCBtX2NvdW50OworfTsKKwordm9pZCBiZW5jaG1h
cmtfc3RyZXNzKGJvb2wgaXNQYXJhbGxlbCkKK3sKKyAgICBjb25zdCBzaXplX3QgaGVhcFNpemUg
PSAxMDAgKiBNQjsKKyAgICBjb25zdCBzaXplX3QgY2h1cm5TaXplID0gLjA1ICogaGVhcFNpemU7
CisgICAgY29uc3Qgc2l6ZV90IGNodXJuQ291bnQgPSAxMDAwMDsKKyAgICAKKyAgICBzcmFuZG9t
KDEpOyAvLyBGb3IgY29uc2lzdGVuY3kgYmV0d2VlbiBydW5zLgorCisgICAgc3RkOjp2ZWN0b3I8
T2JqZWN0PiBvYmplY3RzOworICAgIAorICAgIFNpemVTdHJlYW0gc2l6ZVN0cmVhbTsKKyAgICAK
KyAgICBzaXplX3QgbGFzdFNpemUgPSAwOworICAgIGZvciAoc2l6ZV90IHJlbWFpbmluZyA9IGhl
YXBTaXplOyByZW1haW5pbmc7IHJlbWFpbmluZyAtPSBzdGQ6Om1pbihyZW1haW5pbmcsIGxhc3RT
aXplKSkgeworICAgICAgICBsYXN0U2l6ZSA9IHNpemVTdHJlYW0ubmV4dCgpOworICAgICAgICBP
YmplY3Qgb2JqZWN0KG1ibWFsbG9jKGxhc3RTaXplKSwgbGFzdFNpemUpOworICAgICAgICBvYmpl
Y3RzLnB1c2hfYmFjayhvYmplY3QpOworICAgIH0KKyAgICAKKyAgICBmb3IgKHNpemVfdCBpID0g
MDsgaSA8IGNodXJuQ291bnQ7ICsraSkgeworICAgICAgICBzdGQ6OnZlY3RvcjxPYmplY3Q+IG9i
amVjdHNUb0ZyZWU7CisgICAgICAgIGZvciAoc2l6ZV90IHJlbWFpbmluZyA9IGNodXJuU2l6ZTsg
cmVtYWluaW5nOyByZW1haW5pbmcgLT0gc3RkOjptaW4ocmVtYWluaW5nLCBsYXN0U2l6ZSkpIHsK
KyAgICAgICAgICAgIGxhc3RTaXplID0gc2l6ZVN0cmVhbS5uZXh0KCk7CisgICAgICAgICAgICBP
YmplY3Qgb2JqZWN0KG1ibWFsbG9jKGxhc3RTaXplKSwgbGFzdFNpemUpOworCisgICAgICAgICAg
ICBzaXplX3QgaW5kZXggPSByYW5kb20oKSAlIG9iamVjdHMuc2l6ZSgpOworICAgICAgICAgICAg
b2JqZWN0c1RvRnJlZS5wdXNoX2JhY2sob2JqZWN0c1tpbmRleF0pOworICAgICAgICAgICAgb2Jq
ZWN0c1tpbmRleF0gPSBvYmplY3Q7CisgICAgICAgIH0KKworICAgICAgICBmb3IgKGF1dG8mIG9i
amVjdCA6IG9iamVjdHNUb0ZyZWUpCisgICAgICAgICAgICBtYmZyZWUob2JqZWN0LnBvaW50ZXIs
IG9iamVjdC5zaXplKTsKKyAgICB9CisgICAgCisgICAgZm9yIChhdXRvJiBvYmplY3QgOiBvYmpl
Y3RzKQorICAgICAgICBtYmZyZWUob2JqZWN0LnBvaW50ZXIsIG9iamVjdC5zaXplKTsKK30KSW5k
ZXg6IFBlcmZvcm1hbmNlVGVzdHMvTWFsbG9jQmVuY2gvTWFsbG9jQmVuY2gvc3RyZXNzLmgKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5jaC9NYWxsb2NCZW5jaC9zdHJl
c3MuaAkocmV2aXNpb24gMCkKKysrIFBlcmZvcm1hbmNlVGVzdHMvTWFsbG9jQmVuY2gvTWFsbG9j
QmVuY2gvc3RyZXNzLmgJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzMSBAQAorLyoKKyAqIENv
cHlyaWdodCAoQykgMjAxNCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICog
UmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBv
ciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0
aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlv
bnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAg
bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp
bWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNl
IHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlv
bnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRp
b24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24u
CisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIGBgQVMgSVMn
JyBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBC
VVQgTk9UIExJTUlURUQgVE8sIFRIRQorICogSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5U
QUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVND
TEFJTUVELiAgSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUgorICogQ09OVFJJQlVUT1JT
IEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUws
CisgKiBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQg
Tk9UIExJTUlURUQgVE8sCisgKiBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNF
UlZJQ0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IKKyAqIFBST0ZJVFM7IE9SIEJVU0lORVNTIElO
VEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKKyAqIE9GIExJQUJJ
TElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICog
KElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9V
VCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF
IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLiAKKyAqLworCisjaWZuZGVmIHN0cmVzc19oCisj
ZGVmaW5lIHN0cmVzc19oCisKK3ZvaWQgYmVuY2htYXJrX3N0cmVzcyhib29sIGlzUGFyYWxsZWwp
OworCisjZW5kaWYgLy8gc3RyZXNzX2gK
</data>
<flag name="review"
          id="262257"
          type_id="1"
          status="+"
          setter="kling"
    />
          </attachment>
      

    </bug>

</bugzilla>