136464 2014-09-02 14:20:00 -0700 Fix an assertion sometimes seen under RenderLayerCompositor::detachRootLayer() 2014-09-02 14:26:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1032737 0 simon.fraser 2014-09-02 14:20:00 -0700 Fix an assertion sometimes seen under RenderLayerCompositor::detachRootLayer() 1032739 1 237514 simon.fraser 2014-09-02 14:20:54 -0700 Created attachment 237514 Patch 1032740 2 237514 thorton 2014-09-02 14:22:27 -0700 Comment on attachment 237514 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237514&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:3451 > + if (RenderLayerBacking* backing = layer ? layer->backing() : 0) nullptr What makes us sure layout is up to date now? 1032742 3 simon.fraser 2014-09-02 14:26:02 -0700 http://trac.webkit.org/changeset/173186 237514 2014-09-02 14:20:54 -0700 2014-09-02 14:22:26 -0700 Patch bug-136464-20140902142048.patch text/plain 2713 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGY4NmU5NWM4YTBjMGJm YTc3MjdiNWZhMmM2ZjFlN2NkMDg5NmM0OS4uMTlmOGI5ZTI4MDNkYjc4MzA2YmNhMjdlNGZhNDA3 MTRmY2JhZjQ3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA5LTAyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIEZpeCBhbiBhc3Nl cnRpb24gc29tZXRpbWVzIHNlZW4gdW5kZXIgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpkZXRhY2hS b290TGF5ZXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM2NDY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRG9uJ3QgdHJ5IHRvIGNhbGwgUmVuZGVyTGF5ZXI6OmlzVmlzdWFsbHlOb25FbXB0eSgpIHVu ZGVyIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZGV0YWNoUm9vdExheWVyKCkKKyAgICAgICAgd2hl biBsYXlvdXQgbWlnaHQgYmUgc3RhbGU7IHRoZXJlJ3Mgbm90IHBvaW50IHRyeWluZyB0byB1cGRh dGUgdGhlIGJhY2tpbmcgc3RvcmUgc3RhdGUKKyAgICAgICAgd2hlbiBkZXRhY2hpbmcsIG9ubHkg d2hlbiBhdHRhY2hpbmcuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6cm9vdExh eWVyQXR0YWNobWVudENoYW5nZWQpOgorCisyMDE0LTA5LTAyICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIEF2b2lkIGJhY2tpbmcgc3RvcmUgYWxsb2Nh dGlvbiB3aXRoIHNvbWUgY29tYmluYXRpb25zIG9mIHJlcGxhY2VkIGVsZW1lbnRzLCBtYXNraW5n IGFuZCB2aXNpYmlsaXR5OmhpZGRlbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM2NDAwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggNTY3YzM2NjlhMzA3NDRhYTgxZDQ5YjQw MzhkN2FhYjY0NWI3MDM5NC4uY2Y3ZTBiMDMxNTc5MTI1NjA1OGFiYjhkYWJmNTViYTAxMjczYWY5 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9z aXRvci5jcHAKQEAgLTM0MzQsMTIgKzM0MzQsNiBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRv cjo6dXBkYXRlUm9vdExheWVyQXR0YWNobWVudCgpCiAKIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3Np dG9yOjpyb290TGF5ZXJBdHRhY2htZW50Q2hhbmdlZCgpCiB7Ci0gICAgLy8gVGhlIGF0dGFjaG1l bnQgY2FuIGFmZmVjdCB3aGV0aGVyIHRoZSBSZW5kZXJWaWV3IGxheWVyJ3MgcGFpbnRzSW50b1dp bmRvdygpIGJlaGF2aW9yLAotICAgIC8vIHNvIGNhbGwgdXBkYXRlRHJhd3NDb250ZW50KCkgdG8g dXBkYXRlIHRoYXQuCi0gICAgUmVuZGVyTGF5ZXIqIGxheWVyID0gbV9yZW5kZXJWaWV3LmxheWVy KCk7Ci0gICAgaWYgKFJlbmRlckxheWVyQmFja2luZyogYmFja2luZyA9IGxheWVyID8gbGF5ZXIt PmJhY2tpbmcoKSA6IDApCi0gICAgICAgIGJhY2tpbmctPnVwZGF0ZURyYXdzQ29udGVudCgpOwot CiAgICAgLy8gVGhlIGRvY3VtZW50LXJlbGF0aXZlIHBhZ2Ugb3ZlcmxheSBsYXllciAod2hpY2gg aXMgcGlubmVkIHRvIHRoZSBtYWluIGZyYW1lJ3MgbGF5ZXIgdHJlZSkKICAgICAvLyBpcyBtb3Zl ZCBiZXR3ZWVuIGRpZmZlcmVudCBSZW5kZXJMYXllckNvbXBvc2l0b3JzJyBsYXllciB0cmVlcywg YW5kIG5lZWRzIHRvIGJlCiAgICAgLy8gcmVhdHRhY2hlZCB3aGVuZXZlciB3ZSBzd2FwIGluIGEg bmV3IFJlbmRlckxheWVyQ29tcG9zaXRvci4KQEAgLTM0NTEsNiArMzQ0NSwxMiBAQCB2b2lkIFJl bmRlckxheWVyQ29tcG9zaXRvcjo6cm9vdExheWVyQXR0YWNobWVudENoYW5nZWQoKQogICAgIGlm ICghcGFnZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgLy8gVGhlIGF0dGFjaG1lbnQgY2FuIGFm ZmVjdCB3aGV0aGVyIHRoZSBSZW5kZXJWaWV3IGxheWVyJ3MgcGFpbnRzSW50b1dpbmRvdygpIGJl aGF2aW9yLAorICAgIC8vIHNvIGNhbGwgdXBkYXRlRHJhd3NDb250ZW50KCkgdG8gdXBkYXRlIHRo YXQuCisgICAgUmVuZGVyTGF5ZXIqIGxheWVyID0gbV9yZW5kZXJWaWV3LmxheWVyKCk7CisgICAg aWYgKFJlbmRlckxheWVyQmFja2luZyogYmFja2luZyA9IGxheWVyID8gbGF5ZXItPmJhY2tpbmco KSA6IDApCisgICAgICAgIGJhY2tpbmctPnVwZGF0ZURyYXdzQ29udGVudCgpOworCiAgICAgaWYg KEdyYXBoaWNzTGF5ZXIqIG92ZXJsYXlMYXllciA9IHBhZ2UtPmNocm9tZSgpLmNsaWVudCgpLmRv Y3VtZW50T3ZlcmxheUxheWVyRm9yRnJhbWUoZnJhbWUpKQogICAgICAgICBtX3Jvb3RDb250ZW50 TGF5ZXItPmFkZENoaWxkKG92ZXJsYXlMYXllcik7CiB9Cg==