136444 2014-09-01 21:06:12 -0700 CommitLayerTree decode fails in 32-bit apps on 64-bit devices (TransformationMatrix alignment differs) 2014-09-25 12:31:40 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca benjamin mitz sam simon.fraser oldest_to_newest 1032562 0 thorton 2014-09-01 21:06:12 -0700 For PLATFORM(IOS), 32-bit apps launch 64-bit Web processes. alignof(TransformationMatrix) = 8 in the 64-bit Web process, but it's 4 in the app. TransformationMatrix is encoded using SimpleArgumentCoder. SimpleArgumentCoder respects alignment when copying into the IPC message buffer (Sam says this is important but I don't really understand; Sam or Anders, if you want to clarify that would be cool!). This means that the message decode fails, and the UI process kills the Web process, whenever you have a TransformationMatrix in a message, which happens a lot with UI-Side Compositing. rdar://problem/17952526 1032563 1 thorton 2014-09-01 21:08:42 -0700 Various potential fixes: 1. Don't use a SimpleArgumentCoder here; manually encode/decode the 16 doubles. 2. Force the alignment of TransformationMatrix to be the same everywhere (we already force it to 16 byte alignment on some platforms). 3. Don't copy into the message buffer respecting alignment (it sounds like this is a nonstarter). Going to post a patch for #1, but we can discuss alternatives. Also going to check if AffineTransform is also affected. 1032564 2 237475 thorton 2014-09-01 21:13:29 -0700 Created attachment 237475 patch 1032568 3 237475 simon.fraser 2014-09-01 22:03:15 -0700 Comment on attachment 237475 patch :( 1037269 4 thorton 2014-09-25 12:31:40 -0700 http://trac.webkit.org/changeset/173973 237475 2014-09-01 21:13:29 -0700 2014-09-02 10:08:36 -0700 patch transformationmatrix.diff text/plain 3904 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzZDY4ODVkLi41Yjc4YmU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDktMDEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgQ29tbWl0TGF5ZXJUcmVlIGRlY29kZSBmYWlscyBpbiAzMi1iaXQgYXBwcyBvbiA2 NC1iaXQgZGV2aWNlcyAoVHJhbnNmb3JtYXRpb25NYXRyaXggYWxpZ25tZW50IGRpZmZlcnMpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY0NDQKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3OTUyNTI2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5j cHA6CisgICAgICAgIChJUEM6OkFyZ3VtZW50Q29kZXI8VHJhbnNmb3JtYXRpb25NYXRyaXg+Ojpl bmNvZGUpOgorICAgICAgICAoSVBDOjpBcmd1bWVudENvZGVyPFRyYW5zZm9ybWF0aW9uTWF0cml4 Pjo6ZGVjb2RlKToKKyAgICAgICAgU3RvcCB1c2luZyBTaW1wbGVBcmd1bWVudENvZGVyIHRvIGVu Y29kZS9kZWNvZGUgVHJhbnNmb3JtYXRpb25NYXRyaXgsCisgICAgICAgIGJlY2F1c2UgdGhlIGFs aWdubWVudCBvZiBUcmFuc2Zvcm1hdGlvbk1hdHJpeCBkaWZmZXJzIGJldHdlZW4gYXJjaGl0ZWN0 dXJlcywKKyAgICAgICAgYW5kIHRoZXJlJ3Mgbm8gZ3VhcmFudGVlIHRoYXQgYm90aCBzaWRlcyBv ZiBhIGNvbm5lY3Rpb24gYXJlIHRoZSBzYW1lIGFyY2hpdGVjdHVyZS4KKwogMjAxNC0wOS0wMSAg Unl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAZ21haWwuY29tPgogCiAgICAgICAgIEJ1aWxkIGJyZWFr IG9uIHRoZSBFRkwgcG9ydCBzaW5jZSByMTczMTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCmluZGV4IDM1OTkyZTUuLjcwZWI1MjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCkBAIC05 OCwxMiArOTgsODMgQEAgYm9vbCBBcmd1bWVudENvZGVyPEFmZmluZVRyYW5zZm9ybT46OmRlY29k ZShBcmd1bWVudERlY29kZXImIGRlY29kZXIsIEFmZmluZVRyYW4KIAogdm9pZCBBcmd1bWVudENv ZGVyPFRyYW5zZm9ybWF0aW9uTWF0cml4Pjo6ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYgZW5jb2Rl ciwgY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIHRyYW5zZm9ybWF0aW9uTWF0cml4KQogewot ICAgIFNpbXBsZUFyZ3VtZW50Q29kZXI8VHJhbnNmb3JtYXRpb25NYXRyaXg+OjplbmNvZGUoZW5j b2RlciwgdHJhbnNmb3JtYXRpb25NYXRyaXgpOworICAgIGVuY29kZXIgPDwgdHJhbnNmb3JtYXRp b25NYXRyaXgubTExKCk7CisgICAgZW5jb2RlciA8PCB0cmFuc2Zvcm1hdGlvbk1hdHJpeC5tMTIo KTsKKyAgICBlbmNvZGVyIDw8IHRyYW5zZm9ybWF0aW9uTWF0cml4Lm0xMygpOworICAgIGVuY29k ZXIgPDwgdHJhbnNmb3JtYXRpb25NYXRyaXgubTE0KCk7CisKKyAgICBlbmNvZGVyIDw8IHRyYW5z Zm9ybWF0aW9uTWF0cml4Lm0yMSgpOworICAgIGVuY29kZXIgPDwgdHJhbnNmb3JtYXRpb25NYXRy aXgubTIyKCk7CisgICAgZW5jb2RlciA8PCB0cmFuc2Zvcm1hdGlvbk1hdHJpeC5tMjMoKTsKKyAg ICBlbmNvZGVyIDw8IHRyYW5zZm9ybWF0aW9uTWF0cml4Lm0yNCgpOworCisgICAgZW5jb2RlciA8 PCB0cmFuc2Zvcm1hdGlvbk1hdHJpeC5tMzEoKTsKKyAgICBlbmNvZGVyIDw8IHRyYW5zZm9ybWF0 aW9uTWF0cml4Lm0zMigpOworICAgIGVuY29kZXIgPDwgdHJhbnNmb3JtYXRpb25NYXRyaXgubTMz KCk7CisgICAgZW5jb2RlciA8PCB0cmFuc2Zvcm1hdGlvbk1hdHJpeC5tMzQoKTsKKworICAgIGVu Y29kZXIgPDwgdHJhbnNmb3JtYXRpb25NYXRyaXgubTQxKCk7CisgICAgZW5jb2RlciA8PCB0cmFu c2Zvcm1hdGlvbk1hdHJpeC5tNDIoKTsKKyAgICBlbmNvZGVyIDw8IHRyYW5zZm9ybWF0aW9uTWF0 cml4Lm00MygpOworICAgIGVuY29kZXIgPDwgdHJhbnNmb3JtYXRpb25NYXRyaXgubTQ0KCk7CiB9 CiAKIGJvb2wgQXJndW1lbnRDb2RlcjxUcmFuc2Zvcm1hdGlvbk1hdHJpeD46OmRlY29kZShBcmd1 bWVudERlY29kZXImIGRlY29kZXIsIFRyYW5zZm9ybWF0aW9uTWF0cml4JiB0cmFuc2Zvcm1hdGlv bk1hdHJpeCkKIHsKLSAgICByZXR1cm4gU2ltcGxlQXJndW1lbnRDb2RlcjxUcmFuc2Zvcm1hdGlv bk1hdHJpeD46OmRlY29kZShkZWNvZGVyLCB0cmFuc2Zvcm1hdGlvbk1hdHJpeCk7CisgICAgZG91 YmxlIG0xMTsKKyAgICBpZiAoIWRlY29kZXIuZGVjb2RlKG0xMSkpCisgICAgICAgIHJldHVybiBm YWxzZTsKKyAgICBkb3VibGUgbTEyOworICAgIGlmICghZGVjb2Rlci5kZWNvZGUobTEyKSkKKyAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgIGRvdWJsZSBtMTM7CisgICAgaWYgKCFkZWNvZGVyLmRl Y29kZShtMTMpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgZG91YmxlIG0xNDsKKyAgICBp ZiAoIWRlY29kZXIuZGVjb2RlKG0xNCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGRv dWJsZSBtMjE7CisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShtMjEpKQorICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgZG91YmxlIG0yMjsKKyAgICBpZiAoIWRlY29kZXIuZGVjb2RlKG0yMikpCisg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBkb3VibGUgbTIzOworICAgIGlmICghZGVjb2Rlci5k ZWNvZGUobTIzKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGRvdWJsZSBtMjQ7CisgICAg aWYgKCFkZWNvZGVyLmRlY29kZShtMjQpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBk b3VibGUgbTMxOworICAgIGlmICghZGVjb2Rlci5kZWNvZGUobTMxKSkKKyAgICAgICAgcmV0dXJu IGZhbHNlOworICAgIGRvdWJsZSBtMzI7CisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShtMzIpKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgZG91YmxlIG0zMzsKKyAgICBpZiAoIWRlY29kZXIu ZGVjb2RlKG0zMykpCisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBkb3VibGUgbTM0OworICAg IGlmICghZGVjb2Rlci5kZWNvZGUobTM0KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAg ZG91YmxlIG00MTsKKyAgICBpZiAoIWRlY29kZXIuZGVjb2RlKG00MSkpCisgICAgICAgIHJldHVy biBmYWxzZTsKKyAgICBkb3VibGUgbTQyOworICAgIGlmICghZGVjb2Rlci5kZWNvZGUobTQyKSkK KyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGRvdWJsZSBtNDM7CisgICAgaWYgKCFkZWNvZGVy LmRlY29kZShtNDMpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgZG91YmxlIG00NDsKKyAg ICBpZiAoIWRlY29kZXIuZGVjb2RlKG00NCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAg IHRyYW5zZm9ybWF0aW9uTWF0cml4LnNldE1hdHJpeChtMTEsIG0xMiwgbTEzLCBtMTQsIG0yMSwg bTIyLCBtMjMsIG0yNCwgbTMxLCBtMzIsIG0zMywgbTM0LCBtNDEsIG00MiwgbTQzLCBtNDQpOwor ICAgIHJldHVybiB0cnVlOwogfQogCiB2b2lkIEFyZ3VtZW50Q29kZXI8TGluZWFyVGltaW5nRnVu Y3Rpb24+OjplbmNvZGUoQXJndW1lbnRFbmNvZGVyJiBlbmNvZGVyLCBjb25zdCBMaW5lYXJUaW1p bmdGdW5jdGlvbiYgdGltaW5nRnVuY3Rpb24pCg==