136442 2014-09-01 18:08:53 -0700 check-webkit-style is confused by ternary expression inside first member initializer 2014-12-03 05:31:38 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 burg webkit-unassigned commit-queue glenn llango.u-szeged ossy rnagy oldest_to_newest 1032552 0 burg 2014-09-01 18:08:53 -0700 Test case: ProfileGenerator::ProfileGenerator(ExecState* exec, const String&, unsigned) : m_origin(exec ? exec->lexicalGlobalObject() : nullptr) , m_profileGroup(exec ? exec->lexicalGlobalObject()->profileGroup() : 0) , m_foundConsoleStartParent(false) { } 1034091 1 237844 rnagy 2014-09-09 01:48:22 -0700 Created attachment 237844 Proposed patch 1034097 2 237845 rnagy 2014-09-09 02:27:33 -0700 Created attachment 237845 Proposed patch Fix missing unittests. 1052130 3 237845 commit-queue 2014-12-03 05:31:34 -0800 Comment on attachment 237845 Proposed patch Clearing flags on attachment: 237845 Committed r176718: <http://trac.webkit.org/changeset/176718> 1052131 4 commit-queue 2014-12-03 05:31:38 -0800 All reviewed patches have been landed. Closing bug. 237844 2014-09-09 01:48:22 -0700 2014-09-09 02:27:33 -0700 Proposed patch 0001-check-webkit-style-is-confused-by-ternary-expression.patch text/plain 1806 rnagy RnJvbSBiZGQ2N2RjNzM4YWNlZWRlNDY0Nzg0YmUyNWIxNTQyOGNmODUwMzQ2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZW5hdG8gTmFneSA8bmFneS5yZW5hdG9Ac3R1ZC51LXN6ZWdl ZC5odT4KRGF0ZTogVHVlLCA5IFNlcCAyMDE0IDEwOjQ1OjAxICswMjAwClN1YmplY3Q6IFtQQVRD SF0gY2hlY2std2Via2l0LXN0eWxlIGlzIGNvbmZ1c2VkIGJ5IHRlcm5hcnkgZXhwcmVzc2lvbiBp bnNpZGUKIGZpcnN0IG1lbWJlciBpbml0aWFsaXplcgoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEwICsrKysrKysrKysKIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IHwgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwg MTEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5n ZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxOGQ5NTQ4Li42ZWIxYjhiIDEwMDY0NAotLS0g YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTQtMDktMDkgIFJlbmF0byBOYWd5ICA8cm5hZ3lAaW5mLnUtc3plZ2VkLmh1PgorCisgICAg ICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBpcyBjb25mdXNlZCBieSB0ZXJuYXJ5IGV4cHJlc3Npb24g aW5zaWRlIGZpcnN0IG1lbWJlciBpbml0aWFsaXplcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NDQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weToKKyAgICAgICAgKGNoZWNrX21lbWJlcl9pbml0aWFsaXphdGlvbl9saXN0KToKKwog MjAxNC0wOS0wMyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBbV2luXSBVbnJldmlld2VkIHRlc3QgZml4LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCAwZTE1ODhmLi5mMzhkYTdhIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjA0Myw3ICsyMDQzLDcg QEAgZGVmIGNoZWNrX21lbWJlcl9pbml0aWFsaXphdGlvbl9saXN0KGNsZWFuX2xpbmVzLCBsaW5l X251bWJlciwgZXJyb3IpOgogICAgICAgICBpZiBzZWFyY2gocidbXjpdXDpbXlw6XHNdKycsIGxp bmUpOgogICAgICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2luaXQnLCA0 LAogICAgICAgICAgICAgICAgICdNaXNzaW5nIHNwYWNlcyBhcm91bmQgOicpCi0gICAgICAgIGlm IHNlYXJjaChyJ1teXHNdXCguKlwpXHM/XDouKlteO10qJCcsIGxpbmUpOgorICAgICAgICBpZiAo bm90IGxpbmUubHN0cmlwKCkuc3RhcnRzd2l0aCgnOicpKSBhbmQgc2VhcmNoKHInW15cc11cKC4q XClccz9cOi4qW147XSokJywgbGluZSk6CiAgICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwg J3doaXRlc3BhY2UvaW5kZW50JywgNCwKICAgICAgICAgICAgICAgICAnU2hvdWxkIGJlIGluZGVu dGVkIG9uIGEgc2VwYXJhdGUgbGluZSwgd2l0aCB0aGUgY29sb24gb3IgY29tbWEgZmlyc3Qgb24g dGhhdCBsaW5lLicpCiAgICAgICAgIGVsc2U6Ci0tIAoxLjkuMQoK 237845 2014-09-09 02:27:33 -0700 2014-12-03 05:31:34 -0800 Proposed patch 0001-check-webkit-style-is-confused-by-ternary-expression.patch text/plain 2795 rnagy RnJvbSAwNWNkMTcyNmQ1NmVkNGIwMWY5Zjk5NzNmZGI1MGNmNzQ0YWE3YmZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZW5hdG8gTmFneSA8bmFneS5yZW5hdG9Ac3R1ZC51LXN6ZWdl ZC5odT4KRGF0ZTogVHVlLCA5IFNlcCAyMDE0IDExOjIyOjQ0ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gY2hlY2std2Via2l0LXN0eWxlIGlzIGNvbmZ1c2VkIGJ5IHRlcm5hcnkgZXhwcmVzc2lvbiBp bnNpZGUKIGZpcnN0IG1lbWJlciBpbml0aWFsaXplcgoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEwICsrKysrKysrKysKIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5ICAgICAgICAgIHwgIDIgKy0K IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IHwg IDYgKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24o LSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXgg MThkOTU0OC4uNmViMWI4YiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA5LTA5ICBSZW5hdG8gTmFneSAgPHJu YWd5QGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgaXMgY29u ZnVzZWQgYnkgdGVybmFyeSBleHByZXNzaW9uIGluc2lkZSBmaXJzdCBtZW1iZXIgaW5pdGlhbGl6 ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjQ0 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6CisgICAgICAgIChjaGVja19tZW1i ZXJfaW5pdGlhbGl6YXRpb25fbGlzdCk6CisKIDIwMTQtMDktMDMgIEJyZW50IEZ1bGdoYW0gIDxi ZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gVW5yZXZpZXdlZCB0ZXN0IGZpeC4K ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggMGUx NTg4Zi4uZjM4ZGE3YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHAucHkKQEAgLTIwNDMsNyArMjA0Myw3IEBAIGRlZiBjaGVja19tZW1iZXJfaW5pdGlhbGl6 YXRpb25fbGlzdChjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKToKICAgICAgICAgaWYg c2VhcmNoKHInW146XVw6W15cOlxzXSsnLCBsaW5lKToKICAgICAgICAgICAgIGVycm9yKGxpbmVf bnVtYmVyLCAnd2hpdGVzcGFjZS9pbml0JywgNCwKICAgICAgICAgICAgICAgICAnTWlzc2luZyBz cGFjZXMgYXJvdW5kIDonKQotICAgICAgICBpZiBzZWFyY2gocidbXlxzXVwoLipcKVxzP1w6Lipb XjtdKiQnLCBsaW5lKToKKyAgICAgICAgaWYgKG5vdCBsaW5lLmxzdHJpcCgpLnN0YXJ0c3dpdGgo JzonKSkgYW5kIHNlYXJjaChyJ1teXHNdXCguKlwpXHM/XDouKlteO10qJCcsIGxpbmUpOgogICAg ICAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2luZGVudCcsIDQsCiAgICAg ICAgICAgICAgICAgJ1Nob3VsZCBiZSBpbmRlbnRlZCBvbiBhIHNlcGFyYXRlIGxpbmUsIHdpdGgg dGhlIGNvbG9uIG9yIGNvbW1hIGZpcnN0IG9uIHRoYXQgbGluZS4nKQogICAgICAgICBlbHNlOgpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weQppbmRleCAyMmFlNDY4Li41OTE2ZjYxIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAtNTA4Nyw2ICs1 MDg3LDEyIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnTXlDbGFzczo6TXlDbGFzcyhEb2N1bWVudCogZG9jKSA6IE15 U3VwZXJDbGFzcygpIHsgfScsCiAgICAgICAgICdTaG91bGQgYmUgaW5kZW50ZWQgb24gYSBzZXBh cmF0ZSBsaW5lLCB3aXRoIHRoZSBjb2xvbiBvciBjb21tYSBmaXJzdCBvbiB0aGF0IGxpbmUuJwog ICAgICAgICAnICBbd2hpdGVzcGFjZS9pbmRlbnRdIFs0XScpCisgICAgICAgIHNlbGYuYXNzZXJ0 X211bHRpX2xpbmVfbGludCgoCisgICAgICAgICAgICAnTXlDbGFzczo6TXlDbGFzcyhEb2N1bWVu dCogZG9jKVxuJworICAgICAgICAgICAgJyAgICA6IG1fbXlNZW1iZXIoYiA/IGJhcigpIDogYmF6 KCkpXG4nCisgICAgICAgICAgICAnICAgICwgTXlTdXBlckNsYXNzKClcbicKKyAgICAgICAgICAg ICcgICAgLCBtX2RvYygwKVxuJworICAgICAgICAgICAgJ3sgfScpLCAnJykKICAgICAgICAgc2Vs Zi5hc3NlcnRfbXVsdGlfbGluZV9saW50KCcnJ1wKICAgICAgICAgTXlDbGFzczo6TXlDbGFzcyhE b2N1bWVudCogZG9jKSA6IE15U3VwZXJDbGFzcygpCiAgICAgICAgIHsgfScnJywKLS0gCjEuOS4x Cgo=