136438 2014-09-01 15:41:01 -0700 Make DrawingArea a real MessageReceiver 2014-09-09 08:58:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca commit-queue mitz mkwst simon.fraser oldest_to_newest 1032536 0 thorton 2014-09-01 15:41:01 -0700 Make DrawingArea a real MessageReceiver 1032537 1 237466 thorton 2014-09-01 15:41:38 -0700 Created attachment 237466 Patch 1033167 2 237466 darin 2014-09-04 01:23:43 -0700 Comment on attachment 237466 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review > Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61 > +class DrawingArea : public IPC::MessageReceiver { Can this derive privately instead of publicly? Just wondering. 1033168 3 237466 darin 2014-09-04 01:24:14 -0700 Comment on attachment 237466 Patch Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose. 1034116 4 thorton 2014-09-09 08:34:36 -0700 (In reply to comment #3) > (From update of attachment 237466 [details]) > Not sure why this breaks the EFL build. The EWS output doesn’t contain enough context for me to diagnose. It's one of these: c++: internal compiler error: Killed (program cc1plus) which tend (usually) not to be the patch's fault. 1034117 5 thorton 2014-09-09 08:49:19 -0700 (In reply to comment #2) > (From update of attachment 237466 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237466&action=review > > > Source/WebKit2/WebProcess/WebPage/DrawingArea.h:61 > > +class DrawingArea : public IPC::MessageReceiver { > > Can this derive privately instead of publicly? Just wondering. I don't think so, because MessageReceiverMap and friends need to be able to call the MessageReceiver functions. In any case, there's no precedent. 1034118 6 thorton 2014-09-09 08:58:29 -0700 http://trac.webkit.org/changeset/173429 237466 2014-09-01 15:41:38 -0700 2014-09-04 01:24:14 -0700 Patch bug-136438-20140901154132.patch text/plain 6954 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWQxOTgyZjEzNDljZmNj YTdmNTZmOTAwY2UzODMyZmU2M2NhN2VmMS4uNGU2ZDlmMGZkZjAwMDlmNWExODQ4NDc0MzA2YWUy ZDVkZDBhMzM1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA5LTAxICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgRHJhd2lu Z0FyZWEgYSByZWFsIE1lc3NhZ2VSZWNlaXZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NDM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuY3Bw OgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJlYTo6RHJhd2luZ0FyZWEpOgorICAgICAgICAo V2ViS2l0OjpEcmF3aW5nQXJlYTo6fkRyYXdpbmdBcmVhKToKKyAgICAgICAgKiBXZWJQcm9jZXNz L1dlYlBhZ2UvRHJhd2luZ0FyZWEuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJh d2luZ0FyZWEubWVzc2FnZXMuaW46CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpXZWJQYWdlKToKKyAgICAgICAgKFdl YktpdDo6V2ViUGFnZTo6fldlYlBhZ2UpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpkaWRS ZWNlaXZlTWVzc2FnZSk6CisgICAgICAgIE1ha2UgRHJhd2luZ0FyZWEgYSByZWFsIE1lc3NhZ2VS ZWNlaXZlciBpbnN0ZWFkIG9mIGEgTGVnYWN5UmVjZWl2ZXIgdGhhdAorICAgICAgICBqdW1wcyB0 aHJvdWdoIFdlYlBhZ2UgdG8gcmVjZWl2ZSBpdHMgbWVzc2FnZXMuCisKIDIwMTQtMDktMDEgIEd5 dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQ01BS0Vd IEJ1aWxkIHdhcm5pbmcgYnkgSU5URVJGQUNFX0xJTktfTElCUkFSSUVTCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuY3BwIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhLmNwcAppbmRleCA0MTQ2M2I5 OTE0ZGJhN2M2NmFiNmRiNDgzMTc0NjQxZGNiMTUwZmEyLi42ZWNkNzI2MDdlMGFmNTRiODVhZTky MTgxOGFkM2Y0OWY3YjhjN2M2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvRHJhd2luZ0FyZWEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9EcmF3aW5nQXJlYS5jcHAKQEAgLTI1LDYgKzI1LDExIEBACiAKICNpbmNsdWRlICJj b25maWcuaCIKICNpbmNsdWRlICJEcmF3aW5nQXJlYS5oIgorCisjaW5jbHVkZSAiRHJhd2luZ0Fy ZWFNZXNzYWdlcy5oIgorI2luY2x1ZGUgIldlYlBhZ2UuaCIKKyNpbmNsdWRlICJXZWJQYWdlQ3Jl YXRpb25QYXJhbWV0ZXJzLmgiCisjaW5jbHVkZSAiV2ViUHJvY2Vzcy5oIgogI2luY2x1ZGUgPFdl YkNvcmUvRGlzcGxheVJlZnJlc2hNb25pdG9yLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9UcmFuc2Zv cm1hdGlvbk1hdHJpeC5oPgogI2luY2x1ZGUgPHd0Zi9GdW5jdGlvbmFsLmg+CkBAIC00MSw4ICs0 Niw2IEBACiAjZW5kaWYKICNlbmRpZgogCi0jaW5jbHVkZSAiV2ViUGFnZUNyZWF0aW9uUGFyYW1l dGVycy5oIgotCiB1c2luZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7 CkBAIC03NSwxMCArNzgsMTIgQEAgRHJhd2luZ0FyZWE6OkRyYXdpbmdBcmVhKERyYXdpbmdBcmVh VHlwZSB0eXBlLCBXZWJQYWdlJiB3ZWJQYWdlKQogICAgIDogbV90eXBlKHR5cGUpCiAgICAgLCBt X3dlYlBhZ2Uod2ViUGFnZSkKIHsKKyAgICBXZWJQcm9jZXNzOjpzaGFyZWQoKS5hZGRNZXNzYWdl UmVjZWl2ZXIoTWVzc2FnZXM6OkRyYXdpbmdBcmVhOjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIG1f d2ViUGFnZS5wYWdlSUQoKSwgKnRoaXMpOwogfQogCiBEcmF3aW5nQXJlYTo6fkRyYXdpbmdBcmVh KCkKIHsKKyAgICBXZWJQcm9jZXNzOjpzaGFyZWQoKS5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIoTWVz c2FnZXM6OkRyYXdpbmdBcmVhOjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIG1fd2ViUGFnZS5wYWdl SUQoKSk7CiB9CiAKIHZvaWQgRHJhd2luZ0FyZWE6OmRpc3BhdGNoQWZ0ZXJFbnN1cmluZ1VwZGF0 ZWRTY3JvbGxQb3NpdGlvbihzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGZ1bmN0aW9uKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhLmggYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuaAppbmRleCA3OTgy MTMzNDg2NDA2OTY2YjExYWM4MDU2MDI1YmFkZjQyNDVkNDIyLi5mNzRiNGRlM2FjMTEyN2Y4ZjE4 ZTM2NmVmMGIxNWI5OWY5MzUxYTkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvRHJhd2luZ0FyZWEuaApAQCAtMjgsNiArMjgsNyBAQAogCiAjaW5jbHVkZSAiRHJh d2luZ0FyZWFJbmZvLmgiCiAjaW5jbHVkZSAiTGF5ZXJUcmVlQ29udGV4dC5oIgorI2luY2x1ZGUg Ik1lc3NhZ2VSZWNlaXZlci5oIgogI2luY2x1ZGUgPFdlYkNvcmUvRmxvYXRSZWN0Lmg+CiAjaW5j bHVkZSA8V2ViQ29yZS9JbnRSZWN0Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9MYXllckZsdXNoVGhy b3R0bGVTdGF0ZS5oPgpAQCAtNTcsNyArNTgsNyBAQCBjbGFzcyBXZWJQYWdlOwogc3RydWN0IFdl YlBhZ2VDcmVhdGlvblBhcmFtZXRlcnM7CiBzdHJ1Y3QgV2ViUHJlZmVyZW5jZXNTdG9yZTsKIAot Y2xhc3MgRHJhd2luZ0FyZWEgeworY2xhc3MgRHJhd2luZ0FyZWEgOiBwdWJsaWMgSVBDOjpNZXNz YWdlUmVjZWl2ZXIgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKERyYXdpbmdBcmVhKTsKIAog cHVibGljOgpAQCAtNjUsOCArNjYsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+RHJhd2luZ0Fy ZWEoKTsKICAgICAKICAgICBEcmF3aW5nQXJlYVR5cGUgdHlwZSgpIGNvbnN0IHsgcmV0dXJuIG1f dHlwZTsgfQotICAgIAotICAgIHZvaWQgZGlkUmVjZWl2ZURyYXdpbmdBcmVhTWVzc2FnZShJUEM6 OkNvbm5lY3Rpb24qLCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJik7CiAKICAgICB2aXJ0dWFsIHZvaWQg c2V0TmVlZHNEaXNwbGF5KCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzZXROZWVkc0Rpc3BsYXlJ blJlY3QoY29uc3QgV2ViQ29yZTo6SW50UmVjdCYpID0gMDsKQEAgLTEyOCw2ICsxMjcsOSBAQCBw cm90ZWN0ZWQ6CiAgICAgV2ViUGFnZSYgbV93ZWJQYWdlOwogCiBwcml2YXRlOgorICAgIC8vIElQ Qzo6TWVzc2FnZVJlY2VpdmVyLgorICAgIHZpcnR1YWwgdm9pZCBkaWRSZWNlaXZlTWVzc2FnZShJ UEM6OkNvbm5lY3Rpb24qLCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJikgb3ZlcnJpZGU7CisKICAgICAv LyBNZXNzYWdlIGhhbmRsZXJzLgogICAgIC8vIEZJWE1FOiBUaGVzZSBzaG91bGQgYmUgcHVyZSB2 aXJ0dWFsLgogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVCYWNraW5nU3RvcmVTdGF0ZSh1aW50NjRf dCAvKmJhY2tpbmdTdG9yZVN0YXRlSUQqLywgYm9vbCAvKnJlc3BvbmRJbW1lZGlhdGVseSovLCBm bG9hdCAvKmRldmljZVNjYWxlRmFjdG9yKi8sIGNvbnN0IFdlYkNvcmU6OkludFNpemUmIC8qc2l6 ZSovLCAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3 aW5nQXJlYS5tZXNzYWdlcy5pbiBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9E cmF3aW5nQXJlYS5tZXNzYWdlcy5pbgppbmRleCAxZTQzYzM2MmZiODYzOGZhNWYyMjFkZmZhNDRh YTg2M2JkODk3MzEzLi40NTcyOTg0NmI1NDQ0YzNjYjI2MzA4MGQxNjMzMDcwMzJjZTdiMGEyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWEu bWVzc2FnZXMuaW4KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdp bmdBcmVhLm1lc3NhZ2VzLmluCkBAIC0yMCw3ICsyMCw3IEBACiAjIE9SIFRPUlQgKElOQ0xVRElO RyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUg VVNFCiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJ VFkgT0YgU1VDSCBEQU1BR0UuCiAKLW1lc3NhZ2VzIC0+IERyYXdpbmdBcmVhIExlZ2FjeVJlY2Vp dmVyIHsKK21lc3NhZ2VzIC0+IERyYXdpbmdBcmVhIHsKICAgICBVcGRhdGVCYWNraW5nU3RvcmVT dGF0ZSh1aW50NjRfdCBiYWNraW5nU3RvcmVTdGF0ZUlELCBib29sIHJlc3BvbmRJbW1lZGlhdGVs eSwgZmxvYXQgZGV2aWNlU2NhbGVGYWN0b3IsIFdlYkNvcmU6OkludFNpemUgc2l6ZSwgV2ViQ29y ZTo6SW50U2l6ZSBzY3JvbGxPZmZzZXQpCiAgICAgRGlkVXBkYXRlKCkKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDAwNjYwYzIxM2U2NWE2 NDhlMzljMzQ5NzA4MWNlNmUzMGVkZGJhNGQuLjk2ZTU1YWE5MzhjMTk4MGFhNzlmZTlhZWM2MGJj Y2ZlNWMzMTRiODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKQEAgLTQ1NSw3ICs0NTUsNiBAQCBXZWJQYWdlOjpXZWJQYWdlKHVpbnQ2NF90IHBh Z2VJRCwgY29uc3QgV2ViUGFnZUNyZWF0aW9uUGFyYW1ldGVycyYgcGFyYW1ldGVycykKICAgICBX ZWJQcm9jZXNzOjpzaGFyZWQoKS5hZGRNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OldlYlBhZ2U6 Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSwgbV9wYWdlSUQsICp0aGlzKTsKIAogICAgIC8vIEZJWE1F OiBUaGlzIHNob3VsZCBiZSBkb25lIGluIHRoZSBvYmplY3QgY29uc3RydWN0b3JzLCBhbmQgdGhl IG9iamVjdHMgdGhlbXNlbHZlcyBzaG91bGQgYmUgbWVzc2FnZSByZWNlaXZlcnMuCi0gICAgV2Vi UHJvY2Vzczo6c2hhcmVkKCkuYWRkTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2VzOjpEcmF3aW5nQXJl YTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBtX3BhZ2VJRCwgKnRoaXMpOwogI2lmIFVTRShDT09S RElOQVRFRF9HUkFQSElDUykKICAgICBXZWJQcm9jZXNzOjpzaGFyZWQoKS5hZGRNZXNzYWdlUmVj ZWl2ZXIoTWVzc2FnZXM6OkNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6bWVzc2FnZVJlY2VpdmVy TmFtZSgpLCBtX3BhZ2VJRCwgKnRoaXMpOwogI2VuZGlmCkBAIC01MTYsNyArNTE1LDYgQEAgV2Vi UGFnZTo6fldlYlBhZ2UoKQogICAgIFdlYlByb2Nlc3M6OnNoYXJlZCgpLnJlbW92ZU1lc3NhZ2VS ZWNlaXZlcihNZXNzYWdlczo6V2ViUGFnZTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBtX3BhZ2VJ RCk7CiAKICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYmUgZG9uZSBpbiB0aGUgb2JqZWN0IGRl c3RydWN0b3JzLCBhbmQgdGhlIG9iamVjdHMgdGhlbXNlbHZlcyBzaG91bGQgYmUgbWVzc2FnZSBy ZWNlaXZlcnMuCi0gICAgV2ViUHJvY2Vzczo6c2hhcmVkKCkucmVtb3ZlTWVzc2FnZVJlY2VpdmVy KE1lc3NhZ2VzOjpEcmF3aW5nQXJlYTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCBtX3BhZ2VJRCk7 CiAjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNTKQogICAgIFdlYlByb2Nlc3M6OnNoYXJlZCgp LnJlbW92ZU1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0 OjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIG1fcGFnZUlEKTsKICNlbmRpZgpAQCAtMzQ4NCwxMiAr MzQ4Miw2IEBAIGJvb2wgV2ViUGFnZTo6d2luZG93QW5kV2ViUGFnZUFyZUZvY3VzZWQoKSBjb25z dAogCiB2b2lkIFdlYlBhZ2U6OmRpZFJlY2VpdmVNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiogY29u bmVjdGlvbiwgSVBDOjpNZXNzYWdlRGVjb2RlciYgZGVjb2RlcikKIHsKLSAgICBpZiAoZGVjb2Rl ci5tZXNzYWdlUmVjZWl2ZXJOYW1lKCkgPT0gTWVzc2FnZXM6OkRyYXdpbmdBcmVhOjptZXNzYWdl UmVjZWl2ZXJOYW1lKCkpIHsKLSAgICAgICAgaWYgKG1fZHJhd2luZ0FyZWEpCi0gICAgICAgICAg ICBtX2RyYXdpbmdBcmVhLT5kaWRSZWNlaXZlRHJhd2luZ0FyZWFNZXNzYWdlKGNvbm5lY3Rpb24s IGRlY29kZXIpOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCiAjaWYgVVNFKFRJTEVEX0JBQ0tJ TkdfU1RPUkUpCiAgICAgaWYgKGRlY29kZXIubWVzc2FnZVJlY2VpdmVyTmFtZSgpID09IE1lc3Nh Z2VzOjpDb29yZGluYXRlZExheWVyVHJlZUhvc3Q6Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSkgewog ICAgICAgICBpZiAobV9kcmF3aW5nQXJlYSkKQEAgLTM0OTcsNyArMzQ4OSw3IEBAIHZvaWQgV2Vi UGFnZTo6ZGlkUmVjZWl2ZU1lc3NhZ2UoSVBDOjpDb25uZWN0aW9uKiBjb25uZWN0aW9uLCBJUEM6 Ok1lc3NhZ2VEZWNvZGVyCiAgICAgICAgIHJldHVybjsKICAgICB9CiAjZW5kaWYKLSAgICAKKwog I2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgaWYgKGRlY29kZXIubWVzc2FnZVJlY2VpdmVyTmFt ZSgpID09IE1lc3NhZ2VzOjpXZWJJbnNwZWN0b3I6Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSkgewog ICAgICAgICBpZiAoV2ViSW5zcGVjdG9yKiBpbnNwZWN0b3IgPSB0aGlzLT5pbnNwZWN0b3IoKSkK