136435 2014-09-01 13:51:00 -0700 offlineasm generates suboptimal code for move immediate on ARM64 2014-09-03 07:15:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 akiss webkit-unassigned barraclough commit-queue dbates fpizlo ggaren msaboff oldest_to_newest 1032522 0 akiss 2014-09-01 13:51:00 -0700 emitARM64MoveImmediate generates a slightly suboptimal code if value is greater than 0xffff but the last 16 bits are all zeros, or less than ~0xffff but the last 16 bits are all ones. E.g., move 0xffff000000000000, csr1 in LowLevelInterpreter64.asm becomes movz x27, #65535, lsl #48 movk x27, #0, lsl #0 1032526 1 237462 akiss 2014-09-01 14:26:17 -0700 Created attachment 237462 Proposed patch. 1032893 2 237462 msaboff 2014-09-03 06:40:15 -0700 Comment on attachment 237462 Proposed patch. r=me 1032894 3 237462 commit-queue 2014-09-03 07:15:21 -0700 Comment on attachment 237462 Proposed patch. Clearing flags on attachment: 237462 Committed r173205: <http://trac.webkit.org/changeset/173205> 1032895 4 commit-queue 2014-09-03 07:15:25 -0700 All reviewed patches have been landed. Closing bug. 237462 2014-09-01 14:26:17 -0700 2014-09-03 07:15:21 -0700 Proposed patch. offline-moveimm-opt.patch text/plain 1885 akiss ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBkY2FmY2IuLjgyMmQwYWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA5LTAxICBBa29zIEtpc3MgIDxh a2lzc0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgRG9uJ3QgZ2VuZXJhdGUgc3VwZXJmbHVv dXMgbW92IGluc3RydWN0aW9ucyBmb3IgbW92ZSBpbW1lZGlhdGUgb24gQVJNNjQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY0MzUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbiBBUk02NCwgdGhlIHNp emUgb2YgYW4gaW1tZWRpYXRlIG9wZXJhbmQgZm9yIGEgbW92IGluc3RydWN0aW9uIGlzIDE2Cisg ICAgICAgIGJpdHMuIFRodXMsIGEgbW92ZSBpbW1lZGlhdGUgb2ZmbGluZWFzbSBpbnN0cnVjdGlv biBtYXkgcG90ZW50aWFsbHkgYmUKKyAgICAgICAgc3BsaXQgdXAgdG8gc2V2ZXJhbCBtYWNoaW5l IGxldmVsIGluc3RydWN0aW9ucy4gVGhlIGN1cnJlbnQKKyAgICAgICAgaW1wbGVtZW50YXRpb24g YWx3YXlzIGVtaXRzIGEgbW92IGZvciB0aGUgbGVhc3Qgc2lnbmlmaWNhbnQgMTYgYml0cyBvZgor ICAgICAgICB0aGUgdmFsdWUuIEhvd2V2ZXIsIGlmIGFueSBvZiB0aGUgYml0cyA2MzoxNiBhcmUg c2lnbmlmaWNhbnQgdGhlbiB0aGUKKyAgICAgICAgZmlyc3QgZW1pdHRlZCBtb3YgYWxyZWFkeSBm aWxsZWQgYml0cyAxNTowIHdpdGggemVyb2VzIChvciBvbmVzLCBmb3IKKyAgICAgICAgbmVnYXRp dmUgdmFsdWVzKS4gU28sIGlmIGJpdHMgMTU6MCBvZiB0aGUgdmFsdWUgYXJlIGFsbCB6ZXJvZXMg KG9yIG9uZXMpCisgICAgICAgIHRoZW4gdGhlIGxhc3QgbW92IGRvZXMgbm90IG5lZWQgdG8gYmUg ZW1pdHRlZC4KKworICAgICAgICAqIG9mZmxpbmVhc20vYXJtNjQucmI6CisKIDIwMTQtMDktMDEg IEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQ01B S0VdIEJ1aWxkIHdhcm5pbmcgYnkgSU5URVJGQUNFX0xJTktfTElCUkFSSUVTCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hcm02NC5yYiBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FybTY0LnJiCmluZGV4IGJkYzg0ZjUuLjllODUwMjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FybTY0LnJiCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FybTY0LnJiCkBAIC0zNjksNyArMzY5 LDcgQEAgZGVmIGVtaXRBUk02NE1vdmVJbW1lZGlhdGUodmFsdWUsIHRhcmdldCkKICAgICBbNDgs IDMyLCAxNiwgMF0uZWFjaCB7CiAgICAgICAgIHwgc2hpZnQgfAogICAgICAgICBjdXJyZW50VmFs dWUgPSAodmFsdWUgPj4gc2hpZnQpICYgMHhmZmZmCi0gICAgICAgIG5leHQgaWYgY3VycmVudFZh bHVlID09IChpc05lZ2F0aXZlID8gMHhmZmZmIDogMCkgYW5kIHNoaWZ0ICE9IDAKKyAgICAgICAg bmV4dCBpZiBjdXJyZW50VmFsdWUgPT0gKGlzTmVnYXRpdmUgPyAweGZmZmYgOiAwKSBhbmQgKHNo aWZ0ICE9IDAgb3IgIWZpcnN0KQogICAgICAgICBpZiBmaXJzdAogICAgICAgICAgICAgaWYgaXNO ZWdhdGl2ZQogICAgICAgICAgICAgICAgICRhc20ucHV0cyAibW92biAje3RhcmdldC5hcm02NE9w ZXJhbmQoOnB0cil9LCBcIyN7KH5jdXJyZW50VmFsdWUpICYgMHhmZmZmfSwgbHNsIFwjI3tzaGlm dH0iCg==