136433 2014-09-01 12:26:27 -0700 REGRESSION (r172832): Poor 2-finger scrolling performance at theverge.com articles (all tiles repaint) 2014-09-04 13:48:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.theverge.com/2014/8/31/6091393/anandtech-founder-anand-shimpi-retires-from-journalism-to-join-apple InRadar, Regression P1 Normal --- 1 mitz webkit-unassigned bdakin commit-queue esprehn+autocc glenn kondapallykalyan sam simon.fraser thorton oldest_to_newest 1032516 0 mitz 2014-09-01 12:26:27 -0700 Performing a two-finger scroll gesture on theverge.com articles causes all tiles to repaint, and scrolling either doesn’t happen or happens very slowly. To reproduce, navigate to the URL and two-finger scroll vertically. With repaint counters on, you’ll see that all the tiles repaint with every wheel event (even if the page doesn’t scroll at all). This was cause by <http://trac.webkit.org/r172832>, the fix for bug 91655. 1032517 1 mitz 2014-09-01 12:26:39 -0700 <rdar://problem/18193942> 1032725 2 bdakin 2014-09-02 13:17:59 -0700 I'm actually having a hard time reproducing the bug at The Verge, but it is very obvious at hulu.com for me. 1033002 3 237578 bdakin 2014-09-03 13:54:38 -0700 Created attachment 237578 Patch Unfortunately, I still don't totally understand what Hulu is doing to get into this state, and therefore I don't have a test case. I have failed so far in my attempts to make a reduction. 1033075 4 237596 bdakin 2014-09-03 15:59:42 -0700 Created attachment 237596 Test case Here's a test case that reproduces the bug! So far I haven't found a way to turn it into a layout test since the bug does not reproduce when scrolling programatically. 1033076 5 thorton 2014-09-03 16:02:20 -0700 (In reply to comment #4) > Created an attachment (id=237596) [details] > Test case > > Here's a test case that reproduces the bug! So far I haven't found a way to turn it into a layout test since the bug does not reproduce when scrolling programatically. What if you use bfulgham's magical scroll event generating internals thing? Those look way more like real scroll events to WebKit IIRC. 1033119 6 237607 bdakin 2014-09-03 20:10:26 -0700 Created attachment 237607 Patch A few notes about this patch. I took Tim's suggestion, and tried to use Brent's momentum events to create a test, and I kind of succeeded. The test seems to work on my machine. I am just dubious because I am not 100% convinced that these momentum events will do the exact same thing on all computers. So I put a note in the test about how if it turns out to be flakey, we can skip it. But! It is effective on my machine. Another note. Sitting with Simon and Sam about this bug, they also want ScrollableArea::handleWheelEvent() to return early is the ScrollableArea is not scrollable or rubberbandable. I am going to implement that in a followup patch because adding a virtual function to ScrollableArea called isScrollableOrRubberbandable() turns out to be a bit complicated for RenderListBox since there is already a virtual function of that same name in its RenderObject inheritance chain. Ah, the joys of multiple inheritance. Anyway, there are obviously solutions to that problem, but it seems involved enough that it should be a separate patch. 1033269 7 237607 bdakin 2014-09-04 12:19:31 -0700 Comment on attachment 237607 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237607&action=review > LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/root-overflow-with-mousewheel.html:35 > + setTimeout(checkForScroll, 500); Oh, I can get rid of this setTimeout completely, so that's good. 1033293 8 237607 thorton 2014-09-04 13:43:33 -0700 Comment on attachment 237607 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237607&action=review > Source/WebCore/rendering/RenderLayer.cpp:6401 > + bool needsHorizontalScrollbar = renderer().hasOverflowClip() && ((hasHorizontalScrollbar() && overflowDefinesAutomaticScrollbar(overflowX)) || overflowRequiresScrollbar(overflowX)); we already have our RenderBox in a local, perhaps use that instead? >> LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/root-overflow-with-mousewheel.html:35 >> + setTimeout(checkForScroll, 500); > > Oh, I can get rid of this setTimeout completely, so that's good. Please do! 500ms tests are unwelcome :) 1033294 9 bdakin 2014-09-04 13:48:35 -0700 Thanks Tim! http://trac.webkit.org/changeset/173275 237578 2014-09-03 13:54:38 -0700 2014-09-03 20:10:26 -0700 Patch for-review.txt text/plain 2661 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzIyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA5LTAzICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTcyODMyKTog UG9vciAyLWZpbmdlciBzY3JvbGxpbmcgcGVyZm9ybWFuY2UgYXQgdGhldmVyZ2UuY29tIGFydGlj bGVzIAorICAgICAgICAoYWxsIHRpbGVzIHJlcGFpbnQpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY0MzMKKyAgICAgICAgLWFuZCBjb3JyZXNwb25k aW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xODE5Mzk0MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBlbnN1cmUgdGhhdCB3ZSBh cmUgb25seSBzZXR0aW5nIHNjcm9sbCBlbGFzdGljaXR5IGZvciBvdmVyZmxvdzpzY3JvbGwgCisg ICAgICAgIGVsZW1lbnRzLiBJbiB0aGUgYnVnZ3kgY2FzZSwgd2UgZ290IGludG8gdGhpcyBjb2Rl IHBhdGggZm9yIGEgcm9vdCByZW5kZXJlciB0aGF0IAorICAgICAgICBkaWQgbm90IGhhdmUgdGhl IG92ZXJmbG93IHByb3BlcnR5IHNldCwgYW5kIHRoYXQgbWVzc2VkIHdpdGggdGhlIHdheSB0aGF0 IHRoZSBib2R5IAorICAgICAgICBpcyBtZWFudCB0byBzY3JvbGwuCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpzZXRI YXNIb3Jpem9udGFsU2Nyb2xsYmFyKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpz ZXRIYXNWZXJ0aWNhbFNjcm9sbGJhcik6CisKIDIwMTQtMDktMDMgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgaU9TIGJ1aWxkIGZpeCBhZnRlciByMTcz MjE3IApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShyZXZp c2lvbiAxNzMyMTEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMDAzLDcgKzMwMDMsOCBAQCB2b2lkIFJlbmRlckxheWVyOjpz ZXRIYXNIb3Jpem9udGFsU2Nyb2xsCiAgICAgaWYgKGhhc1Njcm9sbGJhcikgewogICAgICAgICBt X2hCYXIgPSBjcmVhdGVTY3JvbGxiYXIoSG9yaXpvbnRhbFNjcm9sbGJhcik7CiAjaWYgRU5BQkxF KFJVQkJFUl9CQU5ESU5HKQotICAgICAgICBTY3JvbGxhYmxlQXJlYTo6c2V0SG9yaXpvbnRhbFNj cm9sbEVsYXN0aWNpdHkocmVuZGVyZXIoKS5mcmFtZSgpLnNldHRpbmdzKCkucnViYmVyQmFuZGlu Z0Zvck92ZXJmbG93U2Nyb2xsRW5hYmxlZCgpID8gU2Nyb2xsRWxhc3RpY2l0eUF1dG9tYXRpYyA6 IFNjcm9sbEVsYXN0aWNpdHlOb25lKTsKKyAgICAgICAgU2Nyb2xsRWxhc3RpY2l0eSBlbGFzdGlj aXR5ID0gc2Nyb2xsc092ZXJmbG93KCkgJiYgcmVuZGVyZXIoKS5mcmFtZSgpLnNldHRpbmdzKCku cnViYmVyQmFuZGluZ0Zvck92ZXJmbG93U2Nyb2xsRW5hYmxlZCgpID8gU2Nyb2xsRWxhc3RpY2l0 eUF1dG9tYXRpYyA6IFNjcm9sbEVsYXN0aWNpdHlOb25lOworICAgICAgICBTY3JvbGxhYmxlQXJl YTo6c2V0SG9yaXpvbnRhbFNjcm9sbEVsYXN0aWNpdHkoZWxhc3RpY2l0eSk7CiAjZW5kaWYKICAg ICB9IGVsc2UgewogICAgICAgICBkZXN0cm95U2Nyb2xsYmFyKEhvcml6b250YWxTY3JvbGxiYXIp OwpAQCAtMzAzMyw3ICszMDM0LDggQEAgdm9pZCBSZW5kZXJMYXllcjo6c2V0SGFzVmVydGljYWxT Y3JvbGxiYQogICAgIGlmIChoYXNTY3JvbGxiYXIpIHsKICAgICAgICAgbV92QmFyID0gY3JlYXRl U2Nyb2xsYmFyKFZlcnRpY2FsU2Nyb2xsYmFyKTsKICNpZiBFTkFCTEUoUlVCQkVSX0JBTkRJTkcp Ci0gICAgICAgIFNjcm9sbGFibGVBcmVhOjpzZXRWZXJ0aWNhbFNjcm9sbEVsYXN0aWNpdHkoKHJl bmRlcmVyKCkuZnJhbWUoKS5zZXR0aW5ncygpLnJ1YmJlckJhbmRpbmdGb3JPdmVyZmxvd1Njcm9s bEVuYWJsZWQoKSA/IFNjcm9sbEVsYXN0aWNpdHlBdXRvbWF0aWMgOiBTY3JvbGxFbGFzdGljaXR5 Tm9uZSkpOworICAgICAgICBTY3JvbGxFbGFzdGljaXR5IGVsYXN0aWNpdHkgPSBzY3JvbGxzT3Zl cmZsb3coKSAmJiByZW5kZXJlcigpLmZyYW1lKCkuc2V0dGluZ3MoKS5ydWJiZXJCYW5kaW5nRm9y T3ZlcmZsb3dTY3JvbGxFbmFibGVkKCkgPyBTY3JvbGxFbGFzdGljaXR5QXV0b21hdGljIDogU2Ny b2xsRWxhc3RpY2l0eU5vbmU7CisgICAgICAgIFNjcm9sbGFibGVBcmVhOjpzZXRWZXJ0aWNhbFNj cm9sbEVsYXN0aWNpdHkoZWxhc3RpY2l0eSk7CiAjZW5kaWYKICAgICB9IGVsc2UgewogICAgICAg ICBkZXN0cm95U2Nyb2xsYmFyKFZlcnRpY2FsU2Nyb2xsYmFyKTsK 237596 2014-09-03 15:59:42 -0700 2014-09-03 15:59:42 -0700 Test case hulu.html text/html 201 bdakin PGh0bWw+CjxoZWFkPgo8c3R5bGU+CgpodG1sIHsKICAgIGhlaWdodDogMjAwMHB4OwogICAgb3Zl cmZsb3c6IHNjcm9sbDsKfQoKPC9zdHlsZT4KCjxzY3JpcHQ+Cgp3aW5kb3cuYWRkRXZlbnRMaXN0 ZW5lcignbW91c2V3aGVlbCcsIGZ1bmN0aW9uKCkgeyA7IH0sIGZhbHNlKTsKPC9zY3JpcHQ+Cjwv aGVhZD4KCjxib2R5Pgo8L2JvZHk+CjwvaHRtbD4K 237607 2014-09-03 20:10:26 -0700 2014-09-04 13:43:33 -0700 Patch for-review-2.txt text/plain 7854 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzI0OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE0LTA5LTAzICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTcyODMyKTog UG9vciAyLWZpbmdlciBzY3JvbGxpbmcgcGVyZm9ybWFuY2UgYXQgdGhldmVyZ2UuY29tIGFydGlj bGVzIAorICAgICAgICAoYWxsIHRpbGVzIHJlcGFpbnQpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY0MzMKKyAgICAgICAgLWFuZCBjb3JyZXNwb25k aW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8xODE5Mzk0MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBlbnN1cmUgdGhhdCB3ZSBh cmUgb25seSBzZXR0aW5nIHNjcm9sbCBlbGFzdGljaXR5IGZvciBsYXllcnMgdGhhdCByZXR1cm4g CisgICAgICAgIHRydWUgZm9yIHNjcm9sbHNPdmVyZmxvdygpLiBXaGVuIG92ZXJmbG93OnNjcm9s bCBpcyBzZXQgb24gdGhlIHJvb3QgZWxlbWVudCwgd2UgCisgICAgICAgIHdvdW5kIHVwIHNldHRp bmcgdGhlIFNjcm9sbEVsYXN0aWNpdHkgZm9yIHRoZSByb290LCB3aGljaCBtZXNzZWQgdXAgd2l0 aCB0aGUgCisgICAgICAgIHNwZWNpYWwgd2F5IHRoYXQgdGhlIHJvb3QgaXMgbWVhbnQgdG8gc2Ny b2xsLiBFdmVuIHRob3VnaCBvdmVyZmxvdzpzY3JvbGwgaGFzIGJlZW4gCisgICAgICAgIHNldCBv biB0aGUgcm9vdCwgc2Nyb2xsc092ZXJmbG93KCkgaXMgc3RpbGwgZmFsc2UgYmVjYXVzZSB3ZSBr bmV3IG5vdCB0byBzZXQgCisgICAgICAgIGhhc092ZXJmbG93Q2xpcCgpIHNpbmNlIGl04oCZcyB0 aGUgcm9vdCwgd2hpY2ggaXMgd2h5IHRoaXMgY2hlY2sgd29ya3MuICAKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnNl dEhhc0hvcml6b250YWxTY3JvbGxiYXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6 OnNldEhhc1ZlcnRpY2FsU2Nyb2xsYmFyKToKKworICAgICAgICBSZWFsbHksIHdlIHNob3VsZCBo YXZlIG5ldmVyIGV2ZW4gY2FsbGVkIFJlbmRlckxheWVyOjpzZXRIYXNWZXJ0aWNhbFNjcm9sbGJh ciBvciAKKyAgICAgICAgUmVuZGVyTGF5ZXI6OnNldEhhc0hvcml6b250YWxTY3JvbGxiYXIgc2lu Y2UgaXTigJlzIHdyb25nIHRvIGJlIGNyZWF0aW5nIGEgc2Nyb2xsYmFyIAorICAgICAgICBvbiBS ZW5kZXJMYXllciBmb3IgdGhlIHJvb3QuIFdlIHNob3VsZCBtYWtlIHN1cmUsIGluIGFkZGl0aW9u IHRvIHRoZSBvdGhlciAKKyAgICAgICAgcmVxdWlyZW1lbnRzIGNvbnN1bHRlZCwgdGhhdCB0aGUg cmVuZGVyZXIgaGFzIGFuIG92ZXJmbG93IGNsaXAgYmVmb3JlIHdlIGNyZWF0ZSAKKyAgICAgICAg dGhlIHNjcm9sbGJhcnMuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6Y2FsY3VsYXRl Q2xpcFJlY3RzKToKKwogMjAxNC0wOS0wMyAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUu Y29tPgogCiAgICAgICAgIEZpeCBhIGZldyBsZWZ0b3ZlcnMgZnJvbSByZW1vdmluZyBNSU1FLXJl bGF0ZWQgV0tTSSB1c2FnZQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuY3BwCShyZXZpc2lvbiAxNzMyMTEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDAzLDcgKzMwMDMsOCBAQCB2b2lkIFJl bmRlckxheWVyOjpzZXRIYXNIb3Jpem9udGFsU2Nyb2xsCiAgICAgaWYgKGhhc1Njcm9sbGJhcikg ewogICAgICAgICBtX2hCYXIgPSBjcmVhdGVTY3JvbGxiYXIoSG9yaXpvbnRhbFNjcm9sbGJhcik7 CiAjaWYgRU5BQkxFKFJVQkJFUl9CQU5ESU5HKQotICAgICAgICBTY3JvbGxhYmxlQXJlYTo6c2V0 SG9yaXpvbnRhbFNjcm9sbEVsYXN0aWNpdHkocmVuZGVyZXIoKS5mcmFtZSgpLnNldHRpbmdzKCku cnViYmVyQmFuZGluZ0Zvck92ZXJmbG93U2Nyb2xsRW5hYmxlZCgpID8gU2Nyb2xsRWxhc3RpY2l0 eUF1dG9tYXRpYyA6IFNjcm9sbEVsYXN0aWNpdHlOb25lKTsKKyAgICAgICAgU2Nyb2xsRWxhc3Rp Y2l0eSBlbGFzdGljaXR5ID0gc2Nyb2xsc092ZXJmbG93KCkgJiYgcmVuZGVyZXIoKS5mcmFtZSgp LnNldHRpbmdzKCkucnViYmVyQmFuZGluZ0Zvck92ZXJmbG93U2Nyb2xsRW5hYmxlZCgpID8gU2Ny b2xsRWxhc3RpY2l0eUF1dG9tYXRpYyA6IFNjcm9sbEVsYXN0aWNpdHlOb25lOworICAgICAgICBT Y3JvbGxhYmxlQXJlYTo6c2V0SG9yaXpvbnRhbFNjcm9sbEVsYXN0aWNpdHkoZWxhc3RpY2l0eSk7 CiAjZW5kaWYKICAgICB9IGVsc2UgewogICAgICAgICBkZXN0cm95U2Nyb2xsYmFyKEhvcml6b250 YWxTY3JvbGxiYXIpOwpAQCAtMzAzMyw3ICszMDM0LDggQEAgdm9pZCBSZW5kZXJMYXllcjo6c2V0 SGFzVmVydGljYWxTY3JvbGxiYQogICAgIGlmIChoYXNTY3JvbGxiYXIpIHsKICAgICAgICAgbV92 QmFyID0gY3JlYXRlU2Nyb2xsYmFyKFZlcnRpY2FsU2Nyb2xsYmFyKTsKICNpZiBFTkFCTEUoUlVC QkVSX0JBTkRJTkcpCi0gICAgICAgIFNjcm9sbGFibGVBcmVhOjpzZXRWZXJ0aWNhbFNjcm9sbEVs YXN0aWNpdHkoKHJlbmRlcmVyKCkuZnJhbWUoKS5zZXR0aW5ncygpLnJ1YmJlckJhbmRpbmdGb3JP dmVyZmxvd1Njcm9sbEVuYWJsZWQoKSA/IFNjcm9sbEVsYXN0aWNpdHlBdXRvbWF0aWMgOiBTY3Jv bGxFbGFzdGljaXR5Tm9uZSkpOworICAgICAgICBTY3JvbGxFbGFzdGljaXR5IGVsYXN0aWNpdHkg PSBzY3JvbGxzT3ZlcmZsb3coKSAmJiByZW5kZXJlcigpLmZyYW1lKCkuc2V0dGluZ3MoKS5ydWJi ZXJCYW5kaW5nRm9yT3ZlcmZsb3dTY3JvbGxFbmFibGVkKCkgPyBTY3JvbGxFbGFzdGljaXR5QXV0 b21hdGljIDogU2Nyb2xsRWxhc3RpY2l0eU5vbmU7CisgICAgICAgIFNjcm9sbGFibGVBcmVhOjpz ZXRWZXJ0aWNhbFNjcm9sbEVsYXN0aWNpdHkoZWxhc3RpY2l0eSk7CiAjZW5kaWYKICAgICB9IGVs c2UgewogICAgICAgICBkZXN0cm95U2Nyb2xsYmFyKFZlcnRpY2FsU2Nyb2xsYmFyKTsKQEAgLTYz OTYsOCArNjM5OCw4IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZVNjcm9sbGJhcnNBZnRlclMK ICAgICBFT3ZlcmZsb3cgb3ZlcmZsb3dZID0gYm94LT5zdHlsZSgpLm92ZXJmbG93WSgpOwogCiAg ICAgLy8gVG8gYXZvaWQgZG9pbmcgYSByZWxheW91dCBpbiB1cGRhdGVTY3JvbGxiYXJzQWZ0ZXJM YXlvdXQsIHdlIHRyeSB0byBrZWVwIGFueSBhdXRvbWF0aWMgc2Nyb2xsYmFyIHRoYXQgd2FzIGFs cmVhZHkgcHJlc2VudC4KLSAgICBib29sIG5lZWRzSG9yaXpvbnRhbFNjcm9sbGJhciA9IChoYXNI b3Jpem9udGFsU2Nyb2xsYmFyKCkgJiYgb3ZlcmZsb3dEZWZpbmVzQXV0b21hdGljU2Nyb2xsYmFy KG92ZXJmbG93WCkpIHx8IG92ZXJmbG93UmVxdWlyZXNTY3JvbGxiYXIob3ZlcmZsb3dYKTsKLSAg ICBib29sIG5lZWRzVmVydGljYWxTY3JvbGxiYXIgPSAoaGFzVmVydGljYWxTY3JvbGxiYXIoKSAm JiBvdmVyZmxvd0RlZmluZXNBdXRvbWF0aWNTY3JvbGxiYXIob3ZlcmZsb3dZKSkgfHwgb3ZlcmZs b3dSZXF1aXJlc1Njcm9sbGJhcihvdmVyZmxvd1kpOworICAgIGJvb2wgbmVlZHNIb3Jpem9udGFs U2Nyb2xsYmFyID0gcmVuZGVyZXIoKS5oYXNPdmVyZmxvd0NsaXAoKSAmJiAoKGhhc0hvcml6b250 YWxTY3JvbGxiYXIoKSAmJiBvdmVyZmxvd0RlZmluZXNBdXRvbWF0aWNTY3JvbGxiYXIob3ZlcmZs b3dYKSkgfHwgb3ZlcmZsb3dSZXF1aXJlc1Njcm9sbGJhcihvdmVyZmxvd1gpKTsKKyAgICBib29s IG5lZWRzVmVydGljYWxTY3JvbGxiYXIgPSByZW5kZXJlcigpLmhhc092ZXJmbG93Q2xpcCgpICYm ICgoaGFzVmVydGljYWxTY3JvbGxiYXIoKSAmJiBvdmVyZmxvd0RlZmluZXNBdXRvbWF0aWNTY3Jv bGxiYXIob3ZlcmZsb3dZKSkgfHwgb3ZlcmZsb3dSZXF1aXJlc1Njcm9sbGJhcihvdmVyZmxvd1kp KTsKICAgICBzZXRIYXNIb3Jpem9udGFsU2Nyb2xsYmFyKG5lZWRzSG9yaXpvbnRhbFNjcm9sbGJh cik7CiAgICAgc2V0SGFzVmVydGljYWxTY3JvbGxiYXIobmVlZHNWZXJ0aWNhbFNjcm9sbGJhcik7 CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzI0OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA5LTAzICBCZXRoIERha2luICA8 YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTcyODMyKTogUG9vciAy LWZpbmdlciBzY3JvbGxpbmcgcGVyZm9ybWFuY2UgYXQgdGhldmVyZ2UuY29tIGFydGljbGVzIAor ICAgICAgICAoYWxsIHRpbGVzIHJlcGFpbnQpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzY0MzMKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQor ICAgICAgICByZGFyOi8vcHJvYmxlbS8xODE5Mzk0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi90aWxlZC1kcmF3aW5n L3Njcm9sbGluZy9yb290LW92ZXJmbG93LXdpdGgtbW91c2V3aGVlbC1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcv cm9vdC1vdmVyZmxvdy13aXRoLW1vdXNld2hlZWwuaHRtbDogQWRkZWQuCisKIDIwMTQtMDktMDMg IEplZmZyZXkgUGZhdSAgPGpwZmF1QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBt YXJrIHRlc3QgYXMgY3Jhc2hpbmcKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIv dGlsZWQtZHJhd2luZy9zY3JvbGxpbmcvcm9vdC1vdmVyZmxvdy13aXRoLW1vdXNld2hlZWwtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvdGls ZWQtZHJhd2luZy9zY3JvbGxpbmcvcm9vdC1vdmVyZmxvdy13aXRoLW1vdXNld2hlZWwtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi90aWxl ZC1kcmF3aW5nL3Njcm9sbGluZy9yb290LW92ZXJmbG93LXdpdGgtbW91c2V3aGVlbC1leHBlY3Rl ZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSBAQAorU3VjY2VzcyEKSW5kZXg6IExheW91 dFRlc3RzL3BsYXRmb3JtL21hYy13azIvdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcvcm9vdC1vdmVy Zmxvdy13aXRoLW1vdXNld2hlZWwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMtd2syL3RpbGVkLWRyYXdpbmcvc2Nyb2xsaW5nL3Jvb3Qtb3ZlcmZsb3ctd2l0aC1t b3VzZXdoZWVsLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMt d2syL3RpbGVkLWRyYXdpbmcvc2Nyb2xsaW5nL3Jvb3Qtb3ZlcmZsb3ctd2l0aC1tb3VzZXdoZWVs Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1MyBAQAorPGh0bWw+Cis8aGVhZD4KKzxz dHlsZT4KK2h0bWwgeworICAgIGhlaWdodDogMjAwMHB4OworICAgIG92ZXJmbG93OiBzY3JvbGw7 Cit9Cis8L3N0eWxlPgorCis8c2NyaXB0PgorZnVuY3Rpb24gY2hlY2tGb3JTY3JvbGwoKQorewor ICAgIHZhciBwYWdlU2Nyb2xsUG9zaXRpb25BZnRlciA9IGRvY3VtZW50LmJvZHkuc2Nyb2xsVG9w OworICAgIHZhciBmaW5pc2hMb2cgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZmluaXNoTG9n Iik7CisgICAgaWYgKHBhZ2VTY3JvbGxQb3NpdGlvbkFmdGVyID4gNTApCisgICAgICAgIGZpbmlz aExvZy5pbm5lckhUTUwgPSAiU3VjY2VzcyEiOworICAgIGVsc2UKKyAgICAgICAgZmluaXNoTG9n LmlubmVySFRNTCA9ICJGYWlsdXJlLiBUcnkgcnVubmluZyB0aGUgdGVzdCBtYW51YWxseS4gSWYg dGhpcyBwcm92ZXMgdG8gYmUgZmxha2V5LCBhbmQgd2UgbWlnaHQgaGF2ZSB0byBza2lwIGl0LiI7 CisgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9CisKK2Z1bmN0aW9uIHNjcm9sbFRlc3Qo KQoreworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKDUwLCA1MCk7CisgICAgZXZlbnRTZW5k ZXIubW91c2VTY3JvbGxCeVdpdGhXaGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIC0xLCAnYmVnYW4n LCAnbm9uZScpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21l bnR1bVBoYXNlcygwLCAtMSwgJ2NoYW5nZWQnLCAnbm9uZScpOworICAgIGV2ZW50U2VuZGVyLm1v dXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygwLCAtMSwgJ2NoYW5nZWQnLCAn bm9uZScpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1 bVBoYXNlcygwLCAwLCAnZW5kZWQnLCAnbm9uZScpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlU2Ny b2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygwLCAtMSwgJ25vbmUnLCAnYmVnaW4nKTsK KyAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFzZXMo MCwgLTEsICdub25lJywgJ2NvbnRpbnVlJyk7CisgICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxC eVdpdGhXaGVlbEFuZE1vbWVudHVtUGhhc2VzKDAsIC0xLCAnbm9uZScsICdjb250aW51ZScpOwor ICAgIGV2ZW50U2VuZGVyLm1vdXNlU2Nyb2xsQnlXaXRoV2hlZWxBbmRNb21lbnR1bVBoYXNlcygw LCAtMSwgJ25vbmUnLCAnY29udGludWUnKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVNjcm9sbEJ5 V2l0aFdoZWVsQW5kTW9tZW50dW1QaGFzZXMoMCwgLTEsICdub25lJywgJ2NvbnRpbnVlJyk7Cisg ICAgZXZlbnRTZW5kZXIubW91c2VTY3JvbGxCeVdpdGhXaGVlbEFuZE1vbWVudHVtUGhhc2VzKDAs IDAsICdub25lJywgJ2VuZCcpOworICAgIHNldFRpbWVvdXQoY2hlY2tGb3JTY3JvbGwsIDUwMCk7 Cit9CisKK2Z1bmN0aW9uIG9uTG9hZCgpIHsKKyAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcign bW91c2V3aGVlbCcsIGZ1bmN0aW9uKCkgeyB9LCBmYWxzZSk7CisKKyAgICBpZiAod2luZG93LmV2 ZW50U2VuZGVyKSB7CisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgICB0 ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAgc2V0VGltZW91dChzY3JvbGxUZXN0 LCAwKTsKKyAgICB9Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgb25sb2FkPSJvbkxv YWQoKTsiPgorICAgIDxwcmUgaWQ9ImZpbmlzaExvZyI+VGhpcyB0ZXN0IHBhc3NlcyBpZiB5b3Ug Y2FuIHNjcm9sbCB0aGUgcGFnZS48L3ByZT4KKzwvYm9keT4KKzwvaHRtbD4K