136429 2014-09-01 09:15:54 -0700 [ARM] MacroAssembler generating incorrect code on ARM32 Traditional 2014-09-02 10:01:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 dbatyai.u-szeged webkit-unassigned commit-queue fpizlo ggaren mark.lam msaboff oliver ossy oldest_to_newest 1032489 0 dbatyai.u-szeged 2014-09-01 09:15:54 -0700 At MacroAssemblerARM.h:945 we check if the value in reg is zero, but the 0 in cmp was being interpreted as r0 instead of a constant. 1032490 1 237452 dbatyai.u-szeged 2014-09-01 09:20:53 -0700 Created attachment 237452 Patch Changed test32 to use tst instead of cmp to check if reg is zero. 1032674 2 237452 commit-queue 2014-09-02 10:01:45 -0700 Comment on attachment 237452 Patch Clearing flags on attachment: 237452 Committed r173179: <http://trac.webkit.org/changeset/173179> 1032675 3 commit-queue 2014-09-02 10:01:50 -0700 All reviewed patches have been landed. Closing bug. 237452 2014-09-01 09:20:53 -0700 2014-09-02 10:01:45 -0700 Patch patch.patch text/plain 1391 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBkY2FmY2IuLjhlYjZkM2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA5LTAxICBEw6FuaWVsIELDoXR5 YWkgIDxkYmF0eWFpLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0FS TV0gTWFjcm9Bc3NlbWJsZXIgZ2VuZXJhdGluZyBpbmNvcnJlY3QgY29kZSBvbiBBUk0zMiBUcmFk aXRpb25hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM2NDI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2hhbmdlZCB0ZXN0MzIgdG8gdXNlIHRzdCB0byBjaGVjayBpZiByZWcgaXMgemVybywgaW5zdGVh ZCBvZiBjbXAuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAg ICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OnRlc3QzMik6CisKIDIwMTQtMDktMDEgIEd5 dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQ01BS0Vd IEJ1aWxkIHdhcm5pbmcgYnkgSU5URVJGQUNFX0xJTktfTElCUkFSSUVTCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKaW5kZXggODJj ODA1Ni4uMzFjMmQ3ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlckFSTS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaApAQCAtOTQyLDcgKzk0Miw3IEBAIHB1YmxpYzoKICAgICB2 b2lkIHRlc3QzMihSZXN1bHRDb25kaXRpb24gY29uZCwgUmVnaXN0ZXJJRCByZWcsIFRydXN0ZWRJ bW0zMiBtYXNrLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAgICBpZiAobWFzay5tX3Zh bHVlID09IC0xKQotICAgICAgICAgICAgbV9hc3NlbWJsZXIuY21wKDAsIHJlZyk7CisgICAgICAg ICAgICBtX2Fzc2VtYmxlci50c3QocmVnLCByZWcpOwogICAgICAgICBlbHNlCiAgICAgICAgICAg ICBtX2Fzc2VtYmxlci50c3QocmVnLCBtX2Fzc2VtYmxlci5nZXRJbW0obWFzay5tX3ZhbHVlLCBB Uk1SZWdpc3RlcnM6OlMwKSk7CiAgICAgICAgIG1fYXNzZW1ibGVyLm1vdihkZXN0LCBBUk1Bc3Nl bWJsZXI6OmdldE9wMkJ5dGUoMCkpOwo=