136420 2014-08-31 18:03:28 -0700 Remove unused ARMv6-specific #if branches in WebCore::canHyphenate 2014-09-01 00:09:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton ap benjamin mitz psolanki oldest_to_newest 1032428 0 thorton 2014-08-31 18:03:28 -0700 Remove unused ARMv6-specific #if branches in WebCore::canHyphenate 1032429 1 237438 thorton 2014-08-31 18:04:03 -0700 Created attachment 237438 Patch 1032430 2 thorton 2014-08-31 18:11:46 -0700 http://trac.webkit.org/changeset/173151 1032443 3 237438 ap 2014-08-31 23:54:51 -0700 Comment on attachment 237438 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237438&action=review > Source/WebCore/ChangeLog:10 > + Use kCFAllocatorDefault instead of 0. Do we do that? I thought that 0 was better in nearly every respect - shorter and faster. 1032444 4 mitz 2014-08-31 23:56:26 -0700 (In reply to comment #3) > (From update of attachment 237438 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237438&action=review > > > Source/WebCore/ChangeLog:10 > > + Use kCFAllocatorDefault instead of 0. > > Do we do that? I thought that 0 was better in nearly every respect - shorter and faster. Perhaps, but also completely mysterious when reading the code. 1032449 5 ap 2014-09-01 00:09:39 -0700 We do need a certain level of C++ knowledge and platform savviness from contributors. I don't think that we have any who actually find this mysterious. I don't have any links, but I'm pretty sure that this was discussed before, and kCFAllocatorDefault was agreed unnecessary. 237438 2014-08-31 18:04:03 -0700 2014-08-31 23:54:51 -0700 Patch bug-136420-20140831180512.patch text/plain 2529 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2U4NmQxNTMxNjgxOGUz ODhhNGJmYzEyYmI0OGEwM2MxNTBkZTk1MS4uZDM5NzM2MzIwMjQ0MWY0MjdkOTcyYmQ1YzZlZWFk YmE3N2RhNjg4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA4LTMxICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCisgICAgICAgIFJlbW92ZSB1bnVz ZWQgI2lmIGJyYW5jaGVzIGluIFdlYkNvcmU6OmNhbkh5cGhlbmF0ZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2NDIwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L2NmL0h5cGhl bmF0aW9uQ0YuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXRvbWljU3RyaW5nS2V5ZWRNUlVDYWNo ZTxSZXRhaW5QdHI8Q0ZMb2NhbGVSZWY+Pjo6Y3JlYXRlVmFsdWVGb3JOdWxsS2V5KToKKyAgICAg ICAgVXNlIGtDRkFsbG9jYXRvckRlZmF1bHQgaW5zdGVhZCBvZiAwLgorCisgICAgICAgIChXZWJD b3JlOjpjYW5IeXBoZW5hdGUpOgorICAgICAgICBSZW1vdmUgQVJNdjYtc3BlY2lmaWMgY29kZS4K KworMjAxNC0wOC0zMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwog ICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgKGFuZCB1bm5lY2Vzc2FyaWx5IGlPUy1zcGVjaWZp Yykgc2V0U3Ryb2tlQW5kRmlsbENvbG9yCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzY0MTYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC9jZi9IeXBoZW5hdGlvbkNGLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3RleHQvY2YvSHlwaGVuYXRpb25DRi5jcHAKaW5kZXggYTM0NGJkODUzMzZlNDk0N2UzMGZmN2U0 NzJiYjVhNTIxOTJiMTYyMi4uNDBiOGJlOWFkYjMxMDdhMTFiNzZlN2YzZDc2MjRkNzRhZDgwNWIw MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9jZi9IeXBoZW5hdGlv bkNGLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2NmL0h5cGhlbmF0aW9u Q0YuY3BwCkBAIC00MCw3ICs0MCw3IEBAIFJldGFpblB0cjxDRkxvY2FsZVJlZj4gQXRvbWljU3Ry aW5nS2V5ZWRNUlVDYWNoZTxSZXRhaW5QdHI8Q0ZMb2NhbGVSZWY+Pjo6Y3JlYXRlCiB7CiAgICAg Ly8gQ0YgaHlwaGVuYXRpb24gZnVuY3Rpb25zIHVzZSBsb2NhbGUgKHJlZ2lvbmFsIGZvcm1hdHMp IGxhbmd1YWdlLCB3aGljaCBkb2Vzbid0IG5lY2Vzc2FyaWx5IG1hdGNoIHByaW1hcnkgVUkgbGFu Z3VhZ2UsCiAgICAgLy8gc28gd2UgY2FuJ3QgdXNlIGRlZmF1bHQgbG9jYWxlIGhlcmUuIFNlZSA8 cmRhcjovL3Byb2JsZW0vMTQ4OTc2NjQ+LgotICAgIFJldGFpblB0cjxDRkxvY2FsZVJlZj4gbG9j YWxlID0gYWRvcHRDRihDRkxvY2FsZUNyZWF0ZSgwLCBkZWZhdWx0TGFuZ3VhZ2UoKS5jcmVhdGVD RlN0cmluZygpLmdldCgpKSk7CisgICAgUmV0YWluUHRyPENGTG9jYWxlUmVmPiBsb2NhbGUgPSBh ZG9wdENGKENGTG9jYWxlQ3JlYXRlKGtDRkFsbG9jYXRvckRlZmF1bHQsIGRlZmF1bHRMYW5ndWFn ZSgpLmNyZWF0ZUNGU3RyaW5nKCkuZ2V0KCkpKTsKIAogICAgIHJldHVybiBDRlN0cmluZ0lzSHlw aGVuYXRpb25BdmFpbGFibGVGb3JMb2NhbGUobG9jYWxlLmdldCgpKSA/IGxvY2FsZSA6IDA7CiB9 CkBAIC02MSwxNyArNjEsNyBAQCBzdGF0aWMgQXRvbWljU3RyaW5nS2V5ZWRNUlVDYWNoZTxSZXRh aW5QdHI8Q0ZMb2NhbGVSZWY+PiYgY2ZMb2NhbGVDYWNoZSgpCiAKIGJvb2wgY2FuSHlwaGVuYXRl KGNvbnN0IEF0b21pY1N0cmluZyYgbG9jYWxlSWRlbnRpZmllcikKIHsKLSNpZiAhUExBVEZPUk0o SU9TKQogICAgIHJldHVybiBjZkxvY2FsZUNhY2hlKCkuZ2V0KGxvY2FsZUlkZW50aWZpZXIpOwot I2Vsc2UKLSNpZiAhKGRlZmluZWQoV1RGX0FSTV9BUkNIX1ZFUlNJT04pICYmIFdURl9BUk1fQVJD SF9WRVJTSU9OID09IDYpCi0gICAgcmV0dXJuIGNmTG9jYWxlQ2FjaGUoKS5nZXQobG9jYWxlSWRl bnRpZmllcik7Ci0jZWxzZQotICAgIC8vIEh5cGhlbmF0aW9uIGlzIG5vdCBhdmFpbGFibGUgb24g ZGV2aWNlcyB3aXRoIEFSTXY2IHByb2Nlc3NvcnMuIFNlZSA8cmRhcjovLzgzNTI1NzA+LgotICAg IFVOVVNFRF9QQVJBTShsb2NhbGVJZGVudGlmaWVyKTsKLSAgICByZXR1cm4gZmFsc2U7Ci0jZW5k aWYKLSNlbmRpZiAvLyBQTEFURk9STShJT1MpCiB9CiAKIHNpemVfdCBsYXN0SHlwaGVuTG9jYXRp b24oU3RyaW5nVmlldyB0ZXh0LCBzaXplX3QgYmVmb3JlSW5kZXgsIGNvbnN0IEF0b21pY1N0cmlu ZyYgbG9jYWxlSWRlbnRpZmllcikK