136416 2014-08-31 04:45:55 -0700 Remove unnecessary (and unnecessarily iOS-specific) setStrokeAndFillColor 2014-08-31 15:06:49 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton commit-queue mitz simon.fraser oldest_to_newest 1032399 0 thorton 2014-08-31 04:45:55 -0700 All of the callers only end up filling, and this function is pretty silly and not really in the right place. 1032400 1 237426 thorton 2014-08-31 04:53:36 -0700 Created attachment 237426 Patch 1032401 2 commit-queue 2014-08-31 04:54:43 -0700 Attachment 237426 did not pass style-queue: ERROR: Source/WebKit/ios/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 3 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1032420 3 thorton 2014-08-31 15:06:49 -0700 http://trac.webkit.org/changeset/173150 237426 2014-08-31 04:53:36 -0700 2014-08-31 09:33:27 -0700 Patch fillstroke.diff text/plain 7227 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZmE0Yjc4Li41ZDIwMmJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDgtMzEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5IChhbmQgdW5uZWNlc3NhcmlseSBpT1Mtc3BlY2lm aWMpIHNldFN0cm9rZUFuZEZpbGxDb2xvcgorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BT ISkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBX ZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRl eHQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpzZXRTdHJva2VBbmRGaWxsQ29sb3IpOiBEZWxldGVkLgor ICAgICAgICBSZW1vdmUuCisKIDIwMTQtMDgtMzAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KIAogICAgICAgICBDb252ZXJ0IHN0cmluZyBsaXRlcmFscyB0byBjaGFyYWN0 ZXIgbGl0ZXJhbHMgaW4gbWFrZVN0cmluZyB1c2FnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvV2ViQ29yZS5leHAuaW4gYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgppbmRleCA4 Njk1MTE3Li4yNjI4YWQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5p bgorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgpAQCAtMjY1NCw3ICsyNjU0LDYg QEAgX19aTjdXZWJDb3JlMjFNZW1vcnlQcmVzc3VyZUhhbmRsZXIzMXNob3VsZFdhaXRGb3JNZW1v cnlDbGVhck1lc3NhZ2VFdgogX19aTjdXZWJDb3JlMjFTUUxpdGVEYXRhYmFzZVRyYWNrZXI5c2V0 Q2xpZW50RVBOU18yN1NRTGl0ZURhdGFiYXNlVHJhY2tlckNsaWVudEUKIF9fWk43V2ViQ29yZTIx YXBwbGljYXRpb25Jc0ZhY2Vib29rRXYKIF9fWk43V2ViQ29yZTIxbmV4dFBhcmFncmFwaFBvc2l0 aW9uRVJLTlNfMTVWaXNpYmxlUG9zaXRpb25FaQotX19aTjdXZWJDb3JlMjFzZXRTdHJva2VBbmRG aWxsQ29sb3JFUDlDR0NvbnRleHRQN0NHQ29sb3IKIF9fWk43V2ViQ29yZTIxd29yZFJhbmdlRnJv bVBvc2l0aW9uRVJLTlNfMTVWaXNpYmxlUG9zaXRpb25FCiBfX1pON1dlYkNvcmUyMnN0YXJ0T2ZF ZGl0YWJsZUNvbnRlbnRFUktOU18xNVZpc2libGVQb3NpdGlvbkUKIF9fWk43V2ViQ29yZTIzYXBw bGljYXRpb25Jc01vYmlsZU1haWxFdgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAppbmRleCBhZjVhMDViLi5mZDUwYzRhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaApA QCAtMTg5LDEwICsxODksNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgZHJh d0x1bWluYW5jZU1hc2sgOiAxOwogICAgIH07CiAKLSNpZiBQTEFURk9STShJT1MpCi0gICAgV0VC Q09SRV9FWFBPUlQgdm9pZCBzZXRTdHJva2VBbmRGaWxsQ29sb3IoUGxhdGZvcm1HcmFwaGljc0Nv bnRleHQqLCBDR0NvbG9yUmVmKTsKLSNlbmRpZgotCiAgICAgc3RydWN0IEltYWdlUGFpbnRpbmdP cHRpb25zIHsKICAgICAgICAgSW1hZ2VQYWludGluZ09wdGlvbnMoQ29tcG9zaXRlT3BlcmF0b3Ig Y29tcG9zaXRlT3BlcmF0b3IgPSBDb21wb3NpdGVTb3VyY2VPdmVyLCBCbGVuZE1vZGUgYmxlbmRN b2RlID0gQmxlbmRNb2RlTm9ybWFsLCBJbWFnZU9yaWVudGF0aW9uRGVzY3JpcHRpb24gb3JpZW50 YXRpb25EZXNjcmlwdGlvbiA9IEltYWdlT3JpZW50YXRpb25EZXNjcmlwdGlvbigpLCBib29sIHVz ZUxvd1F1YWxpdHlTY2FsZSA9IGZhbHNlKQogICAgICAgICAgICAgOiBtX2NvbXBvc2l0ZU9wZXJh dG9yKGNvbXBvc2l0ZU9wZXJhdG9yKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCmluZGV4IGIwYTA1ZDUuLmRh NzRlMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dy YXBoaWNzQ29udGV4dENHLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAKQEAgLTEwNCwxNCArMTA0LDYgQEAgQ0dDb2xvclNw YWNlUmVmIHNSR0JDb2xvclNwYWNlUmVmKCkKICNlbmRpZiAvLyBQTEFURk9STShJT1MpCiB9CiAK LSNpZiBQTEFURk9STShJT1MpCi12b2lkIHNldFN0cm9rZUFuZEZpbGxDb2xvcihDR0NvbnRleHRS ZWYgY29udGV4dCwgQ0dDb2xvclJlZiBjb2xvcikKLXsKLSAgICBDR0NvbnRleHRTZXRTdHJva2VD b2xvcldpdGhDb2xvcihjb250ZXh0LCBjb2xvcik7Ci0gICAgQ0dDb250ZXh0U2V0RmlsbENvbG9y V2l0aENvbG9yKGNvbnRleHQsIGNvbG9yKTsKLX0KLSNlbmRpZiAvLyBQTEFURk9STShJT1MpCi0K ICNpZiBQTEFURk9STShXSU4pIHx8IFBMQVRGT1JNKElPUykKIENHQ29sb3JTcGFjZVJlZiBsaW5l YXJSR0JDb2xvclNwYWNlUmVmKCkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvaW9zL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvaW9zL0NoYW5nZUxvZwppbmRleCA0NDBiYjQ5Li43ZmVm OWFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2lvcy9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9pb3MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDgtMzEgIFRpbSBI b3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVubmVj ZXNzYXJ5IChhbmQgdW5uZWNlc3NhcmlseSBpT1Mtc3BlY2lmaWMpIHNldFN0cm9rZUFuZEZpbGxD b2xvcgorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYlBERlZpZXdJT1Mu bW06CisgICAgICAgICgtW1dlYlBERlZpZXcgZHJhd1BhZ2U6XSk6CisgICAgICAgICgtW1dlYlBE RlZpZXcgZHJhd1JlY3Q6XSk6CisgICAgICAgICogV2ViVmlldy9XZWJQbGFpbldoaXRlVmlldy5t bToKKyAgICAgICAgV2Ugb25seSBlbmQgdXAgZmlsbGluZywgc28gb25seSBzZXQgdGhlIGZpbGwg Y29sb3IuCisKIDIwMTQtMDgtMjIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgSW1wbGVtZW50IHBhaW50IGZsYXNoaW5nIGluIHRoZSBXSzEgSW5zcGVj dG9yT3ZlcmxheSBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dl YlBERlZpZXdJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dlYlBERlZpZXdJT1Mu bW0KaW5kZXggZjY0OWY3ZC4uZGFiMDk0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9pb3Mv V2ViVmlldy9XZWJQREZWaWV3SU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvaW9zL1dlYlZpZXcv V2ViUERGVmlld0lPUy5tbQpAQCAtMTEzLDcgKzExMyw3IEBAIHN0YXRpYyBjb25zdCBmbG9hdCBQ QUdFX0hFSUdIVF9JTlNFVCAgICA9IDQuMCAqIDIuMDsKICAgICBDR0NvbnRleHRTYXZlR1N0YXRl KGNvbnRleHQpOwogICAgIENHRmxvYXQgaGVpZ2h0ID0gV2ViS2l0TGlua2VkT25PckFmdGVyKFdF QktJVF9GSVJTVF9WRVJTSU9OX1dJVEhfRkxJUFBFRF9TSEFET1dTKSA/IDIuMGYgOiAtMi4wZjsK ICAgICBDR0NvbnRleHRTZXRTaGFkb3dXaXRoQ29sb3IoY29udGV4dCwgQ0dTaXplTWFrZSgwLjBm LCBoZWlnaHQpLCAzLjBmLCBbW3NlbGYgY2xhc3NdIHNoYWRvd0NvbG9yXSk7Ci0gICAgc2V0U3Ry b2tlQW5kRmlsbENvbG9yKGNvbnRleHQsIGNhY2hlZENHQ29sb3IoQ29sb3I6OndoaXRlLCBDb2xv clNwYWNlRGV2aWNlUkdCKSk7CisgICAgQ0dDb250ZXh0U2V0RmlsbENvbG9yV2l0aENvbG9yKGNv bnRleHQsIGNhY2hlZENHQ29sb3IoQ29sb3I6OndoaXRlLCBDb2xvclNwYWNlRGV2aWNlUkdCKSk7 CiAgICAgQ0dDb250ZXh0RmlsbFJlY3QoY29udGV4dCwgcGFnZVJlY3QpOwogICAgIENHQ29udGV4 dFJlc3RvcmVHU3RhdGUoY29udGV4dCk7ICAgIAogICAgIApAQCAtMTczLDcgKzE3Myw3IEBAIHN0 YXRpYyBjb25zdCBmbG9hdCBQQUdFX0hFSUdIVF9JTlNFVCAgICA9IDQuMCAqIDIuMDsKIAogICAg IC8vIERyYXcgQmFja2dyb3VuZC4KICAgICBDR0NvbnRleHRTYXZlR1N0YXRlKGNvbnRleHQpOwot ICAgIHNldFN0cm9rZUFuZEZpbGxDb2xvcihjb250ZXh0LCBbW3NlbGYgY2xhc3NdIGJhY2tncm91 bmRDb2xvcl0pOworICAgIENHQ29udGV4dFNldEZpbGxDb2xvcldpdGhDb2xvcihjb250ZXh0LCBb W3NlbGYgY2xhc3NdIGJhY2tncm91bmRDb2xvcl0pOwogICAgIENHQ29udGV4dEZpbGxSZWN0KGNv bnRleHQsIGFSZWN0KTsKICAgICBDR0NvbnRleHRSZXN0b3JlR1N0YXRlKGNvbnRleHQpOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dlYlBsYWluV2hpdGVWaWV3Lm1t IGIvU291cmNlL1dlYktpdC9pb3MvV2ViVmlldy9XZWJQbGFpbldoaXRlVmlldy5tbQppbmRleCA4 YTJhZDViLi4xZTBlMDdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2lvcy9XZWJWaWV3L1dl YlBsYWluV2hpdGVWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvaW9zL1dlYlZpZXcvV2ViUGxh aW5XaGl0ZVZpZXcubW0KQEAgLTQyLDcgKzQyLDcgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7 CiAtICh2b2lkKWRyYXdSZWN0OihOU1JlY3QpcmVjdAogewogICAgIENHQ29udGV4dFJlZiBjb250 ZXh0ID0gV0tHZXRDdXJyZW50R3JhcGhpY3NDb250ZXh0KCk7Ci0gICAgc2V0U3Ryb2tlQW5kRmls bENvbG9yKGNvbnRleHQsIGNhY2hlZENHQ29sb3IoQ29sb3I6OndoaXRlLCBDb2xvclNwYWNlRGV2 aWNlUkdCKSk7CisgICAgQ0dDb250ZXh0U2V0RmlsbENvbG9yV2l0aENvbG9yKGNvbnRleHQsIGNh Y2hlZENHQ29sb3IoQ29sb3I6OndoaXRlLCBDb2xvclNwYWNlRGV2aWNlUkdCKSk7CiAgICAgV0tS ZWN0RmlsbChjb250ZXh0LCBbc2VsZiBib3VuZHNdKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCmluZGV4 IGNmMDc4MWIuLmY0ZTU4YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAx NC0wOC0zMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAg ICBSZW1vdmUgdW5uZWNlc3NhcnkgKGFuZCB1bm5lY2Vzc2FyaWx5IGlPUy1zcGVjaWZpYykgc2V0 U3Ryb2tlQW5kRmlsbENvbG9yCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlZpZXcv V2ViRnJhbWVWaWV3Lm1tOgorICAgICAgICAoLVtXZWJGcmFtZVZpZXcgZHJhd1JlY3Q6XSk6Cisg ICAgICAgIFdlIG9ubHkgZW5kIHVwIGZpbGxpbmcsIHNvIG9ubHkgc2V0IHRoZSBmaWxsIGNvbG9y LgorCiAyMDE0LTA4LTI2ICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAg ICAgICAgVXNlIFJldGFpblB0cjo6YXV0b3JlbGVhc2UgaW4gc29tZSBwbGFjZXMgd2hlcmUgaXQg c2VlbXMgYXBwcm9wcmlhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcv V2ViRnJhbWVWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJGcmFtZVZpZXcu bW0KaW5kZXggODVmYWE2My4uNjUzYTc3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMv V2ViVmlldy9XZWJGcmFtZVZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9X ZWJGcmFtZVZpZXcubW0KQEAgLTUyNiw3ICs1MjYsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYWRk VHlwZXNGcm9tQ2xhc3MoTlNNdXRhYmxlRGljdGlvbmFyeSAqYWxsVHlwZXMsIENsYXNzIG9iakND bAogICAgICAgICAgICAgTlNSZWN0RmlsbChyZWN0KTsKICNlbHNlCiAgICAgICAgICAgICBDR0Nv bnRleHRSZWYgY2dDb250ZXh0ID0gV0tHZXRDdXJyZW50R3JhcGhpY3NDb250ZXh0KCk7Ci0gICAg ICAgICAgICBzZXRTdHJva2VBbmRGaWxsQ29sb3IoY2dDb250ZXh0LCBjYWNoZWRDR0NvbG9yKENv bG9yOjp3aGl0ZSwgQ29sb3JTcGFjZURldmljZVJHQikpOworICAgICAgICAgICAgQ0dDb250ZXh0 U2V0RmlsbENvbG9yV2l0aENvbG9yKGNnQ29udGV4dCwgY2FjaGVkQ0dDb2xvcihDb2xvcjo6d2hp dGUsIENvbG9yU3BhY2VEZXZpY2VSR0IpKTsKICAgICAgICAgICAgIFdLUmVjdEZpbGwoY2dDb250 ZXh0LCByZWN0KTsKICNlbmRpZgogICAgICAgICB9CkBAIC01MzgsNyArNTM4LDcgQEAgc3RhdGlj IGlubGluZSB2b2lkIGFkZFR5cGVzRnJvbUNsYXNzKE5TTXV0YWJsZURpY3Rpb25hcnkgKmFsbFR5 cGVzLCBDbGFzcyBvYmpDQ2wKICAgICAgICAgICAgIE5TUmVjdEZpbGwocmVjdCk7CiAjZWxzZQog ICAgICAgICAgICAgQ0dDb250ZXh0UmVmIGNnQ29udGV4dCA9IFdLR2V0Q3VycmVudEdyYXBoaWNz Q29udGV4dCgpOwotICAgICAgICAgICAgc2V0U3Ryb2tlQW5kRmlsbENvbG9yKGNnQ29udGV4dCwg Y2FjaGVkQ0dDb2xvcihDb2xvcjo6Y3lhbiwgQ29sb3JTcGFjZURldmljZVJHQikpOworICAgICAg ICAgICAgQ0dDb250ZXh0U2V0RmlsbENvbG9yV2l0aENvbG9yKGNnQ29udGV4dCwgY2FjaGVkQ0dD b2xvcihDb2xvcjo6Y3lhbiwgQ29sb3JTcGFjZURldmljZVJHQikpOwogICAgICAgICAgICAgV0tS ZWN0RmlsbChjZ0NvbnRleHQsIHJlY3QpOwogI2VuZGlmCiAgICAgICAgIH0K