136408 2014-08-30 22:23:35 -0700 SVGImage::drawPatternForContainer creates a buffer without respecting the destination's acceleration setting 2014-08-31 00:42:11 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue d-r fmalita gyuyoung.kim mitz pdr schenney sergio simon.fraser zimmermann oldest_to_newest 1032372 0 thorton 2014-08-30 22:23:35 -0700 Mismatched acceleration settings == terrible performance. rdar://problem/12013317 1032373 1 237419 thorton 2014-08-30 22:25:17 -0700 Created attachment 237419 patch 1032374 2 commit-queue 2014-08-30 22:27:32 -0700 Attachment 237419 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1032380 3 237419 mitz 2014-08-31 00:04:05 -0700 Comment on attachment 237419 patch Any way to test this? Is this a performance enhancement or something else? 1032383 4 thorton 2014-08-31 00:34:01 -0700 Just performance, no way to test (unless we were to add some mechanism to log when someone paints from an unaccelerated buffer to an accelerated context or vice versa, and then wrote some tests around that). 1032384 5 thorton 2014-08-31 00:42:11 -0700 http://trac.webkit.org/changeset/173143 237419 2014-08-30 22:25:17 -0700 2014-08-31 00:39:36 -0700 patch accel.diff text/plain 1923 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZmE0Yjc4Li4yNTA0ZmRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDgtMzAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgU1ZHSW1hZ2U6OmRyYXdQYXR0ZXJuRm9yQ29udGFpbmVyIGNyZWF0ZXMgYSBidWZm ZXIgd2l0aG91dCByZXNwZWN0aW5nIHRoZSBkZXN0aW5hdGlvbidzIGFjY2VsZXJhdGlvbiBzZXR0 aW5nCisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMhKS4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN2Zy9ncmFwaGljcy9TVkdJbWFnZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdJbWFnZTo6ZHJhd1BhdHRlcm5Gb3JDb250YWluZXIp OgorICAgICAgICBVc2UgSW1hZ2VCdWZmZXI6OmNyZWF0ZUNvbXBhdGlibGVCdWZmZXIsIHdoaWNo IHBhc3NlcyB0aGUgZGVzdGluYXRpb24ncworICAgICAgICBhY2NlbGVyYXRpb24gc2V0dGluZyB0 aHJvdWdoIHRvIHRoZSBJbWFnZUJ1ZmZlciBjb25zdHJ1Y3Rvci4KKworICAgICAgICBJIGRpZG4n dCB1c2UgR3JhcGhpY3NDb250ZXh0OjpjcmVhdGVDb21wYXRpYmxlQnVmZmVyIGJlY2F1c2UgYWRq dXN0aW5nCisgICAgICAgIGhvdyB0aGlzIGZ1bmN0aW9uIGFwcGxpZXMgdGhlIGRlc3RpbmF0aW9u J3MgQ1RNIGlzIG91dHNpZGUgdGhlIHNjb3BlIG9mIHRoaXMgcGF0Y2guCisKIDIwMTQtMDgtMzAg IEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBDb252ZXJ0 IHN0cmluZyBsaXRlcmFscyB0byBjaGFyYWN0ZXIgbGl0ZXJhbHMgaW4gbWFrZVN0cmluZyB1c2Fn ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKaW5kZXggMDQxMDJkYi4u YTQ4OTE5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwCkBAIC0x OTQsNyArMTk0LDcgQEAgdm9pZCBTVkdJbWFnZTo6ZHJhd1BhdHRlcm5Gb3JDb250YWluZXIoR3Jh cGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBGbG9hdFNpemUKICAgICBGbG9hdFJlY3QgaW1h Z2VCdWZmZXJTaXplID0gem9vbWVkQ29udGFpbmVyUmVjdDsKICAgICBpbWFnZUJ1ZmZlclNpemUu c2NhbGUoaW1hZ2VCdWZmZXJTY2FsZS53aWR0aCgpLCBpbWFnZUJ1ZmZlclNjYWxlLmhlaWdodCgp KTsKIAotICAgIHN0ZDo6dW5pcXVlX3B0cjxJbWFnZUJ1ZmZlcj4gYnVmZmVyID0gSW1hZ2VCdWZm ZXI6OmNyZWF0ZShleHBhbmRlZEludFNpemUoaW1hZ2VCdWZmZXJTaXplLnNpemUoKSksIDEpOwor ICAgIHN0ZDo6dW5pcXVlX3B0cjxJbWFnZUJ1ZmZlcj4gYnVmZmVyID0gSW1hZ2VCdWZmZXI6OmNy ZWF0ZUNvbXBhdGlibGVCdWZmZXIoZXhwYW5kZWRJbnRTaXplKGltYWdlQnVmZmVyU2l6ZS5zaXpl KCkpLCAxLCBDb2xvclNwYWNlRGV2aWNlUkdCLCBjb250ZXh0LCB0cnVlKTsKICAgICBpZiAoIWJ1 ZmZlcikgLy8gRmFpbGVkIHRvIGFsbG9jYXRlIGJ1ZmZlci4KICAgICAgICAgcmV0dXJuOwogICAg IGRyYXdGb3JDb250YWluZXIoYnVmZmVyLT5jb250ZXh0KCksIGNvbnRhaW5lclNpemUsIHpvb20s IGltYWdlQnVmZmVyU2l6ZSwgem9vbWVkQ29udGFpbmVyUmVjdCwgQ29sb3JTcGFjZURldmljZVJH QiwgQ29tcG9zaXRlU291cmNlT3ZlciwgQmxlbmRNb2RlTm9ybWFsKTsK