136378 2014-08-29 11:45:41 -0700 WebPageProxy::close() is a no-op for terminated processes 2014-08-29 14:23:41 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca beidson commit-queue sam oldest_to_newest 1032215 0 ap 2014-08-29 11:45:41 -0700 WebPageProxy::close() has some clean-up that should happen regardless of whether the page has a running process, but it is a no-op when isValid() returns false. 1032216 1 ap 2014-08-29 11:46:25 -0700 Related to <rdar://problem/16991213> and to <rdar://problem/17095600>. 1032218 2 237366 ap 2014-08-29 11:53:00 -0700 Created attachment 237366 proposed fix 1032234 3 237366 beidson 2014-08-29 13:22:48 -0700 Comment on attachment 237366 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=237366&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:555 > + m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_pageID); KEY!!!! 1032253 4 237366 commit-queue 2014-08-29 14:23:38 -0700 Comment on attachment 237366 proposed fix Clearing flags on attachment: 237366 Committed r173118: <http://trac.webkit.org/changeset/173118> 1032254 5 commit-queue 2014-08-29 14:23:41 -0700 All reviewed patches have been landed. Closing bug. 237366 2014-08-29 11:53:00 -0700 2014-08-29 14:23:37 -0700 proposed fix CloseShouldClose.txt text/plain 3911 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzExNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE0LTA4LTI5ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFdlYlBhZ2VQcm94eTo6Y2xv c2UoKSBpcyBhIG5vLW9wIGZvciB0ZXJtaW5hdGVkIHByb2Nlc3NlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2Mzc4CisgICAgICAgIFJlbGF0ZWQg dG8gPHJkYXI6Ly9wcm9ibGVtLzE2OTkxMjEzPiBhbmQgdG8gPHJkYXI6Ly9wcm9ibGVtLzE3MDk1 NjAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFs c28gZml4ZXMgaXNzdWVzIHRoYXQgZ290IHVuY292ZXJlZCBhZnRlciBtYWtpbmcgY2xvc2UoKSB3 b3JrLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkluc3BlY3RvclByb3h5LmNwcDogKFdlYktp dDo6V2ViSW5zcGVjdG9yUHJveHk6OmludmFsaWRhdGUpOiBEb24ndAorICAgICAgICBjbG9zZSB0 aGUgcGFnZSwgYmVjYXVzZSBpdCBtYWtlcyBubyBzZW5zZSwgYW5kIGNhdXNlcyBhbiBhc3NlcnRp b24gbm93LiBQcmV2aW9zbHksCisgICAgICAgIHRoaXMgd2FzIE9LIGJlY2F1c2UgdGhlIHBhZ2Ug d2FzIGludmFsaWQgYWxyZWFkeSwgYW5kIGNsb3NlKCkgd2FzIGEgbm8tb3AuCisKKyAgICAgICAg KiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVBy b3h5Ojp+V2ViUGFnZVByb3h5KTogQWRkZWQgc29tZSBhc3NlcnRpb25zIHRvIGNhdGNoIGludmFs aWRhdGlvbgorICAgICAgICBpc3N1ZXMgZWFybGllci4KKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZVByb3h5OjpyZWF0dGFjaFRvV2ViUHJvY2Vzcyk6IE1ha2UgaXQgYW4gaW52YXJpYW50IHRoYXQg YSBwYWdlJ3MKKyAgICAgICAgcHJvY2VzcyBhbHdheXMgaGFzIGEgbWVzc2FnZSByZWNlaXZlciBm b3IgaXQsIHVudGlsIGNsb3NlKCkgcmVtb3ZlcyBpdC4KKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZVByb3h5OjpjbG9zZSk6IE1ha2UgdGhpcyBmdW5jdGlvbiB3b3JrIGZvciBhbGwgb3BlbiBwYWdl cywgd2hldGhlcgorICAgICAgICB0aGV5IGhhdmUgYSBwYWdlIG9yIG5vdC4KKyAgICAgICAgKFdl YktpdDo6V2ViUGFnZVByb3h5Ojpwcm9jZXNzRGlkRmluaXNoTGF1bmNoaW5nKTogQWRkZWQgYW4g YXNzZXJpb24gdGhhdCBwcm9jZXNzCisgICAgICAgIGFncmVlcyBhYm91dCBpdHMgc3RhdGUuCisg ICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cmVzZXRTdGF0ZUFmdGVyUHJvY2Vzc0V4aXRl ZCk6IERvbid0IHJlbW92ZSBhIG1lc3NhZ2UgcmVjZWl2ZXIsCisgICAgICAgIHdlIG5vdyBvbmx5 IGRvIHRoaXMgaW4gcmVhdHRhY2ggb3IgY2xvc2UuCisKIDIwMTQtMDgtMjkgIEFudHRpIEtvaXZp c3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBOZXR3b3JrUmVzb3VyY2VM b2FkZXJDbGllbnQgYW5kIHN1YmNsYXNzZXMuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAJKHJldmlzaW9uIDE3MzAwNikKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE2Myw4ICsxNjMsNiBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5OjppbnZhbGlkYXRlKCkK IAogICAgIG1fcGFnZS0+cHJvY2VzcygpLnJlbW92ZU1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6 V2ViSW5zcGVjdG9yUHJveHk6Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSwgbV9wYWdlLT5wYWdlSUQo KSk7CiAKLSAgICBtX3BhZ2UtPmNsb3NlKCk7Ci0KICAgICBkaWRDbG9zZSgpOwogCiAgICAgbV9w YWdlID0gMDsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CShyZXZpc2lvbiAxNzMwMDYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDI1LDYgKzQyNSwxMiBAQCBXZWJQYWdlUHJveHk6 OldlYlBhZ2VQcm94eShQYWdlQ2xpZW50JiBwCiAKIFdlYlBhZ2VQcm94eTo6fldlYlBhZ2VQcm94 eSgpCiB7CisgICAgQVNTRVJUKG1fcHJvY2Vzcy0+d2ViUGFnZShtX3BhZ2VJRCkgIT0gdGhpcyk7 CisjaWYgIUFTU0VSVF9ESVNBQkxFRAorICAgIGZvciAoV2ViUGFnZVByb3h5KiBwYWdlIDogbV9w cm9jZXNzLT5wYWdlcygpKQorICAgICAgICBBU1NFUlQocGFnZSAhPSB0aGlzKTsKKyNlbmRpZgor CiAgICAgaWYgKCFtX2lzQ2xvc2VkKQogICAgICAgICBjbG9zZSgpOwogCkBAIC01NDYsNiArNTUy LDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnJlYXR0YWNoVG9XZWJQcm9jZXNzKAogCiAgICAgbV9p c1ZhbGlkID0gdHJ1ZTsKICAgICBtX3Byb2Nlc3MtPnJlbW92ZVdlYlBhZ2UobV9wYWdlSUQpOwor ICAgIG1fcHJvY2Vzcy0+cmVtb3ZlTWVzc2FnZVJlY2VpdmVyKE1lc3NhZ2VzOjpXZWJQYWdlUHJv eHk6Om1lc3NhZ2VSZWNlaXZlck5hbWUoKSwgbV9wYWdlSUQpOwogCiAgICAgaWYgKG1fcHJvY2Vz cy0+Y29udGV4dCgpLnByb2Nlc3NNb2RlbCgpID09IFByb2Nlc3NNb2RlbFNoYXJlZFNlY29uZGFy eVByb2Nlc3MpCiAgICAgICAgIG1fcHJvY2VzcyA9IG1fcHJvY2Vzcy0+Y29udGV4dCgpLmVuc3Vy ZVNoYXJlZFdlYlByb2Nlc3MoKTsKQEAgLTY1MCw3ICs2NTcsNyBAQCBib29sIFdlYlBhZ2VQcm94 eTo6aXNQcm9jZXNzU3VwcHJlc3NpYmxlCiAKIHZvaWQgV2ViUGFnZVByb3h5OjpjbG9zZSgpCiB7 Ci0gICAgaWYgKCFpc1ZhbGlkKCkpCisgICAgaWYgKG1faXNDbG9zZWQpCiAgICAgICAgIHJldHVy bjsKIAogICAgIG1faXNDbG9zZWQgPSB0cnVlOwpAQCAtMzEzMyw2ICszMTQwLDggQEAgdm9pZCBX ZWJQYWdlUHJveHk6OmNvbm5lY3Rpb25XaWxsQ2xvc2UoSQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6 cHJvY2Vzc0RpZEZpbmlzaExhdW5jaGluZygpCiB7CisgICAgQVNTRVJUKG1fcHJvY2Vzcy0+c3Rh dGUoKSA9PSBXZWJQcm9jZXNzUHJveHk6OlN0YXRlOjpSdW5uaW5nKTsKKwogICAgIGlmIChtX3Vz ZXJDb250ZW50Q29udHJvbGxlcikKICAgICAgICAgbV91c2VyQ29udGVudENvbnRyb2xsZXItPmFk ZFByb2Nlc3MobV9wcm9jZXNzLmdldCgpKTsKICAgICBtX3Zpc2l0ZWRMaW5rUHJvdmlkZXItPmFk ZFByb2Nlc3MobV9wcm9jZXNzLmdldCgpKTsKQEAgLTQ0NTksOCArNDQ2OCw2IEBAIHZvaWQgV2Vi UGFnZVByb3h5OjpyZXNldFN0YXRlQWZ0ZXJQcm9jZXMKICAgICAgICAgbV92aXNpdGVkTGlua1By b3ZpZGVyLT5yZW1vdmVQcm9jZXNzKG1fcHJvY2Vzcy5nZXQoKSk7CiAgICAgfQogCi0gICAgbV9w cm9jZXNzLT5yZW1vdmVNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6bWVz c2FnZVJlY2VpdmVyTmFtZSgpLCBtX3BhZ2VJRCk7Ci0KICNpZiBQTEFURk9STShJT1MpCiAgICAg bV9hY3Rpdml0eVRva2VuID0gbnVsbHB0cjsKICNlbmRpZgo=