13637 2007-05-09 02:17:48 -0700 Gdk build fix 2007-05-09 09:16:50 -0700 1 1 1 Unclassified WebKit New Bugs 420+ PC Linux RESOLVED DUPLICATE 13641 P2 Normal --- 0 atul.mehrotra webkit-unassigned oldest_to_newest 10637 0 atul.mehrotra 2007-05-09 02:17:48 -0700 obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::ignoreSpelling()':../../platform/gdk/TemporaryLinkStubs.cpp:285: multiple definition of `WebCore::Editor::ignoreSpelling()' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:1702: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::ignoreSpelling()' changed from 267 in obj-gnu/webcore_gdk_Editor.o to 114 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::learnSpelling()':../../platform/gdk/TemporaryLinkStubs.cpp:286: multiple definition of `WebCore::Editor::learnSpelling()' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:1712: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::learnSpelling()' changed from 267 in obj-gnu/webcore_gdk_Editor.o to 114 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::isSelectionUngrammatical()':../../platform/gdk/TemporaryLinkStubs.cpp:287: multiple definition of `WebCore::Editor::isSelectionUngrammatical()' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:2114: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::isSelectionUngrammatical()' changed from 245 in obj-gnu/webcore_gdk_Editor.o to 116 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::advanceToNextMisspelling(bool)':../../platform/gdk/TemporaryLinkStubs.cpp:288: multiple definition of `WebCore::Editor::advanceToNextMisspelling(bool)' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:1903: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::advanceToNextMisspelling(bool)' changed from 6393 in obj-gnu/webcore_gdk_Editor.o to 114 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::isSelectionMisspelled()':../../platform/gdk/TemporaryLinkStubs.cpp:289: multiple definition of `WebCore::Editor::isSelectionMisspelled()' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:2040: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::isSelectionMisspelled()' changed from 450 in obj-gnu/webcore_gdk_Editor.o to 116 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::markMisspellingsAfterTypingToPosition(WebCore::VisiblePosition const&)':../../platform/gdk/TemporaryLinkStubs.cpp:292: multiple definition of `WebCore::Editor::markMisspellingsAfterTypingToPosition(WebCore::VisiblePosition const&)' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:2174: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::markMisspellingsAfterTypingToPosition(WebCore::VisiblePosition const&)' changed from 856 in obj-gnu/webcore_gdk_Editor.o to 114 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::markMisspellings(WebCore::Selection const&)':../../platform/gdk/TemporaryLinkStubs.cpp:294: multiple definition of `WebCore::Editor::markMisspellings(WebCore::Selection const&)' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:2244: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::markMisspellings(WebCore::Selection const&)' changed from 22 in obj-gnu/webcore_gdk_Editor.o to 114 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::markBadGrammar(WebCore::Selection const&)':../../platform/gdk/TemporaryLinkStubs.cpp:295: multiple definition of `WebCore::Editor::markBadGrammar(WebCore::Selection const&)' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:2249: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::markBadGrammar(WebCore::Selection const&)' changed from 22 in obj-gnu/webcore_gdk_Editor.o to 114 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::showSpellingGuessPanel()':../../platform/gdk/TemporaryLinkStubs.cpp:296: multiple definition of `WebCore::Editor::showSpellingGuessPanel()' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:2147: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::showSpellingGuessPanel()' changed from 186 in obj-gnu/webcore_gdk_Editor.o to 114 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::spellingPanelIsShowing()':../../platform/gdk/TemporaryLinkStubs.cpp:297: multiple definition of `WebCore::Editor::spellingPanelIsShowing()' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:2167: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::spellingPanelIsShowing()' changed from 86 in obj-gnu/webcore_gdk_Editor.o to 116 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::guessesForUngrammaticalSelection()':../../platform/gdk/TemporaryLinkStubs.cpp:291: multiple definition of `WebCore::Editor::guessesForUngrammaticalSelection()' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:2124: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::guessesForUngrammaticalSelection()' changed from 224 in obj-gnu/webcore_gdk_Editor.o to 150 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o obj-gnu/webcore_gdk_TemporaryLinkStubs.o: In function `WebCore::Editor::guessesForMisspelledSelection()':../../platform/gdk/TemporaryLinkStubs.cpp:290: multiple definition of `WebCore::Editor::guessesForMisspelledSelection()' obj-gnu/webcore_gdk_Editor.o:../../editing/Editor.cpp:2136: first defined here /usr/bin/ld: Warning: size of symbol `WebCore::Editor::guessesForMisspelledSelection()' changed from 321 in obj-gnu/webcore_gdk_Editor.o to 150 in obj-gnu/webcore_gdk_TemporaryLinkStubs.o collect2: ld returned 1 exit status make: *** [libwebcore-gdk.so] Error 1 10624 1 14424 atul.mehrotra 2007-05-09 02:18:50 -0700 Created attachment 14424 patch for build fix 10625 2 14424 atul.mehrotra 2007-05-09 02:23:22 -0700 Comment on attachment 14424 patch for build fix >Index: WebCore/ChangeLog >=================================================================== >--- WebCore/ChangeLog (revision 21330) >+++ WebCore/ChangeLog (working copy) >@@ -1,3 +1,11 @@ >+2007-05-09 Atul,,, <atul.mehrotra@celunite.com> +2007-05-09 Atul Mehrotra <atul.mehrotra@celunite.com> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ WARNING: NO TEST CASES ADDED OR CHANGED >+ >+ * platform/gdk/TemporaryLinkStubs.cpp: >+ > 2007-05-09 Mitz Pettel <mitz@webkit.org> > > Reviewed by Dave Hyatt. >Index: WebCore/platform/gdk/TemporaryLinkStubs.cpp >=================================================================== >--- WebCore/platform/gdk/TemporaryLinkStubs.cpp (revision 21330) >+++ WebCore/platform/gdk/TemporaryLinkStubs.cpp (working copy) >@@ -282,19 +282,8 @@ int Font::offsetForPositionForComplexTex > > void CachedPage::close() { notImplementedGdk(); } > >-void Editor::ignoreSpelling() { notImplementedGdk(); } >-void Editor::learnSpelling() { notImplementedGdk(); } >-bool Editor::isSelectionUngrammatical() { notImplementedGdk(); return false; } >-void Editor::advanceToNextMisspelling(bool startBeforeSelection) { notImplementedGdk(); } >-bool Editor::isSelectionMisspelled() { notImplementedGdk(); return false; } >-Vector<String> Editor::guessesForMisspelledSelection() { notImplementedGdk(); return Vector<String>(); } >-Vector<String> Editor::guessesForUngrammaticalSelection() { notImplementedGdk(); return Vector<String>(); } >-void Editor::markMisspellingsAfterTypingToPosition(const VisiblePosition&) { notImplementedGdk(); } > PassRefPtr<Clipboard> Editor::newGeneralClipboard(ClipboardAccessPolicy) { notImplementedGdk(); return 0; } >-void Editor::markMisspellings(const Selection&) { notImplementedGdk(); } >-void Editor::markBadGrammar(const Selection&) { notImplementedGdk(); } >-void Editor::showSpellingGuessPanel() { notImplementedGdk(); } >-bool Editor::spellingPanelIsShowing() { notImplementedGdk(); return false; } > > Pasteboard* Pasteboard::generalPasteboard() { notImplementedGdk(); return 0; } > void Pasteboard::writeSelection(Range*, bool, Frame*) { notImplementedGdk(); } 10626 3 14425 atul.mehrotra 2007-05-09 02:27:27 -0700 Created attachment 14425 Patch for Gdk Build fix Removed unnecessary space & also put full name in changelog. 10455 4 atul.mehrotra 2007-05-09 03:25:25 -0700 *** This bug has been marked as a duplicate of 13641 *** 14424 2007-05-09 02:18:50 -0700 2007-05-09 09:16:50 -0700 patch for build fix patch.21330 text/plain 2058 atul.mehrotra SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTMzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDctMDUtMDkgIEF0dWwsLCwgIDxhdHVsLm1laHJvdHJhQGNlbHVu aXRlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICAqIHBs YXRmb3JtL2dkay9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwOgorCiAyMDA3LTA1LTA5ICBNaXR6IFBl dHRlbCAgPG1pdHpAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0 LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9nZGsvVGVtcG9yYXJ5TGlua1N0dWJzLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dkay9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwCShy ZXZpc2lvbiAyMTMzMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ2RrL1RlbXBvcmFyeUxpbmtTdHVi cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4MiwxOSArMjgyLDggQEAgaW50IEZvbnQ6Om9mZnNl dEZvclBvc2l0aW9uRm9yQ29tcGxleFRleAogCiB2b2lkIENhY2hlZFBhZ2U6OmNsb3NlKCkgeyBu b3RJbXBsZW1lbnRlZEdkaygpOyB9CiAKLXZvaWQgRWRpdG9yOjppZ25vcmVTcGVsbGluZygpIHsg bm90SW1wbGVtZW50ZWRHZGsoKTsgfQotdm9pZCBFZGl0b3I6OmxlYXJuU3BlbGxpbmcoKSB7IG5v dEltcGxlbWVudGVkR2RrKCk7IH0KLWJvb2wgRWRpdG9yOjppc1NlbGVjdGlvblVuZ3JhbW1hdGlj YWwoKSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IHJldHVybiBmYWxzZTsgfQotdm9pZCBFZGl0b3I6 OmFkdmFuY2VUb05leHRNaXNzcGVsbGluZyhib29sIHN0YXJ0QmVmb3JlU2VsZWN0aW9uKSB7IG5v dEltcGxlbWVudGVkR2RrKCk7IH0KLWJvb2wgRWRpdG9yOjppc1NlbGVjdGlvbk1pc3NwZWxsZWQo KSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IHJldHVybiBmYWxzZTsgfQotVmVjdG9yPFN0cmluZz4g RWRpdG9yOjpndWVzc2VzRm9yTWlzc3BlbGxlZFNlbGVjdGlvbigpIHsgbm90SW1wbGVtZW50ZWRH ZGsoKTsgcmV0dXJuIFZlY3RvcjxTdHJpbmc+KCk7IH0KLVZlY3RvcjxTdHJpbmc+IEVkaXRvcjo6 Z3Vlc3Nlc0ZvclVuZ3JhbW1hdGljYWxTZWxlY3Rpb24oKSB7IG5vdEltcGxlbWVudGVkR2RrKCk7 IHJldHVybiBWZWN0b3I8U3RyaW5nPigpOyB9Ci12b2lkIEVkaXRvcjo6bWFya01pc3NwZWxsaW5n c0FmdGVyVHlwaW5nVG9Qb3NpdGlvbihjb25zdCBWaXNpYmxlUG9zaXRpb24mKSB7IG5vdEltcGxl bWVudGVkR2RrKCk7IH0KIFBhc3NSZWZQdHI8Q2xpcGJvYXJkPiBFZGl0b3I6Om5ld0dlbmVyYWxD bGlwYm9hcmQoQ2xpcGJvYXJkQWNjZXNzUG9saWN5KSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IHJl dHVybiAwOyB9Ci12b2lkIEVkaXRvcjo6bWFya01pc3NwZWxsaW5ncyhjb25zdCBTZWxlY3Rpb24m KSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IH0KLXZvaWQgRWRpdG9yOjptYXJrQmFkR3JhbW1hcihj b25zdCBTZWxlY3Rpb24mKSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IH0KLXZvaWQgRWRpdG9yOjpz aG93U3BlbGxpbmdHdWVzc1BhbmVsKCkgeyBub3RJbXBsZW1lbnRlZEdkaygpOyB9Ci1ib29sIEVk aXRvcjo6c3BlbGxpbmdQYW5lbElzU2hvd2luZygpIHsgbm90SW1wbGVtZW50ZWRHZGsoKTsgcmV0 dXJuIGZhbHNlOyB9CisKIAogUGFzdGVib2FyZCogUGFzdGVib2FyZDo6Z2VuZXJhbFBhc3RlYm9h cmQoKSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IHJldHVybiAwOyB9CiB2b2lkIFBhc3RlYm9hcmQ6 OndyaXRlU2VsZWN0aW9uKFJhbmdlKiwgYm9vbCwgRnJhbWUqKSB7IG5vdEltcGxlbWVudGVkR2Rr KCk7IH0K 14425 2007-05-09 02:27:27 -0700 2007-05-09 09:16:31 -0700 Patch for Gdk Build fix patch.21330 text/plain 2062 atul.mehrotra SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTMzMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDctMDUtMDkgIEF0dWwgTWVocm90cmEgIDxhdHVsLm1laHJvdHJh QGNlbHVuaXRlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAg ICAqIHBsYXRmb3JtL2dkay9UZW1wb3JhcnlMaW5rU3R1YnMuY3BwOgorCiAyMDA3LTA1LTA5ICBN aXR6IFBldHRlbCAgPG1pdHpAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZl IEh5YXR0LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9nZGsvVGVtcG9yYXJ5TGlua1N0dWJzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dkay9UZW1wb3JhcnlMaW5rU3R1YnMu Y3BwCShyZXZpc2lvbiAyMTMzMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ2RrL1RlbXBvcmFyeUxp bmtTdHVicy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4MiwxOSArMjgyLDggQEAgaW50IEZvbnQ6 Om9mZnNldEZvclBvc2l0aW9uRm9yQ29tcGxleFRleAogCiB2b2lkIENhY2hlZFBhZ2U6OmNsb3Nl KCkgeyBub3RJbXBsZW1lbnRlZEdkaygpOyB9CiAKLXZvaWQgRWRpdG9yOjppZ25vcmVTcGVsbGlu ZygpIHsgbm90SW1wbGVtZW50ZWRHZGsoKTsgfQotdm9pZCBFZGl0b3I6OmxlYXJuU3BlbGxpbmco KSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IH0KLWJvb2wgRWRpdG9yOjppc1NlbGVjdGlvblVuZ3Jh bW1hdGljYWwoKSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IHJldHVybiBmYWxzZTsgfQotdm9pZCBF ZGl0b3I6OmFkdmFuY2VUb05leHRNaXNzcGVsbGluZyhib29sIHN0YXJ0QmVmb3JlU2VsZWN0aW9u KSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IH0KLWJvb2wgRWRpdG9yOjppc1NlbGVjdGlvbk1pc3Nw ZWxsZWQoKSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IHJldHVybiBmYWxzZTsgfQotVmVjdG9yPFN0 cmluZz4gRWRpdG9yOjpndWVzc2VzRm9yTWlzc3BlbGxlZFNlbGVjdGlvbigpIHsgbm90SW1wbGVt ZW50ZWRHZGsoKTsgcmV0dXJuIFZlY3RvcjxTdHJpbmc+KCk7IH0KLVZlY3RvcjxTdHJpbmc+IEVk aXRvcjo6Z3Vlc3Nlc0ZvclVuZ3JhbW1hdGljYWxTZWxlY3Rpb24oKSB7IG5vdEltcGxlbWVudGVk R2RrKCk7IHJldHVybiBWZWN0b3I8U3RyaW5nPigpOyB9Ci12b2lkIEVkaXRvcjo6bWFya01pc3Nw ZWxsaW5nc0FmdGVyVHlwaW5nVG9Qb3NpdGlvbihjb25zdCBWaXNpYmxlUG9zaXRpb24mKSB7IG5v dEltcGxlbWVudGVkR2RrKCk7IH0KIFBhc3NSZWZQdHI8Q2xpcGJvYXJkPiBFZGl0b3I6Om5ld0dl bmVyYWxDbGlwYm9hcmQoQ2xpcGJvYXJkQWNjZXNzUG9saWN5KSB7IG5vdEltcGxlbWVudGVkR2Rr KCk7IHJldHVybiAwOyB9Ci12b2lkIEVkaXRvcjo6bWFya01pc3NwZWxsaW5ncyhjb25zdCBTZWxl Y3Rpb24mKSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IH0KLXZvaWQgRWRpdG9yOjptYXJrQmFkR3Jh bW1hcihjb25zdCBTZWxlY3Rpb24mKSB7IG5vdEltcGxlbWVudGVkR2RrKCk7IH0KLXZvaWQgRWRp dG9yOjpzaG93U3BlbGxpbmdHdWVzc1BhbmVsKCkgeyBub3RJbXBsZW1lbnRlZEdkaygpOyB9Ci1i b29sIEVkaXRvcjo6c3BlbGxpbmdQYW5lbElzU2hvd2luZygpIHsgbm90SW1wbGVtZW50ZWRHZGso KTsgcmV0dXJuIGZhbHNlOyB9CiAKIFBhc3RlYm9hcmQqIFBhc3RlYm9hcmQ6OmdlbmVyYWxQYXN0 ZWJvYXJkKCkgeyBub3RJbXBsZW1lbnRlZEdkaygpOyByZXR1cm4gMDsgfQogdm9pZCBQYXN0ZWJv YXJkOjp3cml0ZVNlbGVjdGlvbihSYW5nZSosIGJvb2wsIEZyYW1lKikgeyBub3RJbXBsZW1lbnRl ZEdkaygpOyB9Cg==