136354 2014-08-28 15:39:17 -0700 _setDidMoveSwipeSnapshotCallback's block should only be called if the snapshot is going to move 2014-08-28 17:01:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue mitz simon.fraser oldest_to_newest 1032085 0 thorton 2014-08-28 15:39:17 -0700 Don't call the callback if the snapshot is "below" the live view and won't be moving. rdar://problem/18167791 1032086 1 237327 thorton 2014-08-28 15:44:30 -0700 Created attachment 237327 patch 1032100 2 237327 commit-queue 2014-08-28 17:01:52 -0700 Comment on attachment 237327 patch Clearing flags on attachment: 237327 Committed r173093: <http://trac.webkit.org/changeset/173093> 1032101 3 commit-queue 2014-08-28 17:01:54 -0700 All reviewed patches have been landed. Closing bug. 237327 2014-08-28 15:44:30 -0700 2014-08-28 17:01:51 -0700 patch swipe2.diff text/plain 2802 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNzE2MDJkLi42ZjI2MjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTQtMDgtMjggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgX3NldERpZE1vdmVTd2lwZVNuYXBzaG90Q2FsbGJhY2sncyBibG9jayBzaG91bGQg b25seSBiZSBjYWxsZWQgaWYgdGhlIHNuYXBzaG90IGlzIGdvaW5nIHRvIG1vdmUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjM1NAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTgxNjc3OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZhdGUuaDoK KyAgICAgICAgVXBkYXRlIHRoZSBjb21tZW50IHRvIG5vdGUgdGhlIG5ldyBiZWhhdmlvci4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyTWFjLm1tOgorICAg ICAgICAoV2ViS2l0OjpWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OmJlZ2luU3dpcGVHZXN0dXJlKToK KyAgICAgICAgRG9uJ3QgY2FsbCB0aGUgYmxvY2sgdW50aWwgdGhlIHNuYXBzaG90IGlzIGFjdHVh bGx5IG1vdmluZyAoaWYgdGhlIHNuYXBzaG90CisgICAgICAgIG5ldmVyIG1vdmVzIGJlY2F1c2Ug aXQncyBiZWhpbmQgdGhlIGxpdmUgdmlldywgZG9uJ3QgY2FsbCB0aGUgYmxvY2sgYXQgYWxsKS4K KworMjAxNC0wOC0yOCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwog ICAgICAgICBXZWJLaXQyIGRvZXNuJ3Qgc3VwcG9ydCB2aWV3ZXIgc2VydmljZXMgdGhhdCBhY2Nl cHQgaW1hZ2UgYXR0YWNobWVudHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzNjM0OQogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTgxNjQ2MDY+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVmlld1ByaXZh dGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tWaWV3UHJpdmF0ZS5o CmluZGV4IDNiNTJhMWYuLmVhMmQ5NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tWaWV3UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tWaWV3UHJpdmF0ZS5oCkBAIC0xMTMsNyArMTEzLDcgQEAKIC8vIFRo ZSB0b3AgY29udGVudCBpbnNldCBpcyBhcHBsaWVkIGluIHRoZSB3aW5kb3cncyBjb29yZGluYXRl IHNwYWNlLCB0byB0aGUgdW5pb24gb2YgdGhlIGN1c3RvbSBzd2lwZSB2aWV3J3MgZnJhbWVzLgog LSAodm9pZClfc2V0Q3VzdG9tU3dpcGVWaWV3c1RvcENvbnRlbnRJbnNldDooZmxvYXQpdG9wQ29u dGVudEluc2V0OwogLSAoQk9PTClfdHJ5VG9Td2lwZVdpdGhFdmVudDooTlNFdmVudCAqKWV2ZW50 IGlnbm9yaW5nUGlubmVkU3RhdGU6KEJPT0wpaWdub3JpbmdQaW5uZWRTdGF0ZTsKLS8vIFRoZSBy ZWN0IHJldHVybmVkIGlzIGFsd2F5cyB0aGF0IG9mIHRoZSBzbmFwc2hvdCwgbm90IG5lY2Vzc2Fy aWx5IHRoZSBzd2lwaW5nIGxheWVyLiBUaGlzIG9ubHkgd29ya3MgZm9yIGxheWVyLWJhY2tlZCB3 aW5kb3dzLgorLy8gVGhlIHJlY3QgcmV0dXJuZWQgaXMgYWx3YXlzIHRoYXQgb2YgdGhlIHNuYXBz aG90LCBhbmQgb25seSBpZiBpdCBpcyB0aGUgdmlldyBiZWluZyBtYW5pcHVsYXRlZCBieSB0aGUg c3dpcGUuIFRoaXMgb25seSB3b3JrcyBmb3IgbGF5ZXItYmFja2VkIHdpbmRvd3MuCiAtICh2b2lk KV9zZXREaWRNb3ZlU3dpcGVTbmFwc2hvdENhbGxiYWNrOih2b2lkKF4pKENHUmVjdCBzd2lwZVNu YXBzaG90UmVjdEluV2luZG93Q29vcmRpbmF0ZXMpKWNhbGxiYWNrOwogCiAjZW5kaWYKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVy TWFjLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xs ZXJNYWMubW0KaW5kZXggOWI3MWI5Yi4uNWQ2NGQ5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJNYWMubW0KKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJNYWMubW0KQEAgLTYw OCw4ICs2MDgsNiBAQCB2b2lkIFZpZXdHZXN0dXJlQ29udHJvbGxlcjo6YmVnaW5Td2lwZUdlc3R1 cmUoV2ViQmFja0ZvcndhcmRMaXN0SXRlbSogdGFyZ2V0SXRlbQogICAgICAgICBbc25hcHNob3RM YXllclBhcmVudCBpbnNlcnRTdWJsYXllcjptX3N3aXBlTGF5ZXIuZ2V0KCkgYmVsb3c6bGF5ZXJB ZGphY2VudFRvU25hcHNob3RdOwogICAgIGVsc2UKICAgICAgICAgW3NuYXBzaG90TGF5ZXJQYXJl bnQgaW5zZXJ0U3VibGF5ZXI6bV9zd2lwZUxheWVyLmdldCgpIGFib3ZlOmxheWVyQWRqYWNlbnRU b1NuYXBzaG90XTsKLQotICAgIGRpZE1vdmVTd2lwZVNuYXBzaG90TGF5ZXIoKTsKIH0KIAogdm9p ZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OmhhbmRsZVN3aXBlR2VzdHVyZShXZWJCYWNrRm9yd2Fy ZExpc3RJdGVtKiB0YXJnZXRJdGVtLCBkb3VibGUgcHJvZ3Jlc3MsIFN3aXBlRGlyZWN0aW9uIGRp cmVjdGlvbikK