136347 2014-08-28 12:05:41 -0700 WebContent hangs under SharedBuffer::duplicateDataBufferIfNecessary() while browsing some websites 2014-08-28 14:08:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psolanki psolanki ap beidson kling koivisto psolanki oldest_to_newest 1032042 0 psolanki 2014-08-28 12:05:41 -0700 We've got reports of WebContent hangs when browsing some pages. The following two sites have been reported <http://www.liverpoolway.co.uk/index.php?/forum/1-ff-football-forum/> <https://sports.yahoo.com/blogs/mlb-big-league-stew/mo-ne-davis-has-rough-outing-in-tough-matchup-with-las-vegas-003922244.html> The spins show us doing a lot of allocation and memcpy under SharedBuffer::createCFData() 16 WebCore::SharedBuffer::createCFData() + 50 (WebCore + 52722) [0x7fff8fd70df2] 1-16 16 WebCore::SharedBuffer::data() const + 68 (WebCore + 53780) [0x7fff8fd71214] 1-16 16 WebCore::SharedBuffer::buffer() const + 36 (WebCore + 53828) [0x7fff8fd71244] 1-16 16 WebCore::SharedBuffer::duplicateDataBufferIfNecessary() const + 117 (WebCore + 13117829) [0x7fff909e6985] 1-16 16 WTF::Vector<char, 0ul, WTF::CrashOnOverflow>::operator=(WTF::Vector<char, 0ul, WTF::CrashOnOverflow> const&) + 223 (WebCore + 13118159) [0x7fff909e6acf] 1-16 16 _platform_memmove$VARIANT$Ivybridge + 49 (libsystem_platform.dylib + 4913) [0x7fff82e76331] 1-16 1032043 1 psolanki 2014-08-28 12:05:57 -0700 <rdar://problem/18073745> 1032048 2 237322 psolanki 2014-08-28 12:38:41 -0700 Created attachment 237322 Patch 1032058 3 237322 kling 2014-08-28 13:17:26 -0700 Comment on attachment 237322 Patch r=me 1032059 4 237322 kling 2014-08-28 13:18:27 -0700 Comment on attachment 237322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237322&action=review > Source/WebCore/platform/SharedBuffer.cpp:359 > + size_t newCapacity = std::max(static_cast<size_t>(m_size), currentCapacity * 2); We could consider a less aggressive growth strategy here, e.g 1.25x instead of 2x. 1032071 5 psolanki 2014-08-28 14:08:43 -0700 Committed r173080: <http://trac.webkit.org/changeset/173080> 237322 2014-08-28 12:38:41 -0700 2014-08-28 13:18:27 -0700 Patch bug-136347-20140828123833.patch text/plain 2286 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWNiYWFiYTgzYmE1YjVj ZjBhOTUyN2FiNmE2YWYzOTViMjMzMWJjMi4uNjM1ZWEyNmViMGIxNGVhZGZlZGZhZDE5Yjk4NmEw ODlkZjc5MTg1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA4LTI4ICBQcmF0 aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJDb250ZW50IGhh bmdzIHVuZGVyIFNoYXJlZEJ1ZmZlcjo6ZHVwbGljYXRlRGF0YUJ1ZmZlcklmTmVjZXNzYXJ5KCkg d2hpbGUgYnJvd3Npbmcgc29tZSB3ZWJzaXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MzQ3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xODA3 Mzc0NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBX aGVuIHBhc3NpbmcgZGF0YSB0byBJbWFnZUlPLCB3ZSBjcmVhdGUgYSBjb3B5IGlmIHdlIGhhdmUg dG8gcmVhbGxvY2F0ZSB0aGUgYnVmZmVyLiBXZSB3b3VsZAorICAgICAgICBzZXQgdGhlIHNpemUg b2YgdGhlIG5ldyBidWZmZXIgdG8gYmUgdGhlIHNpemUgb2YgdGhlIFNoYXJlZEJ1ZmZlciBkYXRh LiBUaGlzIGNhdXNlcyBtZW1vcnkKKyAgICAgICAgY2h1cm4gc2luY2Ugd2Ugd291bGQgY3JlYXRl IGEgbmV3IGJ1ZmZlciBmb3IgZXZlcnkgZGF0YSBjaHVuayB3ZSBnZXQuIEZpeCB0aGlzIGJ5IGF0 IGxlYXN0CisgICAgICAgIGRvdWJsaW5nIHRoZSBjYXBhY2l0eSBvZiB0aGUgYnVmZmVyIHdoZW4g d2UgZHVwbGljYXRlIGl0LgorCisgICAgICAgICogcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEJ1ZmZlcjo6ZHVwbGljYXRlRGF0YUJ1ZmZlcklmTmVj ZXNzYXJ5KToKKwogMjAxNC0wOC0yOCAgSWFnbyBUb3JhbCAgPGl0b3JhbEBpZ2FsaWEuY29tPiBh bmQgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g QWRkIFdheWxhbmRFdmVudFNvdXJjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vU2hhcmVkQnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NoYXJlZEJ1ZmZl ci5jcHAKaW5kZXggYzc0ZDNlMzQ0NjkyNTZjNTQzODYzZmY3MzQzZGE3NjFmNzY3MGEyNi4uYTZk NjIzM2RhNDdmZTIzYjk4ZDFkOTk1NmJmY2MwOTQ4NjMwZWRjNCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vU2hhcmVkQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9TaGFyZWRCdWZmZXIuY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVkZSAiY29u ZmlnLmgiCiAjaW5jbHVkZSAiU2hhcmVkQnVmZmVyLmgiCiAKKyNpbmNsdWRlIDxhbGdvcml0aG0+ CiAjaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIuaD4KICNpbmNsdWRlIDx3dGYvdW5pY29kZS9VVEY4 Lmg+CiAKQEAgLTM1MSwxMSArMzUyLDEzIEBAIFBhc3NSZWZQdHI8U2hhcmVkQnVmZmVyPiBTaGFy ZWRCdWZmZXI6OmNvcHkoKSBjb25zdAogCiB2b2lkIFNoYXJlZEJ1ZmZlcjo6ZHVwbGljYXRlRGF0 YUJ1ZmZlcklmTmVjZXNzYXJ5KCkgY29uc3QKIHsKLSAgICBpZiAobV9idWZmZXItPmhhc09uZVJl ZigpIHx8IG1fc2l6ZSA8PSBtX2J1ZmZlci0+ZGF0YS5jYXBhY2l0eSgpKQorICAgIHNpemVfdCBj dXJyZW50Q2FwYWNpdHkgPSBtX2J1ZmZlci0+ZGF0YS5jYXBhY2l0eSgpOworICAgIGlmIChtX2J1 ZmZlci0+aGFzT25lUmVmKCkgfHwgbV9zaXplIDw9IGN1cnJlbnRDYXBhY2l0eSkKICAgICAgICAg cmV0dXJuOwogCisgICAgc2l6ZV90IG5ld0NhcGFjaXR5ID0gc3RkOjptYXgoc3RhdGljX2Nhc3Q8 c2l6ZV90PihtX3NpemUpLCBjdXJyZW50Q2FwYWNpdHkgKiAyKTsKICAgICBSZWZQdHI8RGF0YUJ1 ZmZlcj4gbmV3QnVmZmVyID0gYWRvcHRSZWYobmV3IERhdGFCdWZmZXIpOwotICAgIG5ld0J1ZmZl ci0+ZGF0YS5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KG1fc2l6ZSk7CisgICAgbmV3QnVmZmVyLT5k YXRhLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkobmV3Q2FwYWNpdHkpOwogICAgIG5ld0J1ZmZlci0+ ZGF0YSA9IG1fYnVmZmVyLT5kYXRhOwogICAgIG1fYnVmZmVyID0gbmV3QnVmZmVyLnJlbGVhc2Uo KTsKIH0K