136329 2014-08-27 21:13:57 -0700 ASSERTION FAILED: !m_renderView.document().inPageCache() in compositing/iframes/resources/page-cache-helper.html 2014-08-28 10:54:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn kangil.han kling koivisto kondapallykalyan simon.fraser zalan oldest_to_newest 1031895 0 kling 2014-08-27 21:13:57 -0700 Spotted this on the Mavericks WK1 debug bot: ASSERTION FAILED: !m_renderView.document().inPageCache() /Volumes/Data/slave/mavericks-debug/build/Source/WebCore/rendering/RenderLayerCompositor.cpp(653) : void WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer *) 1 0x104dde250 WTFCrash 2 0x109b2414c WebCore::RenderLayerCompositor::updateCompositingLayers(WebCore::CompositingUpdateType, WebCore::RenderLayer*) 3 0x109b1e9ea WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired(WebCore::Timer<WebCore::RenderLayerCompositor>&) 4 0x109b3b54e std::__1::__function::__func<std::__1::__bind<void (WebCore::RenderLayerCompositor::*&)(WebCore::Timer<WebCore::RenderLayerCompositor>&), WebCore::RenderLayerCompositor*&, std::__1::reference_wrapper<WebCore::Timer<WebCore::RenderLayerCompositor> > >, std::__1::allocator<std::__1::__bind<void (WebCore::RenderLayerCompositor::*&)(WebCore::Timer<WebCore::RenderLayerCompositor>&), WebCore::RenderLayerCompositor*&, std::__1::reference_wrapper<WebCore::Timer<WebCore::RenderLayerCompositor> > > >, void ()>::operator()() 5 0x10834070a std::__1::function<void ()>::operator()() const 6 0x109b3904c WebCore::Timer<WebCore::RenderLayerCompositor>::fired() 7 0x10a17285c WebCore::ThreadTimers::sharedTimerFiredInternal() 8 0x10a172519 WebCore::ThreadTimers::sharedTimerFired() 9 0x109e5cd5f WebCore::timerFired(__CFRunLoopTimer*, void*) 10 0x7fff97d603e4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 11 0x7fff97d5ff1f __CFRunLoopDoTimer 12 0x7fff97dd15aa __CFRunLoopDoTimers 13 0x7fff97d1b6a5 __CFRunLoopRun 14 0x7fff97d1ae75 CFRunLoopRunSpecific 15 0x10423bb65 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) 16 0x10423a7fa runTestingServerLoop() 17 0x10423a025 dumpRenderTree(int, char const**) 18 0x10423c3f7 DumpRenderTreeMain(int, char const**) 19 0x10428c062 main 20 0x7fff90cef5fd start 21 0x2 1031897 1 237286 kling 2014-08-27 21:15:43 -0700 Created attachment 237286 Patch 1031898 2 zalan 2014-08-27 21:18:25 -0700 So you decided to not to go with the suspendable group timer controlled by RenderView? 1031900 3 kling 2014-08-27 21:21:56 -0700 (In reply to comment #2) > So you decided to not to go with the suspendable group timer controlled by RenderView? Maybe later. :) 1032031 4 237286 commit-queue 2014-08-28 10:54:48 -0700 Comment on attachment 237286 Patch Clearing flags on attachment: 237286 Committed r173066: <http://trac.webkit.org/changeset/173066> 1032032 5 commit-queue 2014-08-28 10:54:54 -0700 All reviewed patches have been landed. Closing bug. 237286 2014-08-27 21:15:43 -0700 2014-08-28 10:54:48 -0700 Patch bug-136329.diff text/plain 3083 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4NGU2NjFjLi5lYzYxMDU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDgtMjcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIEFTU0VSVElPTiBGQUlMRUQ6ICFtX3JlbmRlclZpZXcuZG9jdW1lbnQoKS5pblBhZ2VDYWNo ZSgpIGluIGNvbXBvc2l0aW5nL2lmcmFtZXMvcmVzb3VyY2VzL3BhZ2UtY2FjaGUtaGVscGVyLmh0 bWwKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzNjMyOT4KKworICAgICAgICBDYW5j ZWwgYW55IHBlbmRpbmcgY29tcG9zaXRpbmcgbGF5ZXIgdXBkYXRlcyB3aGVuIG1vdmluZyBhIGRv Y3VtZW50CisgICAgICAgIGludG8gdGhlIHBhZ2UgY2FjaGUuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmRvY3VtZW50V2lsbFN1c3BlbmRGb3JQYWdlQ2FjaGUpOgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpjYW5jZWxDb21wb3NpdGluZ0xheWVyVXBk YXRlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmg6CisKIDIw MTQtMDgtMjcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBTdWJw aXhlbCBsYXlvdXQ6IFJlbmFtZSBMYXlvdXRQb2ludCdzIGRldmljZSBwaXhlbCBzbmFwcGluZyBm dW5jdGlvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCAzYTE3ZThmLi4zMTQwNDNkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTQxMzksNiArNDEzOSwxMSBAQCB2b2lkIERvY3Vt ZW50Ojpkb2N1bWVudFdpbGxTdXNwZW5kRm9yUGFnZUNhY2hlKCkKICAgICAvLyBpcyBkaXNwYXRj aGVkLCBhZnRlciB0aGUgZG9jdW1lbnQgaXMgcmVzdG9yZWQgZnJvbSB0aGUgcGFnZSBjYWNoZS4K ICAgICBtX2RpZERpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzQ2hhbmdlZCA9IGZhbHNlOwogI2Vu ZGlmCisKKyAgICBpZiAoUmVuZGVyVmlldyogdmlldyA9IHJlbmRlclZpZXcoKSkgeworICAgICAg ICBpZiAodmlldy0+dXNlc0NvbXBvc2l0aW5nKCkpCisgICAgICAgICAgICB2aWV3LT5jb21wb3Np dG9yKCkuY2FuY2VsQ29tcG9zaXRpbmdMYXllclVwZGF0ZSgpOworICAgIH0KIH0KIAogdm9pZCBE b2N1bWVudDo6ZG9jdW1lbnREaWRSZXN1bWVGcm9tUGFnZUNhY2hlKCkgCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmluZGV4IDQ0ZWI1 MTkuLmY1NjIyZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuY3BwCkBAIC02NDYsNiArNjQ2LDExIEBAIGJvb2wgUmVuZGVyTGF5ZXJD b21wb3NpdG9yOjpoYXNBbnlBZGRpdGlvbmFsQ29tcG9zaXRlZExheWVycyhjb25zdCBSZW5kZXJM YXllciYKICAgICByZXR1cm4gbV9jb21wb3NpdGVkTGF5ZXJDb3VudCA+IChyb290TGF5ZXIuaXND b21wb3NpdGVkKCkgPyAxIDogMCk7CiB9CiAKK3ZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpj YW5jZWxDb21wb3NpdGluZ0xheWVyVXBkYXRlKCkKK3sKKyAgICBtX3VwZGF0ZUNvbXBvc2l0aW5n TGF5ZXJzVGltZXIuc3RvcCgpOworfQorCiB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6dXBk YXRlQ29tcG9zaXRpbmdMYXllcnMoQ29tcG9zaXRpbmdVcGRhdGVUeXBlIHVwZGF0ZVR5cGUsIFJl bmRlckxheWVyKiB1cGRhdGVSb290KQogewogICAgIG1fdXBkYXRlQ29tcG9zaXRpbmdMYXllcnNU aW1lci5zdG9wKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJD b21wb3NpdG9yLmgKaW5kZXggYTg2NzU3OS4uN2JkMjQwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaApAQCAtMTQwLDYgKzE0MCw4IEBA IHB1YmxpYzoKICAgICAvLyBUaGlzIGlzIG9ubHkgdXNlZCB3aGVuIHN0YXRlIGNoYW5nZXMgYW5k IHdlIGRvIG5vdCBleGVwZWN0IGEgc3R5bGUgdXBkYXRlIG9yIGxheW91dCB0byBoYXBwZW4gc29v biAoZS5nLiB3aGVuCiAgICAgLy8gd2UgZGlzY292ZXIgdGhhdCBhbiBpZnJhbWUgaXMgb3Zlcmxh cHBlZCBkdXJpbmcgcGFpbnRpbmcpLgogICAgIHZvaWQgc2NoZWR1bGVDb21wb3NpdGluZ0xheWVy VXBkYXRlKCk7CisgICAgLy8gVGhpcyBpcyB1c2VkIHRvIGNhbmNlbCBhbnkgcGVuZGluZyB1cGRh dGUgdGltZXJzIHdoZW4gdGhlIGRvY3VtZW50IGdvZXMgaW50byBwYWdlIGNhY2hlLgorICAgIHZv aWQgY2FuY2VsQ29tcG9zaXRpbmdMYXllclVwZGF0ZSgpOwogCiAgICAgLy8gVXBkYXRlIHRoZSBj b21wb3NpdGluZyBzdGF0ZSBvZiB0aGUgZ2l2ZW4gbGF5ZXIuIFJldHVybnMgdHJ1ZSBpZiB0aGF0 IHN0YXRlIGNoYW5nZWQuCiAgICAgZW51bSBDb21wb3NpdGluZ0NoYW5nZVJlcGFpbnQgeyBDb21w b3NpdGluZ0NoYW5nZVJlcGFpbnROb3csIENvbXBvc2l0aW5nQ2hhbmdlV2lsbFJlcGFpbnRMYXRl ciB9Owo=