136318 2014-08-27 15:38:30 -0700 Enums in ScrollTypes and PlatformWheelEvent should not use uint64_t storage 2014-08-27 16:29:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 burg burg commit-queue simon.fraser oldest_to_newest 1031818 0 burg 2014-08-27 15:38:30 -0700 It's wasteful. 1031820 1 237265 burg 2014-08-27 15:42:13 -0700 Created attachment 237265 Patch 1031821 2 commit-queue 2014-08-27 15:44:55 -0700 Attachment 237265 did not pass style-queue: ERROR: Source/WebCore/platform/ScrollTypes.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1031836 3 237265 commit-queue 2014-08-27 16:29:39 -0700 Comment on attachment 237265 Patch Clearing flags on attachment: 237265 Committed r173034: <http://trac.webkit.org/changeset/173034> 1031837 4 commit-queue 2014-08-27 16:29:41 -0700 All reviewed patches have been landed. Closing bug. 237265 2014-08-27 15:42:13 -0700 2014-08-27 16:29:39 -0700 Patch bug-136318-20140827154147.patch text/plain 5165 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTMyMTk0YWFlMjAyNWUz MWRhYzc5NDAxNzU5NmU5OWY5MTFlMzUyNC4uZmVhMzQ5ZDIxOWM4MWVmYjYzN2VhYTc4YzY3ODBk OGY1ZDM0OTNmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA4LTI3ICBCcmlh biBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KKworICAgICAgICBFbnVtcyBpbiBT Y3JvbGxUeXBlcyBhbmQgUGxhdGZvcm1XaGVlbEV2ZW50IHNob3VsZCBub3QgdXNlIHVpbnQ2NF90 IHN0b3JhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNjMxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgcmVncmVzc2VkIGluIGEgcmVwbGF5LXJlbGF0ZWQgcGF0Y2guIFJldmVydCBiYWNrIHRv IHVpbnQ4X3Qgc3RvcmFnZSBzaXplLgorCisgICAgICAgICogcGxhdGZvcm0vUGxhdGZvcm1XaGVl bEV2ZW50Lmg6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVHlwZXMuaDoKKyAgICAgICAgKiBy ZXBsYXkvV2ViSW5wdXRzLmpzb246CisKIDIwMTQtMDgtMjcgIEFudHRpIEtvaXZpc3RvICA8YW50 dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE3Mjk0Nik6IFBsdWdpbiB0ZXN0 cyBhc3NlcnRpbmcgb24gWW9zZW1pdGUgZGVidWcgYm90CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9QbGF0Zm9ybVdoZWVsRXZlbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1BsYXRmb3JtV2hlZWxFdmVudC5oCmluZGV4IDYyZmRiNjYxYTA2OWZmNjA2MWE2ZTY1OTI3 ZTRlMTJjZmYyYzJmMjEuLjFmMTFmZWRmZWQ0MmMxNWUwYWNmMDNhMzRhMzc3NjI3ODQwZjRjZDkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtV2hlZWxFdmVudC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtV2hlZWxFdmVudC5oCkBAIC00 OCwxMyArNDgsMTMgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIC8vIGFuZCBzeW50aGVzaXpl ZCBpbiBvdGhlciBjYXNlcyB3aGVyZSBwbGF0Zm9ybXMgZ2VuZXJhdGUgbGluZS1ieS1saW5lIHNj cm9sbGluZyBldmVudHMuCiAgICAgLy8gVGhlIFNjcm9sbEJ5UGFnZVdoZWVsRXZlbnQgaW5kaWNh dGVzIHRoYXQgdGhlIHdoZWVsIGV2ZW50IHNob3VsZCBzY3JvbGwgYW4gZW50aXJlIHBhZ2UuICBJ biB0aGlzIGNhc2UgV2ViQ29yZSdzIGJ1aWx0IGluIHBhZ2luZyBiZWhhdmlvciBpcyB1c2VkIHRv IHBhZ2UKICAgICAvLyB1cCBhbmQgZG93biAoeW91IGdldCB0aGUgc2FtZSBiZWhhdmlvciBhcyBp ZiB0aGUgdXNlciB3YXMgY2xpY2tpbmcgaW4gYSBzY3JvbGxiYXIgdHJhY2sgdG8gcGFnZSB1cCBv ciBwYWdlIGRvd24pLgotICAgIGVudW0gUGxhdGZvcm1XaGVlbEV2ZW50R3JhbnVsYXJpdHkgOiB1 aW50NjRfdCB7CisgICAgZW51bSBQbGF0Zm9ybVdoZWVsRXZlbnRHcmFudWxhcml0eSA6IHVpbnQ4 X3QgewogICAgICAgICBTY3JvbGxCeVBhZ2VXaGVlbEV2ZW50LAogICAgICAgICBTY3JvbGxCeVBp eGVsV2hlZWxFdmVudCwKICAgICB9OwogCiAjaWYgUExBVEZPUk0oQ09DT0EpCi0gICAgZW51bSBQ bGF0Zm9ybVdoZWVsRXZlbnRQaGFzZSA6IHVpbnQ2NF90IHsKKyAgICBlbnVtIFBsYXRmb3JtV2hl ZWxFdmVudFBoYXNlIDogdWludDhfdCB7CiAgICAgICAgIFBsYXRmb3JtV2hlZWxFdmVudFBoYXNl Tm9uZSAgICAgICAgPSAwLAogICAgICAgICBQbGF0Zm9ybVdoZWVsRXZlbnRQaGFzZUJlZ2FuICAg ICAgID0gMSA8PCAwLAogICAgICAgICBQbGF0Zm9ybVdoZWVsRXZlbnRQaGFzZVN0YXRpb25hcnkg ID0gMSA8PCAxLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVHlw ZXMuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFR5cGVzLmgKaW5kZXggZDYxNmZl NmVlNTE5ODZlOGEzODJiY2E2M2JmOWIyYTNmNGYwMGZjNy4uNDZkZjlmZTkwNzNmZTcyZTY0YzU5 ODFjNTJiZjUyZDdiNDJlNGEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v U2Nyb2xsVHlwZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxUeXBlcy5o CkBAIC0zMCwxNCArMzAsMTQgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi0gICAgZW51bSBT Y3JvbGxEaXJlY3Rpb24gOiB1aW50NjRfdCB7CisgICAgZW51bSBTY3JvbGxEaXJlY3Rpb24gOiB1 aW50OF90IHsKICAgICAgICAgU2Nyb2xsVXAsCiAgICAgICAgIFNjcm9sbERvd24sCiAgICAgICAg IFNjcm9sbExlZnQsCiAgICAgICAgIFNjcm9sbFJpZ2h0CiAgICAgfTsKIAotICAgIGVudW0gU2Ny b2xsTG9naWNhbERpcmVjdGlvbiA6IHVpbnQ2NF90IHsKKyAgICBlbnVtIFNjcm9sbExvZ2ljYWxE aXJlY3Rpb24gOiB1aW50OF90IHsKICAgICAgICAgU2Nyb2xsQmxvY2tEaXJlY3Rpb25CYWNrd2Fy ZCwKICAgICAgICAgU2Nyb2xsQmxvY2tEaXJlY3Rpb25Gb3J3YXJkLAogICAgICAgICBTY3JvbGxJ bmxpbmVEaXJlY3Rpb25CYWNrd2FyZCwKQEAgLTEwMyw3ICsxMDMsNyBAQCBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAgICAgICAgIHJldHVybiBTY3JvbGxVcDsKICAgICB9CiAKLSAgICBlbnVtIFNjcm9s bEdyYW51bGFyaXR5IDogdWludDY0X3QgeworICAgIGVudW0gU2Nyb2xsR3JhbnVsYXJpdHkgOiB1 aW50OF90IHsKICAgICAgICAgU2Nyb2xsQnlMaW5lLAogICAgICAgICBTY3JvbGxCeVBhZ2UsCiAg ICAgICAgIFNjcm9sbEJ5RG9jdW1lbnQsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZXBs YXkvV2ViSW5wdXRzLmpzb24gYi9Tb3VyY2UvV2ViQ29yZS9yZXBsYXkvV2ViSW5wdXRzLmpzb24K aW5kZXggOWQ4YWY2ZWUyOWU5MzdhMWE5Y2NjYTk1NDFkNzVmOGEwNDM1ZTg1YS4uNjFmNWI2MTJm NzUxMTNhNjNlZjk3MGYzYTBhYTJlN2Q0OWZlZTVjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVwbGF5L1dlYklucHV0cy5qc29uCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlcGxheS9XZWJJ bnB1dHMuanNvbgpAQCAtNjcsMTMgKzY3LDEzIEBACiAgICAgICAgICAgICAgICAgImhlYWRlciI6 ICJwbGF0Zm9ybS9QbGF0Zm9ybVdoZWVsRXZlbnQuaCIKICAgICAgICAgICAgIH0sCiAgICAgICAg ICAgICB7Ci0gICAgICAgICAgICAgICAgIm5hbWUiOiAiUGxhdGZvcm1XaGVlbEV2ZW50R3JhbnVs YXJpdHkiLCAibW9kZSI6ICJTQ0FMQVIiLCAic3RvcmFnZSI6ICJ1aW50NjRfdCIsCisgICAgICAg ICAgICAgICAgIm5hbWUiOiAiUGxhdGZvcm1XaGVlbEV2ZW50R3JhbnVsYXJpdHkiLCAibW9kZSI6 ICJTQ0FMQVIiLCAic3RvcmFnZSI6ICJ1aW50OF90IiwKICAgICAgICAgICAgICAgICAiZmxhZ3Mi OiBbIkVOVU0iXSwKICAgICAgICAgICAgICAgICAidmFsdWVzIjogWyJTY3JvbGxCeVBhZ2VXaGVl bEV2ZW50IiwgIlNjcm9sbEJ5UGl4ZWxXaGVlbEV2ZW50Il0sCiAgICAgICAgICAgICAgICAgImhl YWRlciI6ICJwbGF0Zm9ybS9QbGF0Zm9ybVdoZWVsRXZlbnQuaCIKICAgICAgICAgICAgIH0sCiAg ICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgIm5hbWUiOiAiUGxhdGZvcm1XaGVlbEV2ZW50 UGhhc2UiLCAibW9kZSI6ICJTQ0FMQVIiLCAic3RvcmFnZSI6ICJ1aW50NjRfdCIsCisgICAgICAg ICAgICAgICAgIm5hbWUiOiAiUGxhdGZvcm1XaGVlbEV2ZW50UGhhc2UiLCAibW9kZSI6ICJTQ0FM QVIiLCAic3RvcmFnZSI6ICJ1aW50OF90IiwKICAgICAgICAgICAgICAgICAiZmxhZ3MiOiBbIkVO VU0iXSwKICAgICAgICAgICAgICAgICAiZ3VhcmQiOiAiUExBVEZPUk0oQ09DT0EpIiwKICAgICAg ICAgICAgICAgICAidmFsdWVzIjogWwpAQCAtOTIsMTMgKzkyLDEzIEBACiAgICAgICAgICAgICAg ICAgImhlYWRlciI6ICJwbHVnaW5zL1BsdWdpbkRhdGEuaCIKICAgICAgICAgICAgIH0sCiAgICAg ICAgICAgICB7Ci0gICAgICAgICAgICAgICAgIm5hbWUiOiAiU2Nyb2xsRGlyZWN0aW9uIiwgIm1v ZGUiOiAiU0NBTEFSIiwgInN0b3JhZ2UiOiAidWludDY0X3QiLAorICAgICAgICAgICAgICAgICJu YW1lIjogIlNjcm9sbERpcmVjdGlvbiIsICJtb2RlIjogIlNDQUxBUiIsICJzdG9yYWdlIjogInVp bnQ4X3QiLAogICAgICAgICAgICAgICAgICJmbGFncyI6IFsiRU5VTSJdLAogICAgICAgICAgICAg ICAgICJ2YWx1ZXMiOiBbIlNjcm9sbFVwIiwgIlNjcm9sbERvd24iLCAiU2Nyb2xsTGVmdCIsICJT Y3JvbGxSaWdodCJdLAogICAgICAgICAgICAgICAgICJoZWFkZXIiOiAicGxhdGZvcm0vU2Nyb2xs VHlwZXMuaCIKICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAg Im5hbWUiOiAiU2Nyb2xsR3JhbnVsYXJpdHkiLCAibW9kZSI6ICJTQ0FMQVIiLCAic3RvcmFnZSI6 ICJ1aW50NjRfdCIsCisgICAgICAgICAgICAgICAgIm5hbWUiOiAiU2Nyb2xsR3JhbnVsYXJpdHki LCAibW9kZSI6ICJTQ0FMQVIiLCAic3RvcmFnZSI6ICJ1aW50OF90IiwKICAgICAgICAgICAgICAg ICAiZmxhZ3MiOiBbIkVOVU0iXSwKICAgICAgICAgICAgICAgICAidmFsdWVzIjogWwogICAgICAg ICAgICAgICAgICAgICAiU2Nyb2xsQnlMaW5lIiwKQEAgLTExMCw3ICsxMTAsNyBAQAogICAgICAg ICAgICAgICAgICJoZWFkZXIiOiAicGxhdGZvcm0vU2Nyb2xsVHlwZXMuaCIKICAgICAgICAgICAg IH0sCiAgICAgICAgICAgICB7Ci0gICAgICAgICAgICAgICAgIm5hbWUiOiAiU2Nyb2xsTG9naWNh bERpcmVjdGlvbiIsICJtb2RlIjogIlNDQUxBUiIsICJzdG9yYWdlIjogInVpbnQ2NF90IiwKKyAg ICAgICAgICAgICAgICAibmFtZSI6ICJTY3JvbGxMb2dpY2FsRGlyZWN0aW9uIiwgIm1vZGUiOiAi U0NBTEFSIiwgInN0b3JhZ2UiOiAidWludDhfdCIsCiAgICAgICAgICAgICAgICAgImZsYWdzIjog WyJFTlVNIl0sCiAgICAgICAgICAgICAgICAgInZhbHVlcyI6IFsKICAgICAgICAgICAgICAgICAg ICAgIlNjcm9sbEJsb2NrRGlyZWN0aW9uQmFja3dhcmQiLAo=