136317 2014-08-27 15:11:27 -0700 Dashboard metrics page sometimes shows 0 for best time 2014-08-27 15:36:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap dfarler lforschler matthew_hanson thorton timothy oldest_to_newest 1031799 0 ap 2014-08-27 15:11:27 -0700 The metrics page filters out iterations that ended up with EXCEPTION or RETRY, but it doesn't filter out ones that failed due to infrastructure misbehaving. For example, a failure to download built archive counts as if it provided testing results for this revision. This happens quickly, so we get an incorrect small result for the elapsed time. We should be more selective about which iterations we consider productive. 1031805 1 237262 ap 2014-08-27 15:17:37 -0700 Created attachment 237262 proposed fix 1031811 2 237262 thorton 2014-08-27 15:26:49 -0700 Comment on attachment 237262 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=237262&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:71 > +BuildbotIteration.ProductiveSteps = { Not an array? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:295 > + var finishedAProductiveStep = false; s/A/Any/? 1031817 3 ap 2014-08-27 15:36:17 -0700 Committed <http://trac.webkit.org/r173027>. > Not an array? I do an "in" on it, which should be faster than an indexOf on an array. 237262 2014-08-27 15:17:37 -0700 2014-08-27 15:26:48 -0700 proposed fix ZeroTime.txt text/plain 4082 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MzAyMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE0LTA4LTI3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYz MTcKKyAgICAgICAgRGFzaGJvYXJkIG1ldHJpY3MgcGFnZSBzb21ldGltZXMgc2hvd3MgMCBmb3Ig YmVzdCB0aW1lCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBhbHNvIGFmZmVjdHMgcmVndWxhciBkYXNoYm9hcmQgZGlzcGxheSBpbiBhIGdvb2Qg d2F5IC0gaXRlcmF0aW9ucyB0aGF0IGZhaWxlZAorICAgICAgICBkdWUgdG8gaW5mcmFzdHJ1Y3R1 cmUgbWlzYmVoYXZpb3Igd2lsbCBtb3JlIHJlbGlhYmx5IHNob3cgdXAgYXMgeWVsbG93IGFuZCBu b3QgcmVkLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RJdGVyYXRpb24uanM6 CisgICAgICAgIChCdWlsZGJvdEl0ZXJhdGlvbik6IEFkZGVkIGEgbGlzdCBvZiBzdGVwcyB0aGF0 IHdlIGFjdHVhbGx5IGNhcmUgYWJvdXQuIEl0IHdpbGwgbmVlZCB0byBiZQorICAgICAgICB1cGRh dGVkIGlmIHdlIHJlbmFtZSBzdGVwcy4KKyAgICAgICAgKEJ1aWxkYm90SXRlcmF0aW9uLnByb3Rv dHlwZS5nZXQgcHJvZHVjdGl2ZSk6IE5vdyB0aGF0IGNvbXB1dGF0aW9uIGlzIG1vcmUgaW52b2x2 ZWQsCisgICAgICAgIGRvIGl0IG9uY2UuCisgICAgICAgIChCdWlsZGJvdEl0ZXJhdGlvbi5wcm90 b3R5cGUuX3BhcnNlRGF0YSk6IFR3ZWFrIGNvbXB1dGF0aW9uIG9mICJwcm9kdWN0aXZlIiAtIGJ1 aWxkcworICAgICAgICB0aGF0IGZhaWxlZCBlLmcuIGF0IGRvd25sb2FkaW5nIGJ1aWx0IGFyY2hp dmUgc3RlcCBhcmUgbm90IHByb2R1Y3RpdmUuCisKIDIwMTQtMDgtMjcgIEJyZW50IEZ1bGdoYW0g IDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gVW5yZXZpZXdlZCBnYXJkZW5p bmcuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdEl0ZXJhdGlvbi5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdEl0ZXJhdGlvbi5qcwkocmV2 aXNpb24gMTczMDA2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RJdGVyYXRpb24u anMJKHdvcmtpbmcgY29weSkKQEAgLTQxLDYgKzQxLDcgQEAgQnVpbGRib3RJdGVyYXRpb24gPSBm dW5jdGlvbihxdWV1ZSwgZGF0YQogCiAgICAgdGhpcy5sb2FkZWQgPSBmYWxzZTsKICAgICB0aGlz LmlzTG9hZGluZyA9IGZhbHNlOworICAgIHRoaXMuX3Byb2R1Y3RpdmUgPSBmYWxzZTsKIAogICAg IHRoaXMub3BlblNvdXJjZVJldmlzaW9uID0gbnVsbDsKICAgICB0aGlzLmludGVybmFsUmV2aXNp b24gPSBudWxsOwpAQCAtNjYsNiArNjcsMjAgQEAgQnVpbGRib3RJdGVyYXRpb24uU0tJUFBFRCA9 IDM7CiBCdWlsZGJvdEl0ZXJhdGlvbi5FWENFUFRJT04gPSA0OwogQnVpbGRib3RJdGVyYXRpb24u UkVUUlkgPSA1OwogCisvLyBJZiBub25lIG9mIHRoZXNlIHN0ZXBzIHJhbiwgdGhlbiB3ZSBkaWRu J3QgZ2V0IGFueSByZWFsIHJlc3VsdHMsIGFuZCB0aGUgaXRlcmF0aW9uIHdhcyBub3QgcHJvZHVj dGl2ZS4KK0J1aWxkYm90SXRlcmF0aW9uLlByb2R1Y3RpdmVTdGVwcyA9IHsKKyAgICAiY29tcGls ZS13ZWJraXQiOiAxLAorICAgICJidWlsZCBhcmNoaXZlIjogMSwKKyAgICAiQnVpbGQiIDogMSwK KyAgICAibGF5b3V0LXRlc3QiOiAxLAorICAgICJqc2NvcmUtdGVzdCI6IDEsCisgICAgInJ1bi1h cGktdGVzdHMiOiAxLAorICAgICJBUEkgdGVzdHMiOiAxLAorICAgICJ3ZWJraXRweS10ZXN0Ijog MSwKKyAgICAid2Via2l0cGVybC10ZXN0IjogMSwKKyAgICAiYmluZGluZ3MtZ2VuZXJhdGlvbi10 ZXN0cyI6IDEsCit9OworCiBCdWlsZGJvdEl0ZXJhdGlvbi5FdmVudCA9IHsKICAgICBVcGRhdGVk OiAidXBkYXRlZCIsCiAgICAgVW5hdXRob3JpemVkQWNjZXNzOiAidW5hdXRob3JpemVkLWFjY2Vz cyIKQEAgLTEwNiw3ICsxMjEsNyBAQCBCdWlsZGJvdEl0ZXJhdGlvbi5wcm90b3R5cGUgPSB7CiAK ICAgICBnZXQgcHJvZHVjdGl2ZSgpCiAgICAgewotICAgICAgICByZXR1cm4gdGhpcy5sb2FkZWQg JiYgdGhpcy5fZmluaXNoZWQgJiYgdGhpcy5fcmVzdWx0ICE9PSBCdWlsZGJvdEl0ZXJhdGlvbi5F WENFUFRJT04gJiYgdGhpcy5fcmVzdWx0ICE9PSBCdWlsZGJvdEl0ZXJhdGlvbi5SRVRSWTsKKyAg ICAgICAgcmV0dXJuIHRoaXMuX3Byb2R1Y3RpdmU7CiAgICAgfSwKIAogICAgIC8vIEl0IGlzIG5v dCBhIHJlYWwgZmFpbHVyZSBpZiBCdWlsZGJvdCBpdHNlbGYgZmFpbGVkIHdpdGggY29kZXMgbGlr ZSBFWENFUFRJT04gb3IgUkVUUlkuCkBAIC0xNzIsNyArMTg3LDcgQEAgQnVpbGRib3RJdGVyYXRp b24ucHJvdG90eXBlID0gewogICAgICAgICAgICAgdmFyIHRlc3RSZXN1bHRzID0ge307CiAKICAg ICAgICAgICAgIGlmICghdGVzdFN0ZXAuaXNGaW5pc2hlZCkgewotICAgICAgICAgICAgICAgIC8v IFRoZSBzdGVwIG5ldmVyIGV2ZW4gcmFuLCBvciBoYXNuJ3QgZmluaXNoIHJ1bm5pbmcuCisgICAg ICAgICAgICAgICAgLy8gVGhlIHN0ZXAgbmV2ZXIgZXZlbiByYW4sIG9yIGhhc24ndCBmaW5pc2hl ZCBydW5uaW5nLgogICAgICAgICAgICAgICAgIHRlc3RSZXN1bHRzLmZpbmlzaGVkID0gZmFsc2U7 CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRlc3RSZXN1bHRzOwogICAgICAgICAgICAgfQpAQCAt Mjc1LDYgKzI5MCwyMSBAQCBCdWlsZGJvdEl0ZXJhdGlvbi5wcm90b3R5cGUgPSB7CiAgICAgICAg IGlmICghZGF0YS5jdXJyZW50U3RlcCkKICAgICAgICAgICAgIHRoaXMuZmluaXNoZWQgPSB0cnVl OwogCisgICAgICAgIHRoaXMuX3Byb2R1Y3RpdmUgPSB0aGlzLl9maW5pc2hlZCAmJiB0aGlzLl9y ZXN1bHQgIT09IEJ1aWxkYm90SXRlcmF0aW9uLkVYQ0VQVElPTiAmJiB0aGlzLl9yZXN1bHQgIT09 IEJ1aWxkYm90SXRlcmF0aW9uLlJFVFJZOworICAgICAgICBpZiAodGhpcy5fcHJvZHVjdGl2ZSkg eworICAgICAgICAgICAgdmFyIGZpbmlzaGVkQVByb2R1Y3RpdmVTdGVwID0gZmFsc2U7CisgICAg ICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGRhdGEuc3RlcHMubGVuZ3RoOyArK2kpIHsKKyAg ICAgICAgICAgICAgICB2YXIgc3RlcCA9IGRhdGEuc3RlcHNbaV07CisgICAgICAgICAgICAgICAg aWYgKCFzdGVwLmlzRmluaXNoZWQpCisgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAg ICAgICAgICAgIGlmIChzdGVwLm5hbWUgaW4gQnVpbGRib3RJdGVyYXRpb24uUHJvZHVjdGl2ZVN0 ZXBzKSB7CisgICAgICAgICAgICAgICAgICAgIGZpbmlzaGVkQVByb2R1Y3RpdmVTdGVwID0gdHJ1 ZTsKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgfQorICAgICAg ICAgICAgfQorICAgICAgICAgICAgdGhpcy5fcHJvZHVjdGl2ZSA9IGZpbmlzaGVkQVByb2R1Y3Rp dmVTdGVwOworICAgICAgICB9CisKICAgICAgICAgLy8gVXBkYXRlIHRoZSBzb3J0aW5nIHNpbmNl IGl0IGlzIGJhc2VkIG9uIHRoZSByZXZpc2lvbnMgd2UganVzdCBsb2FkZWQuCiAgICAgICAgIHRo aXMucXVldWUuc29ydEl0ZXJhdGlvbnMoKTsKICAgICB9LAo=