136307 2014-08-27 14:06:33 -0700 Make isScrollableOrRubberbandable() a virtual function on RenderLayerModelObject 2014-08-27 15:21:34 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue darin esprehn+autocc glenn kondapallykalyan simon.fraser thorton oldest_to_newest 1031767 0 bdakin 2014-08-27 14:06:33 -0700 This is a follow-up to http://trac.webkit.org/changeset/173014 that Darin suggested in person. 1031773 1 237249 bdakin 2014-08-27 14:11:05 -0700 Created attachment 237249 Patch 1031807 2 bdakin 2014-08-27 15:21:34 -0700 Thanks Simon! http://trac.webkit.org/changeset/173023 237249 2014-08-27 14:11:05 -0700 2014-08-27 14:58:31 -0700 Patch for-review.txt text/plain 5412 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MzAxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDE0LTA4LTI3ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIGlzU2Nyb2xsYWJsZU9yUnVi YmVyYmFuZGFibGUoKSBhIHZpcnR1YWwgZnVuY3Rpb24gb24gUmVuZGVyTGF5ZXJNb2RlbE9iamVj dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MzA3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3Zl IGV4dHJhIHBhcmVudGhlc2VzLiAKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmlzU2Nyb2xsYWJsZSk6CisKKyAgICAgICAgTWFyayBp c1Njcm9sbGFibGVPclJ1YmJlcmJhbmRhYmxlKCkgYXMgb3ZlcnJpZGUgbm93IHRoYXQgdGhlIHJv b3QgaW1wbGVtZW50YXRpb24gCisgICAgICAgIGlzIG1vdmluZyB0byBSZW5kZXJMYXllck1vZGVs T2JqZWN0LiBJdCBjYW4gYWxzbyBiZSBwcml2YXRlIG5vdy4KKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyQm94Lmg6CisKKyAgICAgICAgaXNCb3goKSBjaGVjayBhbmQgY2FzdCBhcmUgbm8gbG9u Z2VyIG5lY2Vzc2FyeS4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6Omhhc1Njcm9sbGFibGVPclJ1YmJlcmJhbmRhYmxl QW5jZXN0b3IpOgorCisgICAgICAgIEJhc2UgaW1wbGVtZW50YXRpb24gc2hvdWxkIHJldHVybiBm YWxzZS4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5oOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJNb2RlbE9iamVjdDo6aXNTY3JvbGxhYmxlT3JSdWJi ZXJiYW5kYWJsZSk6CisKKyAgICAgICAgTWFyayBhcyBvdmVycmlkZS4KKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyVmlldy5oOgorCiAyMDE0LTA4LTI3ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1v dGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDcmFzaCB3aGVuIHlvdSBv cGVuIFdlYiBJbnNwZWN0b3IgaW4gYSBwcml2YXRlIHdpbmRvdyAoZHVlIHRvIEluZGV4ZWREQikK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDE3MzAxNCkKKysrIFNv dXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI4Miw3 ICszMjgyLDcgQEAgYm9vbCBGcmFtZVZpZXc6OmlzU2Nyb2xsYWJsZShTY3JvbGxhYmlsaQogICAg IGlmIChyZXF1aXJlc0FjdHVhbE92ZXJmbG93VG9CZUNvbnNpZGVyZWRTY3JvbGxhYmxlKSB7CiAg ICAgICAgIEludFNpemUgdG90YWxDb250ZW50c1NpemUgPSB0aGlzLT50b3RhbENvbnRlbnRzU2l6 ZSgpOwogICAgICAgICBJbnRTaXplIHZpc2libGVDb250ZW50U2l6ZSA9IHZpc2libGVDb250ZW50 UmVjdChMZWdhY3lJT1NEb2N1bWVudFZpc2libGVSZWN0KS5zaXplKCk7Ci0gICAgICAgIGlmICgo dG90YWxDb250ZW50c1NpemUuaGVpZ2h0KCkgPD0gdmlzaWJsZUNvbnRlbnRTaXplLmhlaWdodCgp ICYmIHRvdGFsQ29udGVudHNTaXplLndpZHRoKCkgPD0gdmlzaWJsZUNvbnRlbnRTaXplLndpZHRo KCkpKQorICAgICAgICBpZiAodG90YWxDb250ZW50c1NpemUuaGVpZ2h0KCkgPD0gdmlzaWJsZUNv bnRlbnRTaXplLmhlaWdodCgpICYmIHRvdGFsQ29udGVudHNTaXplLndpZHRoKCkgPD0gdmlzaWJs ZUNvbnRlbnRTaXplLndpZHRoKCkpCiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQog CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCShyZXZpc2lvbiAxNzMwMTQp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgJKHdvcmtpbmcgY29weSkK QEAgLTQ2Miw3ICs0NjIsNiBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIHNjcm9sbChTY3Jv bGxEaXJlY3Rpb24sIFNjcm9sbEdyYW51bGFyaXR5LCBmbG9hdCBtdWx0aXBsaWVyID0gMSwgRWxl bWVudCoqIHN0b3BFbGVtZW50ID0gbnVsbHB0ciwgUmVuZGVyQm94KiBzdGFydEJveCA9IG51bGxw dHIsIGNvbnN0IEludFBvaW50JiB3aGVlbEV2ZW50QWJzb2x1dGVQb2ludCA9IEludFBvaW50KCkp OwogICAgIHZpcnR1YWwgYm9vbCBsb2dpY2FsU2Nyb2xsKFNjcm9sbExvZ2ljYWxEaXJlY3Rpb24s IFNjcm9sbEdyYW51bGFyaXR5LCBmbG9hdCBtdWx0aXBsaWVyID0gMSwgRWxlbWVudCoqIHN0b3BF bGVtZW50ID0gMCk7CiAgICAgYm9vbCBjYW5CZVNjcm9sbGVkQW5kSGFzU2Nyb2xsYWJsZUFyZWEo KSBjb25zdDsKLSAgICB2aXJ0dWFsIGJvb2wgaXNTY3JvbGxhYmxlT3JSdWJiZXJiYW5kYWJsZSgp IGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBjYW5CZVByb2dyYW1hdGljYWxseVNjcm9sbGVkKCkg Y29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIGF1dG9zY3JvbGwoY29uc3QgSW50UG9pbnQmKTsKICAg ICBib29sIGNhbkF1dG9zY3JvbGwoKSBjb25zdDsKQEAgLTY2Nyw2ICs2NjYsOCBAQCBwcml2YXRl OgogICAgIGJvb2wgaW5jbHVkZVZlcnRpY2FsU2Nyb2xsYmFyU2l6ZSgpIGNvbnN0OwogICAgIGJv b2wgaW5jbHVkZUhvcml6b250YWxTY3JvbGxiYXJTaXplKCkgY29uc3Q7CiAKKyAgICB2aXJ0dWFs IGJvb2wgaXNTY3JvbGxhYmxlT3JSdWJiZXJiYW5kYWJsZSgpIGNvbnN0IG92ZXJyaWRlOworCiAg ICAgLy8gUmV0dXJucyB0cnVlIGlmIHdlIGRpZCBhIGZ1bGwgcmVwYWludAogICAgIGJvb2wgcmVw YWludExheWVyUmVjdHNGb3JJbWFnZShXcmFwcGVkSW1hZ2VQdHIgaW1hZ2UsIGNvbnN0IEZpbGxM YXllciogbGF5ZXJzLCBib29sIGRyYXdpbmdCYWNrZ3JvdW5kKTsKIApJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShyZXZpc2lvbiAxNzMwMTQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z MDY4LDcgKzMwNjgsNyBAQCBTY3JvbGxhYmxlQXJlYSogUmVuZGVyTGF5ZXI6OmVuY2xvc2luZ1Nj CiBib29sIFJlbmRlckxheWVyOjpoYXNTY3JvbGxhYmxlT3JSdWJiZXJiYW5kYWJsZUFuY2VzdG9y KCkKIHsKICAgICBmb3IgKFJlbmRlckxheWVyKiBuZXh0TGF5ZXIgPSBwYXJlbnRMYXllckNyb3Nz RnJhbWUodGhpcyk7IG5leHRMYXllcjsgbmV4dExheWVyID0gcGFyZW50TGF5ZXJDcm9zc0ZyYW1l KG5leHRMYXllcikpIHsKLSAgICAgICAgaWYgKG5leHRMYXllci0+cmVuZGVyZXIoKS5pc0JveCgp ICYmIHRvUmVuZGVyQm94KG5leHRMYXllci0+cmVuZGVyZXIoKSkuaXNTY3JvbGxhYmxlT3JSdWJi ZXJiYW5kYWJsZSgpKQorICAgICAgICBpZiAobmV4dExheWVyLT5yZW5kZXJlcigpLmlzU2Nyb2xs YWJsZU9yUnViYmVyYmFuZGFibGUoKSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0K IApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyTW9kZWxPYmplY3Qu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJNb2Rl bE9iamVjdC5oCShyZXZpc2lvbiAxNzMwMDgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw4IEBA IHB1YmxpYzoKICAgICAvLyBUaGUgcXVlcnkgcmVjdCBpcyBnaXZlbiBpbiBsb2NhbCBjb29yZGlu YXRlIHN5c3RlbS4KICAgICB2aXJ0dWFsIGJvb2wgYmFja2dyb3VuZElzS25vd25Ub0JlT3BhcXVl SW5SZWN0KGNvbnN0IExheW91dFJlY3QmKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogCisgICAg dmlydHVhbCBib29sIGlzU2Nyb2xsYWJsZU9yUnViYmVyYmFuZGFibGUoKSBjb25zdCB7IHJldHVy biBmYWxzZTsgfQorCiBwcm90ZWN0ZWQ6CiAgICAgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdChFbGVt ZW50JiwgUGFzc1JlZjxSZW5kZXJTdHlsZT4sIHVuc2lnbmVkIGJhc2VUeXBlRmxhZ3MpOwogICAg IFJlbmRlckxheWVyTW9kZWxPYmplY3QoRG9jdW1lbnQmLCBQYXNzUmVmPFJlbmRlclN0eWxlPiwg dW5zaWduZWQgYmFzZVR5cGVGbGFncyk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJWaWV3LmgJKHJldmlzaW9uIDE3MzAxNCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTMwMyw3ICszMDMsNyBAQCBwcml2YXRlOgog ICAgIGZyaWVuZCBjbGFzcyBMYXlvdXRTdGF0ZU1haW50YWluZXI7CiAgICAgZnJpZW5kIGNsYXNz IExheW91dFN0YXRlRGlzYWJsZXI7CiAKLSAgICB2aXJ0dWFsIGJvb2wgaXNTY3JvbGxhYmxlT3JS dWJiZXJiYW5kYWJsZSgpIGNvbnN0OworICAgIHZpcnR1YWwgYm9vbCBpc1Njcm9sbGFibGVPclJ1 YmJlcmJhbmRhYmxlKCkgY29uc3Qgb3ZlcnJpZGU7CiAKICAgICB2b2lkIHNwbGl0U2VsZWN0aW9u QmV0d2VlblN1YnRyZWVzKFJlbmRlck9iamVjdCogc3RhcnQsIGludCBzdGFydFBvcywgUmVuZGVy T2JqZWN0KiBlbmQsIGludCBlbmRQb3MsIFNlbGVjdGlvblJlcGFpbnRNb2RlIGJsb2NrUmVwYWlu dE1vZGUpOwogICAgIHZvaWQgY2xlYXJTdWJ0cmVlU2VsZWN0aW9uKGNvbnN0IFNlbGVjdGlvblN1 YnRyZWVSb290JiwgU2VsZWN0aW9uUmVwYWludE1vZGUsIE9sZFNlbGVjdGlvbkRhdGEmKTsK