136287 2014-08-27 06:24:33 -0700 Take advantage of 3 parameters or32() calls 2014-08-27 09:09:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned msaboff oliver zherczeg oldest_to_newest 1031645 0 jbriance 2014-08-27 06:24:33 -0700 For architectures like arm and mips, it's better to use the following sequence: or32(op1, op2, dest); instead of: move(op1, dest); or32(op2, dest); 1031647 1 237223 jbriance 2014-08-27 06:33:24 -0700 Created attachment 237223 Take advantage of 3 parameters or32() calls 1031652 2 237223 msaboff 2014-08-27 07:46:37 -0700 Comment on attachment 237223 Take advantage of 3 parameters or32() calls r=me Are you going to look at other logical / arithmetic ops? 1031663 3 jbriance 2014-08-27 09:06:56 -0700 Manually committed r173006: http://trac.webkit.org/changeset/173006 1031664 4 jbriance 2014-08-27 09:09:18 -0700 (In reply to comment #2) > Are you going to look at other logical / arithmetic ops? Yes, but I didn't find other cases yet. 237223 2014-08-27 06:33:24 -0700 2014-08-27 07:46:36 -0700 Take advantage of 3 parameters or32() calls bug-136287.patch text/plain 5643 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTczMDAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE0LTA4LTI3ICBKdWxpZW4gQnJpYW5jZWF1ICAgPGpicmlhbmNlQGNpc2NvLmNvbT4KKwor ICAgICAgICBUYWtlIGFkdmFudGFnZSBvZiAzIHBhcmFtZXRlcnMgb3IzMigpIGNhbGxzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYyODcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3Igc3BlY2lmaWMg YXJjaGl0ZWN0dXJlcyAoYXJtIGFuZCBtaXBzIGZvciBpbnN0YW5jZSksIG9yMzIoKSBjYWxscwor ICAgICAgICB3aXRoIDMgcGFyYW1ldGVycyBhcmUgbGlrZWx5IHRvIHByb2R1Y2UgYSBzaW5nbGUg aW5zdHJ1Y3Rpb24uCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6 CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6Om5vblNwZWN1bGF0aXZlTm9uUGVl cGhvbGVDb21wYXJlTnVsbCk6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6Om5v blNwZWN1bGF0aXZlUGVlcGhvbGVCcmFuY2hOdWxsKToKKyAgICAgICAgKEpTQzo6REZHOjpTcGVj dWxhdGl2ZUpJVDo6Y29tcGlsZU9iamVjdFRvT2JqZWN0T3JPdGhlckVxdWFsaXR5KToKKyAgICAg ICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZVBlZXBIb2xlT2JqZWN0VG9PYmpl Y3RPck90aGVyRXF1YWxpdHkpOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpj b21waWxlT2JqZWN0T3JPdGhlckxvZ2ljYWxOb3QpOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1 bGF0aXZlSklUOjplbWl0T2JqZWN0T3JPdGhlckJyYW5jaCk6CisgICAgICAgIChKU0M6OkRGRzo6 U3BlY3VsYXRpdmVKSVQ6OmJyYW5jaElzT3RoZXIpOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1 bGF0aXZlSklUOjpicmFuY2hOb3RPdGhlcik6CisKIDIwMTQtMDgtMjYgIEJyaWFuIEouIEJ1cmcg IDxidXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHB1dCBm ZWF0dXJlIGZsYWdzIGZvciBJbnNwZWN0b3IgZG9tYWlucyBpbiB0aGUgcHJvdG9jb2wgc3BlY2lm aWNhdGlvbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VDMyXzY0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklUMzJfNjQuY3BwCShyZXZpc2lvbiAxNzMwMDIpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNzYsOCArMjc2LDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6bm9uU3BlY3VsYXRpdmVOb25Q ZQogICAgICAgICBub3RDZWxsLmxpbmsoJm1faml0KTsKICAgICAgICAgLy8gbnVsbCBvciB1bmRl ZmluZWQ/CiAgICAgICAgIENPTVBJTEVfQVNTRVJUKChKU1ZhbHVlOjpVbmRlZmluZWRUYWcgfCAx KSA9PSBKU1ZhbHVlOjpOdWxsVGFnLCBVbmRlZmluZWRUYWdfT1JfMV9FUVVBTFNfTnVsbFRhZyk7 Ci0gICAgICAgIG1faml0Lm1vdmUoYXJnVGFnR1BSLCByZXN1bHRQYXlsb2FkR1BSKTsKLSAgICAg ICAgbV9qaXQub3IzMihUcnVzdGVkSW1tMzIoMSksIHJlc3VsdFBheWxvYWRHUFIpOworICAgICAg ICBtX2ppdC5vcjMyKFRydXN0ZWRJbW0zMigxKSwgYXJnVGFnR1BSLCByZXN1bHRQYXlsb2FkR1BS KTsKICAgICAgICAgbV9qaXQuY29tcGFyZTMyKGludmVydCA/IEpJVENvbXBpbGVyOjpOb3RFcXVh bCA6IEpJVENvbXBpbGVyOjpFcXVhbCwgcmVzdWx0UGF5bG9hZEdQUiwgVHJ1c3RlZEltbTMyKEpT VmFsdWU6Ok51bGxUYWcpLCByZXN1bHRQYXlsb2FkR1BSKTsKIAogICAgICAgICBkb25lLmxpbmso Jm1faml0KTsKQEAgLTM0MCw4ICszMzksNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpub25TcGVj dWxhdGl2ZVBlZXBoCiAgICAgICAgIG5vdENlbGwubGluaygmbV9qaXQpOwogICAgICAgICAvLyBu dWxsIG9yIHVuZGVmaW5lZD8KICAgICAgICAgQ09NUElMRV9BU1NFUlQoKEpTVmFsdWU6OlVuZGVm aW5lZFRhZyB8IDEpID09IEpTVmFsdWU6Ok51bGxUYWcsIFVuZGVmaW5lZFRhZ19PUl8xX0VRVUFM U19OdWxsVGFnKTsKLSAgICAgICAgbV9qaXQubW92ZShhcmdUYWdHUFIsIHJlc3VsdEdQUik7Ci0g ICAgICAgIG1faml0Lm9yMzIoVHJ1c3RlZEltbTMyKDEpLCByZXN1bHRHUFIpOworICAgICAgICBt X2ppdC5vcjMyKFRydXN0ZWRJbW0zMigxKSwgYXJnVGFnR1BSLCByZXN1bHRHUFIpOwogICAgICAg ICBicmFuY2gzMihpbnZlcnQgPyBKSVRDb21waWxlcjo6Tm90RXF1YWwgOiBKSVRDb21waWxlcjo6 RXF1YWwsIHJlc3VsdEdQUiwgSklUQ29tcGlsZXI6OlRydXN0ZWRJbW0zMihKU1ZhbHVlOjpOdWxs VGFnKSwgdGFrZW4pOwogICAgIH0KICAgICAKQEAgLTExNzksOCArMTE3Nyw3IEBAIHZvaWQgU3Bl Y3VsYXRpdmVKSVQ6OmNvbXBpbGVPYmplY3RUb09iamUKICAgICAvLyBXZSBrbm93IHRoYXQgd2l0 aGluIHRoaXMgYnJhbmNoLCByaWdodENoaWxkIG11c3Qgbm90IGJlIGEgY2VsbC4gQ2hlY2sgaWYg dGhhdCBpcyBlbm91Z2ggdG8KICAgICAvLyBwcm92ZSB0aGF0IGl0IGlzIGVpdGhlciBudWxsIG9y IHVuZGVmaW5lZC4KICAgICBpZiAobmVlZHNUeXBlQ2hlY2socmlnaHRDaGlsZCwgU3BlY0NlbGwg fCBTcGVjT3RoZXIpKSB7Ci0gICAgICAgIG1faml0Lm1vdmUob3AyVGFnR1BSLCByZXN1bHRHUFIp OwotICAgICAgICBtX2ppdC5vcjMyKFRydXN0ZWRJbW0zMigxKSwgcmVzdWx0R1BSKTsKKyAgICAg ICAgbV9qaXQub3IzMihUcnVzdGVkSW1tMzIoMSksIG9wMlRhZ0dQUiwgcmVzdWx0R1BSKTsKICAg ICAgICAgCiAgICAgICAgIHR5cGVDaGVjaygKICAgICAgICAgICAgIEpTVmFsdWVSZWdzKG9wMlRh Z0dQUiwgb3AyUGF5bG9hZEdQUiksIHJpZ2h0Q2hpbGQsIFNwZWNDZWxsIHwgU3BlY090aGVyLApA QCAtMTI3NCw4ICsxMjcxLDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZVBlZXBIb2xl T2JqZQogICAgICAgICBqdW1wKG5vdFRha2VuLCBGb3JjZUp1bXApOwogICAgICAgICAKICAgICAg ICAgcmlnaHROb3RDZWxsLmxpbmsoJm1faml0KTsKLSAgICAgICAgbV9qaXQubW92ZShvcDJUYWdH UFIsIHJlc3VsdEdQUik7Ci0gICAgICAgIG1faml0Lm9yMzIoVHJ1c3RlZEltbTMyKDEpLCByZXN1 bHRHUFIpOworICAgICAgICBtX2ppdC5vcjMyKFRydXN0ZWRJbW0zMigxKSwgb3AyVGFnR1BSLCBy ZXN1bHRHUFIpOwogICAgICAgICAKICAgICAgICAgdHlwZUNoZWNrKAogICAgICAgICAgICAgSlNW YWx1ZVJlZ3Mob3AyVGFnR1BSLCBvcDJQYXlsb2FkR1BSKSwgcmlnaHRDaGlsZCwgU3BlY0NlbGwg fCBTcGVjT3RoZXIsCkBAIC0xMzczLDggKzEzNjksNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpj b21waWxlT2JqZWN0T3JPdGhlCiAgCiAgICAgQ09NUElMRV9BU1NFUlQoKEpTVmFsdWU6OlVuZGVm aW5lZFRhZyB8IDEpID09IEpTVmFsdWU6Ok51bGxUYWcsIFVuZGVmaW5lZFRhZ19PUl8xX0VRVUFM U19OdWxsVGFnKTsKICAgICBpZiAobmVlZHNUeXBlQ2hlY2sobm9kZVVzZSwgU3BlY0NlbGwgfCBT cGVjT3RoZXIpKSB7Ci0gICAgICAgIG1faml0Lm1vdmUodmFsdWVUYWdHUFIsIHJlc3VsdFBheWxv YWRHUFIpOwotICAgICAgICBtX2ppdC5vcjMyKFRydXN0ZWRJbW0zMigxKSwgcmVzdWx0UGF5bG9h ZEdQUik7CisgICAgICAgIG1faml0Lm9yMzIoVHJ1c3RlZEltbTMyKDEpLCB2YWx1ZVRhZ0dQUiwg cmVzdWx0UGF5bG9hZEdQUik7CiAgICAgICAgIHR5cGVDaGVjaygKICAgICAgICAgICAgIEpTVmFs dWVSZWdzKHZhbHVlVGFnR1BSLCB2YWx1ZVBheWxvYWRHUFIpLCBub2RlVXNlLCBTcGVjQ2VsbCB8 IFNwZWNPdGhlciwKICAgICAgICAgICAgIG1faml0LmJyYW5jaDMyKApAQCAtMTUwMSw4ICsxNDk2 LDcgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6ZW1pdE9iamVjdE9yT3RoZXJCcgogICAgIAogICAg IENPTVBJTEVfQVNTRVJUKChKU1ZhbHVlOjpVbmRlZmluZWRUYWcgfCAxKSA9PSBKU1ZhbHVlOjpO dWxsVGFnLCBVbmRlZmluZWRUYWdfT1JfMV9FUVVBTFNfTnVsbFRhZyk7CiAgICAgaWYgKG5lZWRz VHlwZUNoZWNrKG5vZGVVc2UsIFNwZWNDZWxsIHwgU3BlY090aGVyKSkgewotICAgICAgICBtX2pp dC5tb3ZlKHZhbHVlVGFnR1BSLCBzY3JhdGNoR1BSKTsKLSAgICAgICAgbV9qaXQub3IzMihUcnVz dGVkSW1tMzIoMSksIHNjcmF0Y2hHUFIpOworICAgICAgICBtX2ppdC5vcjMyKFRydXN0ZWRJbW0z MigxKSwgdmFsdWVUYWdHUFIsIHNjcmF0Y2hHUFIpOwogICAgICAgICB0eXBlQ2hlY2soCiAgICAg ICAgICAgICBKU1ZhbHVlUmVncyh2YWx1ZVRhZ0dQUiwgdmFsdWVQYXlsb2FkR1BSKSwgbm9kZVVz ZSwgU3BlY0NlbGwgfCBTcGVjT3RoZXIsCiAgICAgICAgICAgICBtX2ppdC5icmFuY2gzMihNYWNy b0Fzc2VtYmxlcjo6Tm90RXF1YWwsIHNjcmF0Y2hHUFIsIFRydXN0ZWRJbW0zMihKU1ZhbHVlOjpO dWxsVGFnKSkpOwpAQCAtNDk1NCw4ICs0OTQ4LDcgQEAgSklUQ29tcGlsZXI6Okp1bXAgU3BlY3Vs YXRpdmVKSVQ6OmJyYW5jaAogCiBKSVRDb21waWxlcjo6SnVtcCBTcGVjdWxhdGl2ZUpJVDo6YnJh bmNoSXNPdGhlcihKU1ZhbHVlUmVncyByZWdzLCBHUFJSZWcgdGVtcEdQUikKIHsKLSAgICBtX2pp dC5tb3ZlKHJlZ3MudGFnR1BSKCksIHRlbXBHUFIpOwotICAgIG1faml0Lm9yMzIoVHJ1c3RlZElt bTMyKDEpLCB0ZW1wR1BSKTsKKyAgICBtX2ppdC5vcjMyKFRydXN0ZWRJbW0zMigxKSwgcmVncy50 YWdHUFIoKSwgdGVtcEdQUik7CiAgICAgcmV0dXJuIG1faml0LmJyYW5jaDMyKAogICAgICAgICBN YWNyb0Fzc2VtYmxlcjo6RXF1YWwsIHRlbXBHUFIsCiAgICAgICAgIE1hY3JvQXNzZW1ibGVyOjpU cnVzdGVkSW1tMzIoSlNWYWx1ZTo6TnVsbFRhZykpOwpAQCAtNDk2Myw4ICs0OTU2LDcgQEAgSklU Q29tcGlsZXI6Okp1bXAgU3BlY3VsYXRpdmVKSVQ6OmJyYW5jaAogCiBKSVRDb21waWxlcjo6SnVt cCBTcGVjdWxhdGl2ZUpJVDo6YnJhbmNoTm90T3RoZXIoSlNWYWx1ZVJlZ3MgcmVncywgR1BSUmVn IHRlbXBHUFIpCiB7Ci0gICAgbV9qaXQubW92ZShyZWdzLnRhZ0dQUigpLCB0ZW1wR1BSKTsKLSAg ICBtX2ppdC5vcjMyKFRydXN0ZWRJbW0zMigxKSwgdGVtcEdQUik7CisgICAgbV9qaXQub3IzMihU cnVzdGVkSW1tMzIoMSksIHJlZ3MudGFnR1BSKCksIHRlbXBHUFIpOwogICAgIHJldHVybiBtX2pp dC5icmFuY2gzMigKICAgICAgICAgTWFjcm9Bc3NlbWJsZXI6Ok5vdEVxdWFsLCB0ZW1wR1BSLAog ICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZEltbTMyKEpTVmFsdWU6Ok51bGxUYWcpKTsK