136286 2014-08-27 06:07:22 -0700 [WinCairo] Link error. 2014-08-27 12:37:36 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue darin oldest_to_newest 1031640 0 peavo 2014-08-27 06:07:22 -0700 Linking WebKit.dll fails with the following error: 1>MSVCRT.lib(MSVCR120.dll) : error LNK2005: _longjmp already defined in LIBCMT.lib(longjmp.obj) 1>MSVCRT.lib(MSVCR120.dll) : error LNK2005: _modf already defined in LIBCMT.lib(modf_pentium4.obj) Creating library WebKit.lib and object WebKit.exp 1>LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library 1>WebKit.dll : fatal error LNK1169: one or more multiply defined symbols found 1>Done Building Project "WebKit.vcxproj" (Build target(s)) -- FAILED. Build FAILED. Time Elapsed 00:02:01.75 I believe this happens because the WebKit libraries are set up to link statically with the runtime libraries, while the WinCairo libraries are using the dynamic runtime libraries. 1031644 1 237222 peavo 2014-08-27 06:16:08 -0700 Created attachment 237222 Patch 1031646 2 peavo 2014-08-27 06:26:54 -0700 (In reply to comment #1) > Created an attachment (id=237222) [details] > Patch I'm not sure that this is the right fix; maybe it's better to recompile the WinCairo libraries with static runtime libraries, to avoid differences between AppleWin and WinCairo ... 1031717 3 bfulgham 2014-08-27 12:15:31 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=237222) [details] [details] > > Patch > > I'm not sure that this is the right fix; maybe it's better to recompile the WinCairo libraries with static runtime libraries, to avoid differences between AppleWin and WinCairo ... No, your change is correct. I'm intending to switch the Apple build back to DLL's at some point in the near future. Sorry for the inconvenience! 1031734 4 peavo 2014-08-27 12:34:58 -0700 (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > Created an attachment (id=237222) [details] [details] [details] > > > Patch > > > > I'm not sure that this is the right fix; maybe it's better to recompile the WinCairo libraries with static runtime libraries, to avoid differences between AppleWin and WinCairo ... > > No, your change is correct. I'm intending to switch the Apple build back to DLL's at some point in the near future. Sorry for the inconvenience! No worries :) 1031735 5 237222 commit-queue 2014-08-27 12:37:33 -0700 Comment on attachment 237222 Patch Clearing flags on attachment: 237222 Committed r173013: <http://trac.webkit.org/changeset/173013> 1031736 6 commit-queue 2014-08-27 12:37:36 -0700 All reviewed patches have been landed. Closing bug. 237222 2014-08-27 06:16:08 -0700 2014-08-27 12:37:32 -0700 Patch bug-136286-20140827151552.patch text/plain 1701 peavo SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTczMDAyKQorKysgV2ViS2l0TGlicmFyaWVzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTI3ICBwZWF2 b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10g TGluayBlcnJvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNjI4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIExpbmsgd2l0aCB0aGUgZHluYW1pYyBydW50aW1lIGxpYnJhcmllcywgc2luY2UgdGhlIFdp bkNhaXJvIGxpYnJhcmllcyBsaW5rIHdpdGggdGhlc2UuCisKKyAgICAgICAgKiB3aW4vdG9vbHMv dnNwcm9wcy9jb21tb24ucHJvcHM6CisKIDIwMTQtMDgtMjYgIEJyZW50IEZ1bGdoYW0gIDxiZnVs Z2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gVmVyc2lvbiBzdGFtcCBzaG91bGQgaW5j bHVkZSBwYWNrYWdlLWxldmVsIHZlcnNpb24KSW5kZXg6IFdlYktpdExpYnJhcmllcy93aW4vdG9v bHMvdnNwcm9wcy9jb21tb24ucHJvcHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGlicmFyaWVzL3dp bi90b29scy92c3Byb3BzL2NvbW1vbi5wcm9wcwkocmV2aXNpb24gMTczMDAyKQorKysgV2ViS2l0 TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL2NvbW1vbi5wcm9wcwkod29ya2luZyBjb3B5KQpA QCAtNTAsNiArNTAsNyBAQCBubWFrZSAvbm9sb2dvIC1mICQoUHJvamVjdE5hbWUpLm1ha2UgY2xl CiAgICAgICA8RGVidWdJbmZvcm1hdGlvbkZvcm1hdD5Qcm9ncmFtRGF0YWJhc2U8L0RlYnVnSW5m b3JtYXRpb25Gb3JtYXQ+CiAgICAgICA8RGlzYWJsZVNwZWNpZmljV2FybmluZ3M+NDAxODs0MDY4 OzQwOTk7NDEwMDs0MTI3OzQxMzg7NDE0Njs0MTgwOzQxODk7NDIwMTs0MjQ0OzQyNTE7NDI2Nzs0 Mjc1OzQyODg7NDI5MTs0MzA1OzQzMDk7NDM0NDs0MzU1OzQzODk7NDM5Njs0NDgxOzQ1MDM7NDUw NTs0NTEwOzQ1MTI7NDUzMDs0NjEwOzQ3MDI7NDcwNjs0ODAwOzQ4MTk7NDk1MTs0OTUyOzQ5OTY7 NjAxMTs2MDMxOzYyMTE7NjI0Njs2MjU1OzYzODc7JShEaXNhYmxlU3BlY2lmaWNXYXJuaW5ncyk8 L0Rpc2FibGVTcGVjaWZpY1dhcm5pbmdzPgogICAgICAgPFJ1bnRpbWVMaWJyYXJ5Pk11bHRpVGhy ZWFkZWQ8L1J1bnRpbWVMaWJyYXJ5PgorICAgICAgPFJ1bnRpbWVMaWJyYXJ5IENvbmRpdGlvbj0i JChDb25maWd1cmF0aW9uKT09J1JlbGVhc2VfV2luQ2Fpcm8nIG9yICQoQ29uZmlndXJhdGlvbik9 PSdEZWJ1Z19XaW5DYWlybyciPk11bHRpVGhyZWFkZWRETEw8L1J1bnRpbWVMaWJyYXJ5PgogICAg ICAgPEZ1bmN0aW9uTGV2ZWxMaW5raW5nPmZhbHNlPC9GdW5jdGlvbkxldmVsTGlua2luZz4KICAg ICAgIDxGbG9hdGluZ1BvaW50RXhjZXB0aW9ucz5mYWxzZTwvRmxvYXRpbmdQb2ludEV4Y2VwdGlv bnM+CiAgICAgICA8T3Blbk1QU3VwcG9ydD5mYWxzZTwvT3Blbk1QU3VwcG9ydD4K