136282 2014-08-26 22:56:41 -0700 build.webkit.org/dashboard raises an exception after a hidden platform is removed 2014-08-26 23:44:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue thorton timothy oldest_to_newest 1031589 0 ap 2014-08-26 22:56:41 -0700 If you have a platform hidden via settings, and the platform gets later removed from Dashboard configuration, then an exception is raised at load time. 1031591 1 237206 ap 2014-08-26 22:58:58 -0700 Created attachment 237206 proposed fix 1031592 2 237206 thorton 2014-08-26 23:03:44 -0700 Comment on attachment 237206 proposed fix Whoops! 1031599 3 237206 commit-queue 2014-08-26 23:44:11 -0700 Comment on attachment 237206 proposed fix Clearing flags on attachment: 237206 Committed r172996: <http://trac.webkit.org/changeset/172996> 1031600 4 commit-queue 2014-08-26 23:44:14 -0700 All reviewed patches have been landed. Closing bug. 237206 2014-08-26 22:58:58 -0700 2014-08-26 23:44:11 -0700 proposed fix OldHiddenPlaform.txt text/plain 1717 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3Mjk5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE0LTA4LTI2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkIHJhaXNlcyBhbiBleGNlcHRp b24gYWZ0ZXIgYSBoaWRkZW4gcGxhdGZvcm0gaXMgcmVtb3ZlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MjgyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9NYWluLmpzOgor ICAgICAgICAodXBkYXRlSGlkZGVuUGxhdGZvcm1zKTogQ2hlY2sgdGhhdCB0aGUgcGxhdGZvcm0g aXMgc3RpbGwgdmFsaWQuCisKIDIwMTQtMDgtMjYgIE1hdHQgTGlsZWsgIDxtcmxAYXBwbGUuY29t PgogCiAgICAgICAgIEFkZCBXZWJLaXQgU1BJIHRvIGNvbnRyb2wgdGhlIG5hdmlnYXRvci5zdGFu ZGFsb25lIHByb3BlcnR5CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9NYWluLmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL01haW4uanMJKHJldmlzaW9uIDE3Mjk0NikK KysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1Ymxp Y19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL01haW4uanMJKHdvcmtpbmcgY29weSkKQEAgLTEwOSw4 ICsxMDksMTEgQEAgZnVuY3Rpb24gdXBkYXRlSGlkZGVuUGxhdGZvcm1zKCkKICAgICBmb3IgKHZh ciBpID0gMDsgaSA8IHBsYXRmb3JtUm93cy5sZW5ndGg7ICsraSkKICAgICAgICAgcGxhdGZvcm1S b3dzW2ldLmNsYXNzTGlzdC5yZW1vdmUoImhpZGRlbiIpOwogCi0gICAgZm9yICh2YXIgaSA9IDA7 IGkgPCBoaWRkZW5QbGF0Zm9ybXMubGVuZ3RoOyArK2kpCi0gICAgICAgIGRvY3VtZW50LnF1ZXJ5 U2VsZWN0b3IoInRyLnBsYXRmb3JtLiIgKyBoaWRkZW5QbGF0Zm9ybXNbaV0pLmNsYXNzTGlzdC5h ZGQoImhpZGRlbiIpOworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgaGlkZGVuUGxhdGZvcm1zLmxl bmd0aDsgKytpKSB7CisgICAgICAgIHZhciBwbGF0Zm9ybVJvdyA9IGRvY3VtZW50LnF1ZXJ5U2Vs ZWN0b3IoInRyLnBsYXRmb3JtLiIgKyBoaWRkZW5QbGF0Zm9ybXNbaV0pOworICAgICAgICBpZiAo cGxhdGZvcm1Sb3cpCisgICAgICAgICAgICBwbGF0Zm9ybVJvdy5jbGFzc0xpc3QuYWRkKCJoaWRk ZW4iKTsKKyAgICB9CiAKICAgICB2YXIgdW5oaWRlQnV0dG9uID0gZG9jdW1lbnQucXVlcnlTZWxl Y3RvcigiZGl2LmNlbGxCdXR0b24udW5oaWRlIik7CiAgICAgaWYgKGhpZGRlblBsYXRmb3Jtcy5s ZW5ndGgpCg==