136262 2014-08-26 11:53:09 -0700 Remove UNUSED_PARAM macros from ServicesOverlayController.mm 2014-08-26 13:37:19 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dburkart webkit-unassigned commit-queue dburkart ddkilzer oldest_to_newest 1031437 0 dburkart 2014-08-26 11:53:09 -0700 WebKit2 is failing ASan builds because of two UNUSED_PARAM macros for parameters which no longer exist. 1031439 1 237163 dburkart 2014-08-26 11:55:46 -0700 Created attachment 237163 Patch to remove the two UNUSED_PARAM() macros 1031440 2 commit-queue 2014-08-26 11:58:04 -0700 Attachment 237163 did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:4: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1031445 3 237164 dburkart 2014-08-26 12:06:50 -0700 Created attachment 237164 Patch to remove the two UNUSED_PARAM() macros Fix style issues in ChangeLog. 1031446 4 237163 ddkilzer 2014-08-26 12:09:33 -0700 Comment on attachment 237163 Patch to remove the two UNUSED_PARAM() macros View in context: https://bugs.webkit.org/attachment.cgi?id=237163&action=review Please post another patch with the UNUSED_PARAM() statements added, and the tab removed from the ChangeLog. Otherwise, this looks fine. :) > Source/WebKit2/ChangeLog:3 > + The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan failures. Maybe say: "causing ASan build failures." > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-394 > -#else > - UNUSED_PARAM(rects); This one actually needs to add two UNUSED_PARAM() statements for new arguments added to the method at some point: UNUSED_PARAM(rects); UNUSED_PARAM(gapRects); UNUSED_PARAM(isTextOnly); 1031447 5 237164 ddkilzer 2014-08-26 12:10:59 -0700 Comment on attachment 237164 Patch to remove the two UNUSED_PARAM() macros View in context: https://bugs.webkit.org/attachment.cgi?id=237164&action=review Please fix the UNUSED_PARAM() statements in ServicesOverlayController::selectionRectsDidChange(). Thanks! > Source/WebKit2/ChangeLog:3 > + The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan failures. Maybe say: "causing ASan build failures." > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-394 > -#else > - UNUSED_PARAM(rects); This one actually needs to add two UNUSED_PARAM() statements for new arguments added to the method at some point: UNUSED_PARAM(rects); UNUSED_PARAM(gapRects); UNUSED_PARAM(isTextOnly); 1031448 6 237165 dburkart 2014-08-26 12:15:37 -0700 Created attachment 237165 Remove one UNUSED_PARAM() call, and add two others. Changes to address ddkilzer's concerns. 1031459 7 237165 ddkilzer 2014-08-26 13:02:12 -0700 Comment on attachment 237165 Remove one UNUSED_PARAM() call, and add two others. r=me 1031469 8 237165 commit-queue 2014-08-26 13:37:17 -0700 Comment on attachment 237165 Remove one UNUSED_PARAM() call, and add two others. Clearing flags on attachment: 237165 Committed r172974: <http://trac.webkit.org/changeset/172974> 1031470 9 commit-queue 2014-08-26 13:37:19 -0700 All reviewed patches have been landed. Closing bug. 237163 2014-08-26 11:55:46 -0700 2014-08-26 12:09:44 -0700 Patch to remove the two UNUSED_PARAM() macros 136262.patch text/plain 2050 dburkart SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mjk2NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTI2ICBEYW5hIEJ1 cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIFVOVVNFRF9QQVJBTSBt YWNyb3MgaW4gU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbSBhcmUgY2F1c2luZyBBU2FuIGZh aWx1cmVzLgorCQlodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MjYy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW06CisgICAgICAg IChXZWJLaXQ6OlNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6OnNlbGVjdGlvblJlY3RzRGlkQ2hh bmdlKToKKyAgICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6c2VsZWN0 ZWRUZWxlcGhvbmVOdW1iZXJSYW5nZXNDaGFuZ2VkKToKKwogMjAxNC0wOC0yNiAgVGltIEhvcnRv biAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTcy NzcxKTogQW1hem9uIHByb2R1Y3QgcGFnZSBiZWNvbWVzIHVucmVzcG9uc2l2ZSBhZnRlciBzd2lw aW5nIGJhY2sgdG8gaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9t YWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0J KHJldmlzaW9uIDE3Mjk2NSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9t YWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMzc2LDcg KzM3Niw3IEBAIHN0YXRpYyB2b2lkIGNvbXBhY3RSZWN0c1dpdGhHYXBSZWN0cyhWZWMKIAogdm9p ZCBTZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyOjpzZWxlY3Rpb25SZWN0c0RpZENoYW5nZShjb25z dCBWZWN0b3I8TGF5b3V0UmVjdD4mIHJlY3RzLCBjb25zdCBWZWN0b3I8R2FwUmVjdHM+JiBnYXBS ZWN0cywgYm9vbCBpc1RleHRPbmx5KQogewotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVR VUlSRUQgPiAxMDkwCisjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlO X1JFUVVJUkVEID4gMTA5MAogICAgIG1fY3VycmVudFNlbGVjdGlvblJlY3RzID0gcmVjdHM7CiAg ICAgbV9pc1RleHRPbmx5ID0gaXNUZXh0T25seTsKIApAQCAtMzkwLDggKzM5MCw2IEBAIHZvaWQg U2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6c2VsZWN0aW8KICAgICBMT0coU2VydmljZXMsICJT ZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyIC0gU2VsZWN0aW9uIHJlY3RzIGNoYW5nZWQgLSBOb3cg aGF2ZSAlbHVcbiIsIHJlY3RzLnNpemUoKSk7CiAKICAgICBidWlsZFNlbGVjdGlvbkhpZ2hsaWdo dCgpOwotI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0ocmVjdHMpOwogI2VuZGlmCiB9CiAKQEAgLTQw MCw4ICszOTgsNiBAQCB2b2lkIFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6OnNlbGVjdGVkCiAj aWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID4gMTA5 MAogICAgIExPRyhTZXJ2aWNlcywgIlNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIgLSBUZWxlcGhv bmUgbnVtYmVyIHJhbmdlcyBjaGFuZ2VkXG4iKTsKICAgICBidWlsZFBob25lTnVtYmVySGlnaGxp Z2h0cygpOwotI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0ocmFuZ2VzKTsKICNlbmRpZgogfQogCg== 237164 2014-08-26 12:06:50 -0700 2014-08-26 12:15:37 -0700 Patch to remove the two UNUSED_PARAM() macros 136262.patch text/plain 2056 dburkart SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mjk2NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTI2ICBEYW5hIEJ1 cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIFVOVVNFRF9QQVJBTSBt YWNyb3MgaW4gU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbSBhcmUgY2F1c2luZyBBU2FuIGZh aWx1cmVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM2MjYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW06Cisg ICAgICAgIChXZWJLaXQ6OlNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6OnNlbGVjdGlvblJlY3Rz RGlkQ2hhbmdlKToKKyAgICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6 c2VsZWN0ZWRUZWxlcGhvbmVOdW1iZXJSYW5nZXNDaGFuZ2VkKToKKwogMjAxNC0wOC0yNiAgVGlt IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O IChyMTcyNzcxKTogQW1hem9uIHByb2R1Y3QgcGFnZSBiZWNvbWVzIHVucmVzcG9uc2l2ZSBhZnRl ciBzd2lwaW5nIGJhY2sgdG8gaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xs ZXIubW0JKHJldmlzaW9uIDE3Mjk2NSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAt Mzc2LDcgKzM3Niw3IEBAIHN0YXRpYyB2b2lkIGNvbXBhY3RSZWN0c1dpdGhHYXBSZWN0cyhWZWMK IAogdm9pZCBTZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyOjpzZWxlY3Rpb25SZWN0c0RpZENoYW5n ZShjb25zdCBWZWN0b3I8TGF5b3V0UmVjdD4mIHJlY3RzLCBjb25zdCBWZWN0b3I8R2FwUmVjdHM+ JiBnYXBSZWN0cywgYm9vbCBpc1RleHRPbmx5KQogewotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPiAxMDkwCisjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJ T05fTUlOX1JFUVVJUkVEID4gMTA5MAogICAgIG1fY3VycmVudFNlbGVjdGlvblJlY3RzID0gcmVj dHM7CiAgICAgbV9pc1RleHRPbmx5ID0gaXNUZXh0T25seTsKIApAQCAtMzkwLDggKzM5MCw2IEBA IHZvaWQgU2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6c2VsZWN0aW8KICAgICBMT0coU2Vydmlj ZXMsICJTZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyIC0gU2VsZWN0aW9uIHJlY3RzIGNoYW5nZWQg LSBOb3cgaGF2ZSAlbHVcbiIsIHJlY3RzLnNpemUoKSk7CiAKICAgICBidWlsZFNlbGVjdGlvbkhp Z2hsaWdodCgpOwotI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0ocmVjdHMpOwogI2VuZGlmCiB9CiAK QEAgLTQwMCw4ICszOTgsNiBAQCB2b2lkIFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6OnNlbGVj dGVkCiAjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID4gMTA5MAogICAgIExPRyhTZXJ2aWNlcywgIlNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIgLSBU ZWxlcGhvbmUgbnVtYmVyIHJhbmdlcyBjaGFuZ2VkXG4iKTsKICAgICBidWlsZFBob25lTnVtYmVy SGlnaGxpZ2h0cygpOwotI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0ocmFuZ2VzKTsKICNlbmRpZgog fQogCg== 237165 2014-08-26 12:15:37 -0700 2014-08-26 13:37:17 -0700 Remove one UNUSED_PARAM() call, and add two others. 136262.patch text/plain 2014 dburkart SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mjk2NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTI2ICBEYW5hIEJ1 cmthcnQgIDxkYnVya2FydEBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIFVOVVNFRF9QQVJBTSBt YWNyb3MgaW4gU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbSBhcmUgY2F1c2luZyBBU2FuIGJ1 aWxkIGZhaWx1cmVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM2MjYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIu bW06CisgICAgICAgIChXZWJLaXQ6OlNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6OnNlbGVjdGlv blJlY3RzRGlkQ2hhbmdlKToKKyAgICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVybGF5Q29udHJv bGxlcjo6c2VsZWN0ZWRUZWxlcGhvbmVOdW1iZXJSYW5nZXNDaGFuZ2VkKToKKwogMjAxNC0wOC0y NiAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdS RVNTSU9OIChyMTcyNzcxKTogQW1hem9uIHByb2R1Y3QgcGFnZSBiZWNvbWVzIHVucmVzcG9uc2l2 ZSBhZnRlciBzd2lwaW5nIGJhY2sgdG8gaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNv bnRyb2xsZXIubW0JKHJldmlzaW9uIDE3Mjk2NSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5 KQpAQCAtMzc2LDcgKzM3Niw3IEBAIHN0YXRpYyB2b2lkIGNvbXBhY3RSZWN0c1dpdGhHYXBSZWN0 cyhWZWMKIAogdm9pZCBTZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyOjpzZWxlY3Rpb25SZWN0c0Rp ZENoYW5nZShjb25zdCBWZWN0b3I8TGF5b3V0UmVjdD4mIHJlY3RzLCBjb25zdCBWZWN0b3I8R2Fw UmVjdHM+JiBnYXBSZWN0cywgYm9vbCBpc1RleHRPbmx5KQogewotI2lmIF9fTUFDX09TX1hfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPiAxMDkwCisjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19Y X1ZFUlNJT05fTUlOX1JFUVVJUkVEID4gMTA5MAogICAgIG1fY3VycmVudFNlbGVjdGlvblJlY3Rz ID0gcmVjdHM7CiAgICAgbV9pc1RleHRPbmx5ID0gaXNUZXh0T25seTsKIApAQCAtMzkyLDYgKzM5 Miw4IEBAIHZvaWQgU2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6c2VsZWN0aW8KICAgICBidWls ZFNlbGVjdGlvbkhpZ2hsaWdodCgpOwogI2Vsc2UKICAgICBVTlVTRURfUEFSQU0ocmVjdHMpOwor ICAgIFVOVVNFRF9QQVJBTShnYXBSZWN0cyk7CisgICAgVU5VU0VEX1BBUkFNKGlzVGV4dE9ubHkp OwogI2VuZGlmCiB9CiAKQEAgLTQwMCw4ICs0MDIsNiBAQCB2b2lkIFNlcnZpY2VzT3ZlcmxheUNv bnRyb2xsZXI6OnNlbGVjdGVkCiAjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJ T05fTUlOX1JFUVVJUkVEID4gMTA5MAogICAgIExPRyhTZXJ2aWNlcywgIlNlcnZpY2VzT3Zlcmxh eUNvbnRyb2xsZXIgLSBUZWxlcGhvbmUgbnVtYmVyIHJhbmdlcyBjaGFuZ2VkXG4iKTsKICAgICBi dWlsZFBob25lTnVtYmVySGlnaGxpZ2h0cygpOwotI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0ocmFu Z2VzKTsKICNlbmRpZgogfQogCg==