136251 2014-08-26 06:23:44 -0700 [GTK] Selection background is rendered white when unfocused with recent GTK+ 2014-08-26 08:20:37 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo otte pnormand oldest_to_newest 1031368 0 cgarcia 2014-08-26 06:23:44 -0700 This is due to a change in the GTK+ theme, but because of a bug in WebKit. We are not using the right flags to get the selections colors. 1031369 1 237148 cgarcia 2014-08-26 06:29:43 -0700 Created attachment 237148 Patch 1031377 2 237148 mrobinson 2014-08-26 08:04:33 -0700 Comment on attachment 237148 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237148&action=review > Source/WebCore/ChangeLog:8 > + This is due to a change in the GTK+ theme, but because ee are not ee -> we 1031378 3 cgarcia 2014-08-26 08:20:37 -0700 Committed r172958: <http://trac.webkit.org/changeset/172958> 237148 2014-08-26 06:29:43 -0700 2014-08-26 08:04:32 -0700 Patch wk-selection-color.diff text/plain 5036 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzODI2OGI2Li45NGEyMWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTQtMDgtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFNlbGVjdGlvbiBiYWNrZ3JvdW5kIGlzIHJlbmRlcmVkIHdoaXRl IHdoZW4gdW5mb2N1c2VkIHdpdGggcmVjZW50IEdUSysKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjI1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgZHVlIHRvIGEgY2hhbmdlIGluIHRoZSBH VEsrIHRoZW1lLCBidXQgYmVjYXVzZSBlZSBhcmUgbm90CisgICAgICAgIHVzaW5nIHRoZSByaWdo dCBmbGFncyB0byBnZXQgdGhlIHNlbGVjdGlvbnMgY29sb3JzLiBXZSBzaG91bGQgdXNlCisgICAg ICAgIEdUS19TVEFURV9GTEFHX1NFTEVDVEVEIHwgR1RLX1NUQVRFX0ZMQUdfRk9DVVNFRCB3aGVu IGZvY3VzZWQgYW5kCisgICAgICAgIEdUS19TVEFURV9GTEFHX1NFTEVDVEVEIHdoZW4gdW5mb2N1 c2VkLCBpbnN0ZWFkIG9mCisgICAgICAgIEdUS19TVEFURV9GTEFHX0FDVElWRSB3aGVuIHVuZm9j dXNlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVHdGs6OnBsYXRmb3JtQWN0aXZlU2VsZWN0aW9uQmFj a2dyb3VuZENvbG9yKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpwbGF0Zm9y bUluYWN0aXZlU2VsZWN0aW9uQmFja2dyb3VuZENvbG9yKToKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRoZW1lR3RrOjpwbGF0Zm9ybUFjdGl2ZVNlbGVjdGlvbkZvcmVncm91bmRDb2xvcik6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUd0azo6cGxhdGZvcm1JbmFjdGl2ZVNlbGVjdGlv bkZvcmVncm91bmRDb2xvcik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUd0azo6cGxh dGZvcm1BY3RpdmVMaXN0Qm94U2VsZWN0aW9uQmFja2dyb3VuZENvbG9yKToKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclRoZW1lR3RrOjpwbGF0Zm9ybUluYWN0aXZlTGlzdEJveFNlbGVjdGlvbkJh Y2tncm91bmRDb2xvcik6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUd0azo6cGxhdGZv cm1BY3RpdmVMaXN0Qm94U2VsZWN0aW9uRm9yZWdyb3VuZENvbG9yKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclRoZW1lR3RrOjpwbGF0Zm9ybUluYWN0aXZlTGlzdEJveFNlbGVjdGlvbkZvcmVn cm91bmRDb2xvcik6CisKIDIwMTQtMDgtMjYgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ft c3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gVXRpbGl6ZSBlc3BlYWsgYXMgYSBzeW50aGVzaXpl ciBiYWNrLWVuZCBmb3IgV2ViU3BlZWNoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9SZW5kZXJUaGVtZUd0azMuY3BwCmluZGV4IDZkODExYTEuLjhmYTc4MjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3BwCkBAIC05NDEsNTYg Kzk0MSw1NiBAQCBHUmVmUHRyPEdka1BpeGJ1Zj4gZ2V0U3RvY2tTeW1ib2xpY0ljb25Gb3JXaWRn ZXRUeXBlKEdUeXBlIHdpZGdldFR5cGUsIGNvbnN0IGNoYQogQ29sb3IgUmVuZGVyVGhlbWVHdGs6 OnBsYXRmb3JtQWN0aXZlU2VsZWN0aW9uQmFja2dyb3VuZENvbG9yKCkgY29uc3QKIHsKICAgICBH ZGtSR0JBIGdka1JHQkFDb2xvcjsKLSAgICBndGtfc3R5bGVfY29udGV4dF9nZXRfYmFja2dyb3Vu ZF9jb2xvcihnZXRTdHlsZUNvbnRleHQoR1RLX1RZUEVfRU5UUlkpLCBHVEtfU1RBVEVfRkxBR19T RUxFQ1RFRCwgJmdka1JHQkFDb2xvcik7CisgICAgZ3RrX3N0eWxlX2NvbnRleHRfZ2V0X2JhY2tn cm91bmRfY29sb3IoZ2V0U3R5bGVDb250ZXh0KEdUS19UWVBFX0VOVFJZKSwgc3RhdGljX2Nhc3Q8 R3RrU3RhdGVGbGFncz4oR1RLX1NUQVRFX0ZMQUdfU0VMRUNURUQgfCBHVEtfU1RBVEVfRkxBR19G T0NVU0VEKSwgJmdka1JHQkFDb2xvcik7CiAgICAgcmV0dXJuIGdka1JHQkFDb2xvcjsKIH0KIAog Q29sb3IgUmVuZGVyVGhlbWVHdGs6OnBsYXRmb3JtSW5hY3RpdmVTZWxlY3Rpb25CYWNrZ3JvdW5k Q29sb3IoKSBjb25zdAogewogICAgIEdka1JHQkEgZ2RrUkdCQUNvbG9yOwotICAgIGd0a19zdHls ZV9jb250ZXh0X2dldF9iYWNrZ3JvdW5kX2NvbG9yKGdldFN0eWxlQ29udGV4dChHVEtfVFlQRV9F TlRSWSksIEdUS19TVEFURV9GTEFHX0FDVElWRSwgJmdka1JHQkFDb2xvcik7CisgICAgZ3RrX3N0 eWxlX2NvbnRleHRfZ2V0X2JhY2tncm91bmRfY29sb3IoZ2V0U3R5bGVDb250ZXh0KEdUS19UWVBF X0VOVFJZKSwgR1RLX1NUQVRFX0ZMQUdfU0VMRUNURUQsICZnZGtSR0JBQ29sb3IpOwogICAgIHJl dHVybiBnZGtSR0JBQ29sb3I7CiB9CiAKIENvbG9yIFJlbmRlclRoZW1lR3RrOjpwbGF0Zm9ybUFj dGl2ZVNlbGVjdGlvbkZvcmVncm91bmRDb2xvcigpIGNvbnN0CiB7CiAgICAgR2RrUkdCQSBnZGtS R0JBQ29sb3I7Ci0gICAgZ3RrX3N0eWxlX2NvbnRleHRfZ2V0X2NvbG9yKGdldFN0eWxlQ29udGV4 dChHVEtfVFlQRV9FTlRSWSksIEdUS19TVEFURV9GTEFHX1NFTEVDVEVELCAmZ2RrUkdCQUNvbG9y KTsKKyAgICBndGtfc3R5bGVfY29udGV4dF9nZXRfY29sb3IoZ2V0U3R5bGVDb250ZXh0KEdUS19U WVBFX0VOVFJZKSwgc3RhdGljX2Nhc3Q8R3RrU3RhdGVGbGFncz4oR1RLX1NUQVRFX0ZMQUdfU0VM RUNURUQgfCBHVEtfU1RBVEVfRkxBR19GT0NVU0VEKSwgJmdka1JHQkFDb2xvcik7CiAgICAgcmV0 dXJuIGdka1JHQkFDb2xvcjsKIH0KIAogQ29sb3IgUmVuZGVyVGhlbWVHdGs6OnBsYXRmb3JtSW5h Y3RpdmVTZWxlY3Rpb25Gb3JlZ3JvdW5kQ29sb3IoKSBjb25zdAogewogICAgIEdka1JHQkEgZ2Rr UkdCQUNvbG9yOwotICAgIGd0a19zdHlsZV9jb250ZXh0X2dldF9jb2xvcihnZXRTdHlsZUNvbnRl eHQoR1RLX1RZUEVfRU5UUlkpLCBHVEtfU1RBVEVfRkxBR19BQ1RJVkUsICZnZGtSR0JBQ29sb3Ip OworICAgIGd0a19zdHlsZV9jb250ZXh0X2dldF9jb2xvcihnZXRTdHlsZUNvbnRleHQoR1RLX1RZ UEVfRU5UUlkpLCBHVEtfU1RBVEVfRkxBR19TRUxFQ1RFRCwgJmdka1JHQkFDb2xvcik7CiAgICAg cmV0dXJuIGdka1JHQkFDb2xvcjsKIH0KIAogQ29sb3IgUmVuZGVyVGhlbWVHdGs6OnBsYXRmb3Jt QWN0aXZlTGlzdEJveFNlbGVjdGlvbkJhY2tncm91bmRDb2xvcigpIGNvbnN0CiB7CiAgICAgR2Rr UkdCQSBnZGtSR0JBQ29sb3I7Ci0gICAgZ3RrX3N0eWxlX2NvbnRleHRfZ2V0X2JhY2tncm91bmRf Y29sb3IoZ2V0U3R5bGVDb250ZXh0KEdUS19UWVBFX1RSRUVfVklFVyksIEdUS19TVEFURV9GTEFH X1NFTEVDVEVELCAmZ2RrUkdCQUNvbG9yKTsKKyAgICBndGtfc3R5bGVfY29udGV4dF9nZXRfYmFj a2dyb3VuZF9jb2xvcihnZXRTdHlsZUNvbnRleHQoR1RLX1RZUEVfVFJFRV9WSUVXKSwgc3RhdGlj X2Nhc3Q8R3RrU3RhdGVGbGFncz4oR1RLX1NUQVRFX0ZMQUdfU0VMRUNURUQgfCBHVEtfU1RBVEVf RkxBR19GT0NVU0VEKSwgJmdka1JHQkFDb2xvcik7CiAgICAgcmV0dXJuIGdka1JHQkFDb2xvcjsK IH0KIAogQ29sb3IgUmVuZGVyVGhlbWVHdGs6OnBsYXRmb3JtSW5hY3RpdmVMaXN0Qm94U2VsZWN0 aW9uQmFja2dyb3VuZENvbG9yKCkgY29uc3QKIHsKICAgICBHZGtSR0JBIGdka1JHQkFDb2xvcjsK LSAgICBndGtfc3R5bGVfY29udGV4dF9nZXRfYmFja2dyb3VuZF9jb2xvcihnZXRTdHlsZUNvbnRl eHQoR1RLX1RZUEVfVFJFRV9WSUVXKSwgR1RLX1NUQVRFX0ZMQUdfQUNUSVZFLCAmZ2RrUkdCQUNv bG9yKTsKKyAgICBndGtfc3R5bGVfY29udGV4dF9nZXRfYmFja2dyb3VuZF9jb2xvcihnZXRTdHls ZUNvbnRleHQoR1RLX1RZUEVfVFJFRV9WSUVXKSwgR1RLX1NUQVRFX0ZMQUdfU0VMRUNURUQsICZn ZGtSR0JBQ29sb3IpOwogICAgIHJldHVybiBnZGtSR0JBQ29sb3I7CiB9CiAKIENvbG9yIFJlbmRl clRoZW1lR3RrOjpwbGF0Zm9ybUFjdGl2ZUxpc3RCb3hTZWxlY3Rpb25Gb3JlZ3JvdW5kQ29sb3Io KSBjb25zdAogewogICAgIEdka1JHQkEgZ2RrUkdCQUNvbG9yOwotICAgIGd0a19zdHlsZV9jb250 ZXh0X2dldF9jb2xvcihnZXRTdHlsZUNvbnRleHQoR1RLX1RZUEVfVFJFRV9WSUVXKSwgR1RLX1NU QVRFX0ZMQUdfU0VMRUNURUQsICZnZGtSR0JBQ29sb3IpOworICAgIGd0a19zdHlsZV9jb250ZXh0 X2dldF9jb2xvcihnZXRTdHlsZUNvbnRleHQoR1RLX1RZUEVfVFJFRV9WSUVXKSwgc3RhdGljX2Nh c3Q8R3RrU3RhdGVGbGFncz4oR1RLX1NUQVRFX0ZMQUdfU0VMRUNURUQgfCBHVEtfU1RBVEVfRkxB R19GT0NVU0VEKSwgJmdka1JHQkFDb2xvcik7CiAgICAgcmV0dXJuIGdka1JHQkFDb2xvcjsKIH0K IAogQ29sb3IgUmVuZGVyVGhlbWVHdGs6OnBsYXRmb3JtSW5hY3RpdmVMaXN0Qm94U2VsZWN0aW9u Rm9yZWdyb3VuZENvbG9yKCkgY29uc3QKIHsKICAgICBHZGtSR0JBIGdka1JHQkFDb2xvcjsKLSAg ICBndGtfc3R5bGVfY29udGV4dF9nZXRfY29sb3IoZ2V0U3R5bGVDb250ZXh0KEdUS19UWVBFX1RS RUVfVklFVyksIEdUS19TVEFURV9GTEFHX0FDVElWRSwgJmdka1JHQkFDb2xvcik7CisgICAgZ3Rr X3N0eWxlX2NvbnRleHRfZ2V0X2NvbG9yKGdldFN0eWxlQ29udGV4dChHVEtfVFlQRV9UUkVFX1ZJ RVcpLCBHVEtfU1RBVEVfRkxBR19TRUxFQ1RFRCwgJmdka1JHQkFDb2xvcik7CiAgICAgcmV0dXJu IGdka1JHQkFDb2xvcjsKIH0KIAo=