136249 2014-08-26 04:35:28 -0700 [GTK] Translations are not initialized in the UI process 2014-08-26 04:55:21 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto commit-queue gustavo mrobinson pnormand svillar oldest_to_newest 1031360 0 cgarcia 2014-08-26 04:35:28 -0700 This is breaking things like webkitContextMenuActionGetForContextMenuItem() for non English locales in the cases where we use the action title to guess the action, because the action title we get from the web process is translated while the one in the UI process is in English. We should initialize gettext also in the Ui process. 1031361 1 237146 cgarcia 2014-08-26 04:38:09 -0700 Created attachment 237146 Patch 1031362 2 commit-queue 2014-08-26 04:39:39 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1031363 3 237146 pnormand 2014-08-26 04:48:33 -0700 Comment on attachment 237146 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237146&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:254 > + // Initialize gettext here, right before creating the default web context. Not sure this comment has any relevant info. The explanation in the Changelog would be enough for me :) 1031364 4 cgarcia 2014-08-26 04:55:21 -0700 Committed r172957: <http://trac.webkit.org/changeset/172957> 237146 2014-08-26 04:38:09 -0700 2014-08-26 04:48:32 -0700 Patch wk2-translations.diff text/plain 2054 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3YmNlYjkzLi4yOTQ5YWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg QEAKIDIwMTQtMDgtMjYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIFRyYW5zbGF0aW9ucyBhcmUgbm90IGluaXRpYWxpemVkIGluIHRo ZSBVSSBwcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzYyNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGlzIGJyZWFraW5nIHRoaW5ncyBsaWtlIHdlYmtpdENvbnRleHRNZW51QWN0aW9u R2V0Rm9yQ29udGV4dE1lbnVJdGVtKCkKKyAgICAgICAgZm9yIG5vbiBFbmdsaXNoIGxvY2FsZXMg aW4gdGhlIGNhc2VzIHdoZXJlIHdlIHVzZSB0aGUgYWN0aW9uIHRpdGxlIHRvIGd1ZXNzIHRoZQor ICAgICAgICBhY3Rpb24sIGJlY2F1c2UgdGhlIGFjdGlvbiB0aXRsZSB3ZSBnZXQgZnJvbSB0aGUg d2ViIHByb2Nlc3MgaXMgdHJhbnNsYXRlZCB3aGlsZQorICAgICAgICB0aGUgb25lIGluIHRoZSBV SSBwcm9jZXNzIGlzIGluIEVuZ2xpc2guCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKGNyZWF0ZURlZmF1bHRXZWJDb250ZXh0KTog SW5pdGlhbGl6ZSBnZXR0ZXh0IHJpZ2h0IGJlZm9yZQorICAgICAgICBjcmVhdGluZyB0aGUgZGVm YXVsdCB3ZWIgY29udGV4dC4KKworMjAxNC0wOC0yNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gQWRkIHdlYmtpdF91cmlfcmVzcG9u c2VfZ2V0X2h0dHBfaGVhZGVycyB0byBXZWJLaXQyIEdUSysgQVBJCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYyNDgKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcAppbmRleCAx NGViMWZkLi5lYmUyZWJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcApAQCAtNDcsNiArNDcsNyBAQAogI2luY2x1ZGUg PFdlYkNvcmUvRmlsZVN5c3RlbS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvSWNvbkRhdGFiYXNlLmg+ CiAjaW5jbHVkZSA8V2ViQ29yZS9MYW5ndWFnZS5oPgorI2luY2x1ZGUgPGxpYmludGwuaD4KICNp bmNsdWRlIDxtZW1vcnk+CiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYv TmV2ZXJEZXN0cm95ZWQuaD4KQEAgLTI1MCw2ICsyNTEsMTAgQEAgc3RhdGljIENTdHJpbmcgaW5q ZWN0ZWRCdW5kbGVGaWxlbmFtZSgpCiAKIHN0YXRpYyBncG9pbnRlciBjcmVhdGVEZWZhdWx0V2Vi Q29udGV4dChncG9pbnRlcikKIHsKKyAgICAvLyBJbml0aWFsaXplIGdldHRleHQgaGVyZSwgcmln aHQgYmVmb3JlIGNyZWF0aW5nIHRoZSBkZWZhdWx0IHdlYiBjb250ZXh0LgorICAgIGJpbmR0ZXh0 ZG9tYWluKEdFVFRFWFRfUEFDS0FHRSwgUEFDS0FHRV9MT0NBTEVfRElSKTsKKyAgICBiaW5kX3Rl eHRkb21haW5fY29kZXNldChHRVRURVhUX1BBQ0tBR0UsICJVVEYtOCIpOworCiAgICAgc3RhdGlj IEdSZWZQdHI8V2ViS2l0V2ViQ29udGV4dD4gd2ViQ29udGV4dCA9IGFkb3B0R1JlZihXRUJLSVRf V0VCX0NPTlRFWFQoZ19vYmplY3RfbmV3KFdFQktJVF9UWVBFX1dFQl9DT05URVhULCBOVUxMKSkp OwogICAgIFdlYktpdFdlYkNvbnRleHRQcml2YXRlKiBwcml2ID0gd2ViQ29udGV4dC0+cHJpdjsK IAo=