136246 2014-08-26 01:16:35 -0700 [EFL] Remove dead code in WebPageEfl.cpp 2014-08-26 04:18:33 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1031335 0 ryuan.choi 2014-08-26 01:16:35 -0700 Reported by clang. /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp:83:20: warning: unused function 'scroll' [-Wunused-function] static inline void scroll(Page* page, ScrollDirection direction, ScrollGranularity granularity) ^ 1 warning generated. performDefaultBehaviorForKeyEvent uses WebPage::scroll instead of static function. 1031336 1 237139 ryuan.choi 2014-08-26 01:17:44 -0700 Created attachment 237139 Patch 1031357 2 237139 commit-queue 2014-08-26 04:18:28 -0700 Comment on attachment 237139 Patch Clearing flags on attachment: 237139 Committed r172955: <http://trac.webkit.org/changeset/172955> 1031358 3 commit-queue 2014-08-26 04:18:33 -0700 All reviewed patches have been landed. Closing bug. 237139 2014-08-26 01:17:44 -0700 2014-08-26 04:18:28 -0700 Patch bug-136246-20140826171735.patch text/plain 1544 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyOTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2ZiMTA2YmQ5YmNmZTg1 MmEwYmYxYjJhNDI4MTM5Nzk5NmE5MDkxMC4uY2QwN2FiNGZmMzcxYTYyZjExMDM1N2ZjZDE1Zjg3 MDA1ZmI1NjliOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA4LTI2ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBSZW1vdmUg ZGVhZCBjb2RlIGluIFdlYlBhZ2VFZmwuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYyNDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9lZmwvV2ViUGFnZUVmbC5j cHA6CisgICAgICAgIChXZWJLaXQ6OnNjcm9sbCk6IERlbGV0ZWQuCisKIDIwMTQtMDgtMjQgIEJy aWFuIEouIEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAgIFJlbW92ZSB1 bnVzZWQgbWV0aG9kIGRlY2xhcmF0aW9ucyByZXBsYWNlZCBieSBXZWJQYWdlOjpzZXRWaWV3U3Rh dGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9lZmwvV2Vi UGFnZUVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZWZsL1dlYlBh Z2VFZmwuY3BwCmluZGV4IDU2YjE1Njk2MjhlOGJlZDY2OGMwZDliMzU0YjA5YTNmNjczNjhlM2Qu LjFhYWI0ZDUyM2I1NTJhOTQ4MTYzZTNkYzhmNzExNTE5ZGQ5OGJiMDYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9lZmwvV2ViUGFnZUVmbC5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2VmbC9XZWJQYWdlRWZsLmNwcApAQCAt ODAsMTEgKzgwLDYgQEAgdm9pZCBXZWJQYWdlOjpwbGF0Zm9ybVByZWZlcmVuY2VzRGlkQ2hhbmdl KGNvbnN0IFdlYlByZWZlcmVuY2VzU3RvcmUmKQogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9CiAK LXN0YXRpYyBpbmxpbmUgdm9pZCBzY3JvbGwoUGFnZSogcGFnZSwgU2Nyb2xsRGlyZWN0aW9uIGRp cmVjdGlvbiwgU2Nyb2xsR3JhbnVsYXJpdHkgZ3JhbnVsYXJpdHkpCi17Ci0gICAgcGFnZS0+Zm9j dXNDb250cm9sbGVyKCkuZm9jdXNlZE9yTWFpbkZyYW1lKCkuZXZlbnRIYW5kbGVyKCkuc2Nyb2xs UmVjdXJzaXZlbHkoZGlyZWN0aW9uLCBncmFudWxhcml0eSk7Ci19Ci0KIGJvb2wgV2ViUGFnZTo6 cGVyZm9ybURlZmF1bHRCZWhhdmlvckZvcktleUV2ZW50KGNvbnN0IFdlYktleWJvYXJkRXZlbnQm IGtleWJvYXJkRXZlbnQpCiB7CiAgICAgaWYgKGtleWJvYXJkRXZlbnQudHlwZSgpICE9IFdlYkV2 ZW50OjpLZXlEb3duICYmIGtleWJvYXJkRXZlbnQudHlwZSgpICE9IFdlYkV2ZW50OjpSYXdLZXlE b3duKQo=