136245 2014-08-26 00:26:43 -0700 [EFL] Build break using clang 2014-08-26 03:54:37 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi lucas.de.marchi oldest_to_newest 1031327 0 ryuan.choi 2014-08-26 00:26:43 -0700 While building ewebkit via clang, there are some build issues. 1. Too many warnings in system libraries and WebKit code. 2. Build break of UnitTestUtils because of rtti in gtest header 3. undefined reference to `WebCore::Node::renderStyle() const in Source/WebCore/css/ViewportStyleResolver.cpp 1031329 1 237137 ryuan.choi 2014-08-26 00:29:35 -0700 Created attachment 237137 Patch 1031352 2 237137 gyuyoung.kim 2014-08-26 03:22:12 -0700 Comment on attachment 237137 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237137&action=review Please fix my comment. > Source/WebCore/css/ViewportStyleResolver.cpp:37 > +#include "NodeRenderStyle.h" I believe this include won't harmful on other ports. > Source/WebKit2/PlatformEfl.cmake:457 > + -DGTEST_HAS_RTTI=0 GTK port also disabled this macro. > Source/cmake/OptionsEfl.cmake:11 > +# Disable WERROR in clang build because of many warnings. Add FIXME: prefix. 1031356 3 ryuan.choi 2014-08-26 03:54:37 -0700 Committed r172954: <http://trac.webkit.org/changeset/172954> 237137 2014-08-26 00:29:35 -0700 2014-08-26 03:22:11 -0700 Patch bug-136245-20140826162927.patch text/plain 3596 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyOTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmQ1M2Q1OTM5N2IwM2Ew ODJiZjU5NWY3MWExMmJmNGI5ZWM5ZTQ0Yi4uNzU4MGZjMThjM2M3N2YwMzc2N2ZjZDE1YzFjOWQz ZDM2ZWVhOTVlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA4LTI2ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBCdWlsZCBi cmVhayB1c2luZyBjbGFuZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM2MjQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBjc3MvVmlld3BvcnRTdHlsZVJlc29sdmVyLmNwcDogSW5jbHVkZXMgTm9kZVJl bmRlclN0eWxlLmgKKwogMjAxNC0wOC0yNCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxp YS5jb20+CiAKICAgICAgICAgTW92ZSBXZWJDb3JlIHN0b3JhZ2UgY29kZSB0byBDKysxMSBsYW1i ZGFzLCBzdGQ6OmZ1bmN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2ZiMTA2YmQ5YmNmZTg1MmEwYmYxYjJh NDI4MTM5Nzk5NmE5MDkxMC4uNjZmZTIzZjBkNzJkOGU0Njk4MTNmYzcxMmM2ZDRhNTAwYzZkNmVk ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA4LTI2ICBSeXVhbiBDaG9pICA8 cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBCdWlsZCBicmVhayB1c2lu ZyBjbGFuZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM2MjQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBQbGF0Zm9ybUVmbC5jbWFrZTogZGVmaW5lcyBHVEVTVF9IQVNfUlRUST0wCisKIDIwMTQtMDgt MjQgIEJyaWFuIEouIEJ1cmcgIDxidXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAgIFJl bW92ZSB1bnVzZWQgbWV0aG9kIGRlY2xhcmF0aW9ucyByZXBsYWNlZCBieSBXZWJQYWdlOjpzZXRW aWV3U3RhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9WaWV3cG9ydFN0eWxlUmVz b2x2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1ZpZXdwb3J0U3R5bGVSZXNvbHZlci5jcHAK aW5kZXggY2JjMzk4YTI2OGUzMzE2MWNkZDQ3OTg3NTkyZDZiMjIxNzgxNjc3ZS4uOGQ0MTI5YTBj ZjlhZDk2YjliYTZlMjE3OTkwMDVlMzVkM2MzODJiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvY3NzL1ZpZXdwb3J0U3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L1ZpZXdwb3J0U3R5bGVSZXNvbHZlci5jcHAKQEAgLTM0LDYgKzM0LDcgQEAKIAogI2luY2x1ZGUg IkNTU1ZhbHVlS2V5d29yZHMuaCIKICNpbmNsdWRlICJEb2N1bWVudC5oIgorI2luY2x1ZGUgIk5v ZGVSZW5kZXJTdHlsZS5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJSZW5kZXJWaWV3 LmgiCiAjaW5jbHVkZSAiU3R5bGVQcm9wZXJ0aWVzLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtl CmluZGV4IGUwYjYzOTExYjhkMzRhZTUzMWUxNzFmZmZmMDBhZDVkM2NhZDhhYTcuLjA1MTI3OWI5 NmRiNzJjMWM4ZTAyMTM2M2NlYmJjNDg4MDZmZDIzN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNt YWtlCkBAIC00NTQsNiArNDU0LDcgQEAgYWRkX2RlZmluaXRpb25zKC1EVEVTVF9SRVNPVVJDRVNf RElSPVwiJHtURVNUX1JFU09VUkNFU19ESVJ9XCIKICAgICAtRFdFQlBST0NFU1NOQU1FPVwiV2Vi UHJvY2Vzc1wiCiAgICAgLURQTFVHSU5QUk9DRVNTTkFNRT1cIlBsdWdpblByb2Nlc3NcIgogICAg IC1ETkVUV09SS1BST0NFU1NOQU1FPVwiTmV0d29ya1Byb2Nlc3NcIgorICAgIC1ER1RFU1RfSEFT X1JUVEk9MAogKQogCiBhZGRfbGlicmFyeShld2syVW5pdFRlc3RVdGlscwpkaWZmIC0tZ2l0IGEv U291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5j bWFrZQppbmRleCA3N2Q5NTY4NzI4ZjBlYzAwZjM3Mzg2YzMxNWFmZGU0NmQ5NzVhOWRlLi5jOTc0 YjY0ZDgzYzFmYTAxOTJkZjIxOWRhOTk4YjFhM2ZkZWJlMzBjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv Y21ha2UvT3B0aW9uc0VmbC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFr ZQpAQCAtOCw3ICs4LDEwIEBAIGFkZF9kZWZpbml0aW9ucygtREJVSUxESU5HX0VGTF9fPTEpCiBz ZXQoRU5BQkxFX1dFQktJVCBPRkYpCiBzZXQoRU5BQkxFX1dFQktJVDIgT04pCiAKLXNldChBRERJ VElPTkFMX0NPTVBJTEVSX0ZMQUdTIEVOQUJMRV9XRVJST1IpCisjIERpc2FibGUgV0VSUk9SIGlu IGNsYW5nIGJ1aWxkIGJlY2F1c2Ugb2YgbWFueSB3YXJuaW5ncy4KK2lmIChOT1QgIiR7Q01BS0Vf Q1hYX0NPTVBJTEVSX0lEfSIgU1RSRVFVQUwgIkNsYW5nIikKKyAgICBzZXQoQURESVRJT05BTF9D T01QSUxFUl9GTEFHUyBFTkFCTEVfV0VSUk9SKQorZW5kaWYgKCkKIAogZmluZF9wYWNrYWdlKENh aXJvIDEuMTAuMiBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShGb250Y29uZmlnIDIuOC4wIFJFUVVJ UkVEKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGM4NWQ2MjZlZTdk NGQ5MDUyNTI2MGI5N2RlNzZjZDAyNGVkYjM3NjguLjdlYjU4MzViNDIwYzU2MDhjMTg4NDIyY2E0 OTVkY2M2MjcxYzNjZWUgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxNC0wOC0yNiAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3Vu Zy5jb20+CisKKyAgICAgICAgW0VGTF0gQnVpbGQgYnJlYWsgdXNpbmcgY2xhbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjI0NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09w dGlvbnNFZmwuY21ha2U6CisgICAgICAgIERpc2FibGUgRU5BQkxFX1dFUlJPUiB3aGVuIGNvbXBp bGVyIGlzIENsYW5nIGFzIHdvcmthcm91bmQgYmVjYXVzZSB0aGVyZSBhcmUgdG9vIG1hbnkgd2Fy bmluZ3MuCisgICAgICAgIFNvbWUgd2FybmluZ3MgYXJlIGZyb20gc3lzdGVtIGxpYnJhcmllcy4K KwogMjAxNC0wOC0yNCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAg ICAgICAgW0VGTF0gTW92ZSBFZmwgc3BlY2lmaWMgY29kZSBmcm9tIFNvdXJjZS9DTWFrZUxpc3Rz LnR4dAo=