136234 2014-08-25 15:00:05 -0700 Don't crash when the DataDetectors framework is unavailable. 2014-08-25 15:31:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson thorton oldest_to_newest 1031227 0 beidson 2014-08-25 15:00:05 -0700 Don't crash when the DataDetectors framework is unavailable. It's possible to run the same build of WebKit2 that expected DD.framework to be available in an environment that does not have it available. In that environment, it should just early-return by skipping a whole bunch of work that is irrelevant. In Radar - rdar://problem/18106066 1031228 1 237108 beidson 2014-08-25 15:05:06 -0700 Created attachment 237108 Patch v1 1031232 2 237108 thorton 2014-08-25 15:21:47 -0700 Comment on attachment 237108 Patch v1 Should you defend MenuUtilities.mm as well, or is it OK because we'll never get there with these early returns in place? 1031235 3 beidson 2014-08-25 15:25:21 -0700 (In reply to comment #2) > (From update of attachment 237108 [details]) > Should you defend MenuUtilities.mm as well, or is it OK because we'll never get there with these early returns in place? I couldn't find a way you'd end up in MenuUtilities with these in place. I'll double check. 1031237 4 beidson 2014-08-25 15:31:25 -0700 http://trac.webkit.org/changeset/172939 237108 2014-08-25 15:05:06 -0700 2014-08-25 15:21:46 -0700 Patch v1 patch text/plain 1722 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkOTcyZjE1Li45NWM5ZTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDgtMjUgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIERvbid0IGNyYXNoIHdoZW4gdGhlIERhdGFEZXRlY3RvcnMgZnJhbWV3b3JrIGlzIHVuYXZh aWxhYmxlLgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTgxMDYwNjY+IGFuZCBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MjM0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1Nl cnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW06CisgICAgICAgIChXZWJLaXQ6OlNlcnZpY2VzT3Zl cmxheUNvbnRyb2xsZXI6OmJ1aWxkUGhvbmVOdW1iZXJIaWdobGlnaHRzKTogQmFpbCBpZiBERC5m cmFtZXdvcmsgZGlkbuKAmXQgc29mdCBsaW5rLgorICAgICAgICAoV2ViS2l0OjpTZXJ2aWNlc092 ZXJsYXlDb250cm9sbGVyOjpidWlsZFNlbGVjdGlvbkhpZ2hsaWdodCk6IERpdHRvLgorCiAyMDE0 LTA4LTI1ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1v dmUgbG9hZCBzY2hlZHVsaW5nIGNvZGUgZnJvbSBuZXR3b3JrIHByb2Nlc3MKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29u dHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2Vydmlj ZXNPdmVybGF5Q29udHJvbGxlci5tbQppbmRleCA2MDYyODA3Li4xMmUwMDFlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNv bnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9T ZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyLm1tCkBAIC00NzUsNiArNDc1LDkgQEAgdm9pZCBTZXJ2 aWNlc092ZXJsYXlDb250cm9sbGVyOjpyZW1vdmVBbGxQb3RlbnRpYWxIaWdobGlnaHRzT2ZUeXBl KEhpZ2hsaWdodDo6VHkKIAogdm9pZCBTZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyOjpidWlsZFBo b25lTnVtYmVySGlnaGxpZ2h0cygpCiB7CisgICAgaWYgKCFEYXRhRGV0ZWN0b3JzTGlicmFyeSgp KQorICAgICAgICByZXR1cm47CisKICAgICBIYXNoU2V0PFJlZlB0cjxIaWdobGlnaHQ+PiBuZXdQ b3RlbnRpYWxIaWdobGlnaHRzOwogCiAgICAgRnJhbWUqIG1haW5GcmFtZSA9IG1fd2ViUGFnZS5t YWluRnJhbWUoKTsKQEAgLTUxMCw2ICs1MTMsOSBAQCB2b2lkIFNlcnZpY2VzT3ZlcmxheUNvbnRy b2xsZXI6OmJ1aWxkUGhvbmVOdW1iZXJIaWdobGlnaHRzKCkKIAogdm9pZCBTZXJ2aWNlc092ZXJs YXlDb250cm9sbGVyOjpidWlsZFNlbGVjdGlvbkhpZ2hsaWdodCgpCiB7CisgICAgaWYgKCFEYXRh RGV0ZWN0b3JzTGlicmFyeSgpKQorICAgICAgICByZXR1cm47CisKICAgICBIYXNoU2V0PFJlZlB0 cjxIaWdobGlnaHQ+PiBuZXdQb3RlbnRpYWxIaWdobGlnaHRzOwogCiAgICAgVmVjdG9yPENHUmVj dD4gY2dSZWN0czsK