136233 2014-08-25 14:16:42 -0700 Minor style tweak on StyleResolveTree 2014-08-26 17:02:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin oldest_to_newest 1031220 0 benjamin 2014-08-25 14:16:42 -0700 Minor style tweak on StyleResolveTree 1031221 1 237105 benjamin 2014-08-25 14:18:12 -0700 Created attachment 237105 Patch 1031225 2 237105 sam 2014-08-25 14:41:52 -0700 Comment on attachment 237105 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237105&action=review > Source/WebCore/style/StyleResolveTree.cpp:934 > + if (RenderObject *childRenderer = child->renderer()) The * is on the wrong side. 1031523 3 benjamin 2014-08-26 17:02:09 -0700 Committed r172985: <http://trac.webkit.org/changeset/172985> 237105 2014-08-25 14:18:12 -0700 2014-08-25 14:41:51 -0700 Patch bug-136233-20140825141721.patch text/plain 1636 benjamin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjkzNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTI1ICBCZW5qYW1p biBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIE1pbm9yIHN0eWxlIHR3 ZWFrIG9uIFN0eWxlUmVzb2x2ZVRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNjIzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogc3R5bGUvU3R5bGVSZXNvbHZlVHJlZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTdHlsZTo6cmVzb2x2ZVRyZWUpOgorICAgICAgICBDbGFuZyBsaWtlbHkgb3B0aW1p emVkIGl0IGF3YXksIGJ1dCBJIGZpbmQgdGhhdCBleHBsaWNpdCBzdHlsZSBjbGVhbmVyLgorCiAy MDE0LTA4LTI1ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBSZWR1Y2Ugc3R5bGUgbWFya2luZyB3aGVuIHVzaW5nIHRoZSBwc2V1ZG8gY2xhc3MgOnBs YWNlaG9sZGVyLXNob3duCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVJlc29sdmVU cmVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZVJlc29sdmVU cmVlLmNwcAkocmV2aXNpb24gMTcyOTM1KQorKysgU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVS ZXNvbHZlVHJlZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkzMSw4ICs5MzEsOCBAQCB2b2lkIHJl c29sdmVUcmVlKEVsZW1lbnQmIGN1cnJlbnQsIFJlbmRlCiAgICAgICAgIGJvb2wgZm9yY2VDaGVj a09mTmV4dEVsZW1lbnRTaWJsaW5nID0gZmFsc2U7CiAgICAgICAgIGJvb2wgZm9yY2VDaGVja09m QW55RWxlbWVudFNpYmxpbmcgPSBmYWxzZTsKICAgICAgICAgZm9yIChOb2RlKiBjaGlsZCA9IGN1 cnJlbnQuZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKSkg ewotICAgICAgICAgICAgaWYgKGNoaWxkLT5yZW5kZXJlcigpKQotICAgICAgICAgICAgICAgIGNo aWxkUmVuZGVyVHJlZVBvc2l0aW9uLmludmFsaWRhdGVOZXh0U2libGluZygqY2hpbGQtPnJlbmRl cmVyKCkpOworICAgICAgICAgICAgaWYgKFJlbmRlck9iamVjdCAqY2hpbGRSZW5kZXJlciA9IGNo aWxkLT5yZW5kZXJlcigpKQorICAgICAgICAgICAgICAgIGNoaWxkUmVuZGVyVHJlZVBvc2l0aW9u LmludmFsaWRhdGVOZXh0U2libGluZygqY2hpbGRSZW5kZXJlcik7CiAgICAgICAgICAgICBpZiAo Y2hpbGQtPmlzVGV4dE5vZGUoKSAmJiBjaGlsZC0+bmVlZHNTdHlsZVJlY2FsYygpKSB7CiAgICAg ICAgICAgICAgICAgcmVzb2x2ZVRleHROb2RlKCp0b1RleHQoY2hpbGQpLCBjaGlsZFJlbmRlclRy ZWVQb3NpdGlvbik7CiAgICAgICAgICAgICAgICAgY29udGludWU7Cg==