136231 2014-08-25 12:55:09 -0700 [GTK] Disable backspace key navigation 2014-12-11 11:24:12 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Enhancement --- 1 mcatanzaro webkit-unassigned bugzilla cgarcia commit-queue mcatanzaro oldest_to_newest 1031209 0 mcatanzaro 2014-08-25 12:55:09 -0700 As discussed at [1] we don't want backspace key navigation anymore. Alternatively, we could keep it and hide it behind a preference. There's already an internal preference for backspace key navigation, but it doesn't seem to have any effect. [1] https://bugzilla.gnome.org/show_bug.cgi?id=698561 1031211 1 237102 mcatanzaro 2014-08-25 12:57:58 -0700 Created attachment 237102 Patch 1033672 2 mcatanzaro 2014-09-06 09:14:51 -0700 Carlos, can you look at this? 1054447 3 237102 cgarcia 2014-12-11 02:34:38 -0800 Comment on attachment 237102 Patch Nobody likes this, thanks! 1054483 4 mcatanzaro 2014-12-11 06:41:18 -0800 Looks like commit-queue is down; will this need to be committed manually or will it fix itself eventually? 1054558 5 237102 commit-queue 2014-12-11 11:24:08 -0800 Comment on attachment 237102 Patch Clearing flags on attachment: 237102 Committed r177162: <http://trac.webkit.org/changeset/177162> 1054559 6 commit-queue 2014-12-11 11:24:12 -0800 All reviewed patches have been landed. Closing bug. 237102 2014-08-25 12:57:58 -0700 2014-12-11 11:24:08 -0800 Patch bug-136231-20140825145750.patch text/plain 1613 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyODU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDQ1ZjFlZjdiNGVlMTBi ZjY5NWE4Njc0YTRmMmFhZTg5ODI4MmUyYi4uNDY5MWI2YmY2MGE1ODk4MGI0ODRhNTRkNDA1MmFl ZjI3YzI3ZDAwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTI1ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBE aXNhYmxlIGJhY2tzcGFjZSBrZXkgbmF2aWdhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MjMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlBhZ2VH dGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpwZXJmb3JtRGVmYXVsdEJlaGF2aW9y Rm9yS2V5RXZlbnQpOiByZW1vdmUgaGFuZGxpbmcKKyAgICAgICAgZm9yIGJhY2tzcGFjZSBhbmQg PHNoaWZ0PmJhY2tzcGFjZSBrZXkgY29tYmluYXRpb25zLgorCiAyMDE0LTA4LTIxICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgUG9zc2libGUgUmV0YWlu UHRyIG1pc3VzZSBpbiBXS1NjcmlwdE1lc3NhZ2UubW0gLSBjb3VsZCBsZWFrCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlBhZ2VHdGsuY3BwIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9XZWJQYWdlR3RrLmNwcAppbmRl eCA0NTcyZDExMTc2YWU4MWMzOWQ1ODE1OThhODAwZDU5NGI4NTc4OTU4Li5jNzJjYWJmOTJhNTcx M2ZjNWNlOGI5YTAzMDc4MzliZmZmYmI3NGI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X ZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlBhZ2VHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViUGFnZUd0ay5jcHAKQEAgLTk2LDEyICs5Niw2IEBA IGJvb2wgV2ViUGFnZTo6cGVyZm9ybURlZmF1bHRCZWhhdmlvckZvcktleUV2ZW50KGNvbnN0IFdl YktleWJvYXJkRXZlbnQmIGtleWJvYXJkCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIHN3 aXRjaCAoa2V5Ym9hcmRFdmVudC53aW5kb3dzVmlydHVhbEtleUNvZGUoKSkgewotICAgIGNhc2Ug VktfQkFDSzoKLSAgICAgICAgaWYgKGtleWJvYXJkRXZlbnQuc2hpZnRLZXkoKSkKLSAgICAgICAg ICAgIG1fcGFnZS0+YmFja0ZvcndhcmQoKS5nb0ZvcndhcmQoKTsKLSAgICAgICAgZWxzZQotICAg ICAgICAgICAgbV9wYWdlLT5iYWNrRm9yd2FyZCgpLmdvQmFjaygpOwotICAgICAgICBicmVhazsK ICAgICBjYXNlIFZLX1NQQUNFOgogICAgICAgICBzY3JvbGwobV9wYWdlLmdldCgpLCBrZXlib2Fy ZEV2ZW50LnNoaWZ0S2V5KCkgPyBTY3JvbGxVcCA6IFNjcm9sbERvd24sIFNjcm9sbEJ5UGFnZSk7 CiAgICAgICAgIGJyZWFrOwo=