136229 2014-08-25 11:19:37 -0700 [Win] Pass OFFICIAL_BUILD flag to WebInspectorUI build process 2014-08-25 11:36:42 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham webkit-bug-importer oldest_to_newest 1031179 0 bfulgham 2014-08-25 11:19:37 -0700 The "OFFICIAL_BUILD" environment variable is not getting passed down to the Perl scripts that assemble the WebInspectorUI sources into a final minimized document for release builds. This patch corrects this problem. 1031180 1 237097 bfulgham 2014-08-25 11:24:35 -0700 Created attachment 237097 Patch 1031182 2 bfulgham 2014-08-25 11:29:40 -0700 <rdar://problem/18121645> 1031188 3 237097 bfulgham 2014-08-25 11:35:53 -0700 Comment on attachment 237097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237097&action=review > Source/WebInspectorUI/WebInspectorUI.vcxproj/build-webinspectorui.pl:83 > + This is just some drive-by debugging code. I'd like to leave it in so we can see if anything happens in the future. 1031189 4 bfulgham 2014-08-25 11:36:42 -0700 Committed r172929: <http://trac.webkit.org/changeset/172929> 237097 2014-08-25 11:24:35 -0700 2014-08-25 11:35:53 -0700 Patch bug-136229-20140825112535.patch text/plain 5666 bfulgham SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyOTI3KQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA4LTI1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAg ICAgIFtXaW5dIFBhc3MgT0ZGSUNJQUxfQlVJTEQgZmxhZyB0byBXZWJJbnNwZWN0b3JVSSBidWls ZCBwcm9jZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzYyMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFdlYkluc3BlY3RvclVJLnZjeHByb2ovV2ViSW5zcGVjdG9yVUkubWFrZTogUGFzcyBPRkZJ Q0lBTF9CVUlMRAorICAgICAgICBmbGFnIHRvIGJ1aWxkLXdlYmluc3BlY3RvcnVpLnBsLgorICAg ICAgICAqIFdlYkluc3BlY3RvclVJLnZjeHByb2ovYnVpbGQtd2ViaW5zcGVjdG9ydWkucGw6IEFj Y2VwdCBhbmQgdXNlCisgICAgICAgIHRoZSBPRkZJQ0lBTF9CVUlMRCBmbGFnLgorCiAyMDE0LTA4 LTI0ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBU aGUgaW5zcGVjdG9yIHNob3VsZCBub3QgdXNlIHRoZSAiYWZ0ZXIiIHBzZXVkbyBlbGVtZW50IHdp dGggdGhlIGNvbXBhdGliaWxpdHkgc3ludGF4CkluZGV4OiBTb3VyY2UvV2ViSW5zcGVjdG9yVUkv V2ViSW5zcGVjdG9yVUkudmN4cHJvai9XZWJJbnNwZWN0b3JVSS5tYWtlCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9XZWJJbnNwZWN0b3JVSS52Y3hwcm9qL1dlYkluc3BlY3Rv clVJLm1ha2UJKHJldmlzaW9uIDE3MjgwNCkKKysrIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9XZWJJ bnNwZWN0b3JVSS52Y3hwcm9qL1dlYkluc3BlY3RvclVJLm1ha2UJKHdvcmtpbmcgY29weSkKQEAg LTEsNiArMSw2IEBACiBtYWtlOg0KIAktbWtkaXIgIiVDb25maWd1cmF0aW9uQnVpbGREaXIlXGJp biVQbGF0Zm9ybUFyY2hpdGVjdHVyZSVcV2ViS2l0LnJlc291cmNlc1xXZWJJbnNwZWN0b3JVSSIN Ci0JcGVybCBidWlsZC13ZWJpbnNwZWN0b3J1aS5wbCAiJUNvbmZpZ3VyYXRpb25CdWlsZERpciUi ICIlV2ViS2l0X0xpYnJhcmllcyUiIHdpbmRvd3MgIiVQbGF0Zm9ybUFyY2hpdGVjdHVyZSUiDQor CXBlcmwgYnVpbGQtd2ViaW5zcGVjdG9ydWkucGwgIiVDb25maWd1cmF0aW9uQnVpbGREaXIlIiAi JVdlYktpdF9MaWJyYXJpZXMlIiB3aW5kb3dzICIlUGxhdGZvcm1BcmNoaXRlY3R1cmUlIiAiJU9G RklDSUFMX0JVSUxEJSINCiAJaWYgZXJyb3JsZXZlbCAxIGV4aXQgMQ0KIA0KIAl4Y29weSAveSAv ZSAiLi5cTG9jYWxpemF0aW9uc1xlbi5scHJvalwqIiAiJUNvbmZpZ3VyYXRpb25CdWlsZERpciVc YmluJVBsYXRmb3JtQXJjaGl0ZWN0dXJlJVxXZWJLaXQucmVzb3VyY2VzXFdlYkluc3BlY3RvclVJ Ig0KSW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9XZWJJbnNwZWN0b3JVSS52Y3hwcm9qL2J1 aWxkLXdlYmluc3BlY3RvcnVpLnBsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JV SS9XZWJJbnNwZWN0b3JVSS52Y3hwcm9qL2J1aWxkLXdlYmluc3BlY3RvcnVpLnBsCShyZXZpc2lv biAxNzI4MDQpCisrKyBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvV2ViSW5zcGVjdG9yVUkudmN4cHJv ai9idWlsZC13ZWJpbnNwZWN0b3J1aS5wbAkod29ya2luZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBA QCAkRU5WeydYRFNUUk9PVCd9ID0gJFhEU1RST09UOwogbXkgJFRBUkdFVF9CVUlMRF9ESVIgPSBG aWxlOjpTcGVjLT5jYXRkaXIoJFhEU1RST09ULCAiYmluJEFSR1ZbM10iLCAnV2ViS2l0LnJlc291 cmNlcycpOwogJEVOVnsnVEFSR0VUX0JVSUxEX0RJUid9ID0gJFRBUkdFVF9CVUlMRF9ESVI7CiBt eSAoJEpBVkFTQ1JJUFRDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIsICRXRUJDT1JFX1BSSVZBVEVf SEVBREVSU19ESVIpOwotaWYgKCRFTlZ7J09GRklDSUFMX0JVSUxEJ30gZXEgJzEnKSB7CitpZiAo JEFSR1ZbNF0gZXEgJzEnKSB7CiAgICAgJEFSR1ZbMV0gPX4gcy9eXCIvLzsKICAgICAkQVJHVlsx XSA9fiBzL1wiJC8vOwogICAgIG15ICRJbnRlcm5hbCA9IEN3ZDo6cmVhbHBhdGgoJEFSR1ZbMV0p OzsKQEAgLTU5LDYgKzU5LDcgQEAgaWYgKCRFTlZ7J09GRklDSUFMX0JVSUxEJ30gZXEgJzEnKSB7 CiAKICRFTlZ7J0pBVkFTQ1JJUFRDT1JFX1BSSVZBVEVfSEVBREVSU19ESVInfSA9ICRKQVZBU0NS SVBUQ09SRV9QUklWQVRFX0hFQURFUlNfRElSOwogJEVOVnsnV0VCQ09SRV9QUklWQVRFX0hFQURF UlNfRElSJ30gPSAkV0VCQ09SRV9QUklWQVRFX0hFQURFUlNfRElSOworCiBteSAkREVSSVZFRF9T T1VSQ0VTX0RJUiA9IEZpbGU6OlNwZWMtPmNhdGRpcigkWERTVFJPT1QsICJvYmokQVJHVlszXSIs ICdXZWJJbnNwZWN0b3JVSScsICdEZXJpdmVkU291cmNlcycpOwogJEVOVnsnREVSSVZFRF9TT1VS Q0VTX0RJUid9ID0gJERFUklWRURfU09VUkNFU19ESVI7CiAKQEAgLTY4LDUgKzY5LDE3IEBAIGlm ICgoJFRBUkdFVF9CVUlMRF9ESVIgPX4gL1JlbGVhc2UvKSB8fAogICAgICRFTlZ7J0NPTUJJTkVf SU5TUEVDVE9SX1JFU09VUkNFUyd9ID0gJ1lFUyc7CiB9IAogCitteSAkdGFyZ2V0UmVzb3VyY2VQ YXRoID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKCRFTlZ7J1RBUkdFVF9CVUlMRF9ESVInfSwgJEVOVnsn VU5MT0NBTElaRURfUkVTT1VSQ0VTX0ZPTERFUl9QQVRIJ30pOworbXkgJHByb3RvY29sRGlyID0g RmlsZTo6U3BlYy0+Y2F0ZGlyKCR0YXJnZXRSZXNvdXJjZVBhdGgsICdQcm90b2NvbCcpOworCisj IENvcHkgb3ZlciBkeW5hbWljYWxseSBsb2FkZWQgZmlsZXMgZnJvbSBvdGhlciBmcmFtZXdvcmtz LCBldmVuIGlmIHdlIGFyZW4ndCBjb21iaW5pbmcgcmVzb3VyY2VzLgorbXkgJGpzRnJvbSA9IEZp bGU6OlNwZWMtPmNhdGZpbGUoJEVOVnsnSkFWQVNDUklQVENPUkVfUFJJVkFURV9IRUFERVJTX0RJ Uid9LCAnSW5zcGVjdG9ySlNCYWNrZW5kQ29tbWFuZHMuanMnKTsKK215ICRqc1RvID0gRmlsZTo6 U3BlYy0+Y2F0ZmlsZSgkcHJvdG9jb2xEaXIsICdJbnNwZWN0b3JKU0JhY2tlbmRDb21tYW5kcy5q cycpOworcHJpbnQgIkNvcHlpbmcgSmF2YVNjcmlwdCBiaW5kaW5ncyBmcm9tICRqc0Zyb20gdG8g JGpzVG9cbiI7CisKK215ICR3Y0Zyb20gPSBGaWxlOjpTcGVjLT5jYXRmaWxlKCRFTlZ7J1dFQkNP UkVfUFJJVkFURV9IRUFERVJTX0RJUid9LCAnSW5zcGVjdG9yV2ViQmFja2VuZENvbW1hbmRzLmpz Jyk7CitteSAkd2NUbyA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJHByb3RvY29sRGlyLCAnSW5zcGVj dG9yV2ViQmFja2VuZENvbW1hbmRzLmpzJyk7CitwcmludCAiQ29weWluZyBXZWJDb3JlIGJpbmRp bmdzIGZyb20gJHdjRnJvbSB0byAkd2NUb1xuIjsKKwogbXkgJGNvcHlSZXNvdXJjZXNDb21tYW5k ID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkWFNSQ1JPT1QsICdTY3JpcHRzJywgJ2NvcHktdXNlci1p bnRlcmZhY2UtcmVzb3VyY2VzLnBsJyk7CiBkbyAkY29weVJlc291cmNlc0NvbW1hbmQ7CkluZGV4 OiBXZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdExpYnJhcmll cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjkyNykKKysrIFdlYktpdExpYnJhcmllcy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wOC0yNSAgQnJlbnQgRnVs Z2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBQYXNzIE9GRklDSUFM X0JVSUxEIGZsYWcgdG8gV2ViSW5zcGVjdG9yVUkgYnVpbGQgcHJvY2VzcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2MjI5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9j b21tb24ucHJvcHM6IFBhc3MgT0ZGSUNJQUxfQlVJTEQgYXJndW1lbnQKKyAgICAgICAgZnJvbSBW UyB0byBjaGlsZCBNYWtlIHByb2Nlc3Nlcy4KKwogMjAxNC0wOC0xNyAgQnJlbnQgRnVsZ2hhbSAg PGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBVbnJldmlld2VkIGJ1aWxkIGZp eC4KSW5kZXg6IFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9jb21tb24ucHJvcHMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL2NvbW1vbi5w cm9wcwkocmV2aXNpb24gMTcyODA0KQorKysgV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3By b3BzL2NvbW1vbi5wcm9wcwkod29ya2luZyBjb3B5KQpAQCAtMTUsMTIgKzE1LDE0IEBAIGlmIGVy cm9ybGV2ZWwgMSBzZXQgUEFUSD0lU3lzdGVtRHJpdmUlXGMKIHNldCBDT05GSUdVUkFUSU9OQlVJ TERESVI9JChDb25maWd1cmF0aW9uQnVpbGREaXIpCiBzZXQgUExBVEZPUk1BUkNISVRFQ1RVUkU9 JChQbGF0Zm9ybUFyY2hpdGVjdHVyZSkKIHNldCBXRUJLSVRfTElCUkFSSUVTPSQoV0VCS0lUX0xJ QlJBUklFUykKK3NldCBPRkZJQ0lBTF9CVUlMRD0kKE9GRklDSUFMX0JVSUxEKQogbm1ha2UgL25v bG9nbyAtZiAkKFByb2plY3ROYW1lKS5tYWtlPC9OTWFrZUJ1aWxkQ29tbWFuZExpbmU+CiAgICAg PE5NYWtlUmVCdWlsZENvbW1hbmRMaW5lPiVTeXN0ZW1Ecml2ZSVcY3lnd2luXGJpblx3aGljaC5l eGUgYmFzaAogaWYgZXJyb3JsZXZlbCAxIHNldCBQQVRIPSVTeXN0ZW1Ecml2ZSVcY3lnd2luXGJp bjslUEFUSCUKIHNldCBDT05GSUdVUkFUSU9OQlVJTERESVI9JChDb25maWd1cmF0aW9uQnVpbGRE aXIpCiBzZXQgUExBVEZPUk1BUkNISVRFQ1RVUkU9JChQbGF0Zm9ybUFyY2hpdGVjdHVyZSkKIHNl dCBXRUJLSVRfTElCUkFSSUVTPSQoV0VCS0lUX0xJQlJBUklFUykKK3NldCBPRkZJQ0lBTF9CVUlM RD0kKE9GRklDSUFMX0JVSUxEKQogbm1ha2UgL25vbG9nbyAtZiAkKFByb2plY3ROYW1lKS5tYWtl IGNsZWFuCiBubWFrZSAvbm9sb2dvIC1mICQoUHJvamVjdE5hbWUpLm1ha2U8L05NYWtlUmVCdWls ZENvbW1hbmRMaW5lPgogICAgIDxOTWFrZUNsZWFuQ29tbWFuZExpbmU+JVN5c3RlbURyaXZlJVxj eWd3aW5cYmluXHdoaWNoLmV4ZSBiYXNoCkBAIC0yNDEsNCArMjQzLDQgQEAgY21kIC9jCiAgICAg ICA8RW52aXJvbm1lbnRWYXJpYWJsZT50cnVlPC9FbnZpcm9ubWVudFZhcmlhYmxlPgogICAgIDwv QnVpbGRNYWNybz4KICAgPC9JdGVtR3JvdXA+Ci08L1Byb2plY3Q+ClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQorPC9Qcm9qZWN0Pgo=