136224 2014-08-25 06:09:32 -0700 [EFL] Share fast/speechsynthesis/ with other ports 2014-08-27 01:04:34 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 k.czech k.czech bunhere cfleizach commit-queue gyuyoung.kim lucas.de.marchi rakuco sergio oldest_to_newest 1031132 0 k.czech 2014-08-25 06:09:32 -0700 webkit.org/b/136127 introduces platform support for WebSpeech in EFL. I propose to share fast/speechsynthesis tests so that other ports (EFL) could use them. Tests seem to be generic so they do not really need any modifications. I will skip them in other ports, they do not support them yet. 1031376 1 237151 k.czech 2014-08-26 07:46:46 -0700 Created attachment 237151 patch 1031397 2 237151 cfleizach 2014-08-26 10:08:13 -0700 Comment on attachment 237151 patch View in context: https://bugs.webkit.org/attachment.cgi?id=237151&action=review > Source/cmake/OptionsEfl.cmake:109 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPEECH_SYNTHESIS ON) it seems like we might want to wait until it's implemented before turning it on or did the implementation already go in? 1031478 3 k.czech 2014-08-26 14:13:44 -0700 (In reply to comment #2) > (From update of attachment 237151 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237151&action=review > > > Source/cmake/OptionsEfl.cmake:109 > > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPEECH_SYNTHESIS ON) > > it seems like we might want to wait until it's implemented before turning it on > or did the implementation already go in? Yes, the implementation is already in (r172956) 1031616 4 237151 commit-queue 2014-08-27 01:04:28 -0700 Comment on attachment 237151 patch Clearing flags on attachment: 237151 Committed r173000: <http://trac.webkit.org/changeset/173000> 1031617 5 commit-queue 2014-08-27 01:04:34 -0700 All reviewed patches have been landed. Closing bug. 237151 2014-08-26 07:46:46 -0700 2014-08-27 01:04:28 -0700 patch share-speech-synthesis-tests.patch text/plain 0 k.czech