136212 2014-08-25 02:48:38 -0700 [TexMap] Use std::sort instead of qsort in TextureMapperLayer::sortByZOrder() 2015-01-07 05:19:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan bfulgham cmarcelo commit-queue darin kondapallykalyan luiz mrobinson noam oldest_to_newest 1031078 0 zan 2014-08-25 02:48:38 -0700 [TexMap] Use std::sort instead of qsort in TextureMapperLayer::sortByZOrder() 1031079 1 237069 zan 2014-08-25 02:54:23 -0700 Created attachment 237069 Patch 1031080 2 commit-queue 2014-08-25 02:55:51 -0700 Attachment 237069 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:156: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1031083 3 237069 svillar 2014-08-25 03:12:04 -0700 Comment on attachment 237069 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237069&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:157 > + return a->m_centerZ < b->m_centerZ * 1000; why "* 1000" ? 1045348 4 bfulgham 2014-10-31 12:37:25 -0700 It's not clear from this bug why the change is being proposed. Do you find that std::sort is quicker than qsort, or has better memory characteristics? Could you include that in the ChangeLog to give context? 1045349 5 237069 bfulgham 2014-10-31 12:38:12 -0700 Comment on attachment 237069 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237069&action=review >> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:157 >> + return a->m_centerZ < b->m_centerZ * 1000; > > why "* 1000" ? That's the same as was used in the original compareGraphicsLayerZValue method. 1045592 6 zan 2014-11-02 02:57:55 -0800 (In reply to comment #4) > It's not clear from this bug why the change is being proposed. Do you find > that std::sort is quicker than qsort, or has better memory characteristics? > > Could you include that in the ChangeLog to give context? std::sort() can be faster due to ideally inlining the comparison function. There are a couple of issues with rendering when std::sort() is used instead of qsort. I'll look into that first and then update the patch. 1045593 7 237069 zan 2014-11-02 03:02:38 -0800 Comment on attachment 237069 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237069&action=review >>> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:157 >>> + return a->m_centerZ < b->m_centerZ * 1000; >> >> why "* 1000" ? > > That's the same as was used in the original compareGraphicsLayerZValue method. I kept the same comparison that was used for qsort. But I don't know off the top of my head why 1000 is used here. 1057995 8 237069 darin 2014-12-27 13:36:47 -0800 Comment on attachment 237069 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237069&action=review >>>> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:157 >>>> + return a->m_centerZ < b->m_centerZ * 1000; >>> >>> why "* 1000" ? >> >> That's the same as was used in the original compareGraphicsLayerZValue method. > > I kept the same comparison that was used for qsort. But I don't know off the top of my head why 1000 is used here. That * 1000 is absolutely *not* the same as what was in the original function! The original subtracts two floats and then multiplies the difference times 1000 to convert them to an integer that the sort algorithm can use. Look carefully at where the parentheses are. This new code multiplies only b’s value by 1000. That’s not right. 1058686 9 237069 zan 2015-01-05 03:26:07 -0800 Comment on attachment 237069 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237069&action=review >>>>> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:157 >>>>> + return a->m_centerZ < b->m_centerZ * 1000; >>>> >>>> why "* 1000" ? >>> >>> That's the same as was used in the original compareGraphicsLayerZValue method. >> >> I kept the same comparison that was used for qsort. But I don't know off the top of my head why 1000 is used here. > > That * 1000 is absolutely *not* the same as what was in the original function! > > The original subtracts two floats and then multiplies the difference times 1000 to convert them to an integer that the sort algorithm can use. Look carefully at where the parentheses are. > > This new code multiplies only b’s value by 1000. That’s not right. Well, that turned out embarrassing. Thanks for spotting it. 1059063 10 244075 zan 2015-01-06 11:05:59 -0800 Created attachment 244075 Patch 1059066 11 commit-queue 2015-01-06 11:08:56 -0800 Attachment 244075 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:156: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1059377 12 244075 zan 2015-01-07 05:19:19 -0800 Comment on attachment 244075 Patch Clearing flags on attachment: 244075 Committed r178035: <http://trac.webkit.org/changeset/178035> 1059378 13 zan 2015-01-07 05:19:28 -0800 All reviewed patches have been landed. Closing bug. 237069 2014-08-25 02:54:23 -0700 2015-01-06 11:05:51 -0800 Patch bug-136212-20140825025414.patch text/plain 3200 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjkwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTA4LTI1ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbVGV4TWFwXSBVc2Ugc3Rk Ojpzb3J0IGluc3RlYWQgb2YgcXNvcnQgaW4gVGV4dHVyZU1hcHBlckxheWVyOjpzb3J0QnlaT3Jk ZXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM2 MjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNl IHN0ZDo6c29ydCgpIGluc3RlYWQgb2YgcXNvcnQoKSB0byBzb3J0IHRoZSBUZXh0dXJlTWFwcGVy TGF5ZXIgb2JqZWN0cworICAgICAgICBieSB0aGVpciB6LW9yZGVyLiBBIGxhbWJkYSBleHByZXNz aW9uIGNhbiBiZSB1c2VkIHRvIGNvbXBhcmUgdGhlIG1fY2VudGVyWiAKKyAgICAgICAgbWVtYmVy IHZhcmlhYmxlcyBvZiBhbnkgdHdvIFRleHR1cmVNYXBwZXJMYXllcnMuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6c29ydEJ5Wk9yZGVyKToKKyAgICAgICAgKFdl YkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6Y29tcGFyZUdyYXBoaWNzTGF5ZXJzWlZhbHVlKTog RGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckxheWVyLmg6CisKIDIwMTQtMDgtMjUgIFNoaXZha3VtYXIgSk0gIDxzaGl2YS5qbUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBXZWIgQ29yZTogRml4IHVudXNlZCBwYXJhbWV0ZXIgYnVpbGQgd2Fy bmluZy4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0 dXJlTWFwcGVyTGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCShyZXZpc2lvbiAxNzI5MDAp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBl ckxheWVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUwLDE2ICsxNTAsMTIgQEAgdm9pZCBUZXh0 dXJlTWFwcGVyTGF5ZXI6OnBhaW50U2VsZihjb25zdAogICAgICAgICBtX2NvbnRlbnRzTGF5ZXIt PmRyYXdCb3JkZXIob3B0aW9ucy50ZXh0dXJlTWFwcGVyLCBtX3N0YXRlLmRlYnVnQm9yZGVyQ29s b3IsIG1fc3RhdGUuZGVidWdCb3JkZXJXaWR0aCwgbV9zdGF0ZS5jb250ZW50c1JlY3QsIHRyYW5z Zm9ybSk7CiB9CiAKLWludCBUZXh0dXJlTWFwcGVyTGF5ZXI6OmNvbXBhcmVHcmFwaGljc0xheWVy c1pWYWx1ZShjb25zdCB2b2lkKiBhLCBjb25zdCB2b2lkKiBiKQordm9pZCBUZXh0dXJlTWFwcGVy TGF5ZXI6OnNvcnRCeVpPcmRlcihWZWN0b3I8VGV4dHVyZU1hcHBlckxheWVyKj4mIGFycmF5KQog ewotICAgIFRleHR1cmVNYXBwZXJMYXllciogY29uc3QqIGxheWVyQSA9IHN0YXRpY19jYXN0PFRl eHR1cmVNYXBwZXJMYXllciogY29uc3QqPihhKTsKLSAgICBUZXh0dXJlTWFwcGVyTGF5ZXIqIGNv bnN0KiBsYXllckIgPSBzdGF0aWNfY2FzdDxUZXh0dXJlTWFwcGVyTGF5ZXIqIGNvbnN0Kj4oYik7 Ci0gICAgcmV0dXJuIGludCgoKCpsYXllckEpLT5tX2NlbnRlclogLSAoKmxheWVyQiktPm1fY2Vu dGVyWikgKiAxMDAwKTsKLX0KLQotdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6OnNvcnRCeVpPcmRl cihWZWN0b3I8VGV4dHVyZU1hcHBlckxheWVyKiA+JiBhcnJheSkKLXsKLSAgICBxc29ydChhcnJh eS5kYXRhKCksIGFycmF5LnNpemUoKSwgc2l6ZW9mKFRleHR1cmVNYXBwZXJMYXllciopLCBjb21w YXJlR3JhcGhpY3NMYXllcnNaVmFsdWUpOworICAgIHN0ZDo6c29ydChhcnJheS5iZWdpbigpLCBh cnJheS5lbmQoKSwKKyAgICAgICAgW10oVGV4dHVyZU1hcHBlckxheWVyKiBhLCBUZXh0dXJlTWFw cGVyTGF5ZXIqIGIpIHsKKyAgICAgICAgICAgIHJldHVybiBhLT5tX2NlbnRlclogPCBiLT5tX2Nl bnRlclogKiAxMDAwOworICAgICAgICB9KTsKIH0KIAogdm9pZCBUZXh0dXJlTWFwcGVyTGF5ZXI6 OnBhaW50U2VsZkFuZENoaWxkcmVuKGNvbnN0IFRleHR1cmVNYXBwZXJQYWludE9wdGlvbnMmIG9w dGlvbnMpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlckxheWVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5oCShyZXZpc2lvbiAxNzI5MDApCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxh eWVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0NCw4ICsxNDQsNyBAQCBwcml2YXRlOgogICAgIH0K ICAgICB2b2lkIGNvbXB1dGVUcmFuc2Zvcm1zUmVjdXJzaXZlKCk7CiAKLSAgICBzdGF0aWMgaW50 IGNvbXBhcmVHcmFwaGljc0xheWVyc1pWYWx1ZShjb25zdCB2b2lkKiBhLCBjb25zdCB2b2lkKiBi KTsKLSAgICBzdGF0aWMgdm9pZCBzb3J0QnlaT3JkZXIoVmVjdG9yPFRleHR1cmVNYXBwZXJMYXll ciogPiYgYXJyYXkpOworICAgIHN0YXRpYyB2b2lkIHNvcnRCeVpPcmRlcihWZWN0b3I8VGV4dHVy ZU1hcHBlckxheWVyKj4mIGFycmF5KTsKIAogICAgIFBhc3NSZWZQdHI8Qml0bWFwVGV4dHVyZT4g dGV4dHVyZSgpIHsgcmV0dXJuIG1fYmFja2luZ1N0b3JlID8gbV9iYWNraW5nU3RvcmUtPnRleHR1 cmUoKSA6IDA7IH0KICAgICBGbG9hdFBvaW50IGFkanVzdGVkUG9zaXRpb24oKSBjb25zdCB7IHJl dHVybiBtX3N0YXRlLnBvcyArIG1fc2Nyb2xsUG9zaXRpb25EZWx0YSAtIG1fdXNlclNjcm9sbE9m ZnNldDsgfQo= 244075 2015-01-06 11:05:59 -0800 2015-01-07 05:19:19 -0800 Patch bug-136212-20150106110756.patch text/plain 3185 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3OTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDIxZmM5Yjc1ZDRiNTEz NTY0YzNhZmJkMDJhYjA3Yzc4NjI5YzNkZS4uNWE4YWFkYmQ4MjU5NWYzMzdjZWViNmMwMDk0YTZm ZmYxY2ZjZTBhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAxLTA2ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbVGV4TWFwXSBVc2Ug c3RkOjpzb3J0IGluc3RlYWQgb2YgcXNvcnQgaW4gVGV4dHVyZU1hcHBlckxheWVyOjpzb3J0Qnla T3JkZXIoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM2MjEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXNlIHN0ZDo6c29ydCgpIGluc3RlYWQgb2YgcXNvcnQoKSB0byBzb3J0IHRoZSBUZXh0dXJlTWFw cGVyTGF5ZXIgb2JqZWN0cworICAgICAgICBieSB0aGVpciB6LW9yZGVyLiBBIGxhbWJkYSBleHBy ZXNzaW9uIGNhbiBiZSB1c2VkIHRvIGNvbXBhcmUgdGhlIG1fY2VudGVyWiAKKyAgICAgICAgbWVt YmVyIHZhcmlhYmxlcyBvZiBhbnkgdHdvIFRleHR1cmVNYXBwZXJMYXllcnMuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6c29ydEJ5Wk9yZGVyKToKKyAgICAgICAg KFdlYkNvcmU6OlRleHR1cmVNYXBwZXJMYXllcjo6Y29tcGFyZUdyYXBoaWNzTGF5ZXJzWlZhbHVl KTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckxheWVyLmg6CisKIDIwMTUtMDEtMDYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFJlc29sdmUgbWlycm9yaW5nIGFuZCB2YXJpYW50IGluIEZvbnQgaW5z dGVhZCBvZiBGb250R2x5cGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCmluZGV4IDJkYTNl MjIwYTEzYmQ3ZTNjYjk3NmZmNDdkZDdlMWIzMjI2NGRmZjUuLjhlNDllODcxODkyNjlmMzZhNWIz YjBhM2EzM2JhYjQ2ZmU2YWZhZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuY3BwCkBAIC0x NTAsMTYgKzE1MCwxMiBAQCB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6cGFpbnRTZWxmKGNvbnN0 IFRleHR1cmVNYXBwZXJQYWludE9wdGlvbnMmIG9wdGlvbnMpCiAgICAgICAgIG1fY29udGVudHNM YXllci0+ZHJhd0JvcmRlcihvcHRpb25zLnRleHR1cmVNYXBwZXIsIG1fc3RhdGUuZGVidWdCb3Jk ZXJDb2xvciwgbV9zdGF0ZS5kZWJ1Z0JvcmRlcldpZHRoLCBtX3N0YXRlLmNvbnRlbnRzUmVjdCwg dHJhbnNmb3JtKTsKIH0KIAotaW50IFRleHR1cmVNYXBwZXJMYXllcjo6Y29tcGFyZUdyYXBoaWNz TGF5ZXJzWlZhbHVlKGNvbnN0IHZvaWQqIGEsIGNvbnN0IHZvaWQqIGIpCi17Ci0gICAgVGV4dHVy ZU1hcHBlckxheWVyKiBjb25zdCogbGF5ZXJBID0gc3RhdGljX2Nhc3Q8VGV4dHVyZU1hcHBlckxh eWVyKiBjb25zdCo+KGEpOwotICAgIFRleHR1cmVNYXBwZXJMYXllciogY29uc3QqIGxheWVyQiA9 IHN0YXRpY19jYXN0PFRleHR1cmVNYXBwZXJMYXllciogY29uc3QqPihiKTsKLSAgICByZXR1cm4g aW50KCgoKmxheWVyQSktPm1fY2VudGVyWiAtICgqbGF5ZXJCKS0+bV9jZW50ZXJaKSAqIDEwMDAp OwotfQotCiB2b2lkIFRleHR1cmVNYXBwZXJMYXllcjo6c29ydEJ5Wk9yZGVyKFZlY3RvcjxUZXh0 dXJlTWFwcGVyTGF5ZXIqID4mIGFycmF5KQogewotICAgIHFzb3J0KGFycmF5LmRhdGEoKSwgYXJy YXkuc2l6ZSgpLCBzaXplb2YoVGV4dHVyZU1hcHBlckxheWVyKiksIGNvbXBhcmVHcmFwaGljc0xh eWVyc1pWYWx1ZSk7CisgICAgc3RkOjpzb3J0KGFycmF5LmJlZ2luKCksIGFycmF5LmVuZCgpLAor ICAgICAgICBbXShUZXh0dXJlTWFwcGVyTGF5ZXIqIGEsIFRleHR1cmVNYXBwZXJMYXllciogYikg eworICAgICAgICAgICAgcmV0dXJuIGEtPm1fY2VudGVyWiA8IGItPm1fY2VudGVyWjsKKyAgICAg ICAgfSk7CiB9CiAKIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjpwYWludFNlbGZBbmRDaGlsZHJl bihjb25zdCBUZXh0dXJlTWFwcGVyUGFpbnRPcHRpb25zJiBvcHRpb25zKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXll ci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBw ZXJMYXllci5oCmluZGV4IDE0MGEwZWQyYzc3Y2Q1NjM2OWNmODhjZTc2MjhmMjk1YmE2OTc3NDIu LmE0N2EwYzlmZjhkZDFkOGY0OGFkOGNhMjYwNzA0NWU3MjEwMzJjMzEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckxheWVyLmgKQEAgLTEzOCw3ICsxMzgsNiBAQCBwcml2YXRlOgogICAgIH0KICAgICB2b2lk IGNvbXB1dGVUcmFuc2Zvcm1zUmVjdXJzaXZlKCk7CiAKLSAgICBzdGF0aWMgaW50IGNvbXBhcmVH cmFwaGljc0xheWVyc1pWYWx1ZShjb25zdCB2b2lkKiBhLCBjb25zdCB2b2lkKiBiKTsKICAgICBz dGF0aWMgdm9pZCBzb3J0QnlaT3JkZXIoVmVjdG9yPFRleHR1cmVNYXBwZXJMYXllciogPiYgYXJy YXkpOwogCiAgICAgUGFzc1JlZlB0cjxCaXRtYXBUZXh0dXJlPiB0ZXh0dXJlKCkgeyByZXR1cm4g bV9iYWNraW5nU3RvcmUgPyBtX2JhY2tpbmdTdG9yZS0+dGV4dHVyZSgpIDogMDsgfQo=