136191 2014-08-22 19:24:41 -0700 Web Inspector: Do not copy large module source strings 2014-08-23 01:17:08 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck benjamin commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1030871 0 joepeck 2014-08-22 19:24:41 -0700 We should use a non-copying WTFString constructor for the large inspector module strings: InjectedScriptSource_js CommandLineAPIModuleSource_js Note, other compiled strings were not copied: XMLViewer_js XMLViewer_css 1030872 1 webkit-bug-importer 2014-08-22 19:25:36 -0700 <rdar://problem/18109945> 1030873 2 237021 joepeck 2014-08-22 19:25:48 -0700 Created attachment 237021 [PATCH] Proposed Fix 1030917 3 237021 commit-queue 2014-08-23 01:17:05 -0700 Comment on attachment 237021 [PATCH] Proposed Fix Clearing flags on attachment: 237021 Committed r172888: <http://trac.webkit.org/changeset/172888> 1030918 4 commit-queue 2014-08-23 01:17:08 -0700 All reviewed patches have been landed. Closing bug. 237021 2014-08-22 19:25:48 -0700 2014-08-23 01:17:05 -0700 [PATCH] Proposed Fix do-not-copy.patch text/plain 2906 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGMzYmIzMTAuLmVjZTQ3YmEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE0LTA4LTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90 IGNvcHkgbGFyZ2UgbW9kdWxlIHNvdXJjZSBzdHJpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzYxOTEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbmplY3RlZFNjcmlwdE1hbmFn ZXIuY3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpJbmplY3RlZFNjcmlwdE1hbmFnZXI6OmluamVj dGVkU2NyaXB0U291cmNlKToKKworMjAxNC0wOC0yMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgorCiAgICAgICAgIEphdmFTY3JpcHRDb3JlOiBVc2UgQVNDSUlMaXRlcmFs IHdoZXJlIHBvc3NpYmxlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzYxNzkKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9JbmplY3RlZFNjcmlwdE1hbmFnZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu c3BlY3Rvci9JbmplY3RlZFNjcmlwdE1hbmFnZXIuY3BwCmluZGV4IDQ1MTczZmMuLjU5YTBlZGUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3Jp cHRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVj dGVkU2NyaXB0TWFuYWdlci5jcHAKQEAgLTEyMCw3ICsxMjAsNyBAQCB2b2lkIEluamVjdGVkU2Ny aXB0TWFuYWdlcjo6cmVsZWFzZU9iamVjdEdyb3VwKGNvbnN0IFN0cmluZyYgb2JqZWN0R3JvdXAp CiAKIFN0cmluZyBJbmplY3RlZFNjcmlwdE1hbmFnZXI6OmluamVjdGVkU2NyaXB0U291cmNlKCkK IHsKLSAgICByZXR1cm4gU3RyaW5nKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KEluamVj dGVkU2NyaXB0U291cmNlX2pzKSwgc2l6ZW9mKEluamVjdGVkU2NyaXB0U291cmNlX2pzKSk7Cisg ICAgcmV0dXJuIFN0cmluZ0ltcGw6OmNyZWF0ZVdpdGhvdXRDb3B5aW5nKEluamVjdGVkU2NyaXB0 U291cmNlX2pzLCBzaXplb2YoSW5qZWN0ZWRTY3JpcHRTb3VyY2VfanMpKTsKIH0KIAogRGVwcmVj YXRlZDo6U2NyaXB0T2JqZWN0IEluamVjdGVkU2NyaXB0TWFuYWdlcjo6Y3JlYXRlSW5qZWN0ZWRT Y3JpcHQoY29uc3QgU3RyaW5nJiBzb3VyY2UsIEV4ZWNTdGF0ZSogc2NyaXB0U3RhdGUsIGludCBp ZCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCBlYTUwZGUxLi5lNTg4ZmI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEs MTUgQEAKIDIwMTQtMDgtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAorICAgICAgICBXZWIgSW5zcGVjdG9yOiBEbyBub3QgY29weSBsYXJnZSBtb2R1bGUgc291cmNl IHN0cmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNjE5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaW5zcGVjdG9yL0NvbW1hbmRMaW5lQVBJTW9kdWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNvbW1hbmRMaW5lQVBJTW9kdWxlOjpzb3VyY2UpOgorCisyMDE0LTA4LTIyICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgUmVtb3ZlIHVudXNlZCBsZWdh Y3kgSW5zcGVjdG9yRnJvbnRlbmRIb3N0IG1ldGhvZHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjE4NgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvQ29tbWFuZExpbmVBUElNb2R1bGUuY3BwIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0NvbW1hbmRMaW5lQVBJTW9kdWxlLmNwcAppbmRleCBkMTc0MmE4Li41ZjJmYmU5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29tbWFuZExpbmVBUElNb2R1 bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Db21tYW5kTGluZUFQSU1vZHVs ZS5jcHAKQEAgLTUxLDcgKzUxLDcgQEAgdm9pZCBDb21tYW5kTGluZUFQSU1vZHVsZTo6aW5qZWN0 SWZOZWVkZWQoSW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKiBpbmplY3RlZFNjcmlwdE0KIAogU3RyaW5n IENvbW1hbmRMaW5lQVBJTW9kdWxlOjpzb3VyY2UoKSBjb25zdAogewotICAgIHJldHVybiBTdHJp bmcocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4oQ29tbWFuZExpbmVBUElNb2R1bGVTb3Vy Y2VfanMpLCBzaXplb2YoQ29tbWFuZExpbmVBUElNb2R1bGVTb3VyY2VfanMpKTsKKyAgICByZXR1 cm4gU3RyaW5nSW1wbDo6Y3JlYXRlV2l0aG91dENvcHlpbmcoQ29tbWFuZExpbmVBUElNb2R1bGVT b3VyY2VfanMsIHNpemVvZihDb21tYW5kTGluZUFQSU1vZHVsZVNvdXJjZV9qcykpOwogfQogCiBK U0M6OkpTVmFsdWUgQ29tbWFuZExpbmVBUElNb2R1bGU6Omhvc3QoSW5qZWN0ZWRTY3JpcHRNYW5h Z2VyKiBpbmplY3RlZFNjcmlwdE1hbmFnZXIsIEpTQzo6RXhlY1N0YXRlKiBleGVjKSBjb25zdAo=