136190 2014-08-22 19:13:54 -0700 [GTK] Compilation error in LayerTreeHostGtk.cpp and PluginInfoCache.cpp 2014-12-01 23:14:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 withlhw webkit-unassigned pnormand zan oldest_to_newest 1030870 0 withlhw 2014-08-22 19:13:54 -0700 When I compile WebKit GTK port, It makes compilation error as below. ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp: In member function ‘void WebKit::LayerTreeHostGtk::layerFlushTimerFired()’: ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:292:129: error: call of overloaded ‘scheduleAfterDelay(const char [25], std::_Bind_helper<false, void (WebKit::LayerTreeHostGtk::*)(), WebKit::LayerTreeHostGtk* const>::type, std::enable_if<true, std::chrono::duration<long int, std::ratio<1l, 1000l> > >::type, int)’ is ambiguous ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:292:129: note: candidates are: In file included from ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h:39:0, from ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:28: ../../Source/WTF/wtf/gobject/GMainLoopSource.h:56:29: note: void WTF::GMainLoopSource::scheduleAfterDelay(const char*, std::function<void()>, std::chrono::milliseconds, int, std::function<void()>, GMainContext*) ../../Source/WTF/wtf/gobject/GMainLoopSource.h:57:29: note: void WTF::GMainLoopSource::scheduleAfterDelay(const char*, std::function<bool()>, std::chrono::milliseconds, int, std::function<void()>, GMainContext*) ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp: In member function ‘virtual void WebKit::LayerTreeHostGtk::scheduleLayerFlush()’: ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:392:149: error: call of overloaded ‘schedule(const char [25], std::_Bind_helper<false, void (WebKit::LayerTreeHostGtk::*)(), WebKit::LayerTreeHostGtk* const>::type, int)’ is ambiguous ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:392:149: note: candidates are: In file included from ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h:39:0, from ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:28: ../../Source/WTF/wtf/gobject/GMainLoopSource.h:53:29: note: void WTF::GMainLoopSource::schedule(const char*, std::function<void()>, int, std::function<void()>, GMainContext*) In file included from ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.h:39:0, from ../../Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:28: 1030876 1 237023 withlhw 2014-08-22 20:05:35 -0700 Created attachment 237023 Patches 01 1030905 2 zan 2014-08-22 23:32:43 -0700 What compiler are you using? Would it be possible for you to use GCC 4.8? This is the version that we'll be requiring in the near future, and should work without a hitch. 1031013 3 withlhw 2014-08-24 18:46:38 -0700 I'm using gcc 4.7.3 on Ubuntu 13.04 Many place in WebKit GTK using "std::function<void()>" type casting for make sure. ex) m_audioTimerHandler.schedule("[WebKit] MediaPlayerPrivateGStreamer::audioChanged", std::function<void()>(std::bind(&MediaPlayerPrivateGStreamer::notifyPlayerOfAudio, this))); I think we'd better to put "std::function<void()>" type casting in this case. 1049511 4 pnormand 2014-11-18 09:54:31 -0800 Is this still an issue with current trunk? 1051722 5 withlhw 2014-12-01 20:18:48 -0800 Yes, there is no problem when I upgrade gcc compiler to 4.8.x Thanks. 1051746 6 pnormand 2014-12-01 23:14:48 -0800 Let's close this bug then. 237023 2014-08-22 20:05:35 -0700 2014-08-22 20:07:55 -0700 Patches 01 patches-136190-01.patch text/plain 3127 withlhw SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mjg3NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA4LTIzICBIeXVuZ3dv b2sgTGVlICA8d2l0aGxod0BuYXZlcmNvcnAuY29tPgorCisgICAgICAgIEZpeCBjb21waWxhdGlv biBlcnJyb3IgaW4gaW4gTGF5ZXJUcmVlSG9zdEd0ay5jcHAgYW5kIFBsdWdpbkluZm9DYWNoZS5j cHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjE5 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9MYXllclRyZWVIb3N0R3RrLmNwcDog QWRkIHN0ZDo6ZnVuY3Rpb248dm9pZCgpPigpIHR5cGUgY2FzdGluZy4gCisgICAgICAgICogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvZ3RrL1BsdWdpbkluZm9DYWNoZS5jcHA6IEFk ZCBzdGQ6OmZ1bmN0aW9uPHZvaWQoKT4oKSB0eXBlIGNhc3RpbmcuCisKIDIwMTQtMDgtMjIgIENv bW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIxNzI4NjYuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv UGx1Z2lucy9ndGsvUGx1Z2luSW5mb0NhY2hlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy9ndGsvUGx1Z2luSW5mb0NhY2hlLmNwcAkocmV2aXNpb24g MTcyODc3KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvZ3RrL1BsdWdpbklu Zm9DYWNoZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0MCw3ICsxNDAsNyBAQAogICAgICAgICBp ZiAobV9zYXZlVG9GaWxlSWRsZS5pc1NjaGVkdWxlZCgpKQogICAgICAgICAgICAgcmV0dXJuOwog Ci0gICAgICAgIG1fc2F2ZVRvRmlsZUlkbGUuc2NoZWR1bGUoIltXZWJLaXRdIFBsdWdpbkluZm9D YWNoZTo6c2F2ZVRvRmlsZSIsIHN0ZDo6YmluZCgmUGx1Z2luSW5mb0NhY2hlOjpzYXZlVG9GaWxl LCB0aGlzKSwgR19QUklPUklUWV9ERUZBVUxUX0lETEUpOworICAgICAgICBtX3NhdmVUb0ZpbGVJ ZGxlLnNjaGVkdWxlKCJbV2ViS2l0XSBQbHVnaW5JbmZvQ2FjaGU6OnNhdmVUb0ZpbGUiLCBzdGQ6 OmZ1bmN0aW9uPHZvaWQoKT4oc3RkOjpiaW5kKCZQbHVnaW5JbmZvQ2FjaGU6OnNhdmVUb0ZpbGUs IHRoaXMpKSwgR19QUklPUklUWV9ERUZBVUxUX0lETEUpOwogICAgIH0KIH0KIApJbmRleDogU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2d0ay9MYXllclRyZWVIb3N0R3RrLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL0xheWVy VHJlZUhvc3RHdGsuY3BwCShyZXZpc2lvbiAxNzI4NzcpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvZ3RrL0xheWVyVHJlZUhvc3RHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yODgsNyArMjg4LDcgQEAKICAgICBpZiAoIW1fbGF5ZXJGbHVzaFRpbWVyQ2FsbGJhY2suaXNT Y2hlZHVsZWQoKSAmJiB0b1RleHR1cmVNYXBwZXJMYXllcihtX3Jvb3RMYXllci5nZXQoKSktPmRl c2NlbmRhbnRzT3JTZWxmSGF2ZVJ1bm5pbmdBbmltYXRpb25zKCkpIHsKICAgICAgICAgY29uc3Qg ZG91YmxlIHRhcmdldEZQUyA9IDYwOwogICAgICAgICBkb3VibGUgbmV4dEZsdXNoID0gc3RkOjpt YXgoKDEgLyB0YXJnZXRGUFMpIC0gKGN1cnJlbnRUaW1lKCkgLSBtX2xhc3RGbHVzaFRpbWUpLCAw LjApOwotICAgICAgICBtX2xheWVyRmx1c2hUaW1lckNhbGxiYWNrLnNjaGVkdWxlQWZ0ZXJEZWxh eSgiW1dlYktpdF0gbGF5ZXJGbHVzaFRpbWVyIiwgc3RkOjpiaW5kKCZMYXllclRyZWVIb3N0R3Rr OjpsYXllckZsdXNoVGltZXJGaXJlZCwgdGhpcyksCisgICAgICAgIG1fbGF5ZXJGbHVzaFRpbWVy Q2FsbGJhY2suc2NoZWR1bGVBZnRlckRlbGF5KCJbV2ViS2l0XSBsYXllckZsdXNoVGltZXIiLCBz dGQ6OmZ1bmN0aW9uPHZvaWQoKT4oc3RkOjpiaW5kKCZMYXllclRyZWVIb3N0R3RrOjpsYXllckZs dXNoVGltZXJGaXJlZCwgdGhpcykpLAogICAgICAgICAgICAgc3RkOjpjaHJvbm86OmR1cmF0aW9u X2Nhc3Q8c3RkOjpjaHJvbm86Om1pbGxpc2Vjb25kcz4oc3RkOjpjaHJvbm86OmR1cmF0aW9uPGRv dWJsZT4obmV4dEZsdXNoKSksIEdES19QUklPUklUWV9FVkVOVFMpOwogICAgIH0KIH0KQEAgLTM4 OSw3ICszODksNyBAQAogCiAgICAgLy8gV2UgdXNlIGEgR0xpYiB0aW1lciBiZWNhdXNlIG90aGVy d2lzZSBHVEsrIGV2ZW50IGhhbmRsaW5nIGR1cmluZyBkcmFnZ2luZyBjYW4gc3RhcnZlIFdlYkNv cmUgdGltZXJzLCB3aGljaCBoYXZlIGEgbG93ZXIgcHJpb3JpdHkuCiAgICAgaWYgKCFtX2xheWVy Rmx1c2hUaW1lckNhbGxiYWNrLmlzU2NoZWR1bGVkKCkpCi0gICAgICAgIG1fbGF5ZXJGbHVzaFRp bWVyQ2FsbGJhY2suc2NoZWR1bGUoIltXZWJLaXRdIGxheWVyRmx1c2hUaW1lciIsIHN0ZDo6Ymlu ZCgmTGF5ZXJUcmVlSG9zdEd0azo6bGF5ZXJGbHVzaFRpbWVyRmlyZWQsIHRoaXMpLCBHREtfUFJJ T1JJVFlfRVZFTlRTKTsKKyAgICAgICAgbV9sYXllckZsdXNoVGltZXJDYWxsYmFjay5zY2hlZHVs ZSgiW1dlYktpdF0gbGF5ZXJGbHVzaFRpbWVyIiwgc3RkOjpmdW5jdGlvbjx2b2lkKCk+KHN0ZDo6 YmluZCgmTGF5ZXJUcmVlSG9zdEd0azo6bGF5ZXJGbHVzaFRpbWVyRmlyZWQsIHRoaXMpKSwgR0RL X1BSSU9SSVRZX0VWRU5UUyk7CiB9CiAKIHZvaWQgTGF5ZXJUcmVlSG9zdEd0azo6c2V0TGF5ZXJG bHVzaFNjaGVkdWxpbmdFbmFibGVkKGJvb2wgbGF5ZXJGbHVzaGluZ0VuYWJsZWQpCg==